55321 2011-02-27 09:54:35 -0800 REGRESSION (r79784): Lots of tests failing assertions in Length::setValue on Windows 2011-03-08 09:47:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED DUPLICATE 55301 http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r79784%20(25719)/results.html LayoutTestFailure, PlatformOnly, Regression P2 Normal --- 1 aroben webkit-unassigned cabanier hyatt mitz oldest_to_newest 358699 0 aroben 2011-02-27 09:54:35 -0800 Lots of tests on Windows are failing assertions in Length::setValue. See the URL for some examples. The failing code is: FAULTING_SOURCE_CODE: 87: bool quirk() const { return m_quirk; } 88: 89: void setValue(LengthType t, int value) 90: { > 91: ASSERT(t != Percent); 92: *this = Length(value, t); 93: } 94: 95: void setValue(int value) 96: { Here's an example backtrace: 00 0012e250 0150ba65 WebKit!WebCore::Length::setValue(WebCore::LengthType t = Percent (0n2), int value = 0n12800)+0x43 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\length.h @ 91] 01 0012e394 0150af51 WebKit!WebCore::AutoTableLayout::calcEffectiveLogicalWidth(void)+0x505 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\autotablelayout.cpp @ 378] 02 0012e43c 015a7f4c WebKit!WebCore::AutoTableLayout::computePreferredLogicalWidths(int * minWidth = 0x0b606fe8, int * maxWidth = 0x0b606fec)+0x31 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\autotablelayout.cpp @ 226] 03 0012e45c 01545ee0 WebKit!WebCore::RenderTable::computePreferredLogicalWidths(void)+0xac [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\rendertable.cpp @ 574] 04 0012e46c 015a6276 WebKit!WebCore::RenderBox::minPreferredLogicalWidth(void)+0x30 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderbox.cpp @ 659] 05 0012e50c 015a67ed WebKit!WebCore::RenderTable::computeLogicalWidth(void)+0x146 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\rendertable.cpp @ 219] 06 0012e628 01529b70 WebKit!WebCore::RenderTable::layout(void)+0x12d [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\rendertable.cpp @ 278] 07 0012e6d0 01529844 WebKit!WebCore::RenderBlock::layoutBlockChild(class WebCore::RenderBox * child = 0x0b606f9c, class WebCore::RenderBlock::MarginInfo * marginInfo = 0x0012e738, int * previousFloatLogicalBottom = 0x0012e728, int * maxFloatLogicalBottom = 0x0012e870)+0x280 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1958] 08 0012e794 01526fe5 WebKit!WebCore::RenderBlock::layoutBlockChildren(bool relayoutChildren = true, int * maxFloatLogicalBottom = 0x0012e870)+0x364 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1897] 09 0012e8f8 01526b2e WebKit!WebCore::RenderBlock::layoutBlock(bool relayoutChildren = true, int pageLogicalHeight = 0n0)+0x465 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1227] 0a 0012e910 01529b70 WebKit!WebCore::RenderBlock::layout(void)+0x3e [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1120] 0b 0012e9b8 01529844 WebKit!WebCore::RenderBlock::layoutBlockChild(class WebCore::RenderBox * child = 0x0a33f474, class WebCore::RenderBlock::MarginInfo * marginInfo = 0x0012ea20, int * previousFloatLogicalBottom = 0x0012ea10, int * maxFloatLogicalBottom = 0x0012eb58)+0x280 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1958] 0c 0012ea7c 01526fe5 WebKit!WebCore::RenderBlock::layoutBlockChildren(bool relayoutChildren = true, int * maxFloatLogicalBottom = 0x0012eb58)+0x364 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1897] 0d 0012ebe0 01526b2e WebKit!WebCore::RenderBlock::layoutBlock(bool relayoutChildren = true, int pageLogicalHeight = 0n0)+0x465 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1227] 0e 0012ebf8 01529b70 WebKit!WebCore::RenderBlock::layout(void)+0x3e [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1120] 0f 0012eca0 01529844 WebKit!WebCore::RenderBlock::layoutBlockChild(class WebCore::RenderBox * child = 0x09f3a2b4, class WebCore::RenderBlock::MarginInfo * marginInfo = 0x0012ed08, int * previousFloatLogicalBottom = 0x0012ecf8, int * maxFloatLogicalBottom = 0x0012ee40)+0x280 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1958] 10 0012ed64 01526fe5 WebKit!WebCore::RenderBlock::layoutBlockChildren(bool relayoutChildren = true, int * maxFloatLogicalBottom = 0x0012ee40)+0x364 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1897] 11 0012eec8 01526b2e WebKit!WebCore::RenderBlock::layoutBlock(bool relayoutChildren = true, int pageLogicalHeight = 0n0)+0x465 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1227] 12 0012eee0 015cd0b5 WebKit!WebCore::RenderBlock::layout(void)+0x3e [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1120] 13 0012ef78 014e14fa WebKit!WebCore::RenderView::layout(void)+0x215 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderview.cpp @ 132] 14 0012f054 013928b3 WebKit!WebCore::FrameView::layout(bool allowSubtree = true)+0x93a [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\page\frameview.cpp @ 906] 15 0012f0a0 013478a4 WebKit!WebCore::Document::implicitClose(void)+0x353 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\dom\document.cpp @ 2123] 16 0012f0ac 01347620 WebKit!WebCore::FrameLoader::checkCallImplicitClose(void)+0x84 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 896] 17 0012f0c4 01347388 WebKit!WebCore::FrameLoader::checkCompleted(void)+0xf0 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 845] 18 0012f0e4 0139a70a WebKit!WebCore::FrameLoader::finishedParsing(void)+0x98 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 779] 19 0012f0fc 01edf1ec WebKit!WebCore::Document::finishedParsing(void)+0x18a [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\dom\document.cpp @ 4230] 1a 0012f10c 01c6f4c2 WebKit!WebCore::HTMLTreeBuilder::finished(void)+0x8c [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmltreebuilder.cpp @ 2804] 1b 0012f11c 01c6f5d4 WebKit!WebCore::HTMLDocumentParser::end(void)+0xc2 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 355] 1c 0012f12c 01c6e7eb WebKit!WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd(void)+0xf4 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 364] 1d 0012f148 01c6f629 WebKit!WebCore::HTMLDocumentParser::prepareToStopParsing(void)+0xdb [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 152] 1e 0012f158 01c6f6e3 WebKit!WebCore::HTMLDocumentParser::attemptToEnd(void)+0x39 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 375] 1f 0012f164 01392e1b WebKit!WebCore::HTMLDocumentParser::finish(void)+0x33 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 404] 20 0012f178 01bbdded WebKit!WebCore::Document::finishParsing(void)+0x4b [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\dom\document.cpp @ 2232] 21 0012f190 01bbdd57 WebKit!WebCore::DocumentWriter::endIfNotLoadingMainResource(void)+0x7d [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\documentwriter.cpp @ 223] 22 0012f19c 014c6b74 WebKit!WebCore::DocumentWriter::end(void)+0x27 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\documentwriter.cpp @ 208] 23 0012f1ac 0134ceb2 WebKit!WebCore::DocumentLoader::finishedLoading(void)+0x54 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\documentloader.cpp @ 286] 24 0012f1d4 01d082e6 WebKit!WebCore::FrameLoader::finishedLoading(void)+0x52 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 2193] 25 0012f204 019dc957 WebKit!WebCore::MainResourceLoader::didFinishLoading(double finishTime = 0)+0xe6 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\mainresourceloader.cpp @ 465] 26 0012f21c 019788a1 WebKit!WebCore::ResourceLoader::didFinishLoading(class WebCore::ResourceHandle * __formal = 0x0b5e9768, double finishTime = 0)+0x27 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\resourceloader.cpp @ 436] 27 0012f240 007dbfd4 WebKit!WebCore::didFinishLoading(struct _CFURLConnection * conn = 0x0b4ff310, void * clientInfo = 0x0b5e9768)+0xa1 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\network\cf\resourcehandlecfnet.cpp @ 241] 28 0012f278 007dc337 CFNetwork!URLConnectionClient::_clientDidFinishLoading+0xb1 29 0012f37c 007dcf0b CFNetwork!URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload+0xa6 2a 0012f38c 007dc6cd CFNetwork!XConnectionEventQueue<enum XLoaderEvent,XLoaderEventParams>::processAllEvents+0x14 2b 0012f3a0 007da495 CFNetwork!URLConnectionClient::processEvents+0x44 2c 0012f3ac 7e418734 CFNetwork!MirroredSet::contains+0x5b 2d 0012f3d8 7e418816 USER32!InternalCallWinProc+0x28 2e 0012f440 7e4189cd USER32!UserCallWinProcCheckWow+0x150 2f 0012f4a0 7e418a10 USER32!DispatchMessageWorker+0x306 30 0012f4b0 004586a5 USER32!DispatchMessageW+0xf 31 0012f624 0045748f DumpRenderTree!runTest(class std::basic_string<char,std::char_traits<char>,std::allocator<char> > * testPathOrURL = 0x0012f69c)+0x775 [c:\cygwin\home\buildbot\slave\win-debug\build\tools\dumprendertree\win\dumprendertree.cpp @ 1002] 32 0012ff7c 0046656f DumpRenderTree!main(int argc = 0n2, char ** argv = 0x051e9f70)+0x8df [c:\cygwin\home\buildbot\slave\win-debug\build\tools\dumprendertree\win\dumprendertree.cpp @ 1384] 33 0012ffc0 7c817077 DumpRenderTree!__tmainCRTStartup(void)+0x10f [f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c @ 597] 34 0012fff0 00000000 kernel32!BaseProcessStart+0x23 358705 1 aroben 2011-02-27 10:01:08 -0800 *** This bug has been marked as a duplicate of bug 55301 *** 358744 2 83984 cabanier 2011-02-27 12:09:44 -0800 Created attachment 83984 changed code to work around asserts + updated to real boolean values 364002 3 83984 eric 2011-03-08 09:47:09 -0800 Comment on attachment 83984 changed code to work around asserts + updated to real boolean values Cleared review? from attachment 83984 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 83984 2011-02-27 12:09:44 -0800 2011-03-08 09:47:09 -0800 changed code to work around asserts + updated to real boolean values patch.txt text/plain 2666 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMjYgIFJpayBDYWJh bmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIGJ1ZyBpbiB0aGUgYXNzZXJ0cyBvZiB0aGUgTGVu Z3RoIGNsYXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTUzMDEKKworICAgICAgICBUaGlzIGJ1ZyB3YXMgaW50cm9kdWNlZCBieSB0aGUgZml4IGZv ciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI2OTkKKyAgICAgICAg SXQgaXMgb25seSBhIHByb2JsZW0gaW4gZGVidWcgYnVpbGRzCisKKyAgICAgICAgVGVzdDogdGFi bGVzL21vemlsbGEvY29yZS9uZXN0ZWQxLmh0bWwgKFRoaXMgb25seSBoYXBwZW5zIGluIGRlYnVn IGJ1aWxkcykKKworICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoK KyAgICAgICAgKiBwbGF0Zm9ybS9MZW5ndGguaDoKKyAgICAgICAgKFdlYkNvcmU6Okxlbmd0aDo6 TGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6Okxlbmd0aDo6c2V0VmFsdWUpOgorCiAyMDExLTAy LTI2ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9MZW5ndGguaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5n dGguaAkocmV2aXNpb24gNzk4MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGgu aAkod29ya2luZyBjb3B5KQpAQCAtNDAsMjggKzQwLDI4IEBAIHN0cnVjdCBMZW5ndGggewogICAg IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIExlbmd0aCgpCi0gICAgICAg IDogbV9pbnRWYWx1ZSgwKSwgbV9xdWlyaygwKSwgbV90eXBlKEF1dG8pLCBtX2lzRmxvYXQoMCkK KyAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKGZhbHNlKSwgbV90eXBlKEF1dG8pLCBt X2lzRmxvYXQoZmFsc2UpCiAgICAgewogICAgIH0KIAogICAgIExlbmd0aChMZW5ndGhUeXBlIHQp Ci0gICAgICAgIDogbV9pbnRWYWx1ZSgwKSwgbV9xdWlyaygwKSwgbV90eXBlKHQpLCBtX2lzRmxv YXQoMCkKKyAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKGZhbHNlKSwgbV90eXBlKHQp LCBtX2lzRmxvYXQoZmFsc2UpCiAgICAgewogICAgIH0KIAogICAgIExlbmd0aChpbnQgdiwgTGVu Z3RoVHlwZSB0LCBib29sIHEgPSBmYWxzZSkKLSAgICAgICAgOiBtX2ludFZhbHVlKHYpLCBtX3F1 aXJrKHEpLCBtX3R5cGUodCksIG1faXNGbG9hdCgwKQorICAgICAgICA6IG1faW50VmFsdWUodiks IG1fcXVpcmsocSksIG1fdHlwZSh0KSwgbV9pc0Zsb2F0KGZhbHNlKQogICAgIHsKICAgICAgICAg QVNTRVJUKHQgIT0gUGVyY2VudCk7CiAgICAgfQogCiAgICAgTGVuZ3RoKGRvdWJsZSB2LCBMZW5n dGhUeXBlIHQsIGJvb2wgcSA9IGZhbHNlKQotICAgICAgICA6IG1fcXVpcmsocSksIG1fdHlwZSh0 KSwgbV9pc0Zsb2F0KDApCisgICAgICAgIDogbV9xdWlyayhxKSwgbV90eXBlKHQpLCBtX2lzRmxv YXQoZmFsc2UpCiAgICAgewogICAgICAgICBpZiAobV90eXBlID09IFBlcmNlbnQpCiAgICAgICAg ICAgICBtX2ludFZhbHVlID0gc3RhdGljX2Nhc3Q8aW50Pih2KnBlcmNlbnRTY2FsZUZhY3Rvcik7 CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgbV9pc0Zsb2F0ID0gMTsgICAgICAgICAgICAK KyAgICAgICAgICAgIG1faXNGbG9hdCA9IHRydWU7ICAgICAgICAgICAgCiAgICAgICAgICAgICBt X2Zsb2F0VmFsdWUgPSBzdGF0aWNfY2FzdDxmbG9hdD4odik7CiAgICAgICAgIH0KICAgICB9CkBA IC04OCw4ICs4OCw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0VmFsdWUoTGVuZ3RoVHlwZSB0 LCBpbnQgdmFsdWUpCiAgICAgewotICAgICAgICBBU1NFUlQodCAhPSBQZXJjZW50KTsKLSAgICAg ICAgKnRoaXMgPSBMZW5ndGgodmFsdWUsIHQpOworICAgICAgICBtX3R5cGUgPSB0OworICAgICAg ICBtX2ludFZhbHVlID0gdmFsdWU7CisgICAgICAgIG1faXNGbG9hdCA9IGZhbHNlOwogICAgIH0K IAogICAgIHZvaWQgc2V0VmFsdWUoaW50IHZhbHVlKQpAQCAtMTAwLDcgKzEwMSw5IEBAIHB1Ymxp YzoKIAogICAgIHZvaWQgc2V0VmFsdWUoTGVuZ3RoVHlwZSB0LCBkb3VibGUgdmFsdWUpCiAgICAg ewotICAgICAgICAqdGhpcyA9IExlbmd0aCh2YWx1ZSwgdCk7CisgICAgICAgIG1fdHlwZSA9IHQ7 CisgICAgICAgIG1fZmxvYXRWYWx1ZSA9IHZhbHVlOworICAgICAgICBtX2lzRmxvYXQgPSB0cnVl OwogICAgIH0KIAogICAgIHZvaWQgc2V0VmFsdWUoZG91YmxlIHZhbHVlKQo=