55275 2011-02-25 15:57:55 -0800 Augment style guidelines about meaningless parameters from text the unwritten rules email. 2011-04-06 19:04:13 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 55271 1 levin levin abarth commit-queue eric webkit.review.bot oldest_to_newest 358252 0 levin 2011-02-25 15:57:55 -0800 This text is in the email. The guideline is already in the style guide but it could use another example and a little more text (so this patch does that). *Function parameters* Don't put in parameter names in function declarations if they don't add information. A good rule of thumb is if the parameter type name contains the parameter name (without trailing numbers or pluralization), then the parameter name isn't needed. Usually, there should be a parameter name for bools, strings, and numerical types. 358254 1 83895 levin 2011-02-25 15:59:41 -0800 Created attachment 83895 Patch 381021 2 83895 commit-queue 2011-04-06 18:04:47 -0700 Comment on attachment 83895 Patch Clearing flags on attachment: 83895 Committed r83127: <http://trac.webkit.org/changeset/83127> 381022 3 commit-queue 2011-04-06 18:04:52 -0700 All reviewed patches have been landed. Closing bug. 381057 4 webkit.review.bot 2011-04-06 19:04:13 -0700 http://trac.webkit.org/changeset/83127 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/dom/52776.html fast/text/complex-text-opacity.html fast/text/international/bidi-AN-after-L.html fast/text/international/bidi-AN-after-empty-run.html fast/text/international/bidi-CS-after-AN.html fast/text/international/bidi-mirror-he-ar.html fast/text/international/bidi-neutral-run.html platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html 83895 2011-02-25 15:59:41 -0800 2011-04-06 18:04:47 -0700 Patch bug-55275-20110225155939.patch text/plain 1783 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzk3MzMKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5v cmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggMThiOTY3 MWFiNmQ5YWQ5OTVmY2NkOTU4ODAyZjhmYTZjY2I4ZTEwYy4uZDY3NTYxOGNmZTEwNGM5Yjc0ZWI3 MzA2Nzc5ZWE2MGFmYWMxMDA2YiAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFu Z2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNSBA QAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEF1Z21l bnQgc3R5bGUgZ3VpZGVsaW5lcyBhYm91dCBtZWFuaW5nbGVzcyBwYXJhbWV0ZXJzIGZyb20gdGV4 dCB0aGUgdW53cml0dGVuIHJ1bGVzIGVtYWlsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUyNzUKKworICAgICAgICAqIGNvZGluZy9jb2Rpbmctc3R5 bGUuaHRtbDoKKworMjAxMS0wMi0yNSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgQWRkIHN0 eWxlIGd1aWRlbGluZXMgYWJvdXQgY29tbWVudHMgZnJvbSB0aGUgdW53cml0dGVuIHJ1bGVzIGVt YWlsLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUy NzIKIApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxl Lmh0bWwgYi9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAppbmRl eCBhYWI2ZDU3OTZmZjc1Zjg0YmIzYmRkNTMwNjEzNjYzMmZjNTQ0NGMyLi40MzMxYWFmMTIxMjI4 OWM4Y2IwMzQ1NDIxNmE2ZjlkNDZhOTExMjk5IDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQu b3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAorKysgYi9XZWJzaXRlcy93ZWJraXQub3JnL2Nv ZGluZy9jb2Rpbmctc3R5bGUuaHRtbApAQCAtNTg3LDE1ICs1ODcsMTkgQEAgYm9vbCB0b0FTQ0lJ KHNob3J0Kiwgc2l6ZV90KTsKIDwvcHJlPgogPC9saT4KIAotPGxpPkxlYXZlIG1lYW5pbmdsZXNz IHZhcmlhYmxlIG5hbWVzIG91dCBvZiBmdW5jdGlvbiBkZWNsYXJhdGlvbnMuCis8bGk+TGVhdmUg bWVhbmluZ2xlc3MgdmFyaWFibGUgbmFtZXMgb3V0IG9mIGZ1bmN0aW9uIGRlY2xhcmF0aW9ucy4g QSBnb29kIHJ1bGUgb2YgdGh1bWIgaXMgaWYgdGhlIHBhcmFtZXRlciB0eXBlIG5hbWUgY29udGFp bnMgdGhlIHBhcmFtZXRlciBuYW1lICh3aXRob3V0IHRyYWlsaW5nIG51bWJlcnMgb3IgcGx1cmFs aXphdGlvbiksIHRoZW4gdGhlIHBhcmFtZXRlciBuYW1lIGlzbid0IG5lZWRlZC4gIFVzdWFsbHks IHRoZXJlIHNob3VsZCBiZSBhIHBhcmFtZXRlciBuYW1lIGZvciBib29scywgc3RyaW5ncywgYW5k IG51bWVyaWNhbCB0eXBlcy4KIDxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+CiA8cHJlIGNs YXNzPSJjb2RlIj4KIHZvaWQgc2V0Q291bnQoc2l6ZV90KTsKKwordm9pZCBkb1NvbWV0aGluZyhT Y3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CiA8L3ByZT4KIAogPGg0IGNsYXNzPSJ3cm9uZyI+V3Jv bmc6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUiPgogdm9pZCBzZXRDb3VudChzaXplX3QgY291bnQp OworCit2b2lkIGRvU29tZXRoaW5nKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpOwog PC9wcmU+CiA8L2xpPgogCg==