55272 2011-02-25 15:44:18 -0800 Add style guidelines about comments from the unwritten rules email. 2011-02-27 09:01:49 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 55253 55271 1 levin levin abarth commit-queue darin eric webkit.review.bot oldest_to_newest 358238 0 levin 2011-02-25 15:44:18 -0800 See https://lists.webkit.org/pipermail/webkit-dev/2009-September/009807.html (but be careful about the replies and the last changes done). 358244 1 levin 2011-02-25 15:49:51 -0800 These changes address this part of the email: Usually, comments should look like sentences by beginning with a capital and ending with a period (punctation). One exception may be end of line comments like this "if (x == y) // false for NaN".There should be a *single* space after punctation and before the next sentence. There should only be a single space before end of line comments. Use FIXME: to denote items that need to be addressed in the future. 358251 2 83894 levin 2011-02-25 15:54:52 -0800 Created attachment 83894 Patch 358491 3 83894 commit-queue 2011-02-26 06:45:26 -0800 Comment on attachment 83894 Patch Clearing flags on attachment: 83894 Committed r79785: <http://trac.webkit.org/changeset/79785> 358492 4 commit-queue 2011-02-26 06:45:31 -0800 All reviewed patches have been landed. Closing bug. 358689 5 webkit.review.bot 2011-02-27 09:01:49 -0800 http://trac.webkit.org/changeset/79785 might have broken GTK Linux 32-bit Debug 83894 2011-02-25 15:54:52 -0800 2011-02-26 06:45:25 -0800 Patch bug-55272-20110225155451.patch text/plain 2351 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzk3MzMKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5v cmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggYzVkZTE0 YjQ4M2EzZGU3MDQ4NzE2OGUzNjhlOTcyZjg0MTgyMDA1YS4uMThiOTY3MWFiNmQ5YWQ5OTVmY2Nk OTU4ODAyZjhmYTZjY2I4ZTEwYyAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFu Z2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBA QAorMjAxMS0wMi0yNSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN0eWxlIGd1aWRl bGluZXMgYWJvdXQgY29tbWVudHMgZnJvbSB0aGUgdW53cml0dGVuIHJ1bGVzIGVtYWlsLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUyNzIKKworICAg ICAgICAqIGNvZGluZy9jb2Rpbmctc3R5bGUuaHRtbDogQWRkZWQgdGhlIGd1aWRlbGluZXMuCisK IDIwMTEtMDItMDkgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLiBBZGQgV2ViIEluc3BlY3RvciBzdHlsZXNoZWV0IHJlc291cmNl IGRpZmYgc2NyZWVuc2hvdC4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5n L2NvZGluZy1zdHlsZS5odG1sIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0 eWxlLmh0bWwKaW5kZXggOWJjZjAxOTE1NzE2MDNkNGVlZGFiNWYyMGNlMThlMjUyZTE1OGU2OS4u YWFiNmQ1Nzk2ZmY3NWY4NGJiM2JkZDUzMDYxMzY2MzJmYzU0NDRjMiAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKKysrIGIvV2Vic2l0ZXMv d2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKQEAgLTk3MSw2ICs5NzEsNDIgQEAg cHVibGljOgogPC9saT4KIDwvb2w+CiAKKzxoMz5Db21tZW50czwvaDM+Cis8b2w+Cis8bGk+VXNl IG9ubHkgPGk+b25lPC9pPiBzcGFjZSBiZWZvcmUgZW5kIG9mIGxpbmUgY29tbWVudHMgYW5kIGlu IGJldHdlZW4gc2VudGVuY2VzIGluIGNvbW1lbnRzLgorPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6 PC9oND4KKzxwcmUgY2xhc3M9ImNvZGUiPgorZihhLCBiKTsgLy8gVGhpcyBleHBsYWlucyB3aHkg dGhlIGZ1bmN0aW9uIGNhbGwgd2FzIGRvbmUuIFRoaXMgaXMgYW5vdGhlciBzZW50ZW5jZS4KKzwv cHJlPgorCis8aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+ CitpbnQgaTsgICAgLy8gVGhpcyBpcyBhIGNvbW1lbnQgd2l0aCBzZXZlcmFsIHNwYWNlcyBiZWZv cmUgaXQsIHdoaWNoIGlzIGEgbm9uLWNvbmZvcm1pbmcgc3R5bGUuCitkb3VibGUgZjsgLy8gVGhp cyBpcyBhbm90aGVyIGNvbW1lbnQuICBUaGVyZSBhcmUgdHdvIHNwYWNlcyBiZWZvcmUgdGhpcyBz ZW50ZW5jZSB3aGljaCBpcyBhIG5vbi1jb25mb3JtaW5nIHN0eWxlLgorPC9wcmU+Cis8L2xpPgor Cis8bGk+CitNYWtlIGNvbW1lbnRzIGxvb2sgbGlrZSBzZW50ZW5jZXMgYnkgc3RhcnRpbmcgd2l0 aCBhIGNhcGl0YWwgbGV0dGVyIGFuZCBlbmRpbmcgd2l0aCBhIHBlcmlvZCAocHVuY3RhdGlvbiku IE9uZSBleGNlcHRpb24gbWF5IGJlIGVuZCBvZiBsaW5lIGNvbW1lbnRzIGxpa2UgdGhpcyAiaWYg KHggPT0geSkgLy8gZmFsc2UgZm9yIE5hTiIuCis8L2xpPgorCis8bGk+CitVc2UgRklYTUU6ICh3 aXRob3V0IGF0dHJpYnV0aW9uKSB0byBkZW5vdGUgaXRlbXMgdGhhdCBuZWVkIHRvIGJlIGFkZHJl c3NlZCBpbiB0aGUgZnV0dXJlLgorPC9saT4KKzxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+ Cis8cHJlIGNsYXNzPSJjb2RlIj4KK2RyYXdKcGcoKTsgLy8gRklYTUU6IE1ha2UgdGhpcyBjb2Rl IGhhbmRsZSBqcGcgaW4gYWRkaXRpb24gdG8gdGhlIHBuZyBzdXBwb3J0LgorPC9wcmU+CisKKzxo NCBjbGFzcz0id3JvbmciPldyb25nOjwvaDQ+Cis8cHJlIGNsYXNzPSJjb2RlIj4KK2RyYXdKcGco KTsgLy8gRklYTUUoam9lKTogTWFrZSB0aGlzIGNvZGUgaGFuZGxlIGpwZyBpbiBhZGRpdGlvbiB0 byB0aGUgcG5nIHN1cHBvcnQuCis8L3ByZT4KKzxwcmUgY2xhc3M9ImNvZGUiPgorZHJhd0pwZygp OyAvLyBUT0RPOiBNYWtlIHRoaXMgY29kZSBoYW5kbGUganBnIGluIGFkZGl0aW9uIHRvIHRoZSBw bmcgc3VwcG9ydC4KKzwvcHJlPgorPC9vbD4KKwogPD9waHAKICAgICBpbmNsdWRlKCIuLi9mb290 ZXIuaW5jIik7CiA/Pgo=