55253 2011-02-25 13:12:09 -0800 check-webkit-style should check for spaces after periods in comments 2011-02-26 07:30:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 55272 1 eric webkit-unassigned ap commit-queue darin levin simon.fraser oldest_to_newest 358137 0 eric 2011-02-25 13:12:09 -0800 check-webkit-style should check for spaces after periods in comments I feel like every few patches someone tells me my spaces after periods are wrong. My typing teacher taught me 2, but I don't really care which. But I don't want to have my patches cq-'d due to lack of "proper" spacing. :) I'd rather have check-webkit-style tell me what to do (assuming we even want to bother to specify it). CCing folks who I believe care about this. 358138 1 eric 2011-02-25 13:12:53 -0800 We should also add a rule to http://www.webkit.org/coding/coding-style.html if we're going to enforce this. 358140 2 eric 2011-02-25 13:14:20 -0800 My tone in comment 0 sounds more angry than I mean. :) I mean more to sound ignorant and willing to do what I"m told. :) 358177 3 levin 2011-02-25 14:16:21 -0800 (In reply to comment #2) > My tone in comment 0 sounds more angry than I mean. :) I mean more to sound ignorant and willing to do what I"m told. :) I don't really care. I simply tell people because that is how I was brought up to do things in WebKit (per ap). It is part of my way outstanding work to put this in the style guide as it is one of the items in https://lists.webkit.org/pipermail/webkit-dev/2009-September/009807.html I very much need to add all of that to the style guide (and to the style checker) -- I'll try to get to this (unfortunately these items are my side items to handle). 358178 4 levin 2011-02-25 14:17:43 -0800 Added ap because he cares/often notes it as well (but I don't think there is much debate here -- as this was already brought up on the alias and just hasn't made it into the style guide yet b/c no one like me has put it there). 358211 5 darin 2011-02-25 14:53:37 -0800 I do care about consistency in this. And we have chosen single spaces. So yes, lets put it in the style guide and the checker script. 358245 6 ap 2011-02-25 15:50:20 -0800 I've been trained so by Darin (and I also prefer it because Russian typography uses uniform spacing, but that's completely irrelevant for WebKit). 358310 7 83906 levin 2011-02-25 17:40:03 -0800 Created attachment 83906 Patch 358498 8 commit-queue 2011-02-26 07:27:17 -0800 The commit-queue encountered the following flaky tests while processing attachment 83906: inspector/debugger/debugger-pause-on-exception.html bug 55298 (authors: loislo@chromium.org and pfeldman@chromium.org) The commit-queue is continuing to process your patch. 358499 9 83906 commit-queue 2011-02-26 07:30:06 -0800 Comment on attachment 83906 Patch Clearing flags on attachment: 83906 Committed r79787: <http://trac.webkit.org/changeset/79787> 358500 10 commit-queue 2011-02-26 07:30:10 -0800 All reviewed patches have been landed. Closing bug. 83906 2011-02-25 17:40:03 -0800 2011-02-26 07:30:06 -0800 Patch bug-55253-20110225174002.patch text/plain 4782 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2OTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NjBjNTVmNjAzYjdkYWNkNWI5ZWZmMDM0MGVlMDE5OGRj YTM2OGMxLi43ZDZmNmE2M2YxOTlmMTU4Nzc4N2RmOWI2NGMxYzRhNjI1MDJjZTFiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMjUgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1z dHlsZSBzaG91bGQgY2hlY2sgZm9yIHNwYWNlcyBhZnRlciBwZXJpb2RzIGluIGNvbW1lbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTI1MworCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IEFkZGVkIHRo ZSBjaGVjay4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weTogQWRkZWQgdGVzdHMKKyAgICAgICAgICBhbmQgZml4ZWQgdGhlIG5hbWUgb2Yg b25lIHJlbGF0ZWQgdGVzdC4KKwogMjAxMS0wMi0yNCAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2Vs eW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xp bmcuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4 IDljZmE5N2VjMjhiMzEzMzE2ZDMzZDRhYWM1YWJhNmE5NTdhZjA3YWEuLjdmOGE5ZWFiY2Q3OGEy NzAyNWQ0NzdiZGVlMTY0NTBiYWMyMzUwNzkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xNzI2LDcgKzE3MjYsNyBAQCBkZWYgY2hlY2tfc3Bh Y2luZyhmaWxlX2V4dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAg ICAgICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2JsYW5rX2xpbmUn LCAzLAogICAgICAgICAgICAgICAgICAgICAgICdCbGFuayBsaW5lIGF0IHRoZSBlbmQgb2YgYSBj b2RlIGJsb2NrLiAgSXMgdGhpcyBuZWVkZWQ/JykKIAotICAgICMgTmV4dCwgd2UgY29tcGxhaW4g aWYgdGhlcmUncyBhIGNvbW1lbnQgdG9vIG5lYXIgdGhlIHRleHQKKyAgICAjIE5leHQsIHdlIGNo ZWNrIGZvciBwcm9wZXIgc3BhY2luZyB3aXRoIHJlc3BlY3QgdG8gY29tbWVudHMuCiAgICAgY29t bWVudF9wb3NpdGlvbiA9IGxpbmUuZmluZCgnLy8nKQogICAgIGlmIGNvbW1lbnRfcG9zaXRpb24g IT0gLTE6CiAgICAgICAgICMgQ2hlY2sgaWYgdGhlIC8vIG1heSBiZSBpbiBxdW90ZXMuICBJZiBz bywgaWdub3JlIGl0CkBAIC0xNzU0LDYgKzE3NTQsMTEgQEAgZGVmIGNoZWNrX3NwYWNpbmcoZmls ZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAg ICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvY29tbWVudHMnLCA0LAog ICAgICAgICAgICAgICAgICAgICAgICAgICAnU2hvdWxkIGhhdmUgYSBzcGFjZSBiZXR3ZWVuIC8v IGFuZCBjb21tZW50JykKIAorICAgICAgICAgICAgIyBUaGVyZSBzaG91bGQgb25seSBiZSBvbmUg c3BhY2UgYWZ0ZXIgcHVuY3R1YXRpb24gaW4gYSBjb21tZW50LgorICAgICAgICAgICAgaWYgc2Vh cmNoKCdbLiE/LDs6XVxzXHMnLCBsaW5lW2NvbW1lbnRfcG9zaXRpb246XSk6CisgICAgICAgICAg ICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2NvbW1lbnRzJywgNSwKKyAgICAg ICAgICAgICAgICAgICAgICAnU2hvdWxkIG9ubHkgYSBzaW5nbGUgc3BhY2UgYWZ0ZXIgYSBwdW5j dHVhdGlvbiBpbiBhIGNvbW1lbnQuJykKKwogICAgIGxpbmUgPSBjbGVhbl9saW5lcy5lbGlkZWRb bGluZV9udW1iZXJdICAjIGdldCByaWQgb2YgY29tbWVudHMgYW5kIHN0cmluZ3MKIAogICAgICMg RG9uJ3QgdHJ5IHRvIGRvIHNwYWNpbmcgY2hlY2tzIGZvciBvcGVyYXRvciBtZXRob2RzCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVz dC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5CmluZGV4IGQxNDE5ZDllMzJhYTI3NWQ5YmI3ZmJmYmMyNjc3OTJlMzQyODJiMGMuLjJkMmFi YmZhNjBjMDJhNjVmYmQzZDYzMTA2NjJkYjcxYmE3ZmY2ZGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0xNzc5 LDcgKzE3NzksNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAg ICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgnI2VuZGlmXG4gICAgKTsnLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJycpCiAKLSAgICBkZWYgdGVzdF90d29fc3Bh Y2VzX2JldHdlZW5fY29kZV9hbmRfY29tbWVudHMoc2VsZik6CisgICAgZGVmIHRlc3Rfb25lX3Nw YWNlc19iZXR3ZWVuX2NvZGVfYW5kX2NvbW1lbnRzKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2Vy dF9saW50KCd9IC8vIG5hbWVzcGFjZSBmb28nLAogICAgICAgICAgICAgICAgICAgICAgICAgICcn KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd9Ly8gbmFtZXNwYWNlIGZvbycsCkBAIC0xODA2 LDYgKzE4MDYsMjQgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAg ICAgICBzZWxmLmFzc2VydF9saW50KCdwcmludGYoIlxcIiVzIC8vIEluIHF1b3Rlcy4iKScsICcn KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdwcmludGYoIiVzIiwgIi8vIEluIHF1b3Rlcy4i KScsICcnKQogCisgICAgZGVmIHRlc3Rfb25lX3NwYWNlc19hZnRlcl9wdW5jdHVhdGlvbl9pbl9j b21tZW50cyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50IGE7IC8vIFRoaXMg aXMgYSBzZW50ZW5jZS4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICcnKQorICAgICAgICBz ZWxmLmFzc2VydF9saW50KCdpbnQgYTsgLy8gVGhpcyBpcyBhIHNlbnRlbmNlLiBUaGlzIGlzIGEg YW5vdGhlciBzZW50ZW5jZS4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICcnKQorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCdpbnQgYTsgLy8gVGhpcyBpcyBhIHNlbnRlbmNlLiAgVGhpcyBp cyBhIGFub3RoZXIgc2VudGVuY2UuJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAnU2hvdWxk IG9ubHkgYSBzaW5nbGUgc3BhY2UgYWZ0ZXIgYSBwdW5jdHVhdGlvbiBpbiBhIGNvbW1lbnQuICBb d2hpdGVzcGFjZS9jb21tZW50c10gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50 IGE7IC8vIFRoaXMgaXMgYSBzZW50ZW5jZSEgIFRoaXMgaXMgYSBhbm90aGVyIHNlbnRlbmNlLics CisgICAgICAgICAgICAgICAgICAgICAgICAgJ1Nob3VsZCBvbmx5IGEgc2luZ2xlIHNwYWNlIGFm dGVyIGEgcHVuY3R1YXRpb24gaW4gYSBjb21tZW50LiAgW3doaXRlc3BhY2UvY29tbWVudHNdIFs1 XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ludCBhOyAvLyBXaHkgZGlkIEkgd3JpdGUg dGhpcz8gIFRoaXMgaXMgYSBhbm90aGVyIHNlbnRlbmNlLicsCisgICAgICAgICAgICAgICAgICAg ICAgICAgJ1Nob3VsZCBvbmx5IGEgc2luZ2xlIHNwYWNlIGFmdGVyIGEgcHVuY3R1YXRpb24gaW4g YSBjb21tZW50LiAgW3doaXRlc3BhY2UvY29tbWVudHNdIFs1XScpCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoJ2ludCBhOyAvLyBFbGVtZW50YXJ5LCAgbXkgZGVhci4nLAorICAgICAgICAgICAg ICAgICAgICAgICAgICdTaG91bGQgb25seSBhIHNpbmdsZSBzcGFjZSBhZnRlciBhIHB1bmN0dWF0 aW9uIGluIGEgY29tbWVudC4gIFt3aGl0ZXNwYWNlL2NvbW1lbnRzXSBbNV0nKQorICAgICAgICBz ZWxmLmFzc2VydF9saW50KCdpbnQgYTsgLy8gVGhlIGZvbGxvd2luZyBzaG91bGQgYmUgY2xlYXI6 ICBJcyBpdD8nLAorICAgICAgICAgICAgICAgICAgICAgICAgICdTaG91bGQgb25seSBhIHNpbmds ZSBzcGFjZSBhZnRlciBhIHB1bmN0dWF0aW9uIGluIGEgY29tbWVudC4gIFt3aGl0ZXNwYWNlL2Nv bW1lbnRzXSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdpbnQgYTsgLy8gTG9vayBh dCB0aGUgZm9sbG93IHNlbWljb2xvbjsgIEkgaG9wZSB0aGlzIGdpdmVzIGFuIGVycm9yLicsCisg ICAgICAgICAgICAgICAgICAgICAgICAgJ1Nob3VsZCBvbmx5IGEgc2luZ2xlIHNwYWNlIGFmdGVy IGEgcHVuY3R1YXRpb24gaW4gYSBjb21tZW50LiAgW3doaXRlc3BhY2UvY29tbWVudHNdIFs1XScp CisKICAgICBkZWYgdGVzdF9zcGFjZV9hZnRlcl9jb21tZW50X21hcmtlcihzZWxmKToKICAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnLy8nLCAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn Ly94JywgJ1Nob3VsZCBoYXZlIGEgc3BhY2UgYmV0d2VlbiAvLyBhbmQgY29tbWVudCcK