55205 2011-02-24 23:20:45 -0800 HashSet<T>::end() creation is expensive and should be avoided 2011-02-27 09:01:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 48719 1 eric eric abarth aestes commit-queue darin eric mjs webkit.review.bot oldest_to_newest 357722 0 eric 2011-02-24 23:20:45 -0800 HashSet<T>::end() creation is expensive and should be avoided 357724 1 83776 eric 2011-02-24 23:22:28 -0800 Created attachment 83776 Patch 357727 2 83776 mjs 2011-02-24 23:28:58 -0800 Comment on attachment 83776 Patch r=me 358471 3 83776 commit-queue 2011-02-26 05:46:23 -0800 Comment on attachment 83776 Patch Rejecting attachment 83776 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: .......................................................................................................... http/tests/ssl ... http/tests/storage . http/tests/uri .... http/tests/webarchive ..... http/tests/websocket/tests .......................... http/tests/websocket/tests/multiple-connections.html -> failed Exiting early after 1 failures. 22543 tests run. 703.11s total testing time 22542 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 14 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8034759 358473 4 83776 commit-queue 2011-02-26 05:47:29 -0800 Comment on attachment 83776 Patch Clearing flags on attachment: 83776 Committed r79780: <http://trac.webkit.org/changeset/79780> 358474 5 commit-queue 2011-02-26 05:47:35 -0800 All reviewed patches have been landed. Closing bug. 358535 6 darin 2011-02-26 09:22:24 -0800 Maybe we could special case HashTable::end since the hash table knows its empty and could just return begin in that case. 358684 7 webkit.review.bot 2011-02-27 09:01:22 -0800 http://trac.webkit.org/changeset/79780 might have broken GTK Linux 64-bit Debug 83776 2011-02-24 23:22:28 -0800 2011-02-26 05:47:29 -0800 Patch bug-55205-20110224232227.patch text/plain 5213 eric U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2NTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNmExMmZiYjkzYjljNDcx YTNlMzAxMjgyMjY5M2ZjMDg4NjM1Y2Y1Li5lZTY5NDNlZWZlNmU2NDFhZmQ3Y2NjMTc3OGU3ZGEy MGYyODhhY2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsNDIgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBIYXNoU2V0PFQ+OjplbmQoKSBjcmVhdGlv biBpcyBleHBlbnNpdmUgYW5kIHNob3VsZCBiZSBhdm9pZGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIwNQorCisgICAgICAgIEluIHRoZSBjb21t b24gY2FzZSwgbV9yYW5nZXMgaXMgYW4gZW1wdHkgc2V0LiAgV2hlbiB0aGF0J3MKKyAgICAgICAg dGhlIGNhc2UsIHdlIHNwZW5kIGFsbCBvdXIgdGltZSBpbiBza2lwRW1wdHlCdWNrZXRzLCB3YWxr aW5nCisgICAgICAgIHRoZSBoYXNoIHN0b3JhZ2Ugc2tpcHBpbmcgb3ZlciBlbXB0eSBidWNrZXRz LgorICAgICAgICAKKyAgICAgICAgVGhpcyBsb29rcyB0byBiZSBhdCBsZWFzdCBhIDUlIHNwZWVk dXAgb24gKG15IGxvY2FsIHZlcnNpb24gb2YpIHBlYWNla2VlcGVyJ3MgZG9tRHluYW1pY0NyZWF0 aW9uQ3JlYXRlRWxlbWVudC4KKworICAgICAgICBCZWZvcmU6CisgICAgICAgIGF2ZyAzODMuNjY2 NjY2NjY2NjY2NworICAgICAgICBtZWRpYW4gMzg2CisgICAgICAgIHN0ZGV2IDcuMTUyMzExMjAz NzY4NzIyCisgICAgICAgIG1pbiAzNjAKKyAgICAgICAgbWF4IDM5MQorCisgICAgICAgIEFmdGVy OgorICAgICAgICBhdmcgMzY2LjMzMzMzMzMzMzMzMzMKKyAgICAgICAgbWVkaWFuIDM2NgorICAg ICAgICBzdGRldiAyLjcxMjExMjc0NzU3NDM5OQorICAgICAgICBtaW4gMzYyCisgICAgICAgIG1h eCAzNzcKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6bm9kZUNoaWxkcmVuQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVu dDo6bm9kZUNoaWxkcmVuV2lsbEJlUmVtb3ZlZCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVu dDo6bm9kZVdpbGxCZVJlbW92ZWQpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnRleHRJ bnNlcnRlZCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dGV4dFJlbW92ZWQpOgorICAg ICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnRleHROb2Rlc01lcmdlZCk6CisgICAgICAgIChXZWJD b3JlOjpEb2N1bWVudDo6dGV4dE5vZGVTcGxpdCk6CisKKzIwMTEtMDItMjQgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCiAgICAgICAgIG1hbGxvYyBpbiByZW1vdmVDaGlsZHJlbiBzaG93cyB1cCBvbiBwcm9maWxl IG9mIHBlYWNla2VlcGVyIGRvbUR5bmFtaWNDcmVhdGlvbkNyZWF0ZUVsZW1lbnQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MjA0CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCmluZGV4IGQxMTFhMzdlZTEzYTI0NmE1ZjBjNThkZTQzYmM1YTE3ZjkxOWIz NDEuLjFiMmE0YmI3OGJmZDkzMWMzMTdhZGNjYjUzMmU0OTFkNDQwYmJiNWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcApAQCAtMzMxMCw3ICszMzEwLDcgQEAgdm9pZCBEb2N1bWVudDo6bW92ZU5v ZGVJdGVyYXRvcnNUb05ld0RvY3VtZW50KE5vZGUqIG5vZGUsIERvY3VtZW50KiBuZXdEb2N1bWVu dCkKIAogdm9pZCBEb2N1bWVudDo6bm9kZUNoaWxkcmVuQ2hhbmdlZChDb250YWluZXJOb2RlKiBj b250YWluZXIpCiB7Ci0gICAgaWYgKCFkaXNhYmxlUmFuZ2VNdXRhdGlvbihwYWdlKCkpKSB7Cisg ICAgaWYgKCFkaXNhYmxlUmFuZ2VNdXRhdGlvbihwYWdlKCkpICYmICFtX3Jhbmdlcy5pc0VtcHR5 KCkpIHsKICAgICAgICAgSGFzaFNldDxSYW5nZSo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBtX3Jh bmdlcy5lbmQoKTsKICAgICAgICAgZm9yIChIYXNoU2V0PFJhbmdlKj46OmNvbnN0X2l0ZXJhdG9y IGl0ID0gbV9yYW5nZXMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KQogICAgICAgICAgICAgKCpp dCktPm5vZGVDaGlsZHJlbkNoYW5nZWQoY29udGFpbmVyKTsKQEAgLTMzMTksNyArMzMxOSw3IEBA IHZvaWQgRG9jdW1lbnQ6Om5vZGVDaGlsZHJlbkNoYW5nZWQoQ29udGFpbmVyTm9kZSogY29udGFp bmVyKQogCiB2b2lkIERvY3VtZW50Ojpub2RlQ2hpbGRyZW5XaWxsQmVSZW1vdmVkKENvbnRhaW5l ck5vZGUqIGNvbnRhaW5lcikKIHsKLSAgICBpZiAoIWRpc2FibGVSYW5nZU11dGF0aW9uKHBhZ2Uo KSkpIHsKKyAgICBpZiAoIWRpc2FibGVSYW5nZU11dGF0aW9uKHBhZ2UoKSkgJiYgIW1fcmFuZ2Vz LmlzRW1wdHkoKSkgewogICAgICAgICBIYXNoU2V0PFJhbmdlKj46OmNvbnN0X2l0ZXJhdG9yIGVu ZCA9IG1fcmFuZ2VzLmVuZCgpOwogICAgICAgICBmb3IgKEhhc2hTZXQ8UmFuZ2UqPjo6Y29uc3Rf aXRlcmF0b3IgaXQgPSBtX3Jhbmdlcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpCiAgICAgICAg ICAgICAoKml0KS0+bm9kZUNoaWxkcmVuV2lsbEJlUmVtb3ZlZChjb250YWluZXIpOwpAQCAtMzM0 NSw3ICszMzQ1LDcgQEAgdm9pZCBEb2N1bWVudDo6bm9kZVdpbGxCZVJlbW92ZWQoTm9kZSogbikK ICAgICBmb3IgKEhhc2hTZXQ8Tm9kZUl0ZXJhdG9yKj46OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbV9u b2RlSXRlcmF0b3JzLmJlZ2luKCk7IGl0ICE9IG5vZGVJdGVyYXRvcnNFbmQ7ICsraXQpCiAgICAg ICAgICgqaXQpLT5ub2RlV2lsbEJlUmVtb3ZlZChuKTsKIAotICAgIGlmICghZGlzYWJsZVJhbmdl TXV0YXRpb24ocGFnZSgpKSkgeworICAgIGlmICghZGlzYWJsZVJhbmdlTXV0YXRpb24ocGFnZSgp KSAmJiAhbV9yYW5nZXMuaXNFbXB0eSgpKSB7CiAgICAgICAgIEhhc2hTZXQ8UmFuZ2UqPjo6Y29u c3RfaXRlcmF0b3IgcmFuZ2VzRW5kID0gbV9yYW5nZXMuZW5kKCk7CiAgICAgICAgIGZvciAoSGFz aFNldDxSYW5nZSo+Ojpjb25zdF9pdGVyYXRvciBpdCA9IG1fcmFuZ2VzLmJlZ2luKCk7IGl0ICE9 IHJhbmdlc0VuZDsgKytpdCkKICAgICAgICAgICAgICgqaXQpLT5ub2RlV2lsbEJlUmVtb3ZlZChu KTsKQEAgLTMzNzcsNyArMzM3Nyw3IEBAIHZvaWQgRG9jdW1lbnQ6Om5vZGVXaWxsQmVSZW1vdmVk KE5vZGUqIG4pCiAKIHZvaWQgRG9jdW1lbnQ6OnRleHRJbnNlcnRlZChOb2RlKiB0ZXh0LCB1bnNp Z25lZCBvZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCkKIHsKLSAgICBpZiAoIWRpc2FibGVSYW5nZU11 dGF0aW9uKHBhZ2UoKSkpIHsKKyAgICBpZiAoIWRpc2FibGVSYW5nZU11dGF0aW9uKHBhZ2UoKSkg JiYgIW1fcmFuZ2VzLmlzRW1wdHkoKSkgewogICAgICAgICBIYXNoU2V0PFJhbmdlKj46OmNvbnN0 X2l0ZXJhdG9yIGVuZCA9IG1fcmFuZ2VzLmVuZCgpOwogICAgICAgICBmb3IgKEhhc2hTZXQ8UmFu Z2UqPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSBtX3Jhbmdlcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsr aXQpCiAgICAgICAgICAgICAoKml0KS0+dGV4dEluc2VydGVkKHRleHQsIG9mZnNldCwgbGVuZ3Ro KTsKQEAgLTMzODksNyArMzM4OSw3IEBAIHZvaWQgRG9jdW1lbnQ6OnRleHRJbnNlcnRlZChOb2Rl KiB0ZXh0LCB1bnNpZ25lZCBvZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCkKIAogdm9pZCBEb2N1bWVu dDo6dGV4dFJlbW92ZWQoTm9kZSogdGV4dCwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBsZW5n dGgpCiB7Ci0gICAgaWYgKCFkaXNhYmxlUmFuZ2VNdXRhdGlvbihwYWdlKCkpKSB7CisgICAgaWYg KCFkaXNhYmxlUmFuZ2VNdXRhdGlvbihwYWdlKCkpICYmICFtX3Jhbmdlcy5pc0VtcHR5KCkpIHsK ICAgICAgICAgSGFzaFNldDxSYW5nZSo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBtX3Jhbmdlcy5l bmQoKTsKICAgICAgICAgZm9yIChIYXNoU2V0PFJhbmdlKj46OmNvbnN0X2l0ZXJhdG9yIGl0ID0g bV9yYW5nZXMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KQogICAgICAgICAgICAgKCppdCktPnRl eHRSZW1vdmVkKHRleHQsIG9mZnNldCwgbGVuZ3RoKTsKQEAgLTM0MDIsNyArMzQwMiw3IEBAIHZv aWQgRG9jdW1lbnQ6OnRleHRSZW1vdmVkKE5vZGUqIHRleHQsIHVuc2lnbmVkIG9mZnNldCwgdW5z aWduZWQgbGVuZ3RoKQogCiB2b2lkIERvY3VtZW50Ojp0ZXh0Tm9kZXNNZXJnZWQoVGV4dCogb2xk Tm9kZSwgdW5zaWduZWQgb2Zmc2V0KQogewotICAgIGlmICghZGlzYWJsZVJhbmdlTXV0YXRpb24o cGFnZSgpKSkgeworICAgIGlmICghZGlzYWJsZVJhbmdlTXV0YXRpb24ocGFnZSgpKSAmJiAhbV9y YW5nZXMuaXNFbXB0eSgpKSB7CiAgICAgICAgIE5vZGVXaXRoSW5kZXggb2xkTm9kZVdpdGhJbmRl eChvbGROb2RlKTsKICAgICAgICAgSGFzaFNldDxSYW5nZSo+Ojpjb25zdF9pdGVyYXRvciBlbmQg PSBtX3Jhbmdlcy5lbmQoKTsKICAgICAgICAgZm9yIChIYXNoU2V0PFJhbmdlKj46OmNvbnN0X2l0 ZXJhdG9yIGl0ID0gbV9yYW5nZXMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KQpAQCAtMzQxNCw3 ICszNDE0LDcgQEAgdm9pZCBEb2N1bWVudDo6dGV4dE5vZGVzTWVyZ2VkKFRleHQqIG9sZE5vZGUs IHVuc2lnbmVkIG9mZnNldCkKIAogdm9pZCBEb2N1bWVudDo6dGV4dE5vZGVTcGxpdChUZXh0KiBv bGROb2RlKQogewotICAgIGlmICghZGlzYWJsZVJhbmdlTXV0YXRpb24ocGFnZSgpKSkgeworICAg IGlmICghZGlzYWJsZVJhbmdlTXV0YXRpb24ocGFnZSgpKSAmJiAhbV9yYW5nZXMuaXNFbXB0eSgp KSB7CiAgICAgICAgIEhhc2hTZXQ8UmFuZ2UqPjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbV9yYW5n ZXMuZW5kKCk7CiAgICAgICAgIGZvciAoSGFzaFNldDxSYW5nZSo+Ojpjb25zdF9pdGVyYXRvciBp dCA9IG1fcmFuZ2VzLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkKICAgICAgICAgICAgICgqaXQp LT50ZXh0Tm9kZVNwbGl0KG9sZE5vZGUpOwo=