<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55113</bug_id>
          
          <creation_ts>2011-02-23 22:54:01 -0800</creation_ts>
          <short_desc>Add a script for creating gypi files</short_desc>
          <delta_ts>2011-02-24 16:52:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>356685</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-02-23 22:54:01 -0800</bug_when>
    <thetext>Add a script for creating gypi files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>356686</commentid>
    <comment_count>1</comment_count>
      <attachid>83608</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-02-23 22:55:09 -0800</bug_when>
    <thetext>Created attachment 83608
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>356739</commentid>
    <comment_count>2</comment_count>
      <attachid>83608</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-02-24 00:54:51 -0800</bug_when>
    <thetext>Comment on attachment 83608
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83608&amp;action=review

Honestly, this is totally fine and doesn&apos;t really even need review.

&gt; Tools/Scripts/make-gypi:43
&gt; +    source_code_regexp = re.compile(r&apos;\.(cpp|h)$&apos;)

I would have done this as an array of extensions, but this is OK too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357571</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-02-24 16:52:19 -0800</bug_when>
    <thetext>Committed r79642: &lt;http://trac.webkit.org/changeset/79642&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>83608</attachid>
            <date>2011-02-23 22:55:09 -0800</date>
            <delta_ts>2011-02-24 00:54:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55113-20110223225508.patch</filename>
            <type>text/plain</type>
            <size>3691</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDc5NTE3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMTEtMDItMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBzY3Jp
cHQgZm9yIGNyZWF0aW5nIGd5cGkgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTU1MTEzCisKKyAgICAgICAgVGhpcyBpcyBhIHRyaXZpYWwgc2Ny
aXB0IHRvIGNyZWF0ZSBneXBpIGZpbGVzIGZyb20gdGhlIHNvdXJjZSBjb2RlIGluCisgICAgICAg
IHRoZSBjdXJyZW50IGRpcmVjdG9yeS4KKworICAgICAgICAqIFNjcmlwdHMvbWFrZS1neXBpOiBB
ZGRlZC4KKwogMjAxMS0wMi0yMyAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAK
ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjc5Mzg3LgpJbmRleDogVG9vbHMvU2Ny
aXB0cy9tYWtlLWd5cGkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9tYWtlLWd5cGkJKHJl
dmlzaW9uIDApCisrKyBUb29scy9TY3JpcHRzL21ha2UtZ3lwaQkocmV2aXNpb24gMCkKQEAgLTAs
MCArMSw3MiBAQAorIyEvdXNyL2Jpbi9lbnYgcHl0aG9uCisjIENvcHlyaWdodCAoYykgMjAxMSBH
b29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQg
dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZp
Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp
b25zIGFyZQorIyBtZXQ6CisjCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29k
ZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9m
IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgICAgICogUmVkaXN0
cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5
cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk
aXNjbGFpbWVyCisjIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMg
cHJvdmlkZWQgd2l0aCB0aGUKKyMgZGlzdHJpYnV0aW9uLgorIyAgICAgKiBOZWl0aGVyIHRoZSBu
YW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisjIGNvbnRyaWJ1dG9ycyBt
YXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisj
IHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24u
CisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJT
IEFORCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBX
QVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQg
V0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElD
VUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJ
R0hUCisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElO
RElSRUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJ
QUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5U
IE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBP
UiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBP
TiBBTlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNU
IExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNF
KSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwg
RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1w
b3J0IG9zCitpbXBvcnQgcmUKK2ltcG9ydCBzeXMKKworR1lQSV9URU1QTEFURSA9ICIiInsKKyAg
ICAndmFyaWFibGVzJzogeworICAgICAgICAnJXMnOiBbCislcworICAgICAgICBdCisgICAgfQor
fSIiIiAKKworZGVmIGZpbmRfc291cmNlX2NvZGUoKToKKyAgICBzb3VyY2VfY29kZV9yZWdleHAg
PSByZS5jb21waWxlKHInXC4oY3BwfGgpJCcpCisKKyAgICBjb2xsZWN0ZWRfZmlsZXMgPSBbXQor
ICAgIGZvciBkaXJlY3RvcnlfcGF0aCwgZGlyZWN0b3J5X25hbWVzLCBmaWxlX25hbWVzIGluIG9z
LndhbGsoJy4nKToKKyAgICAgICAgZm9yIGZpbGVfbmFtZSBpbiBmaWxlX25hbWVzOgorICAgICAg
ICAgICAgaWYgc291cmNlX2NvZGVfcmVnZXhwLnNlYXJjaChmaWxlX25hbWUpOgorICAgICAgICAg
ICAgICAgIHJlbGF0aXZlX3BhdGggPSBvcy5wYXRoLmpvaW4oZGlyZWN0b3J5X3BhdGgsIGZpbGVf
bmFtZSkKKyAgICAgICAgICAgICAgICBjb2xsZWN0ZWRfZmlsZXMuYXBwZW5kKG9zLnBhdGgucmVs
cGF0aChyZWxhdGl2ZV9wYXRoLCAnLicpKQorCisgICAgcmV0dXJuIGNvbGxlY3RlZF9maWxlcwor
CitkZWYgYnVpbGRfZmlsZV9saW5lKGZpbGVfbmFtZSwgaW5kZW50KToKKyAgICByZXR1cm4gaW5k
ZW50ICsgICInJXMnLCIgJSBmaWxlX25hbWUKKworZGVmIGJ1aWxkX2ZpbGVfbGlzdChzb3VyY2Vf
Y29kZSwgaW5kZW50KToKKyAgICByZXR1cm4gJ1xuJy5qb2luKFtidWlsZF9maWxlX2xpbmUoZmls
ZV9uYW1lLCBpbmRlbnQpIGZvciBmaWxlX25hbWUgaW4gc29ydGVkKHNvdXJjZV9jb2RlKV0pCisK
K2RlZiBidWlsZF9neXBpKHByb2plY3QpOgorICAgIGtleSA9IHByb2plY3QubG93ZXIoKSArICdf
ZmlsZXMnCisgICAgdmFsdWUgPSBidWlsZF9maWxlX2xpc3QoZmluZF9zb3VyY2VfY29kZSgpLCAn
ICAgICcgKiAzKQorICAgIHJldHVybiBHWVBJX1RFTVBMQVRFICUgKGtleSwgdmFsdWUpCisKK2Rl
ZiBtYWluKCk6CisgICAgaWYgbGVuKHN5cy5hcmd2KSA8IDI6CisgICAgICAgIHByaW50ICdVc2Fn
ZTogJXMgcHJvamVjdF9uYW1lJyAlIHN5cy5hcmd2WzBdCisgICAgICAgIHJldHVybgorICAgIHBy
aW50IGJ1aWxkX2d5cGkoc3lzLmFyZ3ZbMV0pCisKK2lmIF9fbmFtZV9fID09ICJfX21haW5fXyI6
CisgICAgbWFpbigpCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBUb29scy9TY3JpcHRzL21ha2UtZ3lw
aQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCkFkZGVkOiBzdm46ZXhlY3V0YWJsZQogICArICoKCg==
</data>
<flag name="review"
          id="75452"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="75453"
          type_id="3"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>