54914 2011-02-21 16:01:19 -0800 [chromium] ChromePluginPrintContext::begin() fails to override superclass method 2011-02-21 18:08:34 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54367 1 thakis webkit-unassigned commit-queue hamaji tkent oldest_to_newest 354873 0 thakis 2011-02-21 16:01:19 -0800 /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:361:18:error: 'WebKit::ChromePluginPrintContext::begin' hides overloaded virtual function [-Woverloaded-virtual] virtual void begin(float width) ^ /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:291:18: note: hidden overloaded virtual function 'WebKit::ChromePrintContext::begin' declared here virtual void begin(float width, float height) ^ The signature of the superclass method was changed in http://trac.webkit.org/changeset/71964 , but the subclass was not updated. 354877 1 83234 thakis 2011-02-21 16:04:30 -0800 Created attachment 83234 Patch 354948 2 commit-queue 2011-02-21 18:06:18 -0800 The commit-queue encountered the following flaky tests while processing attachment 83234: animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 354951 3 83234 commit-queue 2011-02-21 18:08:29 -0800 Comment on attachment 83234 Patch Clearing flags on attachment: 83234 Committed r79276: <http://trac.webkit.org/changeset/79276> 354952 4 commit-queue 2011-02-21 18:08:34 -0800 All reviewed patches have been landed. Closing bug. 83234 2011-02-21 16:04:30 -0800 2011-02-21 18:08:29 -0800 Patch bug-54914-20110221160429.patch text/plain 1288 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogNzgzNTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg N2MxNTRmNWY2Mzg4ZTMxNzFlMjhlZmRiM2FjYTNiZDYwODZkNTcxMy4uZDIzNjQyZWFlMjA2YTY2 Yzc5MzVmZTUwMDM1ZGFkODkxMjNjM2RjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wMi0yMSAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBDaHJvbWVQbHVnaW5QcmludENvbnRleHQ6OmJlZ2luKCkgZmFpbHMgdG8gb3ZlcnJp ZGUgc3VwZXJjbGFzcyBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU0OTE0CisKKyAgICAgICAgVXBkYXRlIHN1YmNsYXNzIG1ldGhvZCBzaWdu YXR1cmUgdG8gbWF0Y2ggc3VwZXJjbGFzcyBhZ2Fpbi4gVGhpcworICAgICAgICByZWdyZXNzZWQg aW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNzE5NjQKKworICAgICAgICAqIHNy Yy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVQbHVnaW5QcmludENv bnRleHQ6OmJlZ2luKToKKwogMjAxMS0wMi0xMCAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCBjODZlNzE1OTExYzBmMmRmMWJj NWUwYzhjY2Q3OTI5YzQzY2Y2NTA0Li5mYTc2ZTFlNDFkNGY1N2Y0NGViODY5MGQ1OWRlYTUwMzRk ZWVkYTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUlt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAK QEAgLTM1OCw3ICszNTgsNyBAQCBwdWJsaWM6CiAgICAgewogICAgIH0KIAotICAgIHZpcnR1YWwg dm9pZCBiZWdpbihmbG9hdCB3aWR0aCkKKyAgICB2aXJ0dWFsIHZvaWQgYmVnaW4oZmxvYXQgd2lk dGgsIGZsb2F0IGhlaWdodCkKICAgICB7CiAgICAgfQogCg==