54833 2011-02-20 13:39:19 -0800 Remove pthread dependency of GCController 2011-04-17 18:26:55 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 paroga paroga ap aroben commit-queue eric ggaren oldest_to_newest 354310 0 paroga 2011-02-20 13:39:19 -0800 Remove pthread dependency of GCController 354311 1 83102 paroga 2011-02-20 13:40:53 -0800 Created attachment 83102 Patch 354335 2 ap 2011-02-20 17:18:49 -0800 The patch looks fine to me, but the code as a whole doesn't. Shouldn't we call pthread_detach() in immediate return case? CC'ing the author of this code in case I'm somehow confused. 354723 3 ggaren 2011-02-21 12:16:22 -0800 (In reply to comment #2) > Shouldn't we call pthread_detach() in immediate return case? Yes. This is a bug. 354725 4 83102 paroga 2011-02-21 12:18:46 -0800 Comment on attachment 83102 Patch (In reply to comment #3) > (In reply to comment #2) > > Shouldn't we call pthread_detach() in immediate return case? > > Yes. This is a bug. I'll create a new patch in the next days. 355499 5 83363 paroga 2011-02-22 12:30:11 -0800 Created attachment 83363 Patch 355504 6 ggaren 2011-02-22 12:35:27 -0800 Is it safe to call detachThread after calling waitForThreadCompletion? 355509 7 ap 2011-02-22 12:40:56 -0800 I thought that it's one or the other, not both. 355514 8 83366 paroga 2011-02-22 12:42:52 -0800 Created attachment 83366 Patch AFAIK it's no problem to do both, but the cleaner way is to to only one of them 382963 9 83366 eric 2011-04-10 16:28:35 -0700 Comment on attachment 83366 Patch Seems sane to me. 387446 10 83366 commit-queue 2011-04-17 16:08:36 -0700 Comment on attachment 83366 Patch Clearing flags on attachment: 83366 Committed r84113: <http://trac.webkit.org/changeset/84113> 387447 11 commit-queue 2011-04-17 16:08:41 -0700 All reviewed patches have been landed. Closing bug. 387454 12 commit-queue 2011-04-17 16:20:13 -0700 The commit-queue encountered the following flaky tests while processing attachment 83366: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 387492 13 commit-queue 2011-04-17 18:26:55 -0700 The commit-queue encountered the following flaky tests while processing attachment 83366: http/tests/xmlhttprequest/abort-crash.html bug 51649 (author: andersca@apple.com) The commit-queue is continuing to process your patch. 83102 2011-02-20 13:40:53 -0800 2011-02-21 12:18:45 -0800 Patch bug-54833-20110220224051.patch text/plain 1632 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxNTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZjZhOWEzM2I2YWRjZjU0 M2RkNzkwY2YwMTk4YzY2Yjg2NTc0ODAwLi5lNmJiODRkNDQ2YTNlNWIxZTE3Njk3ODBhNjU5ZmU3 NWM2MDBlZWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjAgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHB0aHJlYWQgZGVwZW5kZW5jeSBvZiBH Q0NvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0ODMzCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE9uQWx0ZXJuYXRlVGhy ZWFkRm9yRGVidWdnaW5nKToKKwogMjAxMS0wMi0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29u LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAKaW5kZXggZmUw ZTM2ZmI5MDM2ZTBmOTNmMjA3MTFhYzExN2FiNGEyZDE4ZmZiOC4uMDYxYmRmOWZhNzcyN2FhNDY5 NTY5ODk3OGVlMTE5YWVjY2RmYjdkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvR0NDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9H Q0NvbnRyb2xsZXIuY3BwCkBAIC0zMiwxMCArMzIsNiBAQAogI2luY2x1ZGUgPHJ1bnRpbWUvSGVh cC5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAotI2lmIFVTRShQVEhSRUFEUykK LSNpbmNsdWRlIDxwdGhyZWFkLmg+Ci0jZW5kaWYKLQogdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAog bmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNzgsMTMgKzc0LDEwIEBAIHZvaWQgR0NDb250cm9sbGVy OjpnYXJiYWdlQ29sbGVjdE5vdygpCiAKIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVj dE9uQWx0ZXJuYXRlVGhyZWFkRm9yRGVidWdnaW5nKGJvb2wgd2FpdFVudGlsRG9uZSkKIHsKLSNp ZiBVU0UoUFRIUkVBRFMpCi0gICAgcHRocmVhZF90IHRocmVhZDsKLSAgICBwdGhyZWFkX2NyZWF0 ZSgmdGhyZWFkLCBOVUxMLCBjb2xsZWN0LCBOVUxMKTsKKyAgICBUaHJlYWRJZGVudGlmaWVyIHRo cmVhZElEID0gY3JlYXRlVGhyZWFkKGNvbGxlY3QsIDAsICJXZWJDb3JlOiBHQ0NvbnRyb2xsZXIi KTsKIAogICAgIGlmICh3YWl0VW50aWxEb25lKQotICAgICAgICBwdGhyZWFkX2pvaW4odGhyZWFk LCBOVUxMKTsKLSNlbmRpZgorICAgICAgICB3YWl0Rm9yVGhyZWFkQ29tcGxldGlvbih0aHJlYWRJ RCwgMCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 83363 2011-02-22 12:30:11 -0800 2011-02-22 12:42:46 -0800 Patch bug-54833-20110222213008.patch text/plain 1660 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogNzkzNDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwODM2NTZmNTZmMDUyMjA4 ZTFiZTRhMDIxOTkzYTAyNWUwNGMxNjExLi45M2NlYmIxNzljY2FjYTM0ODQ4MjhjYjMzN2UxODk5 N2U4NTQ5M2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjIgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHB0aHJlYWQgZGVwZW5kZW5jeSBvZiBH Q0NvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0ODMzCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE9uQWx0ZXJuYXRlVGhy ZWFkRm9yRGVidWdnaW5nKToKKwogMjAxMS0wMi0yMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAKaW5kZXggZmUwZTM2 ZmI5MDM2ZTBmOTNmMjA3MTFhYzExN2FiNGEyZDE4ZmZiOC4uYTUxMGM5NGQwMjQ0MWU2MjQzMGFm Yjc1YTZkYzg1MzlkYjYwNzg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvR0NDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0Nv bnRyb2xsZXIuY3BwCkBAIC0zMiwxMCArMzIsNiBAQAogI2luY2x1ZGUgPHJ1bnRpbWUvSGVhcC5o PgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAotI2lmIFVTRShQVEhSRUFEUykKLSNp bmNsdWRlIDxwdGhyZWFkLmg+Ci0jZW5kaWYKLQogdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewpAQCAtNzgsMTMgKzc0LDEyIEBAIHZvaWQgR0NDb250cm9sbGVyOjpn YXJiYWdlQ29sbGVjdE5vdygpCiAKIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE9u QWx0ZXJuYXRlVGhyZWFkRm9yRGVidWdnaW5nKGJvb2wgd2FpdFVudGlsRG9uZSkKIHsKLSNpZiBV U0UoUFRIUkVBRFMpCi0gICAgcHRocmVhZF90IHRocmVhZDsKLSAgICBwdGhyZWFkX2NyZWF0ZSgm dGhyZWFkLCBOVUxMLCBjb2xsZWN0LCBOVUxMKTsKKyAgICBUaHJlYWRJZGVudGlmaWVyIHRocmVh ZElEID0gY3JlYXRlVGhyZWFkKGNvbGxlY3QsIDAsICJXZWJDb3JlOiBHQ0NvbnRyb2xsZXIiKTsK IAogICAgIGlmICh3YWl0VW50aWxEb25lKQotICAgICAgICBwdGhyZWFkX2pvaW4odGhyZWFkLCBO VUxMKTsKLSNlbmRpZgorICAgICAgICB3YWl0Rm9yVGhyZWFkQ29tcGxldGlvbih0aHJlYWRJRCwg MCk7CisKKyAgICBkZXRhY2hUaHJlYWQodGhyZWFkSUQpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCg== 83366 2011-02-22 12:42:52 -0800 2011-04-17 16:08:36 -0700 Patch bug-54833-20110222214249.patch text/plain 1710 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogNzkzNDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwODM2NTZmNTZmMDUyMjA4 ZTFiZTRhMDIxOTkzYTAyNWUwNGMxNjExLi45M2NlYmIxNzljY2FjYTM0ODQ4MjhjYjMzN2UxODk5 N2U4NTQ5M2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjIgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHB0aHJlYWQgZGVwZW5kZW5jeSBvZiBH Q0NvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0ODMzCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE9uQWx0ZXJuYXRlVGhy ZWFkRm9yRGVidWdnaW5nKToKKwogMjAxMS0wMi0yMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAKaW5kZXggZmUwZTM2 ZmI5MDM2ZTBmOTNmMjA3MTFhYzExN2FiNGEyZDE4ZmZiOC4uZDdjMmEwMjllMjA0YWUyN2U3NGRm YzRlOWY4YzJiZDI4Mjg4NDhkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvR0NDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0Nv bnRyb2xsZXIuY3BwCkBAIC0zMiwxMCArMzIsNiBAQAogI2luY2x1ZGUgPHJ1bnRpbWUvSGVhcC5o PgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAotI2lmIFVTRShQVEhSRUFEUykKLSNp bmNsdWRlIDxwdGhyZWFkLmg+Ci0jZW5kaWYKLQogdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewpAQCAtNzgsMTMgKzc0LDE0IEBAIHZvaWQgR0NDb250cm9sbGVyOjpn YXJiYWdlQ29sbGVjdE5vdygpCiAKIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE9u QWx0ZXJuYXRlVGhyZWFkRm9yRGVidWdnaW5nKGJvb2wgd2FpdFVudGlsRG9uZSkKIHsKLSNpZiBV U0UoUFRIUkVBRFMpCi0gICAgcHRocmVhZF90IHRocmVhZDsKLSAgICBwdGhyZWFkX2NyZWF0ZSgm dGhyZWFkLCBOVUxMLCBjb2xsZWN0LCBOVUxMKTsKKyAgICBUaHJlYWRJZGVudGlmaWVyIHRocmVh ZElEID0gY3JlYXRlVGhyZWFkKGNvbGxlY3QsIDAsICJXZWJDb3JlOiBHQ0NvbnRyb2xsZXIiKTsK KworICAgIGlmICh3YWl0VW50aWxEb25lKSB7CisgICAgICAgIHdhaXRGb3JUaHJlYWRDb21wbGV0 aW9uKHRocmVhZElELCAwKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KIAotICAgIGlmICh3YWl0 VW50aWxEb25lKQotICAgICAgICBwdGhyZWFkX2pvaW4odGhyZWFkLCBOVUxMKTsKLSNlbmRpZgor ICAgIGRldGFjaFRocmVhZCh0aHJlYWRJRCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK