54588 2011-02-16 14:18:22 -0800 [chromium] Roll Chromium DEPS to 75190 2011-02-17 09:36:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 sjl webkit-unassigned ajwong brettw commit-queue dglazkov fishd jamesr sergeyu webkit.review.bot oldest_to_newest 352342 0 sjl 2011-02-16 14:18:22 -0800 Chromium DEPS needs to roll forward. 352348 1 82695 sjl 2011-02-16 14:22:01 -0800 Created attachment 82695 Patch 352352 2 82695 jamesr 2011-02-16 14:25:22 -0800 Comment on attachment 82695 Patch R=me - let's let the EWs bots have a swing at this before cq+'ing just to be safe. 352363 3 webkit.review.bot 2011-02-16 14:35:23 -0800 Attachment 82695 did not build on chromium: Build output: http://queues.webkit.org/results/7919484 352364 4 jamesr 2011-02-16 14:38:47 -0800 Welp. Looks like upstream has added some more dependencies that didn't used to be there. 352373 5 82702 sjl 2011-02-16 14:47:13 -0800 Created attachment 82702 Patch 352396 6 webkit.review.bot 2011-02-16 15:17:50 -0800 Attachment 82702 did not build on chromium: Build output: http://queues.webkit.org/results/7927356 352434 7 82718 sjl 2011-02-16 16:15:06 -0800 Created attachment 82718 Patch 352435 8 sjl 2011-02-16 16:15:46 -0800 Includes new libjingle dependency. 352440 9 jamesr 2011-02-16 16:22:30 -0800 This makes me sad :( Why does DumpRenderTree need libjingle? What added this dependency? 352477 10 sjl 2011-02-16 17:10:36 -0800 +Albert No idea why DumpRenderTree is now dependent on libjingle. Albert - The only thing that depends on libjingle afaik is remoting. Any idea what would cause DumpRenderTree to now rely on it (changed sometime between now (Weds 5pm PST) and 30 hours ago (Tues, 11am PST). 352489 11 ajwong 2011-02-16 17:24:40 -0800 (In reply to comment #10) > +Albert > > No idea why DumpRenderTree is now dependent on libjingle. > > Albert - The only thing that depends on libjingle afaik is remoting. Any idea what would cause DumpRenderTree to now rely on it (changed sometime between now (Weds 5pm PST) and 30 hours ago (Tues, 11am PST). +Sergey Actually, there's a few places that depend on libjingle (eg., sync). Also, we're starting to use it in PPAPI (albeit to support remoting and similar use cases, but technically its a separate feature). The CL that added the dependency is this: http://codereview.chromium.org/6478018 I think the larger question is if DRT needs to depend on PPAPI...it's just testing the webkit renderer right? Do we actually need pepper plugins for that? 352490 12 jamesr 2011-02-16 17:29:57 -0800 (In reply to comment #11) > (In reply to comment #10) > > +Albert > > > > No idea why DumpRenderTree is now dependent on libjingle. > > > > Albert - The only thing that depends on libjingle afaik is remoting. Any idea what would cause DumpRenderTree to now rely on it (changed sometime between now (Weds 5pm PST) and 30 hours ago (Tues, 11am PST). > > +Sergey > > Actually, there's a few places that depend on libjingle (eg., sync). > > Also, we're starting to use it in PPAPI (albeit to support remoting and similar use cases, but technically its a separate feature). > > The CL that added the dependency is this: > http://codereview.chromium.org/6478018 > > I think the larger question is if DRT needs to depend on PPAPI...it's just testing the webkit renderer right? Do we actually need pepper plugins for that? Indeed. I think eventually we might want to run layout tests that test pepper plugins (we currently have layout tests for NPAPI plugins), but we don't currently have any such layout tests. It sucks that we keep having to add more and more (large) dependencies to this checkout. It increases the complexity of rolling, build+cycle times, and makes it harder to understand what's going on with the code. 352497 13 sergeyu 2011-02-16 17:44:38 -0800 (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > +Albert > > > > > > No idea why DumpRenderTree is now dependent on libjingle. > > > > > > Albert - The only thing that depends on libjingle afaik is remoting. Any idea what would cause DumpRenderTree to now rely on it (changed sometime between now (Weds 5pm PST) and 30 hours ago (Tues, 11am PST). > > > > +Sergey > > > > Actually, there's a few places that depend on libjingle (eg., sync). > > > > Also, we're starting to use it in PPAPI (albeit to support remoting and similar use cases, but technically its a separate feature). > > > > The CL that added the dependency is this: > > http://codereview.chromium.org/6478018 > > > > I think the larger question is if DRT needs to depend on PPAPI...it's just testing the webkit renderer right? Do we actually need pepper plugins for that? > > Indeed. I think eventually we might want to run layout tests that test pepper plugins (we currently have layout tests for NPAPI plugins), but we don't currently have any such layout tests. > > It sucks that we keep having to add more and more (large) dependencies to this checkout. It increases the complexity of rolling, build+cycle times, and makes it harder to understand what's going on with the code. In future I plan to add an abstract interface for P2P, so it will be possible to mock it for layout tests, but I'm not sure if it worth it (do we need to test the full network stack in the layout tests?). 352608 14 fishd 2011-02-16 21:48:19 -0800 DRT should not need to depend on PPAPI. This dependency is just an artifact of the PPAPI implementation living in src/webkit/plugins/ppapi/ (within the chromium tree), and DRT depends on src/webkit. We should ideally break this dependency since it serves no value. 352788 15 sjl 2011-02-17 06:03:45 -0800 Could we break the dependency later? Would like to roll DEPS... 352946 16 82718 fishd 2011-02-17 08:55:37 -0800 Comment on attachment 82718 Patch Yes, of course. Can you please make sure that happens? 352968 17 commit-queue 2011-02-17 09:25:08 -0800 The commit-queue encountered the following flaky tests while processing attachment 82718: http/tests/security/cross-frame-access-port-explicit-domain.html bug 54668 (author: sam@webkit.org) The commit-queue is continuing to process your patch. 352969 18 82718 commit-queue 2011-02-17 09:26:40 -0800 Comment on attachment 82718 Patch Clearing flags on attachment: 82718 Committed r78838: <http://trac.webkit.org/changeset/78838> 352970 19 commit-queue 2011-02-17 09:26:48 -0800 All reviewed patches have been landed. Closing bug. 352974 20 sjl 2011-02-17 09:36:27 -0800 (In reply to comment #16) > (From update of attachment 82718 [details]) > Yes, of course. Can you please make sure that happens? http://code.google.com/p/chromium/issues/detail?id=73304 82695 2011-02-16 14:22:01 -0800 2011-02-16 14:47:09 -0800 Patch bug-54588-20110216142200.patch text/plain 973 sjl ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMzc5MmY3YWMzZTUwMTBjNTJiZmQ3ZGE4MjIz ZDY5YjkxMzQ4ZGRjYi4uZDZiZTU3NDI1NDQ0MzQ0MTBkNmFmNWM5MzMwYTNiMmQ3N2IyMTc0MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMi0xNiAg U3RldmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJvbGwgY2hyb21pdW0gZGVwcyB0byBMS0dSICg3NTEz NSkKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1 ODgKKworICAgICAgICAqIERFUFM6CisKIDIwMTEtMDItMTYgIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHI3ODY3OC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCA5NGYyYjE2NjhkOWJkMTUwMGE4NWM1Mjg2OGRk OWUwMWU2MWNhMzFjLi40MmJmZGJmMGIwMjExNWJiOTE0MzJhZDBhY2Q3ZDg4MjhiYzg5NDVmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1 bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJv bWl1bV9yZXYnOiAnNzQ5ODYnCisgICdjaHJvbWl1bV9yZXYnOiAnNzUxMzUnCiB9CiAKIGRlcHMg PSB7Cg== 82702 2011-02-16 14:47:13 -0800 2011-02-16 16:15:03 -0800 Patch bug-54588-20110216144712.patch text/plain 967 sjl ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMzc5MmY3YWMzZTUwMTBjNTJiZmQ3ZGE4MjIz ZDY5YjkxMzQ4ZGRjYi4uZGRiNDIxY2RjZDI1ZTEwODI1N2RiNWE3NDljMTgxOGEzN2FiYjdiZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMi0xNiAg U3RldmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJvbGwgY2hyb21pdW0gZGVwcyB0byA3NTExOS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1ODgKKwor ICAgICAgICAqIERFUFM6CisKIDIwMTEtMDItMTYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmll dy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3ODY3 OC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vREVQUwppbmRleCA5NGYyYjE2NjhkOWJkMTUwMGE4NWM1Mjg2OGRkOWUwMWU2 MWNhMzFjLi5kMWNmYTFjOWYzNjgwMjk4YTc0OWJkNDQ1MTY0OTQ5OWRhMjllYjViIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4n OiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9y ZXYnOiAnNzQ5ODYnCisgICdjaHJvbWl1bV9yZXYnOiAnNzUxMTknCiB9CiAKIGRlcHMgPSB7Cg== 82718 2011-02-16 16:15:06 -0800 2011-02-17 09:26:40 -0800 Patch bug-54588-20110216161505.patch text/plain 1413 sjl ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMzc5MmY3YWMzZTUwMTBjNTJiZmQ3ZGE4MjIz ZDY5YjkxMzQ4ZGRjYi4uMjY5MjA2MjVhZWY4ZjY1YThmMzZhYzllOTUwMTQyMDUxOTY1NDU3MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wMi0xNiAg U3RldmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJvbGwgY2hyb21pdW0gZGVwcyB0byA3NTE5MC4gSW5j bHVkZXMgbmV3IGRlcGVuZGVuY3kKKyAgICAgICAgb24gbGliamluZ2xlLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDU4OAorCisgICAgICAgICog REVQUzoKKwogMjAxMS0wMi0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjc4Njc4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9ERVBTCmluZGV4IDk0ZjJiMTY2OGQ5YmQxNTAwYTg1YzUyODY4ZGQ5ZTAxZTYxY2EzMWMuLmJi NTUyNGRiYTkzNDM0NmEwMTc0Yjk2ZTEyNTg1MzRiYzcyMjJmY2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vREVQUworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMK QEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2Nocm9taXVtX3N2bic6ICdodHRwOi8v c3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVtX3Jldic6ICc3NDk4 NicKKyAgJ2Nocm9taXVtX3Jldic6ICc3NTE5MCcKIH0KIAogZGVwcyA9IHsKQEAgLTEwMyw2ICsx MDMsOCBAQCBkZXBzID0gewogICAgIEZyb20oJ2Nocm9taXVtX2RlcHMnLCAnc3JjL3RoaXJkX3Bh cnR5L2xpYnZweCcpLAogICAndGhpcmRfcGFydHkvZmZtcGVnJzogIyBuZWVkZWQgYnkgd2Via2l0 L21lZGlhCiAgICAgRnJvbSgnY2hyb21pdW1fZGVwcycsICdzcmMvdGhpcmRfcGFydHkvZmZtcGVn JyksCisgICd0aGlyZF9wYXJ0eS9saWJqaW5nbGUvc291cmNlJzoKKyAgICBGcm9tKCdjaHJvbWl1 bV9kZXBzJywgJ3NyYy90aGlyZF9wYXJ0eS9saWJqaW5nbGUvc291cmNlJyksCiAgICd0aGlyZF9w YXJ0eS9saWJ3ZWJwJzoKICAgICBWYXIoJ2Nocm9taXVtX3N2bicpKycvdGhpcmRfcGFydHkvbGli d2VicEAnK1ZhcignY2hyb21pdW1fcmV2JyksCiAgICd0b29scy9ncml0JzoK