54554 2011-02-16 07:15:40 -0800 REGRESSION(r78678): Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit). 2011-02-21 02:09:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 54489 1 webkit.review.bot webkit.review.bot bbudge levin mnaganov oldest_to_newest 352048 0 webkit.review.bot 2011-02-16 07:15:40 -0800 http://trac.webkit.org/changeset/78678 broke the build: Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 352049 1 82629 webkit.review.bot 2011-02-16 07:16:07 -0800 Created attachment 82629 ROLLOUT of r78678 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 352050 2 mnaganov 2011-02-16 07:21:01 -0800 Manually committed http://trac.webkit.org/changeset/78705 353487 3 mnaganov 2011-02-18 02:02:03 -0800 Ah, I'm sorry for not providing you this info at the first hand. Two tests were failing (crashing): - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change. 353549 4 82629 levin 2011-02-18 05:40:24 -0800 Comment on attachment 82629 ROLLOUT of r78678 Cleared cq? as this was already landed. 353818 5 bbudge 2011-02-18 14:04:58 -0800 Mikhail, I am trying to set breakpoints on the changed code to see why this simple change causes a crash. They never get hit, so I suspect I'm not attached to the right process. Are there any tips you can give me for how to attach (in Visual Studio right now) after the process is created but before too much code gets run? (In reply to comment #3) > Ah, I'm sorry for not providing you this info at the first hand. > Two tests were failing (crashing): > - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc > - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc > > And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change. 354473 6 mnaganov 2011-02-21 02:09:02 -0800 Hi Bill, Take a look at this page: http://dev.chromium.org/developers/how-tos/debugging I used '--renderer-startup-dialog --no-sandbox' flags to get renderer process to stop and show me its PID before it does anything important. You might need to modify the code that starts Chromium from the test. 82629 2011-02-16 07:16:07 -0800 2011-02-18 05:40:24 -0800 ROLLOUT of r78678 bug-54554-20110216151534.patch text/plain 4860 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogNzg3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDMxZjI4NDY4ZWM2MWIwZGI4MDgyY2ZmYzEwYWI1ZGY1YWViZWMzZS4uMzc5MmY3YWMzZTUwMTBj NTJiZmQ3ZGE4MjIzZDY5YjkxMzQ4ZGRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyNCBAQAorMjAxMS0wMi0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjc4Njc4Lgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC83ODY3OAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1NTQKKworICAgICAgICBC cmVha3MgTmFDbCB0ZXN0cyBpbiBDaHJvbWl1bSAoUmVxdWVzdGVkIGJ5IG1uYWdhbm92IG9uCisg ICAgICAgICN3ZWJraXQpLgorCisgICAgICAgICogc3JjL1dlYlVSTFJlcXVlc3QuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJVUkxSZXF1ZXN0UHJpdmF0ZUltcGw6OldlYlVSTFJlcXVlc3RQcml2 YXRlSW1wbCk6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTFJlcXVlc3Q6OmRvd25sb2FkVG9GaWxl KToKKyAgICAgICAgKFdlYktpdDo6V2ViVVJMUmVxdWVzdDo6c2V0RG93bmxvYWRUb0ZpbGUpOgor ICAgICAgICAqIHNyYy9XZWJVUkxSZXF1ZXN0UHJpdmF0ZS5oOgorICAgICAgICAoV2ViS2l0OjpX ZWJVUkxSZXF1ZXN0UHJpdmF0ZTo6V2ViVVJMUmVxdWVzdFByaXZhdGUpOgorICAgICAgICAqIHNy Yy9XZWJVUkxSZXNwb25zZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTFJlc3BvbnNlUHJp dmF0ZUltcGw6OldlYlVSTFJlc3BvbnNlUHJpdmF0ZUltcGwpOgorICAgICAgICAoV2ViS2l0OjpX ZWJVUkxSZXNwb25zZTo6ZG93bmxvYWRGaWxlUGF0aCk6CisgICAgICAgIChXZWJLaXQ6OldlYlVS TFJlc3BvbnNlOjpzZXREb3dubG9hZEZpbGVQYXRoKToKKyAgICAgICAgKiBzcmMvV2ViVVJMUmVz cG9uc2VQcml2YXRlLmg6CisKIDIwMTEtMDItMTUgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXF1ZXN0LmNwcAppbmRleCA0NzEzOWIzNjUzNzQzYjhi OWQ1NWYwOTI1YTAxMzRiOGZiZjY0ZGI3Li43YTc3Y2EzYWE5Yjg5MGJmNDg0NGQxMDAzYzVkMmVl MjE5YjRjZDNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxS ZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXF1ZXN0 LmNwcApAQCAtNTYsNiArNTYsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBtX3Jlc291cmNl UmVxdWVzdCA9ICZtX3Jlc291cmNlUmVxdWVzdEFsbG9jYXRpb247CiAgICAgICAgIG1fYWxsb3dT dG9yZWRDcmVkZW50aWFscyA9IHAtPm1fYWxsb3dTdG9yZWRDcmVkZW50aWFsczsKKyAgICAgICAg bV9kb3dubG9hZFRvRmlsZSA9IHAtPm1fZG93bmxvYWRUb0ZpbGU7CiAgICAgfQogCiAgICAgdmly dHVhbCB2b2lkIGRpc3Bvc2UoKSB7IGRlbGV0ZSB0aGlzOyB9CkBAIC0yNjgsMTIgKzI2OSwxMiBA QCB2b2lkIFdlYlVSTFJlcXVlc3Q6OnNldEFwcENhY2hlSG9zdElEKGludCBhcHBDYWNoZUhvc3RJ RCkKIAogYm9vbCBXZWJVUkxSZXF1ZXN0Ojpkb3dubG9hZFRvRmlsZSgpIGNvbnN0CiB7Ci0gICAg cmV0dXJuIG1fcHJpdmF0ZS0+bV9yZXNvdXJjZVJlcXVlc3QtPmRvd25sb2FkVG9GaWxlKCk7Cisg ICAgcmV0dXJuIG1fcHJpdmF0ZS0+bV9kb3dubG9hZFRvRmlsZTsKIH0KIAogdm9pZCBXZWJVUkxS ZXF1ZXN0OjpzZXREb3dubG9hZFRvRmlsZShib29sIGRvd25sb2FkVG9GaWxlKQogewotICAgIG1f cHJpdmF0ZS0+bV9yZXNvdXJjZVJlcXVlc3QtPnNldERvd25sb2FkVG9GaWxlKGRvd25sb2FkVG9G aWxlKTsKKyAgICBtX3ByaXZhdGUtPm1fZG93bmxvYWRUb0ZpbGUgPSBkb3dubG9hZFRvRmlsZTsK IH0KIAogUmVzb3VyY2VSZXF1ZXN0JiBXZWJVUkxSZXF1ZXN0Ojp0b011dGFibGVSZXNvdXJjZVJl cXVlc3QoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVx dWVzdFByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlcXVlc3RQ cml2YXRlLmgKaW5kZXggMWMxYjY5NjA4ZWM4YThjMTE3NmRlMjBlOTJiYzA4NDFmYTI0OWE0Yy4u NzlmNjQ1MWRjZWE5M2ZmNjc2MmFjNTM2MWQ2YjhkNWM2N2NmYWI5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVxdWVzdFByaXZhdGUuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXF1ZXN0UHJpdmF0ZS5oCkBAIC0zOSwxMyAr MzksMTcgQEAgY2xhc3MgV2ViVVJMUmVxdWVzdFByaXZhdGUgewogcHVibGljOgogICAgIFdlYlVS TFJlcXVlc3RQcml2YXRlKCkKICAgICAgICAgOiBtX3Jlc291cmNlUmVxdWVzdCgwKQotICAgICAg ICAsIG1fYWxsb3dTdG9yZWRDcmVkZW50aWFscyh0cnVlKSB7IH0KKyAgICAgICAgLCBtX2FsbG93 U3RvcmVkQ3JlZGVudGlhbHModHJ1ZSkKKyAgICAgICAgLCBtX2Rvd25sb2FkVG9GaWxlKGZhbHNl KSB7IH0KIAogICAgIC8vIENhbGxlZCBieSBXZWJVUkxSZXF1ZXN0IHdoZW4gaXQgbm8gbG9uZ2Vy IG5lZWRzIHRoaXMgb2JqZWN0LgogICAgIHZpcnR1YWwgdm9pZCBkaXNwb3NlKCkgPSAwOwogCiAg ICAgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0KiBtX3Jlc291cmNlUmVxdWVzdDsKICAgICBib29s IG1fYWxsb3dTdG9yZWRDcmVkZW50aWFsczsKKworICAgIC8vIEZJWE1FOiBNb3ZlIHRoaXMgdG8g UmVzb3VyY2VSZXF1ZXN0IG9uY2Ugd2UgaGF2ZSBhbiBpbnRlcm5hbCBjb25zdW1lci4KKyAgICBi b29sIG1fZG93bmxvYWRUb0ZpbGU7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNlLmNwcAppbmRleCAzMzRmNjQ0 MjA4ZGY2MGRhZTRiYTFlNzA4Mjg2NzkwODNhY2IzYmFmLi43OTE3Mjk4MWVkOWIzMzNhYThlM2Fk MDk2ODVlNDlhNTAwM2QyNDJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJVUkxSZXNwb25zZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi VVJMUmVzcG9uc2UuY3BwCkBAIC02MCw2ICs2MCw3IEBAIHB1YmxpYzoKICAgICAgICAgOiBtX3Jl c291cmNlUmVzcG9uc2VBbGxvY2F0aW9uKCpwLT5tX3Jlc291cmNlUmVzcG9uc2UpCiAgICAgewog ICAgICAgICBtX3Jlc291cmNlUmVzcG9uc2UgPSAmbV9yZXNvdXJjZVJlc3BvbnNlQWxsb2NhdGlv bjsKKyAgICAgICAgbV9kb3dubG9hZEZpbGVQYXRoID0gcC0+bV9kb3dubG9hZEZpbGVQYXRoOwog ICAgIH0KIAogICAgIHZpcnR1YWwgdm9pZCBkaXNwb3NlKCkgeyBkZWxldGUgdGhpczsgfQpAQCAt Mzc1LDEyICszNzYsMTIgQEAgdm9pZCBXZWJVUkxSZXNwb25zZTo6c2V0SXNNdWx0aXBhcnRQYXls b2FkKGJvb2wgdmFsdWUpCiAKIFdlYlN0cmluZyBXZWJVUkxSZXNwb25zZTo6ZG93bmxvYWRGaWxl UGF0aCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fcHJpdmF0ZS0+bV9yZXNvdXJjZVJlc3BvbnNl LT5kb3dubG9hZEZpbGVQYXRoKCk7CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+bV9kb3dubG9hZEZp bGVQYXRoOwogfQogCiB2b2lkIFdlYlVSTFJlc3BvbnNlOjpzZXREb3dubG9hZEZpbGVQYXRoKGNv bnN0IFdlYlN0cmluZyYgZG93bmxvYWRGaWxlUGF0aCkKIHsKLSAgICBtX3ByaXZhdGUtPm1fcmVz b3VyY2VSZXNwb25zZS0+c2V0RG93bmxvYWRGaWxlUGF0aChkb3dubG9hZEZpbGVQYXRoLmRhdGEo KSk7CisgICAgbV9wcml2YXRlLT5tX2Rvd25sb2FkRmlsZVBhdGggPSBkb3dubG9hZEZpbGVQYXRo OwogfQogCiBXZWJTdHJpbmcgV2ViVVJMUmVzcG9uc2U6OnNvY2tldEFkZHJlc3MoKSBjb25zdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVzcG9uc2VQcml2 YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXNwb25zZVByaXZhdGUu aAppbmRleCA3ZDIyZDdhODEzZjFkYWYxYWQ0YmI4NGE1OWJjMTZmZTE5NTk1MTIyLi5kYzVjZTIy NDUwMzk5OTEwZmEwMGViNDU2NGM1NjVmNTg5OWNjYTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXNwb25zZVByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXNwb25zZVByaXZhdGUuaApAQCAtNDUsNiArNDUsOSBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRpc3Bvc2UoKSA9IDA7CiAKICAgICBXZWJDb3Jl OjpSZXNvdXJjZVJlc3BvbnNlKiBtX3Jlc291cmNlUmVzcG9uc2U7CisKKyAgICAvLyBGSVhNRTog TW92ZSB0aGlzIHRvIFJlc291cmNlUmVzcG9uc2Ugb25jZSB3ZSBoYXZlIGFuIGludGVybmFsIGNv bnN1bWVyLgorICAgIFdlYlN0cmluZyBtX2Rvd25sb2FkRmlsZVBhdGg7CiB9OwogCiB9IC8vIG5h bWVzcGFjZSBXZWJLaXQK