54545 2011-02-16 03:50:59 -0800 DragController should use Color::serialized() when passing colors to CSSStyleDeclaration 2011-02-19 19:10:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 54539 1 kling kling oliver oldest_to_newest 351978 0 kling 2011-02-16 03:50:59 -0800 DragController::concludeEditDrag() currently passes the string returned by Color::nameForRenderTreeAsText() to CSSStyleDeclaration::setProperty(). If the color has an alpha value, the string will be in #RRGGBBAA format which is not valid CSS. 351981 1 82612 kling 2011-02-16 03:53:44 -0800 Created attachment 82612 Proposed patch 354232 2 82612 kling 2011-02-19 19:10:43 -0800 Comment on attachment 82612 Proposed patch Clearing flags on attachment: 82612 Committed r79145: <http://trac.webkit.org/changeset/79145> 354233 3 kling 2011-02-19 19:10:49 -0800 All reviewed patches have been landed. Closing bug. 82612 2011-02-16 03:53:44 -0800 2011-02-19 19:10:43 -0800 Proposed patch bug-54545.diff text/plain 1484 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMGU0ZTcyLi40NzY5ZWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMTYgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyYWdDb250cm9sbGVy IHNob3VsZCB1c2UgQ29sb3I6OnNlcmlhbGl6ZWQoKSB3aGVuIHBhc3NpbmcgY29sb3JzIHRvIENT U1N0eWxlRGVjbGFyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0NTQ1CisKKyAgICAgICAgKiBwYWdlL0RyYWdDb250cm9sbGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVyOjpjb25jbHVkZUVkaXREcmFnKToKKwogMjAx MS0wMi0xNSAgSm9obiBTdWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRHJhZ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxl ci5jcHAKaW5kZXggYThkNjhkOS4uYzdlNmNjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9EcmFnQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29u dHJvbGxlci5jcHAKQEAgLTQwMyw4ICs0MDMsNyBAQCBib29sIERyYWdDb250cm9sbGVyOjpjb25j bHVkZUVkaXREcmFnKERyYWdEYXRhKiBkcmFnRGF0YSkKICAgICAgICAgUmVmUHRyPFJhbmdlPiBp bm5lclJhbmdlID0gaW5uZXJGcmFtZS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCk7 CiAgICAgICAgIFJlZlB0cjxDU1NTdHlsZURlY2xhcmF0aW9uPiBzdHlsZSA9IG1fZG9jdW1lbnRV bmRlck1vdXNlLT5jcmVhdGVDU1NTdHlsZURlY2xhcmF0aW9uKCk7CiAgICAgICAgIEV4Y2VwdGlv bkNvZGUgZWM7Ci0gICAgICAgIC8vIEZJWE1FOiBVc2UgQ29sb3I6OnNlcmlhbGl6ZWQoKSBpbnN0 ZWFkLgotICAgICAgICBzdHlsZS0+c2V0UHJvcGVydHkoImNvbG9yIiwgY29sb3IubmFtZUZvclJl bmRlclRyZWVBc1RleHQoKSwgZWMpOworICAgICAgICBzdHlsZS0+c2V0UHJvcGVydHkoImNvbG9y IiwgY29sb3Iuc2VyaWFsaXplZCgpLCBlYyk7CiAgICAgICAgIGlmICghaW5uZXJGcmFtZS0+ZWRp dG9yKCktPnNob3VsZEFwcGx5U3R5bGUoc3R5bGUuZ2V0KCksIGlubmVyUmFuZ2UuZ2V0KCkpKQog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBtX2NsaWVudC0+d2lsbFBlcmZvcm1E cmFnRGVzdGluYXRpb25BY3Rpb24oRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uRWRpdCwgZHJhZ0RhdGEp Owo=