54462 2011-02-15 08:06:41 -0800 XSLT with output method HTML and images crashes in debug mode 2011-02-15 17:04:21 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik abarth abarth eric kbr pfeldman vsevik oldest_to_newest 351269 0 vsevik 2011-02-15 08:06:41 -0800 If 1) XML file links to XSLT 2) XSLT has output method set to html 3) Resulting HTML has images then Webkit crashes on assertion in debug mode (DocumentParser:56). ASSERTION FAILED: m_state == ParsingState .../webkit/Source/WebCore/dom/DocumentParser.cpp(56) : virtual void WebCore::DocumentParser::prepareToStopParsing() -> WebCore::DocumentParser::prepareToStopParsing() -> WebCore::HTMLDocumentParser::prepareToStopParsing() -> WebCore::HTMLDocumentParser::attemptToEnd() -> WebCore::HTMLDocumentParser::finish() -> WebCore::Document::finishParsing() -> WebCore::DocumentWriter::endIfNotLoadingMainResource() -> WebCore::Document::explicitClose() -> WebCore::Document::setContent(WTF::String const&) -> WebCore::XSLTProcessor::createDocumentFromSource(WTF::String const&, WTF::String const&, WTF::String const&, WebCore::Node*, WebCore::Frame*) -> WebCore::Document::applyXSLTransform(WebCore::ProcessingInstruction*) -> WebCore::Document::recalcStyleSelector() -> WebCore::Document::styleSelectorChanged(WebCore::StyleSelectorUpdateFlag) -> WebCore::Document::removePendingSheet() -> WebCore::ProcessingInstruction::sheetLoaded() -> WebCore::XSLStyleSheet::checkLoaded() -> WebCore::ProcessingInstruction::parseStyleSheet(WTF::String const&) -> WebCore::ProcessingInstruction::setXSLStyleSheet(WTF::String const&, WebCore::KURL const&, WTF::String const&) -> WebCore::CachedXSLStyleSheet::checkNotify() -> WebCore::CachedXSLStyleSheet::data(WTF::PassRefPtr<WebCore::SharedBuffer>, bool) -> WebCore::CachedResourceRequest::didFinishLoading(WebCore::SubresourceLoader*) -> WebCore::SubresourceLoader::didFinishLoading(double) -> WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) -> -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] -> _NSURLConnectionDidFinishLoading -> URLConnectionClient::_clientDidFinishLoading(URLConnectionClient::ClientConnectionEventQueue*) -> URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) -> URLConnectionClient::processEvents() -> MultiplexerSource::perform() -> __CFRunLoopDoSources0 -> __CFRunLoopRun -> CFRunLoopRunSpecific 351271 1 82458 vsevik 2011-02-15 08:07:19 -0800 Created attachment 82458 Failing XML example 351273 2 82459 vsevik 2011-02-15 08:07:38 -0800 Created attachment 82459 Failing XSL example 351274 3 vsevik 2011-02-15 08:14:44 -0800 see https://bugs.webkit.org/show_bug.cgi?id=50253 351278 4 pfeldman 2011-02-15 08:18:23 -0800 *** This bug has been marked as a duplicate of bug 50253 *** 351592 5 abarth 2011-02-15 14:41:39 -0800 This is not a duplicate of Bug 50253. Testing a patch now. 351703 6 abarth 2011-02-15 16:15:42 -0800 This is a regression caused by http://trac.webkit.org/changeset/75577 351710 7 82548 abarth 2011-02-15 16:25:13 -0800 Created attachment 82548 Patch 351713 8 82548 darin 2011-02-15 16:26:38 -0800 Comment on attachment 82548 Patch Is this single test case enough coverage? 351715 9 abarth 2011-02-15 16:30:55 -0800 > Is this single test case enough coverage? We more or less would like test coverage for each code path touched in http://trac.webkit.org/changeset/75577. 1) DOMParser::parseFromString <-- We have tests for this one. 2) WebCore/xml/XMLHttpRequest.cpp <-- We have lots of test for this one. :) 3) WebCore/xml/XSLTProcessor.cpp <-- Added in this patch. 4) CachedFont.cpp <-- This is for SVG fonts. I don't know whether this is covered. 351720 10 abarth 2011-02-15 16:36:45 -0800 Committed r78644: <http://trac.webkit.org/changeset/78644> 351723 11 82548 eric 2011-02-15 16:38:07 -0800 Comment on attachment 82548 Patch LGTM too thanks. 351746 12 abarth 2011-02-15 17:04:21 -0800 *** Bug 52929 has been marked as a duplicate of this bug. *** 82458 2011-02-15 08:07:19 -0800 2011-02-15 08:07:19 -0800 Failing XML example a.xml text/xml 96 vsevik PD94bWwgdmVyc2lvbj0nMS4wJyBlbmNvZGluZz0ndXRmLTgnPz4KPD94bWwtc3R5bGVzaGVldCBo cmVmPSJhLnhzbCIgdHlwZT0idGV4dC94c2wiPz4KCjxyb290Lz4K 82459 2011-02-15 08:07:38 -0800 2011-02-15 08:07:38 -0800 Failing XSL example a.xsl application/xslt+xml 242 vsevik PD94bWwgdmVyc2lvbj0nMS4wJyBlbmNvZGluZz0ndXRmLTgnPz4KPHhzbDpzdHlsZXNoZWV0IHZl cnNpb249IjEuMCIgeG1sbnM6eHNsPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L1hTTC9UcmFuc2Zv cm0iPgogIDx4c2w6b3V0cHV0IG1ldGhvZD0iaHRtbCIvPgogIDx4c2w6dGVtcGxhdGUgbWF0Y2g9 Ii8vKiI+CiAgICA8aW1nIHNyYz0iYS5wbmciPjwvaW1nPgogIDwveHNsOnRlbXBsYXRlPgo8L3hz bDpzdHlsZXNoZWV0Pgo= 82548 2011-02-15 16:25:13 -0800 2011-02-15 16:38:07 -0800 Patch bug-54462-20110215162512.patch text/plain 4452 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDItMTUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBYU0xUIHdpdGggb3V0cHV0IG1ldGhvZCBIVE1MIGFuZCBpbWFnZXMg Y3Jhc2hlcyBpbiBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NDQ2MgorCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hh bmdlc2V0Lzc1NTc3IGNyZWF0ZWQgRG9jdW1lbnQ6OnNldENvbnRlbnQgYnV0CisgICAgICAgIGRp ZG4ndCBub3RpY2UgdGhhdCB0aGUgY29kZSBwYXRocyBjb21iaW5lZCBpbnRvIERvY3VtZW50Ojpz ZXRDb250ZW50CisgICAgICAgIHdlcmUgc3VidGx5IGRpZmZlcmVudC4gIEluIHBhcnRpY3VsYXIs IHNvbWUgb2YgdGhlIGNvZGUgcGF0aHMgY2FsbGVkCisgICAgICAgIHBhcnNlci0+ZmluaXNoKCkg d2hlcmVhcyBvdGhlciBkaWQgbm90LgorCisgICAgICAgIFRoZSBkaWZmZXJlbmNlIGlzIHRoYXQg YW4gZXhwbGljaXQgY2FsbCB0byBwYXJzZXItPmZpbmlzaCgpIGlzIHJlcXVpcmVkCisgICAgICAg IGluIHRoZSBjYXNlIHdoZXJlIHRoZXJlIGlzIG5vIGZyYW1lIGJlY2F1c2UgZXhwbGljaXRDbG9z ZSBkb2Vzbid0IGNhbGwKKyAgICAgICAgZW5kSWZOb3RMb2FkaW5nTWFpblJlc291cmNlIGlmIHRo ZXJlIGlzIG5vIGZyYW1lLiAgVGhpcyBwYXRjaCBtb3ZlcworICAgICAgICB0aGF0IGxvZ2ljIGlu c2lkZSBleHBsaWNpdENsb3NlLCB3aGljaCBpcyBtb3JlIG5hdHVyYWwuCisKKyAgICAgICAgVGhp cyBwYXRjaCBhbHNvIHJlbW92ZXMgcmVtb3ZlQWxsQ2hpbGRyZW4sIHdoaWNoIGhhcyBub3QgZWZm ZWN0IGluIHRoaXMKKyAgICAgICAgc2l0dWF0aW9uIGFuZCBzaG91bGQgbmV2ZXIgaGF2ZSBiZWVu IGFkZGVkIGluIHRoZSBmaXJzdCBwbGFjZS4KKworICAgICAgICBUZXN0OiBmYXN0L3BhcnNlci94 c2x0LXdpdGgtaHRtbC54bWwKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudDo6c2V0Q29udGVudCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1 bWVudDo6ZXhwbGljaXRDbG9zZSk6CisKIDIwMTEtMDItMTUgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggRUZMIGJ1aWxkIGZvcgpJbmRleDogU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCShyZXZpc2lvbiA3ODU5OSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOTIsMTIgKzEwOTIsOSBAQCBLVVJMIERvY3Vt ZW50OjpiYXNlVVJJKCkgY29uc3QKIAogdm9pZCBEb2N1bWVudDo6c2V0Q29udGVudChjb25zdCBT dHJpbmcmIGNvbnRlbnQpCiB7Ci0gICAgcmVtb3ZlQWxsQ2hpbGRyZW4oKTsKLQogICAgIG9wZW4o KTsKICAgICBtX3BhcnNlci0+YXBwZW5kKGNvbnRlbnQpOwotICAgIG1fcGFyc2VyLT5maW5pc2go KTsKLSAgICBleHBsaWNpdENsb3NlKCk7CisgICAgY2xvc2UoKTsKIH0KIAogLy8gRklYTUU6IFdl IG5lZWQgdG8gZGlzY3VzcyB0aGUgRE9NIEFQSSBoZXJlIGF0IHNvbWUgcG9pbnQuIElkZWFzOgpA QCAtMjAyMCw2ICsyMDE3LDggQEAgdm9pZCBEb2N1bWVudDo6ZXhwbGljaXRDbG9zZSgpCiAgICAg ICAgIC8vIEJlY2F1c2Ugd2UgaGF2ZSBubyBmcmFtZSwgd2UgZG9uJ3Qga25vdyBpZiBhbGwgbG9h ZGluZyBoYXMgY29tcGxldGVkLAogICAgICAgICAvLyBzbyB3ZSBqdXN0IGNhbGwgaW1wbGljaXRD bG9zZSgpIGltbWVkaWF0ZWx5LiBGSVhNRTogVGhpcyBtaWdodCBmaXJlCiAgICAgICAgIC8vIHRo ZSBsb2FkIGV2ZW50IHByZW1hdHVyZWx5IDxodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDU2OD4uCisgICAgICAgIGlmIChtX3BhcnNlcikKKyAgICAgICAgICAgIG1fcGFy c2VyLT5maW5pc2goKTsKICAgICAgICAgaW1wbGljaXRDbG9zZSgpOwogICAgICAgICByZXR1cm47 CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzg2NDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMi0xNSAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFhTTFQgd2l0aCBvdXRwdXQgbWV0aG9kIEhUTUwgYW5kIGltYWdlcyBj cmFzaGVzIGluIGRlYnVnIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU0NDYyCisKKyAgICAgICAgVGVzdCB0aGF0IHdlIGRvbid0IHRyeSB0byBw cmVwYXJlIHRvIHN0b3AgdHdpY2Ugd2hlbiBwYXNpbmcgSFRNTAorICAgICAgICBnZW5lcmF0ZWQg ZnJvbSBhbiBYU0xULgorCisgICAgICAgICogZmFzdC9wYXJzZXIvcmVzb3VyY2VzL3hzbHQtd2l0 aC1odG1sLnhzbDogQWRkZWQuCisgICAgICAgICogZmFzdC9wYXJzZXIveHNsdC13aXRoLWh0bWwt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3BhcnNlci94c2x0LXdpdGgtaHRt bC54bWw6IEFkZGVkLgorCiAyMDExLTAyLTE1ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29v Z2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBDaHJvbWl1bSB0ZXN0IGV4cGVjdGF0aW9u cyB1cGRhdGUuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci94c2x0LXdpdGgtaHRtbC1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveHNsdC13 aXRoLWh0bWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9w YXJzZXIveHNsdC13aXRoLWh0bWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx IEBACitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci94c2x0LXdpdGgtaHRtbC54 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveHNsdC13aXRoLWh0bWwu eG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveHNsdC13aXRoLWh0 bWwueG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAKKzw/eG1sIHZlcnNpb249JzEuMCcg ZW5jb2Rpbmc9J3V0Zi04Jz8+Cis8P3htbC1zdHlsZXNoZWV0IGhyZWY9InJlc291cmNlcy94c2x0 LXdpdGgtaHRtbC54c2wiIHR5cGU9InRleHQveHNsIj8+CisKKzxyb290Lz4KSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvcGFyc2VyL3Jlc291cmNlcy94c2x0LXdpdGgtaHRtbC54c2wKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvcmVzb3VyY2VzL3hzbHQtd2l0aC1odG1sLnhz bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3Jlc291cmNlcy94c2x0 LXdpdGgtaHRtbC54c2wJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKKzw/eG1sIHZlcnNp b249JzEuMCcgZW5jb2Rpbmc9J3V0Zi04Jz8+Cis8eHNsOnN0eWxlc2hlZXQgdmVyc2lvbj0iMS4w IiB4bWxuczp4c2w9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkvWFNML1RyYW5zZm9ybSI+CisgIDx4 c2w6b3V0cHV0IG1ldGhvZD0iaHRtbCIvPgorICA8eHNsOnRlbXBsYXRlIG1hdGNoPSIvLyoiPgor ICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgPC9zY3Jp cHQ+CisgICAgPGRpdj5QQVNTPC9kaXY+CisgIDwveHNsOnRlbXBsYXRlPgorPC94c2w6c3R5bGVz aGVldD4K