54439 2011-02-15 00:09:29 -0800 [EFL] New API for executing Editor Commands: InsertText, InsertImage. 2011-04-28 20:53:01 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 54624 0 k.blank webkit-unassigned abarth antognolli+webkit commit-queue eric gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 351128 0 82425 k.blank 2011-02-15 00:09:29 -0800 Created attachment 82425 patch I'd like to add new functionalities to be executed by EditorCommand - InsertText, InsertImage. I decided to do it in a different way than previous commands: "SelectWord", "SelectLine" etc. I believe that having one function for all commands is much better than tens of similar functions (what is possible as EditorCommand has a lot of commands defined). Due to this fact I was also thinking about replacing existing functions (listed below) by additional enums in Ewk_Editor_Command but I'm not sure whether removing API is a good idea, what do you think? List of existing editor commands: EAPI Eina_Bool ewk_view_select_none(Evas_Object *o); EAPI Eina_Bool ewk_view_select_all(Evas_Object *o); EAPI Eina_Bool ewk_view_select_paragraph(Evas_Object *o); EAPI Eina_Bool ewk_view_select_sentence(Evas_Object *o); EAPI Eina_Bool ewk_view_select_line(Evas_Object *o); EAPI Eina_Bool ewk_view_select_word(Evas_Object *o); 351129 1 webkit.review.bot 2011-02-15 00:12:25 -0800 Attachment 82425 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_view.h:363: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/efl/ewk/ewk_view.h:363: The parameter name "command" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 351154 2 gyuyoung.kim 2011-02-15 02:16:29 -0800 (In reply to comment #1) > Attachment 82425 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 > > Source/WebKit/efl/ewk/ewk_view.h:363: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] > Source/WebKit/efl/ewk/ewk_view.h:363: The parameter name "command" adds no information, so it should be removed. [readability/parameter_name] [5] > Total errors found: 2 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. To fix these style errors, you have to remove parameter name as below, EAPI Eina_Bool ewk_view_execute_editor_command(Evas_Object*, const Ewk_Editor_Command, const char *value); However, other APIs have parameter name in ewk_view.h. I don't know if we should remove parameter name in this patch. Lucas, how do you think about this ? 351156 3 82425 gyuyoung.kim 2011-02-15 02:22:29 -0800 Comment on attachment 82425 patch View in context: https://bugs.webkit.org/attachment.cgi?id=82425&action=review > Source/WebKit/efl/ChangeLog:6 > + Please add this bug url to here 351167 4 82433 k.blank 2011-02-15 02:50:02 -0800 Created attachment 82433 patch + url added 351170 5 webkit.review.bot 2011-02-15 02:52:31 -0800 Attachment 82433 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_view.h:363: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/efl/ewk/ewk_view.h:363: The parameter name "command" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 351183 6 k.blank 2011-02-15 03:38:31 -0800 > To fix these style errors, you have to remove parameter name as below, It's probably about the names which are used here. Looks like check-webkit-style doesn't accept names like: "o" and "command". As ewk uses "o" for "object" - I don't think it's a good idea to change it in one place. I can only change "command" but there won't be better name for it. 351889 7 gyuyoung.kim 2011-02-15 22:38:57 -0800 I add WebKit EFL reviewers to CC 353148 8 82433 tonikitoo 2011-02-17 13:37:41 -0800 Comment on attachment 82433 patch Waiting for EFL API review... 354079 9 83059 k.blank 2011-02-18 23:47:07 -0800 Created attachment 83059 patch Patch adjusted to the style fixes in ewk_view.h 354083 10 83061 k.blank 2011-02-19 00:01:05 -0800 Created attachment 83061 patch Removed unnecessary line 354521 11 83061 lucas.de.marchi 2011-02-21 04:43:12 -0800 Comment on attachment 83061 patch LGTM 360633 12 83061 gyuyoung.kim 2011-03-02 00:00:11 -0800 Comment on attachment 83061 patch View in context: https://bugs.webkit.org/attachment.cgi?id=83061&action=review > Source/WebKit/efl/ewk/ewk_view.h:365 > +EAPI Eina_Bool ewk_view_execute_editor_command(Evas_Object*, const Ewk_Editor_Command, const char *value); Please add parameters to this API. Style error checker doesn't recognize ewk header files now. 361741 13 84587 k.blank 2011-03-03 10:58:05 -0800 Created attachment 84587 patch Restored params names. 389971 14 k.blank 2011-04-21 06:11:14 -0700 Could someone please review this patch? 393040 15 lucas.de.marchi 2011-04-26 16:42:17 -0700 (In reply to comment #0) > Created an attachment (id=82425) [details] > patch > > I'd like to add new functionalities to be executed by EditorCommand - InsertText, InsertImage. > I decided to do it in a different way than previous commands: "SelectWord", "SelectLine" etc. > I believe that having one function for all commands is much better than tens of similar functions > (what is possible as EditorCommand has a lot of commands defined). > > Due to this fact I was also thinking about replacing existing functions (listed below) by additional enums in Ewk_Editor_Command > but I'm not sure whether removing API is a good idea, what do you think? > > List of existing editor commands: > EAPI Eina_Bool ewk_view_select_none(Evas_Object *o); > EAPI Eina_Bool ewk_view_select_all(Evas_Object *o); > EAPI Eina_Bool ewk_view_select_paragraph(Evas_Object *o); > EAPI Eina_Bool ewk_view_select_sentence(Evas_Object *o); > EAPI Eina_Bool ewk_view_select_line(Evas_Object *o); > EAPI Eina_Bool ewk_view_select_word(Evas_Object *o); IMO it's ok to remove these too, and merge with this new one that you implemented. Feel free to add this later. thanks 393053 16 84587 tonikitoo 2011-04-26 16:46:15 -0700 Comment on attachment 84587 patch View in context: https://bugs.webkit.org/attachment.cgi?id=84587&action=review > Source/WebKit/efl/ewk/ewk_view.h:361 > + EWK_EDITOR_COMMAND_INSERT_TEXT = 1 you do not need "= 1" here. 393459 17 lucas.de.marchi 2011-04-27 02:33:22 -0700 Hi, Kamil Please, remove the "= 1" Antonio mentioned before landing this patch. We do our best to enforce webkit's coding style. Thanks. 393476 18 91263 k.blank 2011-04-27 03:50:51 -0700 Created attachment 91263 patch Removed unnecessary code from previous patch. 395061 19 commit-queue 2011-04-28 20:32:42 -0700 The commit-queue encountered the following flaky tests while processing attachment 91263: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 395062 20 91263 commit-queue 2011-04-28 20:34:02 -0700 Comment on attachment 91263 patch Clearing flags on attachment: 91263 Committed r85295: <http://trac.webkit.org/changeset/85295> 395063 21 commit-queue 2011-04-28 20:34:09 -0700 All reviewed patches have been landed. Closing bug. 395079 22 webkit.review.bot 2011-04-28 20:53:01 -0700 http://trac.webkit.org/changeset/85295 might have broken Windows 7 Release (Tests) 82425 2011-02-15 00:09:29 -0800 2011-02-15 02:50:02 -0800 patch editor_command.diff text/plain 3222 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyMDY4Y2NjLi5hZGEyNGFlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMTQgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZXcgQVBJIGZvciBleGVjdXRpbmcgRWRpdG9yIENvbW1hbmRzOiBJbnNlcnRUZXh0LCBJbnNlcnRJ bWFnZS4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChfZXdrX3ZpZXdf ZWRpdG9yX2NvbW1hbmQpOiBBZGRlZCB2YWx1ZSBwYXJhbWV0ZXIuCisgICAgICAgIChld2tfdmll d19leGVjdXRlX2VkaXRvcl9jb21tYW5kKTogQWRkZWQuCisgICAgICAgICogZXdrL2V3a192aWV3 Lmg6IE5ldyBBUEkgYWRkZWQuCisKIDIwMTEtMDItMDggIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXcuY3BwCmluZGV4IGNlMDlmNjQuLjk0ZTkyZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmNwcApAQCAtMTUzOCw5ICsxNTM4LDkgQEAgY2hhciogZXdrX3ZpZXdfc2VsZWN0 aW9uX2dldChjb25zdCBFdmFzX09iamVjdCogbykKICAgICByZXR1cm4gc3RyZHVwKHMuZGF0YSgp KTsKIH0KIAotc3RhdGljIEVpbmFfQm9vbCBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQoRXdrX1Zp ZXdfUHJpdmF0ZV9EYXRhKiBwcml2LCBjb25zdCBjaGFyKiBjb21tYW5kKQorc3RhdGljIEVpbmFf Qm9vbCBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2 LCBjb25zdCBjaGFyKiBjb21tYW5kLCBjb25zdCBjaGFyKiB2YWx1ZSA9IDApCiB7Ci0gICAgcmV0 dXJuIHByaXYtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKS0+ ZWRpdG9yKCktPmNvbW1hbmQoV1RGOjpTdHJpbmc6OmZyb21VVEY4KGNvbW1hbmQpKS5leGVjdXRl KCk7CisgICAgcmV0dXJuIHByaXYtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JN YWluRnJhbWUoKS0+ZWRpdG9yKCktPmNvbW1hbmQoV1RGOjpTdHJpbmc6OmZyb21VVEY4KGNvbW1h bmQpKS5leGVjdXRlKHZhbHVlKTsKIH0KIAogLyoqCkBAIC0xNjE1LDYgKzE2MTUsMzAgQEAgRWlu YV9Cb29sIGV3a192aWV3X3NlbGVjdF93b3JkKEV2YXNfT2JqZWN0KiBvKQogICAgIHJldHVybiBf ZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwgIlNlbGVjdFdvcmQiKTsKIH0KIAorLyoqCisg KiBFeGVjdXRlcyBlZGl0b3IgY29tbWFuZC4KKyAqCisgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0 byBleGVjdXRlIGNvbW1hbmQuCisgKiBAcGFyYW0gY29tbWFuZCBlZGl0b3IgY29tbWFuZCB0byBi ZSBleGVjdXRlZC4KKyAqIEBwYXJhbSB2YWx1ZSB2YWx1ZSB0byBiZSBwYXNzZWQgaW50byBjb21t YW5kLgorICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIGlmIG9wZXJhdGlvbiB3YXMgZXhlY3V0 ZWQsIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3aXNlLgorICovCitFaW5hX0Jvb2wgZXdrX3ZpZXdfZXhl Y3V0ZV9lZGl0b3JfY29tbWFuZChFdmFzX09iamVjdCogbywgY29uc3QgRXdrX0VkaXRvcl9Db21t YW5kIGNvbW1hbmQsIGNvbnN0IGNoYXIqIHZhbHVlKQoreworICAgIEVXS19WSUVXX1NEX0dFVF9P Ul9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JF VFVSTihzZCwgcHJpdiwgRUlOQV9GQUxTRSk7CisKKyAgICBzd2l0Y2ggKGNvbW1hbmQpIHsKKyAg ICBjYXNlIEVXS19FRElUT1JfQ09NTUFORF9JTlNFUlRfSU1BR0U6CisgICAgICAgIHJldHVybiBf ZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwgIkluc2VydEltYWdlIiwgdmFsdWUpOworICAg IGNhc2UgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9URVhUOgorICAgICAgICByZXR1cm4gX2V3 a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJJbnNlcnRUZXh0IiwgdmFsdWUpOworICAgIGRl ZmF1bHQ6CisgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOworICAgIH0KK30KKwogI2lmIEVOQUJM RShDT05URVhUX01FTlVTKQogCiAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKaW5kZXggZTQ4 N2Y1ZS4uMjY4NjdmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAgLTM1NCw2ICszNTQs MTQgQEAgRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2VsZWN0X3NlbnRlbmNlKEV2YXNfT2Jq ZWN0ICpvKTsKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF9saW5lKEV2YXNfT2Jq ZWN0ICpvKTsKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF93b3JkKEV2YXNfT2Jq ZWN0ICpvKTsKIAorZW51bSBfRXdrX0VkaXRvcl9Db21tYW5kIHsKKyAgICBFV0tfRURJVE9SX0NP TU1BTkRfSU5TRVJUX0lNQUdFID0gMCwKKyAgICBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX1RF WFQgPSAxCit9OwordHlwZWRlZiBlbnVtIF9Fd2tfRWRpdG9yX0NvbW1hbmQgRXdrX0VkaXRvcl9D b21tYW5kOworCitFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19leGVjdXRlX2VkaXRvcl9jb21t YW5kKEV2YXNfT2JqZWN0ICpvLCBjb25zdCBFd2tfRWRpdG9yX0NvbW1hbmQgY29tbWFuZCwgY29u c3QgY2hhciAqdmFsdWUpOworCiBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19jb250ZXh0X21l bnVfZm9yd2FyZF9ldmVudChFdmFzX09iamVjdCAqbywgY29uc3QgRXZhc19FdmVudF9Nb3VzZV9E b3duICpldik7CiAKIEVBUEkgdm9pZCAgICAgICAgIGV3a192aWV3X3BvcHVwX3NlbGVjdGVkX3Nl dChFdmFzX09iamVjdCAqbywgaW50IGluZGV4KTsK 82433 2011-02-15 02:50:02 -0800 2011-02-18 23:47:07 -0800 patch editor_command2.diff text/plain 3277 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyMDY4Y2NjLi5lMWQzYmZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTQgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZXcgQVBJIGZvciBleGVjdXRpbmcgRWRpdG9yIENvbW1hbmRzOiBJbnNlcnRUZXh0LCBJbnNlcnRJ bWFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NDM5CisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKTogQWRkZWQgdmFsdWUgcGFyYW1ldGVyLgorICAgICAgICAoZXdrX3ZpZXdf ZXhlY3V0ZV9lZGl0b3JfY29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIGV3ay9ld2tfdmlldy5o OiBOZXcgQVBJIGFkZGVkLgorCiAyMDExLTAyLTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmNwcAppbmRleCBjZTA5ZjY0Li45NGU5MmU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5jcHAKQEAgLTE1MzgsOSArMTUzOCw5IEBAIGNoYXIqIGV3a192aWV3X3NlbGVjdGlv bl9nZXQoY29uc3QgRXZhc19PYmplY3QqIG8pCiAgICAgcmV0dXJuIHN0cmR1cChzLmRhdGEoKSk7 CiB9CiAKLXN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKEV3a19WaWV3 X1ByaXZhdGVfRGF0YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFuZCkKK3N0YXRpYyBFaW5hX0Jv b2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwg Y29uc3QgY2hhciogY29tbWFuZCwgY29uc3QgY2hhciogdmFsdWUgPSAwKQogewotICAgIHJldHVy biBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCktPmVk aXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRGOChjb21tYW5kKSkuZXhlY3V0ZSgp OworICAgIHJldHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFp bkZyYW1lKCktPmVkaXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRGOChjb21tYW5k KSkuZXhlY3V0ZSh2YWx1ZSk7CiB9CiAKIC8qKgpAQCAtMTYxNSw2ICsxNjE1LDMwIEBAIEVpbmFf Qm9vbCBld2tfdmlld19zZWxlY3Rfd29yZChFdmFzX09iamVjdCogbykKICAgICByZXR1cm4gX2V3 a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJTZWxlY3RXb3JkIik7CiB9CiAKKy8qKgorICog RXhlY3V0ZXMgZWRpdG9yIGNvbW1hbmQuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8g ZXhlY3V0ZSBjb21tYW5kLgorICogQHBhcmFtIGNvbW1hbmQgZWRpdG9yIGNvbW1hbmQgdG8gYmUg ZXhlY3V0ZWQuCisgKiBAcGFyYW0gdmFsdWUgdmFsdWUgdG8gYmUgcGFzc2VkIGludG8gY29tbWFu ZC4KKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBpZiBvcGVyYXRpb24gd2FzIGV4ZWN1dGVk LCBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZS4KKyAqLworRWluYV9Cb29sIGV3a192aWV3X2V4ZWN1 dGVfZWRpdG9yX2NvbW1hbmQoRXZhc19PYmplY3QqIG8sIGNvbnN0IEV3a19FZGl0b3JfQ29tbWFu ZCBjb21tYW5kLCBjb25zdCBjaGFyKiB2YWx1ZSkKK3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1Jf UkVUVVJOKG8sIHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRV Uk4oc2QsIHByaXYsIEVJTkFfRkFMU0UpOworCisgICAgc3dpdGNoIChjb21tYW5kKSB7CisgICAg Y2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX0lNQUdFOgorICAgICAgICByZXR1cm4gX2V3 a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJJbnNlcnRJbWFnZSIsIHZhbHVlKTsKKyAgICBj YXNlIEVXS19FRElUT1JfQ09NTUFORF9JTlNFUlRfVEVYVDoKKyAgICAgICAgcmV0dXJuIF9ld2tf dmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiSW5zZXJ0VGV4dCIsIHZhbHVlKTsKKyAgICBkZWZh dWx0OgorICAgICAgICByZXR1cm4gRUlOQV9GQUxTRTsKKyAgICB9Cit9CisKICNpZiBFTkFCTEUo Q09OVEVYVF9NRU5VUykKIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4IGU0ODdm NWUuLjI2ODY3ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC0zNTQsNiArMzU0LDE0 IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF9zZW50ZW5jZShFdmFzX09iamVj dCAqbyk7CiBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19zZWxlY3RfbGluZShFdmFzX09iamVj dCAqbyk7CiBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19zZWxlY3Rfd29yZChFdmFzX09iamVj dCAqbyk7CiAKK2VudW0gX0V3a19FZGl0b3JfQ29tbWFuZCB7CisgICAgRVdLX0VESVRPUl9DT01N QU5EX0lOU0VSVF9JTUFHRSA9IDAsCisgICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9URVhU ID0gMQorfTsKK3R5cGVkZWYgZW51bSBfRXdrX0VkaXRvcl9Db21tYW5kIEV3a19FZGl0b3JfQ29t bWFuZDsKKworRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfZXhlY3V0ZV9lZGl0b3JfY29tbWFu ZChFdmFzX09iamVjdCAqbywgY29uc3QgRXdrX0VkaXRvcl9Db21tYW5kIGNvbW1hbmQsIGNvbnN0 IGNoYXIgKnZhbHVlKTsKKwogRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfY29udGV4dF9tZW51 X2ZvcndhcmRfZXZlbnQoRXZhc19PYmplY3QgKm8sIGNvbnN0IEV2YXNfRXZlbnRfTW91c2VfRG93 biAqZXYpOwogCiBFQVBJIHZvaWQgICAgICAgICBld2tfdmlld19wb3B1cF9zZWxlY3RlZF9zZXQo RXZhc19PYmplY3QgKm8sIGludCBpbmRleCk7Cg== 83059 2011-02-18 23:47:07 -0800 2011-02-19 00:01:05 -0800 patch patch_editor2.diff text/plain 3210 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwNTA3MzEzLi5kMDE3M2EwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTkgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZXcgQVBJIGZvciBleGVjdXRpbmcgRWRpdG9yIENvbW1hbmRzOiBJbnNlcnRUZXh0LCBJbnNlcnRJ bWFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NDM5CisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKTogQWRkZWQgdmFsdWUgcGFyYW1ldGVyLgorICAgICAgICAoZXdrX3ZpZXdf ZXhlY3V0ZV9lZGl0b3JfY29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIGV3ay9ld2tfdmlldy5o OiBOZXcgQVBJIGFkZGVkLgorCiAyMDExLTAyLTE4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA2MDcwYTAzLi42N2M1Y2UxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTE1MzgsOSArMTUzOCw5IEBAIGNoYXIqIGV3a192aWV3 X3NlbGVjdGlvbl9nZXQoY29uc3QgRXZhc19PYmplY3QqIG8pCiAgICAgcmV0dXJuIHN0cmR1cChz LmRhdGEoKSk7CiB9CiAKLXN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5k KEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFuZCkKK3N0YXRp YyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKEV3a19WaWV3X1ByaXZhdGVfRGF0 YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFuZCwgY29uc3QgY2hhciogdmFsdWUgPSAwKQogewot ICAgIHJldHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZy YW1lKCktPmVkaXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRGOChjb21tYW5kKSku ZXhlY3V0ZSgpOworICAgIHJldHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9j dXNlZE9yTWFpbkZyYW1lKCktPmVkaXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRG OChjb21tYW5kKSkuZXhlY3V0ZSh2YWx1ZSk7CiB9CiAKIC8qKgpAQCAtMTYxNSw2ICsxNjE1LDMw IEBAIEVpbmFfQm9vbCBld2tfdmlld19zZWxlY3Rfd29yZChFdmFzX09iamVjdCogbykKICAgICBy ZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJTZWxlY3RXb3JkIik7CiB9CiAK Ky8qKgorICogRXhlY3V0ZXMgZWRpdG9yIGNvbW1hbmQuCisgKgorICogQHBhcmFtIG8gdmlldyBv YmplY3QgdG8gZXhlY3V0ZSBjb21tYW5kLgorICogQHBhcmFtIGNvbW1hbmQgZWRpdG9yIGNvbW1h bmQgdG8gYmUgZXhlY3V0ZWQuCisgKiBAcGFyYW0gdmFsdWUgdmFsdWUgdG8gYmUgcGFzc2VkIGlu dG8gY29tbWFuZC4KKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBpZiBvcGVyYXRpb24gd2Fz IGV4ZWN1dGVkLCBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZS4KKyAqLworRWluYV9Cb29sIGV3a192 aWV3X2V4ZWN1dGVfZWRpdG9yX2NvbW1hbmQoRXZhc19PYmplY3QqIG8sIGNvbnN0IEV3a19FZGl0 b3JfQ29tbWFuZCBjb21tYW5kLCBjb25zdCBjaGFyKiB2YWx1ZSkKK3sKKyAgICBFV0tfVklFV19T RF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dF VF9PUl9SRVRVUk4oc2QsIHByaXYsIEVJTkFfRkFMU0UpOworCisgICAgc3dpdGNoIChjb21tYW5k KSB7CisgICAgY2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX0lNQUdFOgorICAgICAgICBy ZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJJbnNlcnRJbWFnZSIsIHZhbHVl KTsKKyAgICBjYXNlIEVXS19FRElUT1JfQ09NTUFORF9JTlNFUlRfVEVYVDoKKyAgICAgICAgcmV0 dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiSW5zZXJ0VGV4dCIsIHZhbHVlKTsK KyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gRUlOQV9GQUxTRTsKKyAgICB9Cit9CisKICNp ZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmlu ZGV4IDlhYzUzYWYuLmFmNGNjZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC0zNTYs NiArMzU2LDE1IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF93b3JkKEV2YXNf T2JqZWN0Kik7CiAKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X2NvbnRleHRfbWVudV9mb3J3 YXJkX2V2ZW50KEV2YXNfT2JqZWN0KiwgY29uc3QgRXZhc19FdmVudF9Nb3VzZV9Eb3duKik7CiAK K2VudW0gX0V3a19FZGl0b3JfQ29tbWFuZCB7CisgICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VS VF9JTUFHRSA9IDAsCisgICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9URVhUID0gMQorfTsK K3R5cGVkZWYgZW51bSBfRXdrX0VkaXRvcl9Db21tYW5kIEV3a19FZGl0b3JfQ29tbWFuZDsKKwor RUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfZXhlY3V0ZV9lZGl0b3JfY29tbWFuZChFdmFzX09i amVjdCosIGNvbnN0IEV3a19FZGl0b3JfQ29tbWFuZCwgY29uc3QgY2hhciAqdmFsdWUpOworCisK IEVBUEkgdm9pZCAgICAgICAgIGV3a192aWV3X3BvcHVwX3NlbGVjdGVkX3NldChFdmFzX09iamVj dCosIGludCBpbmRleCk7CiBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19wb3B1cF9kZXN0cm95 KEV2YXNfT2JqZWN0Kik7CiAK 83061 2011-02-19 00:01:05 -0800 2011-03-03 10:58:05 -0800 patch patch_editor3.diff text/plain 3208 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwNTA3MzEzLi5kMDE3M2EwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTkgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZXcgQVBJIGZvciBleGVjdXRpbmcgRWRpdG9yIENvbW1hbmRzOiBJbnNlcnRUZXh0LCBJbnNlcnRJ bWFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NDM5CisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKTogQWRkZWQgdmFsdWUgcGFyYW1ldGVyLgorICAgICAgICAoZXdrX3ZpZXdf ZXhlY3V0ZV9lZGl0b3JfY29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIGV3ay9ld2tfdmlldy5o OiBOZXcgQVBJIGFkZGVkLgorCiAyMDExLTAyLTE4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA2MDcwYTAzLi42N2M1Y2UxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTE1MzgsOSArMTUzOCw5IEBAIGNoYXIqIGV3a192aWV3 X3NlbGVjdGlvbl9nZXQoY29uc3QgRXZhc19PYmplY3QqIG8pCiAgICAgcmV0dXJuIHN0cmR1cChz LmRhdGEoKSk7CiB9CiAKLXN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5k KEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFuZCkKK3N0YXRp YyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKEV3a19WaWV3X1ByaXZhdGVfRGF0 YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFuZCwgY29uc3QgY2hhciogdmFsdWUgPSAwKQogewot ICAgIHJldHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZy YW1lKCktPmVkaXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRGOChjb21tYW5kKSku ZXhlY3V0ZSgpOworICAgIHJldHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9j dXNlZE9yTWFpbkZyYW1lKCktPmVkaXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRG OChjb21tYW5kKSkuZXhlY3V0ZSh2YWx1ZSk7CiB9CiAKIC8qKgpAQCAtMTYxNSw2ICsxNjE1LDMw IEBAIEVpbmFfQm9vbCBld2tfdmlld19zZWxlY3Rfd29yZChFdmFzX09iamVjdCogbykKICAgICBy ZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJTZWxlY3RXb3JkIik7CiB9CiAK Ky8qKgorICogRXhlY3V0ZXMgZWRpdG9yIGNvbW1hbmQuCisgKgorICogQHBhcmFtIG8gdmlldyBv YmplY3QgdG8gZXhlY3V0ZSBjb21tYW5kLgorICogQHBhcmFtIGNvbW1hbmQgZWRpdG9yIGNvbW1h bmQgdG8gYmUgZXhlY3V0ZWQuCisgKiBAcGFyYW0gdmFsdWUgdmFsdWUgdG8gYmUgcGFzc2VkIGlu dG8gY29tbWFuZC4KKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBpZiBvcGVyYXRpb24gd2Fz IGV4ZWN1dGVkLCBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZS4KKyAqLworRWluYV9Cb29sIGV3a192 aWV3X2V4ZWN1dGVfZWRpdG9yX2NvbW1hbmQoRXZhc19PYmplY3QqIG8sIGNvbnN0IEV3a19FZGl0 b3JfQ29tbWFuZCBjb21tYW5kLCBjb25zdCBjaGFyKiB2YWx1ZSkKK3sKKyAgICBFV0tfVklFV19T RF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dF VF9PUl9SRVRVUk4oc2QsIHByaXYsIEVJTkFfRkFMU0UpOworCisgICAgc3dpdGNoIChjb21tYW5k KSB7CisgICAgY2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX0lNQUdFOgorICAgICAgICBy ZXR1cm4gX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKHByaXYsICJJbnNlcnRJbWFnZSIsIHZhbHVl KTsKKyAgICBjYXNlIEVXS19FRElUT1JfQ09NTUFORF9JTlNFUlRfVEVYVDoKKyAgICAgICAgcmV0 dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiSW5zZXJ0VGV4dCIsIHZhbHVlKTsK KyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gRUlOQV9GQUxTRTsKKyAgICB9Cit9CisKICNp ZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmlu ZGV4IDlhYzUzYWYuLjRiOTlmNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC0zNTYs NiArMzU2LDE0IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF93b3JkKEV2YXNf T2JqZWN0Kik7CiAKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X2NvbnRleHRfbWVudV9mb3J3 YXJkX2V2ZW50KEV2YXNfT2JqZWN0KiwgY29uc3QgRXZhc19FdmVudF9Nb3VzZV9Eb3duKik7CiAK K2VudW0gX0V3a19FZGl0b3JfQ29tbWFuZCB7CisgICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VS VF9JTUFHRSA9IDAsCisgICAgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9URVhUID0gMQorfTsK K3R5cGVkZWYgZW51bSBfRXdrX0VkaXRvcl9Db21tYW5kIEV3a19FZGl0b3JfQ29tbWFuZDsKKwor RUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfZXhlY3V0ZV9lZGl0b3JfY29tbWFuZChFdmFzX09i amVjdCosIGNvbnN0IEV3a19FZGl0b3JfQ29tbWFuZCwgY29uc3QgY2hhciAqdmFsdWUpOworCiBF QVBJIHZvaWQgICAgICAgICBld2tfdmlld19wb3B1cF9zZWxlY3RlZF9zZXQoRXZhc19PYmplY3Qq LCBpbnQgaW5kZXgpOwogRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfcG9wdXBfZGVzdHJveShF dmFzX09iamVjdCopOwogCg== 84587 2011-03-03 10:58:05 -0800 2011-04-27 03:50:51 -0700 patch editor2.diff text/plain 3268 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAxYWNjYWQ4Li5jN2Q3ZGRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMDMgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZXcgQVBJIGZvciBleGVjdXRpbmcgRWRpdG9yIENvbW1hbmRzOiBJbnNlcnRUZXh0LCBJbnNlcnRJ bWFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NDM5CisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKTogQWRkZWQgdmFsdWUgcGFyYW1ldGVyLgorICAgICAgICAoZXdrX3ZpZXdf ZXhlY3V0ZV9lZGl0b3JfY29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIGV3ay9ld2tfdmlldy5o OiBOZXcgQVBJIGFkZGVkLgorCiAyMDExLTAzLTAxICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNr QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUm9sbCBvdXQgcjgwMDY4IGFuZCBy ODAwNzMgZHVlIHRvIGJyZWFraW5nIFdlYktpdDIgUXQgcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwCmluZGV4IGFiMDYyOWEuLjE2YWYxMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmNwcApAQCAtMTUzOSw5ICsxNTM5LDkgQEAgY2hhciogZXdrX3ZpZXdfc2VsZWN0aW9uX2dl dChjb25zdCBFdmFzX09iamVjdCogbykKICAgICByZXR1cm4gc3RyZHVwKHMuZGF0YSgpKTsKIH0K IAotc3RhdGljIEVpbmFfQm9vbCBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQoRXdrX1ZpZXdfUHJp dmF0ZV9EYXRhKiBwcml2LCBjb25zdCBjaGFyKiBjb21tYW5kKQorc3RhdGljIEVpbmFfQm9vbCBf ZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2LCBjb25z dCBjaGFyKiBjb21tYW5kLCBjb25zdCBjaGFyKiB2YWx1ZSA9IDApCiB7Ci0gICAgcmV0dXJuIHBy aXYtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKS0+ZWRpdG9y KCktPmNvbW1hbmQoU3RyaW5nOjpmcm9tVVRGOChjb21tYW5kKSkuZXhlY3V0ZSgpOworICAgIHJl dHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCkt PmVkaXRvcigpLT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRGOChjb21tYW5kKSkuZXhlY3V0 ZSh2YWx1ZSk7CiB9CiAKIC8qKgpAQCAtMTYxNiw2ICsxNjE2LDMwIEBAIEVpbmFfQm9vbCBld2tf dmlld19zZWxlY3Rfd29yZChFdmFzX09iamVjdCogbykKICAgICByZXR1cm4gX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKHByaXYsICJTZWxlY3RXb3JkIik7CiB9CiAKKy8qKgorICogRXhlY3V0ZXMg ZWRpdG9yIGNvbW1hbmQuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gZXhlY3V0ZSBj b21tYW5kLgorICogQHBhcmFtIGNvbW1hbmQgZWRpdG9yIGNvbW1hbmQgdG8gYmUgZXhlY3V0ZWQu CisgKiBAcGFyYW0gdmFsdWUgdmFsdWUgdG8gYmUgcGFzc2VkIGludG8gY29tbWFuZC4KKyAqCisg KiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBpZiBvcGVyYXRpb24gd2FzIGV4ZWN1dGVkLCBAYyBFSU5B X0ZBTFNFIG90aGVyd2lzZS4KKyAqLworRWluYV9Cb29sIGV3a192aWV3X2V4ZWN1dGVfZWRpdG9y X2NvbW1hbmQoRXZhc19PYmplY3QqIG8sIGNvbnN0IEV3a19FZGl0b3JfQ29tbWFuZCBjb21tYW5k LCBjb25zdCBjaGFyKiB2YWx1ZSkKK3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8s IHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHBy aXYsIEVJTkFfRkFMU0UpOworCisgICAgc3dpdGNoIChjb21tYW5kKSB7CisgICAgY2FzZSBFV0tf RURJVE9SX0NPTU1BTkRfSU5TRVJUX0lNQUdFOgorICAgICAgICByZXR1cm4gX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKHByaXYsICJJbnNlcnRJbWFnZSIsIHZhbHVlKTsKKyAgICBjYXNlIEVXS19F RElUT1JfQ09NTUFORF9JTlNFUlRfVEVYVDoKKyAgICAgICAgcmV0dXJuIF9ld2tfdmlld19lZGl0 b3JfY29tbWFuZChwcml2LCAiSW5zZXJ0VGV4dCIsIHZhbHVlKTsKKyAgICBkZWZhdWx0OgorICAg ICAgICByZXR1cm4gRUlOQV9GQUxTRTsKKyAgICB9Cit9CisKICNpZiBFTkFCTEUoQ09OVEVYVF9N RU5VUykKIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu aCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4IGU0ODdmNWUuLmMzMDA5 YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC0zNTYsNiArMzU2LDE0IEBAIEVBUEkg RWluYV9Cb29sICAgIGV3a192aWV3X3NlbGVjdF93b3JkKEV2YXNfT2JqZWN0ICpvKTsKIAogRUFQ SSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfY29udGV4dF9tZW51X2ZvcndhcmRfZXZlbnQoRXZhc19P YmplY3QgKm8sIGNvbnN0IEV2YXNfRXZlbnRfTW91c2VfRG93biAqZXYpOwogCitlbnVtIF9Fd2tf RWRpdG9yX0NvbW1hbmQgeworICAgIEVXS19FRElUT1JfQ09NTUFORF9JTlNFUlRfSU1BR0UgPSAw LAorICAgIEVXS19FRElUT1JfQ09NTUFORF9JTlNFUlRfVEVYVCA9IDEKK307Cit0eXBlZGVmIGVu dW0gX0V3a19FZGl0b3JfQ29tbWFuZCBFd2tfRWRpdG9yX0NvbW1hbmQ7CisKK0VBUEkgRWluYV9C b29sICAgIGV3a192aWV3X2V4ZWN1dGVfZWRpdG9yX2NvbW1hbmQoRXZhc19PYmplY3QgKm8sIGNv bnN0IEV3a19FZGl0b3JfQ29tbWFuZCBjb21tYW5kLCBjb25zdCBjaGFyICp2YWx1ZSk7CisKIEVB UEkgdm9pZCAgICAgICAgIGV3a192aWV3X3BvcHVwX3NlbGVjdGVkX3NldChFdmFzX09iamVjdCAq bywgaW50IGluZGV4KTsKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3BvcHVwX2Rlc3Ryb3ko RXZhc19PYmplY3QgKm8pOwogCg== 91263 2011-04-27 03:50:51 -0700 2011-04-28 20:34:02 -0700 patch editor3.diff text/plain 3229 k.blank ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyNGVjZTIxLi4xZDQwYWQzIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjcgIEthbWlsIEJsYW5rICA8ay5ibGFua0BzYW1zdW5n LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZXcgQVBJIGZvciBleGVjdXRpbmcgRWRpdG9yIENvbW1hbmRzOiBJbnNlcnRUZXh0LCBJbnNlcnRJ bWFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NDM5CisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2Vk aXRvcl9jb21tYW5kKTogQWRkZWQgdmFsdWUgcGFyYW1ldGVyLgorICAgICAgICAoZXdrX3ZpZXdf ZXhlY3V0ZV9lZGl0b3JfY29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIGV3ay9ld2tfdmlldy5o OiBOZXcgQVBJIGFkZGVkLgorCiAyMDExLTA0LTI2ICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5j emFqa293c2tpQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29t ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBhNjc0OWRlLi5mYWYyZjZmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTE1MzQsOSArMTUzNCw5IEBAIGNoYXIq IGV3a192aWV3X3NlbGVjdGlvbl9nZXQoY29uc3QgRXZhc19PYmplY3QqIG8pCiAgICAgcmV0dXJu IHN0cmR1cChzLmRhdGEoKSk7CiB9CiAKLXN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRv cl9jb21tYW5kKEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFu ZCkKK3N0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X2VkaXRvcl9jb21tYW5kKEV3a19WaWV3X1By aXZhdGVfRGF0YSogcHJpdiwgY29uc3QgY2hhciogY29tbWFuZCwgY29uc3QgY2hhciogdmFsdWUg PSAwKQogewotICAgIHJldHVybiBwcml2LT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNl ZE9yTWFpbkZyYW1lKCktPmVkaXRvcigpLT5jb21tYW5kKFN0cmluZzo6ZnJvbVVURjgoY29tbWFu ZCkpLmV4ZWN1dGUoKTsKKyAgICByZXR1cm4gcHJpdi0+cGFnZS0+Zm9jdXNDb250cm9sbGVyKCkt PmZvY3VzZWRPck1haW5GcmFtZSgpLT5lZGl0b3IoKS0+Y29tbWFuZChXVEY6OlN0cmluZzo6ZnJv bVVURjgoY29tbWFuZCkpLmV4ZWN1dGUodmFsdWUpOwogfQogCiAvKioKQEAgLTE2MTEsNiArMTYx MSwzMCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfc2VsZWN0X3dvcmQoRXZhc19PYmplY3QqIG8pCiAg ICAgcmV0dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiU2VsZWN0V29yZCIpOwog fQogCisvKioKKyAqIEV4ZWN1dGVzIGVkaXRvciBjb21tYW5kLgorICoKKyAqIEBwYXJhbSBvIHZp ZXcgb2JqZWN0IHRvIGV4ZWN1dGUgY29tbWFuZC4KKyAqIEBwYXJhbSBjb21tYW5kIGVkaXRvciBj b21tYW5kIHRvIGJlIGV4ZWN1dGVkLgorICogQHBhcmFtIHZhbHVlIHZhbHVlIHRvIGJlIHBhc3Nl ZCBpbnRvIGNvbW1hbmQuCisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgb3BlcmF0aW9u IHdhcyBleGVjdXRlZCwgQGMgRUlOQV9GQUxTRSBvdGhlcndpc2UuCisgKi8KK0VpbmFfQm9vbCBl d2tfdmlld19leGVjdXRlX2VkaXRvcl9jb21tYW5kKEV2YXNfT2JqZWN0KiBvLCBjb25zdCBFd2tf RWRpdG9yX0NvbW1hbmQgY29tbWFuZCwgY29uc3QgY2hhciogdmFsdWUpCit7CisgICAgRVdLX1ZJ RVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7CisgICAgRVdLX1ZJRVdfUFJJ Vl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCBFSU5BX0ZBTFNFKTsKKworICAgIHN3aXRjaCAoY29t bWFuZCkgeworICAgIGNhc2UgRVdLX0VESVRPUl9DT01NQU5EX0lOU0VSVF9JTUFHRToKKyAgICAg ICAgcmV0dXJuIF9ld2tfdmlld19lZGl0b3JfY29tbWFuZChwcml2LCAiSW5zZXJ0SW1hZ2UiLCB2 YWx1ZSk7CisgICAgY2FzZSBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX1RFWFQ6CisgICAgICAg IHJldHVybiBfZXdrX3ZpZXdfZWRpdG9yX2NvbW1hbmQocHJpdiwgIkluc2VydFRleHQiLCB2YWx1 ZSk7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuIEVJTkFfRkFMU0U7CisgICAgfQorfQor CiAjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAKIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu aAppbmRleCA4NWRmZWZjLi44NDk5NGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApAQCAt MzU2LDYgKzM1NiwxNCBAQCBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19zZWxlY3Rfd29yZChF dmFzX09iamVjdCAqbyk7CiAKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X2NvbnRleHRfbWVu dV9mb3J3YXJkX2V2ZW50KEV2YXNfT2JqZWN0ICpvLCBjb25zdCBFdmFzX0V2ZW50X01vdXNlX0Rv d24gKmV2KTsKIAorZW51bSBfRXdrX0VkaXRvcl9Db21tYW5kIHsKKyAgICBFV0tfRURJVE9SX0NP TU1BTkRfSU5TRVJUX0lNQUdFID0gMCwKKyAgICBFV0tfRURJVE9SX0NPTU1BTkRfSU5TRVJUX1RF WFQKK307Cit0eXBlZGVmIGVudW0gX0V3a19FZGl0b3JfQ29tbWFuZCBFd2tfRWRpdG9yX0NvbW1h bmQ7CisKK0VBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X2V4ZWN1dGVfZWRpdG9yX2NvbW1hbmQo RXZhc19PYmplY3QgKm8sIGNvbnN0IEV3a19FZGl0b3JfQ29tbWFuZCBjb21tYW5kLCBjb25zdCBj aGFyICp2YWx1ZSk7CisKIEVBUEkgdm9pZCAgICAgICAgIGV3a192aWV3X3BvcHVwX3NlbGVjdGVk X3NldChFdmFzX09iamVjdCAqbywgaW50IGluZGV4KTsKIEVBUEkgRWluYV9Cb29sICAgIGV3a192 aWV3X3BvcHVwX2Rlc3Ryb3koRXZhc19PYmplY3QgKm8pOwogCg==