54363 2011-02-13 13:26:34 -0800 Unused variable result in RenderBlock::addOverflowFromFloats() 2011-02-13 17:20:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P5 Enhancement --- 1 benjamin benjamin commit-queue oldest_to_newest 350448 0 benjamin 2011-02-13 13:26:34 -0800 I just notice result is unused in RenderBlock::addOverflowFromFloats()... 350449 1 82276 benjamin 2011-02-13 13:29:22 -0800 Created attachment 82276 Patch 350451 2 82276 kling 2011-02-13 13:34:09 -0800 Comment on attachment 82276 Patch Did you performance test this? 350490 3 commit-queue 2011-02-13 17:18:41 -0800 The commit-queue encountered the following flaky tests while processing attachment 82276: http/tests/websocket/tests/bad-handshake-crash.html bug 54370 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 350491 4 82276 commit-queue 2011-02-13 17:20:10 -0800 Comment on attachment 82276 Patch Clearing flags on attachment: 82276 Committed r78448: <http://trac.webkit.org/changeset/78448> 350492 5 commit-queue 2011-02-13 17:20:15 -0800 All reviewed patches have been landed. Closing bug. 82276 2011-02-13 13:29:22 -0800 2011-02-13 17:20:10 -0800 Patch bug-54363-20110213222920.patch text/plain 1182 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMzA2ZDY0MDI1NzNkMzkyNDU5YmZiNjI5NGUwOTE4YTE3YTQ5NDIzLi4x ODM4MTk4M2YyMWQ1NDRkYjcwYzIxY2IxYzg4YjVhMGIwYzIzZjhlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDItMTMgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3Vs YWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVbnVzZWQgdmFyaWFibGUgcmVzdWx0IGluIFJlbmRlckJsb2NrOjphZGRPdmVyZmxv d0Zyb21GbG9hdHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTQzNjMKKworICAgICAgICBSZW1vdmUgdGhlIHVudXNlZCB2YXJpYWJsZS4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6YWRkT3ZlcmZsb3dGcm9tRmxvYXRzKToKKwogMjAxMS0wMi0xMiAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCBkYjIyOWZkYzAx YWEyMWRhMDg4ZTZjYjRlMTRkNWNmNjJiNzEyYmRlLi5iMzc4NmE2NzJmY2ZkODhjMDNiNmE3OWJj OWRiMmYwYWIxNzY2ZjdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKQEAgLTEzNzcsNyArMTM3Nyw2IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmFkZE92ZXJmbG93RnJv bUJsb2NrQ2hpbGRyZW4oKQogCiB2b2lkIFJlbmRlckJsb2NrOjphZGRPdmVyZmxvd0Zyb21GbG9h dHMoKQogewotICAgIEludFJlY3QgcmVzdWx0OwogICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMp CiAgICAgICAgIHJldHVybjsKICAgICBGbG9hdGluZ09iamVjdCogcjsK