54333 2011-02-11 19:49:41 -0800 Expose checked field of HTMLInputElement to Chromium API 2011-02-15 10:24:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jaysoffian webkit-unassigned commit-queue darin fishd oldest_to_newest 350218 0 jaysoffian 2011-02-11 19:49:41 -0800 Expose checked field of HTMLInputElement to Chromium API 350219 1 82226 jaysoffian 2011-02-11 19:51:37 -0800 Created attachment 82226 Patch 350516 2 82226 fishd 2011-02-13 21:02:34 -0800 Comment on attachment 82226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82226&action=review > w/Source/WebKit/chromium/public/WebInputElement.h:81 > + WEBKIT_API bool checked() const; How about renaming this to isChecked to be more consistent with how other, similar API methods are named? "checked" is really trying to ask a question, so it helps to word it like a question. 350651 3 jaysoffian 2011-02-14 07:25:51 -0800 Every other WebInputElement method is named identically to the HTMLInputElement method it calls though to. This would be the first WebInputElement method that uses a different name. Isn't consistency more important? Also, there's this comment in HTMLInputElement.h: // isChecked is used by the rendering tree/CSS while checked() is used by JS to determine checked state 350727 4 fishd 2011-02-14 10:03:03 -0800 (In reply to comment #3) > Every other WebInputElement method is named identically to the HTMLInputElement method it calls though to. This would be the first WebInputElement method that uses a different name. Isn't consistency more important? You're talking about an implementation detail. I'm arguing for making the publicly facing API consistent from the perspective of the guy who uses the API. 350736 5 jaysoffian 2011-02-14 10:16:19 -0800 I will defer to your judgement, but in my experience abstractions leak and when that happens, it's less confusing for the same concepts at different layers to have the same name. Sending up new patch shortly. 350743 6 82330 jaysoffian 2011-02-14 10:24:37 -0800 Created attachment 82330 Patch 350776 7 82330 fishd 2011-02-14 11:16:08 -0800 Comment on attachment 82330 Patch R=me It sounds like the internal naming is unfortunate. "isChecked" and "checked" sound way too similar. I'd recommend finding a better name for one of those. 350791 8 commit-queue 2011-02-14 11:43:24 -0800 The commit-queue encountered the following flaky tests while processing attachment 82330: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 350792 9 82330 commit-queue 2011-02-14 11:46:03 -0800 Comment on attachment 82330 Patch Clearing flags on attachment: 82330 Committed r78494: <http://trac.webkit.org/changeset/78494> 350793 10 commit-queue 2011-02-14 11:46:07 -0800 All reviewed patches have been landed. Closing bug. 350818 11 darin 2011-02-14 12:13:18 -0800 (In reply to comment #7) > It sounds like the internal naming is unfortunate. "isChecked" and "checked" sound way too similar. I'd recommend finding a better name for one of those. I think we ended up with these names because isChecked is a good name and checked is the name used in the HTML DOM. 351364 12 fishd 2011-02-15 09:52:29 -0800 (In reply to comment #11) > (In reply to comment #7) > > It sounds like the internal naming is unfortunate. "isChecked" and "checked" sound way too similar. I'd recommend finding a better name for one of those. > > I think we ended up with these names because isChecked is a good name and checked is the name used in the HTML DOM. You don't find the names confusingly similar? 351369 13 darin 2011-02-15 09:57:10 -0800 (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #7) > > > It sounds like the internal naming is unfortunate. "isChecked" and "checked" sound way too similar. I'd recommend finding a better name for one of those. > > > > I think we ended up with these names because isChecked is a good name and checked is the name used in the HTML DOM. > > You don't find the names confusingly similar? I do. My intention was to explain how we got here, not defend where we are ;-) It’s bad to have two similar names with different behavior. They should definitely be named in a way that makes the difference clear. 351387 14 fishd 2011-02-15 10:24:23 -0800 OK, I created a bug about the naming issue: see bug 54476. 82226 2011-02-11 19:51:37 -0800 2011-02-14 10:24:33 -0800 Patch bug-54333-20110211225136.patch text/plain 2002 jaysoffian U3VidmVyc2lvbiBSZXZpc2lvbjogNzg0MDEKZGlmZiAtLWdpdCBjL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIHcvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NjAzZWVhYjllY2M2ODFiM2Y5MDdjYWNjMWNmMWNmZTYxYmU2YjU2NC4uMmEzNDYxZWU2MjkzZWFm YjZjMGEyZDIzMGUyY2U5NzRiNzk4M2MxOSAxMDA2NDQKLS0tIGMvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIHcvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wMi0xMSAgSmF5IFNvZmZpYW4gIDxqYXlzb2ZmaWFuQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF eHBvc2UgY2hlY2tlZCBmaWVsZCBvZiBIVE1MSW5wdXRFbGVtZW50IHRvIENocm9taXVtIEFQSQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQzMzMKKwor ICAgICAgICAqIHB1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaDoKKyAgICAgICAgKiBzcmMvV2ViSW5w dXRFbGVtZW50LmNwcDoKKwogMjAxMS0wMi0xMSAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYy9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaCB3L1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCmluZGV4IDgxYzM5N2M2Nzc5 NGJmMTJjNTdmNWQ0MTZmNzMxYjQyMjM0Zjg3ODUuLjQ0YjNlYjMwMTQwNmM3ODkxOTdmYmM1ZTY0 YjQwOGEwYjUzNjI0OWQgMTAwNjQ0Ci0tLSBjL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYklucHV0RWxlbWVudC5oCisrKyB3L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YklucHV0RWxlbWVudC5oCkBAIC03OCw2ICs3OCw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogICAg ICAgICBXRUJLSVRfQVBJIGludCBzZWxlY3Rpb25TdGFydCgpIGNvbnN0OwogICAgICAgICBXRUJL SVRfQVBJIGludCBzZWxlY3Rpb25FbmQoKSBjb25zdDsKICAgICAgICAgV0VCS0lUX0FQSSBib29s IGlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJpbmcmKSBjb25zdDsKKyAgICAgICAgV0VCS0lUX0FQ SSBib29sIGNoZWNrZWQoKSBjb25zdDsKIAogICAgICAgICAvLyBFeHBvc2VzIHRoZSBkZWZhdWx0 IHZhbHVlIG9mIHRoZSBtYXhMZW5ndGggYXR0cmlidXRlLgogICAgICAgICBXRUJLSVRfQVBJIHN0 YXRpYyBpbnQgZGVmYXVsdE1heExlbmd0aCgpOwpkaWZmIC0tZ2l0IGMvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcCB3L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYklucHV0RWxlbWVudC5jcHAKaW5kZXggN2U5MWExNzRmMjY3YmUxOWU5YjE4ZDkxODVl ZmEzYWE3Yjg5Njg0NS4uYjY0NmY2YTg1M2M2ZWIxYjcwNWM5Mzg3MTNlOWUxYjU5OWVkNzI2ZCAx MDA2NDQKLS0tIGMvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNw cAorKysgdy9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCkBA IC0xNTUsNiArMTU1LDExIEBAIGJvb2wgV2ViSW5wdXRFbGVtZW50Ojppc1ZhbGlkVmFsdWUoY29u c3QgV2ViU3RyaW5nJiB2YWx1ZSkgY29uc3QKICAgICByZXR1cm4gY29uc3RVbndyYXA8SFRNTElu cHV0RWxlbWVudD4oKS0+aXNWYWxpZFZhbHVlKHZhbHVlKTsKIH0KIAorYm9vbCBXZWJJbnB1dEVs ZW1lbnQ6OmNoZWNrZWQoKSBjb25zdAoreworICAgIHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5w dXRFbGVtZW50PigpLT5jaGVja2VkKCk7Cit9CisKIGludCBXZWJJbnB1dEVsZW1lbnQ6OmRlZmF1 bHRNYXhMZW5ndGgoKQogewogICAgIHJldHVybiBIVE1MSW5wdXRFbGVtZW50OjpzX21heGltdW1M ZW5ndGg7Cg== 82330 2011-02-14 10:24:37 -0800 2011-02-14 11:46:03 -0800 Patch bug-54333-20110214132435.patch text/plain 2019 jaysoffian U3VidmVyc2lvbiBSZXZpc2lvbjogNzg0ODcKZGlmZiAtLWdpdCBjL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIHcvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZGFlMDY4YWUxZWQyZThmNjlhNjUyMjNmZDkyNzcxODE2NDg3Nzk5OS4uNDA5ODNjN2E2ZTMzMmVm MTA0M2JkZmFlZTAxNmFkNzcxNjczM2U4NiAxMDA2NDQKLS0tIGMvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIHcvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wMi0xNCAgSmF5IFNvZmZpYW4gIDxqYXlzb2ZmaWFuQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF eHBvc2UgY2hlY2tlZCBmaWVsZCBvZiBIVE1MSW5wdXRFbGVtZW50IHRvIENocm9taXVtIEFQSQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQzMzMKKwor ICAgICAgICAqIHB1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaDoKKyAgICAgICAgKiBzcmMvV2ViSW5w dXRFbGVtZW50LmNwcDoKKwogMjAxMS0wMi0xNCAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk aWZmIC0tZ2l0IGMvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50 Lmggdy9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAppbmRl eCA4MWMzOTdjNjc3OTRiZjEyYzU3ZjVkNDE2ZjczMWI0MjIzNGY4Nzg1Li4xZjA4MzZiZjg3ZDRh MWY0ZWY0YzU5N2U3MzU1MjllYzVmMjMxNDZiIDEwMDY0NAotLS0gYy9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgdy9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaApAQCAtNzgsNiArNzgsNyBAQCBuYW1lc3BhY2Ug V2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0FQSSBpbnQgc2VsZWN0aW9uU3RhcnQoKSBjb25zdDsK ICAgICAgICAgV0VCS0lUX0FQSSBpbnQgc2VsZWN0aW9uRW5kKCkgY29uc3Q7CiAgICAgICAgIFdF QktJVF9BUEkgYm9vbCBpc1ZhbGlkVmFsdWUoY29uc3QgV2ViU3RyaW5nJikgY29uc3Q7CisgICAg ICAgIFdFQktJVF9BUEkgYm9vbCBpc0NoZWNrZWQoKSBjb25zdDsKIAogICAgICAgICAvLyBFeHBv c2VzIHRoZSBkZWZhdWx0IHZhbHVlIG9mIHRoZSBtYXhMZW5ndGggYXR0cmlidXRlLgogICAgICAg ICBXRUJLSVRfQVBJIHN0YXRpYyBpbnQgZGVmYXVsdE1heExlbmd0aCgpOwpkaWZmIC0tZ2l0IGMv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcCB3L1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKaW5kZXggN2U5MWExNzRmMjY3 YmUxOWU5YjE4ZDkxODVlZmEzYWE3Yjg5Njg0NS4uNTQ4ZjFiYjYwMWJmNGU5Mzk0YmExZjdjMzVh OGExMmE5NTI2MWZjNCAxMDA2NDQKLS0tIGMvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi SW5wdXRFbGVtZW50LmNwcAorKysgdy9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1 dEVsZW1lbnQuY3BwCkBAIC0xNTUsNiArMTU1LDExIEBAIGJvb2wgV2ViSW5wdXRFbGVtZW50Ojpp c1ZhbGlkVmFsdWUoY29uc3QgV2ViU3RyaW5nJiB2YWx1ZSkgY29uc3QKICAgICByZXR1cm4gY29u c3RVbndyYXA8SFRNTElucHV0RWxlbWVudD4oKS0+aXNWYWxpZFZhbHVlKHZhbHVlKTsKIH0KIAor Ym9vbCBXZWJJbnB1dEVsZW1lbnQ6OmlzQ2hlY2tlZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGNv bnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPmNoZWNrZWQoKTsKK30KKwogaW50IFdlYklu cHV0RWxlbWVudDo6ZGVmYXVsdE1heExlbmd0aCgpCiB7CiAgICAgcmV0dXJuIEhUTUxJbnB1dEVs ZW1lbnQ6OnNfbWF4aW11bUxlbmd0aDsK