54279 2011-02-11 01:44:41 -0800 Use /dev/urandom as the OSRandomSource on OS(DARWIN) 2011-02-12 15:05:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric mjs mrowe oldest_to_newest 349691 0 abarth 2011-02-11 01:44:41 -0800 Use /dev/urandom as the OSRandomSource on OS(DARWIN) 349692 1 82115 abarth 2011-02-11 01:47:26 -0800 Created attachment 82115 Patch 350236 2 mrowe 2011-02-11 22:35:54 -0800 arc4random itself on Mac OS X seeds from /dev/random rather than /dev/urandom. On Mac OS X and FreeBSD the two are equivalent, but on Linux platforms /dev/random contains strictly more entropy than /dev/urandom, with the latter not being recommended for certain long-term cryptographic purposes. Is there a particular reason why the code uses /dev/random rather than /dev/urandom? 350239 3 abarth 2011-02-11 23:20:40 -0800 > arc4random itself on Mac OS X seeds from /dev/random rather than /dev/urandom. Does it? http://www.opensource.apple.com/source/Libc/Libc-391.2.7/gen/arc4random.c says: fd = open("/dev/urandom", O_RDONLY, 0); Perhaps that code is out of date? 350240 4 abarth 2011-02-11 23:27:58 -0800 In either case, my understanding is that this statement from wikipedia is accurate: [[ A counterpart to /dev/random is /dev/urandom ("unlocked"/non-blocking random source[4]) which reuses the internal pool to produce more pseudo-random bits. This means that the call will not block, but the output may contain less entropy than the corresponding read from /dev/random. While it is still intended as a pseudorandom number generator suitable for most cryptographic purposes, it is not recommended for the generation of long-term cryptographic keys. ]] For our purposes, the non-blocking nature of /dev/urandom is helpful (otherwise the browser will hang). We're already re-using our entropy pool with RC4, so the net result is essentially the same. 350254 5 mrowe 2011-02-12 02:51:09 -0800 (In reply to comment #3) > > arc4random itself on Mac OS X seeds from /dev/random rather than /dev/urandom. > > Does it? > > http://www.opensource.apple.com/source/Libc/Libc-391.2.7/gen/arc4random.c says: > > fd = open("/dev/urandom", O_RDONLY, 0); > > Perhaps that code is out of date? That code is certainly out of date. Libc-391.2.7 looks to come from Mac OS X 10.4.x. The version I was looking at is basically identical to what’s in current FreeBSD (<http://svn.freebsd.org/base/head/lib/libc/gen/arc4random.c>). 350255 6 mrowe 2011-02-12 02:52:30 -0800 (In reply to comment #4) > For our purposes, the non-blocking nature of /dev/urandom is helpful (otherwise the browser will hang). We're already re-using our entropy pool with RC4, so the net result is essentially the same. If you’re convinced it’s good enough then that’s fine with me. It’s obviously makes no difference on Mac OS X which we use as both /dev/urandom and /dev/random are backed by the same device. 350306 7 commit-queue 2011-02-12 13:34:02 -0800 The commit-queue encountered the following flaky tests while processing attachment 82115: http/tests/websocket/tests/handshake-challenge-randomness.html bug 53738 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 350307 8 82115 commit-queue 2011-02-12 13:35:40 -0800 Comment on attachment 82115 Patch Clearing flags on attachment: 82115 Committed r78421: <http://trac.webkit.org/changeset/78421> 350308 9 commit-queue 2011-02-12 13:35:45 -0800 All reviewed patches have been landed. Closing bug. 350323 10 commit-queue 2011-02-12 15:05:35 -0800 The commit-queue encountered the following flaky tests while processing attachment 82115: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 82115 2011-02-11 01:47:26 -0800 2011-02-12 13:35:40 -0800 Patch bug-54279-20110211014725.patch text/plain 3107 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzgzMjUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMDItMTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgL2Rldi91cmFuZG9tIGFz IHRoZSBPU1JhbmRvbVNvdXJjZSBvbiBPUyhEQVJXSU4pCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDI3OQorCisgICAgICAgIEknbSBub3Qgc3VyZSBp dCBtYWtlcyBtdWNoIG9mIGEgZGlmZmVyZW5jZSB3aGV0aGVyIHdlIHVzZSBhcmM0cmFuZG9tIG9y CisgICAgICAgIC9kZXYvdXJhbmRvbSBvbiBNYWMuICBIb3dldmVyLCB0aGVyZSdzIHNvbWUgYWVz dGhldGljIGJlbmVmaXQgdG8gdXNpbmcKKyAgICAgICAgdGhlIHNhbWUgdW5kZXJseWluZyBBUEkg b24gYXMgbWFueSBwbGF0Zm9ybXMgYXMgcmVhc29uYWJsZS4KKworICAgICAgICAqIGNvbmZpZy5o OgorICAgICAgICAqIHd0Zi9PU1JhbmRvbVNvdXJjZS5jcHA6CisgICAgICAgIChXVEY6OmNyeXB0 b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzRnJvbU9TKToKKwogMjAxMS0wMi0xMCAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaAkocmV2aXNpb24gNzgzMjApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTU3LDcgKzU3LDcgQEAK IAogI2VuZGlmCiAKLSNpZiBPUyhEQVJXSU4pIHx8IE9TKFVOSVgpIHx8IE9TKFdJTkRPV1MpCisj aWYgT1MoVU5JWCkgfHwgT1MoV0lORE9XUykKICNkZWZpbmUgV1RGX1VTRV9PU19SQU5ET01ORVNT IDEKICNlbmRpZgogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9tU291 cmNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9t U291cmNlLmNwcAkocmV2aXNpb24gNzgzMjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L09TUmFuZG9tU291cmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQsMTggKzQ0LDEyIEBAIG5h bWVzcGFjZSBXVEYgewogI2lmIFVTRShPU19SQU5ET01ORVNTKQogdm9pZCBjcnlwdG9ncmFwaGlj YWxseVJhbmRvbVZhbHVlc0Zyb21PUyh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5n dGgpCiB7Ci0jaWYgT1MoREFSV0lOKQotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3Ro OyBpKyspIHsKLSAgICAgICAgdWludDMyX3QgYml0czsKLSAgICAgICAgYml0cyA9IGFyYzRyYW5k b20oKTsKLSAgICAgICAgYnVmZmVyW2ldID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hhcj4oYml0 cyk7Ci0gICAgfQotI2VsaWYgT1MoVU5JWCkKKyNpZiBPUyhVTklYKQogICAgIGludCBmZCA9IG9w ZW4oIi9kZXYvdXJhbmRvbSIsIE9fUkRPTkxZLCAwKTsKICAgICBpZiAoZmQgPCAwKQogICAgICAg ICBDUkFTSCgpOyAvLyBXZSBuZWVkIC9kZXYvdXJhbmRvbSBmb3IgdGhpcyBBUEkgdG8gd29yay4u LgogCi0gICAgaWYgKHJlYWQoZmQsIGJ1ZmZlciwgbGVuZ3RoKSAhPSBsZW5ndGgpCisgICAgaWYg KHJlYWQoZmQsIGJ1ZmZlciwgbGVuZ3RoKSAhPSBzdGF0aWNfY2FzdDxzc2l6ZV90PihsZW5ndGgp KQogICAgICAgICBDUkFTSCgpOwogCiAgICAgY2xvc2UoZmQpOwpJbmRleDogU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2 aXNpb24gNzgzMjUpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0xMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVz ZSAvZGV2L3VyYW5kb20gYXMgdGhlIE9TUmFuZG9tU291cmNlIG9uIE9TKERBUldJTikKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0Mjc5CisKKyAgICAg ICAgVXBkYXRlIHRoZSBpZmRlZi4gIE9TKFVOSVgpIGluY2x1ZGVzIE9TKERBUldJTiksIHNvIHRo aXMgY2hhbmdlIGlzCisgICAgICAgIHNob3VsZCBiZSBhIE5PUC4KKworICAgICAgICAqIGNvbmZp Zy5oOgorCiAyMDExLTAyLTExICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQWN0dWFsbHkgYWRkIENyeXB0by5jcHAgdG8gdGhlIFdpbmRvd3MgYnVpbGQuICBJJ20g dGVycmlibGUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jb25maWcuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9jb25maWcuaAkocmV2aXNpb24gNzgzMjEpCisrKyBTb3VyY2UvV2ViQ29y ZS9jb25maWcuaAkod29ya2luZyBjb3B5KQpAQCAtMTcxLDcgKzE3MSw3IEBACiAjZGVmaW5lIFVT RV9TWVNURU1fTUFMTE9DIDEKICNlbmRpZgogCi0jaWYgT1MoREFSV0lOKSB8fCBPUyhVTklYKSB8 fCBPUyhXSU5ET1dTKQorI2lmIE9TKFVOSVgpIHx8IE9TKFdJTkRPV1MpCiAjZGVmaW5lIFdURl9V U0VfT1NfUkFORE9NTkVTUyAxCiAjZW5kaWYKIAo=