54155 2011-02-09 17:33:40 -0800 Add randomValuesFromOS for OS(WINDOWS) 2011-02-10 07:02:44 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 54083 1 paroga paroga abarth aroben commit-queue eric webkit.review.bot oldest_to_newest 348737 0 paroga 2011-02-09 17:33:40 -0800 see patch 348742 1 81902 paroga 2011-02-09 17:38:47 -0800 Created attachment 81902 Patch 348744 2 webkit.review.bot 2011-02-09 17:40:47 -0800 Attachment 81902 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OSRandomSource.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 348748 3 81904 paroga 2011-02-09 17:55:08 -0800 Created attachment 81904 Patch (Added CRASH() for the error case) 348749 4 webkit.review.bot 2011-02-09 17:56:54 -0800 Attachment 81904 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OSRandomSource.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 348770 5 81904 abarth 2011-02-09 19:00:00 -0800 Comment on attachment 81904 Patch (Added CRASH() for the error case) Silly windows include header order dependencies. Thanks! 348972 6 81904 commit-queue 2011-02-10 05:15:40 -0800 Comment on attachment 81904 Patch (Added CRASH() for the error case) Clearing flags on attachment: 81904 Committed r78208: <http://trac.webkit.org/changeset/78208> 348973 7 commit-queue 2011-02-10 05:15:44 -0800 All reviewed patches have been landed. Closing bug. 349045 8 commit-queue 2011-02-10 07:02:44 -0800 The commit-queue encountered the following flaky tests while processing attachment 81904: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 81902 2011-02-09 17:38:47 -0800 2011-02-09 17:55:08 -0800 Patch bug-54155.patch text/plain 2400 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA4NTQyY2UuLjVhOTM3ZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTAyLTA5ICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCByYW5kb21WYWx1ZXNGcm9tT1MgZm9yIE9TKFdJTkRPV1Mp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDE1NQor CisgICAgICAgIFVzZSBDcnlwdEdlblJhbmRvbSBmb3IgZ2VuZXJhdGluZyBjcnlwdG9ncmFwaGlj YWxseSBzZWN1cmUgcmFuZG9tIG51bWJlcnMuCisgICAgICAgIFRoaXMgd2lsbCB3b3JrIG9uIFdp bkNFIGFuZCBNaW5HVyB0b28uCisKKyAgICAgICAgKiBjb25maWcuaDoKKyAgICAgICAgKiB3dGYv T1NSYW5kb21Tb3VyY2UuY3BwOgorICAgICAgICAoV1RGOjpyYW5kb21WYWx1ZXNGcm9tT1MpOgor CiAyMDExLTAyLTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QW5vdGhlciBhdHRlbXB0IHRvIGZpeCB0aGUgUXQgV2luZG93cyBidWlsZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9j b25maWcuaAppbmRleCBmM2FkNmJjLi5mMzFlYWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvY29uZmlnLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oCkBA IC01MiwxNSArNTIsMTIgQEAKIC8vIFdlIG5lZWQgdG8gZGVmaW5lIHRoaXMgYmVmb3JlIHRoZSBm aXJzdCAjaW5jbHVkZSBvZiBzdGRsaWIuaCBvciBpdCB3b24ndCBjb250YWluIHJhbmRfcy4KICNp Zm5kZWYgX0NSVF9SQU5EX1MKICNkZWZpbmUgX0NSVF9SQU5EX1MKLSNpZiBDT01QSUxFUihNU1ZD KQotI2RlZmluZSBXVEZfVVNFX09TX1JBTkRPTU5FU1MgMQotI2VuZGlmCiAjZW5kaWYKICNlbmRp ZgogCiAjZW5kaWYKIAotI2lmIE9TKERBUldJTikgfHwgT1MoVU5JWCkKKyNpZiBPUyhEQVJXSU4p IHx8IE9TKFVOSVgpIHx8IE9TKFdJTkRPV1MpCiAjZGVmaW5lIFdURl9VU0VfT1NfUkFORE9NTkVT UyAxCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9PU1Jh bmRvbVNvdXJjZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9tU291cmNl LmNwcAppbmRleCA0M2FkYTQ2Li4yYWJkNzZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL09TUmFuZG9tU291cmNlLmNwcApAQCAtMzQsNiArMzQsMTEgQEAKICNpbmNsdWRlIDx1bmlz dGQuaD4KICNlbmRpZgogCisjaWYgT1MoV0lORE9XUykKKyNpbmNsdWRlIDx3aW5kb3dzLmg+Cisj aW5jbHVkZSA8d2luY3J5cHQuaD4gLy8gd2luZG93cy5oIG11c3QgYmUgaW5jbHVkZWQgYmVmb3Jl IHdpbmNyeXB0LmguCisjZW5kaWYKKwogbmFtZXNwYWNlIFdURiB7CiAKICNpZiBVU0UoT1NfUkFO RE9NTkVTUykKQEAgLTUyLDEyICs1NywxMSBAQCB2b2lkIHJhbmRvbVZhbHVlc0Zyb21PUyh1bnNp Z25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCiAKICAgICByZWFkKGZkLCBidWZmZXIs IGxlbmd0aCk7CiAgICAgY2xvc2UoZmQpOwotI2VsaWYgQ09NUElMRVIoTVNWQykKLSAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgIHVpbnQzMl90IGJpdHM7 Ci0gICAgICAgIHJhbmRfcygmYml0cyk7Ci0gICAgICAgIGJ1ZmZlcltpXSA9IHN0YXRpY19jYXN0 PHVuc2lnbmVkIGNoYXI+KGJpdHMpOwotICAgIH0KKyNlbGlmIE9TKFdJTkRPV1MpCisgICAgSENS WVBUUFJPViBoUHJvdiA9IDA7CisgICAgQ3J5cHRBY3F1aXJlQ29udGV4dCgmaFByb3YsIDAsIE1T X0RFRl9QUk9WLCBQUk9WX1JTQV9GVUxMLCBDUllQVF9WRVJJRllDT05URVhUKTsKKyAgICBDcnlw dEdlblJhbmRvbShoUHJvdiwgbGVuZ3RoLCBidWZmZXIpOworICAgIENyeXB0UmVsZWFzZUNvbnRl eHQoaFByb3YsIDApOwogI2Vsc2UKICAgICAjZXJyb3IgIlRoaXMgY29uZmlndXJhdGlvbiBkb2Vz bid0IGhhdmUgYSBzdHJvbmcgc291cmNlIG9mIHJhbmRvbW5lc3MuIgogICAgIC8vIFdBUk5JTkc6 IFdoZW4gYWRkaW5nIG5ldyBzb3VyY2VzIG9mIE9TIHJhbmRvbW5lc3MsIHRoZSByYW5kb21uZXNz IG11c3QK 81904 2011-02-09 17:55:08 -0800 2011-02-10 05:15:39 -0800 Patch (Added CRASH() for the error case) bug-54155.patch text/plain 2465 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA4NTQyY2UuLjVhOTM3ZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTAyLTA5ICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCByYW5kb21WYWx1ZXNGcm9tT1MgZm9yIE9TKFdJTkRPV1Mp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDE1NQor CisgICAgICAgIFVzZSBDcnlwdEdlblJhbmRvbSBmb3IgZ2VuZXJhdGluZyBjcnlwdG9ncmFwaGlj YWxseSBzZWN1cmUgcmFuZG9tIG51bWJlcnMuCisgICAgICAgIFRoaXMgd2lsbCB3b3JrIG9uIFdp bkNFIGFuZCBNaW5HVyB0b28uCisKKyAgICAgICAgKiBjb25maWcuaDoKKyAgICAgICAgKiB3dGYv T1NSYW5kb21Tb3VyY2UuY3BwOgorICAgICAgICAoV1RGOjpyYW5kb21WYWx1ZXNGcm9tT1MpOgor CiAyMDExLTAyLTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QW5vdGhlciBhdHRlbXB0IHRvIGZpeCB0aGUgUXQgV2luZG93cyBidWlsZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9j b25maWcuaAppbmRleCBmM2FkNmJjLi5mMzFlYWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvY29uZmlnLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oCkBA IC01MiwxNSArNTIsMTIgQEAKIC8vIFdlIG5lZWQgdG8gZGVmaW5lIHRoaXMgYmVmb3JlIHRoZSBm aXJzdCAjaW5jbHVkZSBvZiBzdGRsaWIuaCBvciBpdCB3b24ndCBjb250YWluIHJhbmRfcy4KICNp Zm5kZWYgX0NSVF9SQU5EX1MKICNkZWZpbmUgX0NSVF9SQU5EX1MKLSNpZiBDT01QSUxFUihNU1ZD KQotI2RlZmluZSBXVEZfVVNFX09TX1JBTkRPTU5FU1MgMQotI2VuZGlmCiAjZW5kaWYKICNlbmRp ZgogCiAjZW5kaWYKIAotI2lmIE9TKERBUldJTikgfHwgT1MoVU5JWCkKKyNpZiBPUyhEQVJXSU4p IHx8IE9TKFVOSVgpIHx8IE9TKFdJTkRPV1MpCiAjZGVmaW5lIFdURl9VU0VfT1NfUkFORE9NTkVT UyAxCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9PU1Jh bmRvbVNvdXJjZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9tU291cmNl LmNwcAppbmRleCA0M2FkYTQ2Li4yYWJkNzZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL09TUmFuZG9tU291cmNlLmNwcApAQCAtMzQsNiArMzQsMTEgQEAKICNpbmNsdWRlIDx1bmlz dGQuaD4KICNlbmRpZgogCisjaWYgT1MoV0lORE9XUykKKyNpbmNsdWRlIDx3aW5kb3dzLmg+Cisj aW5jbHVkZSA8d2luY3J5cHQuaD4gLy8gd2luZG93cy5oIG11c3QgYmUgaW5jbHVkZWQgYmVmb3Jl IHdpbmNyeXB0LmguCisjZW5kaWYKKwogbmFtZXNwYWNlIFdURiB7CiAKICNpZiBVU0UoT1NfUkFO RE9NTkVTUykKQEAgLTUyLDEyICs1NywxMyBAQCB2b2lkIHJhbmRvbVZhbHVlc0Zyb21PUyh1bnNp Z25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCgogICAgIHJlYWQoZmQsIGJ1ZmZlciwg bGVuZ3RoKTsKICAgICBjbG9zZShmZCk7Ci0jZWxpZiBDT01QSUxFUihNU1ZDKQotICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspIHsKLSAgICAgICAgdWludDMyX3QgYml0czsK LSAgICAgICAgcmFuZF9zKCZiaXRzKTsKLSAgICAgICAgYnVmZmVyW2ldID0gc3RhdGljX2Nhc3Q8 dW5zaWduZWQgY2hhcj4oYml0cyk7Ci0gICAgfQorI2VsaWYgT1MoV0lORE9XUykKKyAgICBIQ1JZ UFRQUk9WIGhDcnlwdFByb3YgPSAwOworICAgIGlmICghQ3J5cHRBY3F1aXJlQ29udGV4dCgmaENy eXB0UHJvdiwgMCwgTVNfREVGX1BST1YsIFBST1ZfUlNBX0ZVTEwsIENSWVBUX1ZFUklGWUNPTlRF WFQpKQorICAgICAgICBDUkFTSCgpOworICAgIGlmICghQ3J5cHRHZW5SYW5kb20oaENyeXB0UHJv diwgbGVuZ3RoLCBidWZmZXIpKQorICAgICAgICBDUkFTSCgpOworICAgIENyeXB0UmVsZWFzZUNv bnRleHQoaENyeXB0UHJvdiwgMCk7CiAjZWxzZQogICAgICNlcnJvciAiVGhpcyBjb25maWd1cmF0 aW9uIGRvZXNuJ3QgaGF2ZSBhIHN0cm9uZyBzb3VyY2Ugb2YgcmFuZG9tbmVzcy4iCiAgICAgLy8g V0FSTklORzogV2hlbiBhZGRpbmcgbmV3IHNvdXJjZXMgb2YgT1MgcmFuZG9tbmVzcywgdGhlIHJh bmRvbW5lc3MgbXVzdAo=