54115 2011-02-09 10:06:37 -0800 [Chromium] Use #f7f7f7 for select popup background on chromium/linux 2011-02-09 14:47:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 xiyuan webkit-unassigned commit-queue dglazkov tony oldest_to_newest 348341 0 xiyuan 2011-02-09 10:06:37 -0800 Change the select popup background from #ddd to #f7f7f7. See also http://crosbug.com/9174. 348343 1 81827 xiyuan 2011-02-09 10:09:44 -0800 Created attachment 81827 Proposed UA css change. 348399 2 81827 tony 2011-02-09 11:17:34 -0800 Comment on attachment 81827 Proposed UA css change. Why do we need size="0" and size="1"? 348401 3 xiyuan 2011-02-09 11:22:54 -0800 (In reply to comment #2) > (From update of attachment 81827 [details]) > Why do we need size="0" and size="1"? We only want to change the popup's background but not the listbox. Select size="0"|"1" is select with popup. Other sizes would show up as listbox. The reason behind this is in http://crosbug.com/9174 @ comment 8. Web site might expect listbox background color go with the select element, something like in scrollbars/listbox-scrollbar-combinations.html. And I don't want to force them to do a "select option" rule to override UA css. 348402 4 81827 tony 2011-02-09 11:23:59 -0800 Comment on attachment 81827 Proposed UA css change. I see, I read the bug here: http://code.google.com/p/chromium-os/issues/detail?id=9174 The size="0" bit seems like a hack. Where does the color for <option> background currently come from? Can we fix it there instead? 348409 5 xiyuan 2011-02-09 11:31:17 -0800 (In reply to comment #4) > (From update of attachment 81827 [details]) > I see, I read the bug here: http://code.google.com/p/chromium-os/issues/detail?id=9174 > > The size="0" bit seems like a hack. Where does the color for <option> background currently come from? Can we fix it there instead? It comes from the CSS like other element and if not specified (99.9% of the case), it will use its parent element's, which is the select element. I have checked with Dimitry and Tab but failed to find a CSS selector that could specifically target the select popup. :( And if we change the select element, it changes both the select as a button and as a listbox. I am not sure if that is okay. 348432 6 81827 tony 2011-02-09 12:01:12 -0800 Comment on attachment 81827 Proposed UA css change. I see. It looks like html.css also uses select[size="0"] and select[size="1"] to force the menulist appearance, so this looks fine. 348435 7 81827 xiyuan 2011-02-09 12:03:13 -0800 Comment on attachment 81827 Proposed UA css change. Cool. Thanks for the quick review and checking it up. :) 348568 8 81827 commit-queue 2011-02-09 14:23:58 -0800 Comment on attachment 81827 Proposed UA css change. Clearing flags on attachment: 81827 Committed r78137: <http://trac.webkit.org/changeset/78137> 348569 9 commit-queue 2011-02-09 14:24:03 -0800 All reviewed patches have been landed. Closing bug. 348598 10 commit-queue 2011-02-09 14:47:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 81827: http/tests/websocket/tests/handshake-fail-by-cross-origin.html bug 54147 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 81827 2011-02-09 10:09:44 -0800 2011-02-09 14:23:58 -0800 Proposed UA css change. webkit_54115.patch text/plain 1058 xiyuan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MDc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDkgIFhpeXVhbiBY aWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gVXNlICNmN2Y3ZjcgZm9yIHNlbGVjdCBwb3B1 cCBiYWNrZ3JvdW5kIG9uIGNocm9taXVtL2xpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDExNQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5j ZSBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBjc3MvdGhlbWVDaHJvbWl1bUxpbnV4 LmNzczoKKyAgICAgICAgKHNlbGVjdFtzaXplPSIxIl0gb3B0aW9uKToKKwogMjAxMS0wMi0wOCAg RGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL3RoZW1lQ2hyb21p dW1MaW51eC5jc3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3RoZW1lQ2hyb21p dW1MaW51eC5jc3MJKHJldmlzaW9uIDc4MDc0KQorKysgU291cmNlL1dlYkNvcmUvY3NzL3RoZW1l Q2hyb21pdW1MaW51eC5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTM0LDMgKzM0LDggQEAgc2VsZWN0 IHsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiAjZGRkZGRkOwogICAgIGJvcmRlcjogMHB4OwogfQor CitzZWxlY3Rbc2l6ZT0iMCJdIG9wdGlvbiwKK3NlbGVjdFtzaXplPSIxIl0gb3B0aW9uIHsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiAjZjdmN2Y3OworfQo=