54095 2011-02-09 06:34:20 -0800 [GTK] Implement Module class for WebKit2 2011-02-09 09:54:58 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 52805 1 alex webkit-unassigned amruthraj oldest_to_newest 348184 0 alex 2011-02-09 06:34:20 -0800 Add the Module handle for GTK. 348185 1 81798 alex 2011-02-09 06:35:00 -0800 Created attachment 81798 Proposed patch 348257 2 81798 mrobinson 2011-02-09 08:39:33 -0800 Comment on attachment 81798 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81798&action=review > Source/WebKit2/ChangeLog:5 > + Based on patch by Amruth Raj and Ravi Phaneendra Kasibhatla. Better move these guys to the author line as well. 348314 3 alex 2011-02-09 09:37:26 -0800 (In reply to comment #2) > (From update of attachment 81798 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81798&action=review > > > Source/WebKit2/ChangeLog:5 > > + Based on patch by Amruth Raj and Ravi Phaneendra Kasibhatla. > > Better move these guys to the author line as well. Yep, I'll do it. Thanks for pointing it. 348333 4 alex 2011-02-09 09:54:58 -0800 Landed http://trac.webkit.org/changeset/78072 81798 2011-02-09 06:35:00 -0800 2011-02-09 08:39:33 -0800 Proposed patch module.patch text/plain 4827 alex Y29tbWl0IDBhNWZjYzIzYWZhNmQ3NTYzMmZlMDYyMzVmOWZmYzgyZDA2ZTgxMTcKQXV0aG9yOiBB bGVqYW5kcm8gRy4gQ2FzdHJvIDxhbGV4QGlnYWxpYS5jb20+CkRhdGU6ICAgRnJpIEphbiAyMSAx MjoxNToxMSAyMDExICswMTAwCgogICAgMjAxMS0wMi0wNyAgQWxlamFuZHJvIEcuIENhc3RybyAg PGFsZXhAaWdhbGlhLmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KICAgIAogICAgICAgICAgICBCYXNlZCBvbiBwYXRjaCBieSBBbXJ1dGggUmFqIGFuZCBS YXZpIFBoYW5lZW5kcmEgS2FzaWJoYXRsYS4KICAgIAogICAgICAgICAgICBbR1RLXSBJbXBsZW1l bnQgTW9kdWxlIGNsYXNzIGZvciBXZWJLaXQyCiAgICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODUxMAogICAgCiAgICAgICAgICAgICogR05VbWFrZWZp bGUuYW06CiAgICAgICAgICAgICogUGxhdGZvcm0vTW9kdWxlLmg6ICBBZGRlZCBHTW9kdWxlIGhh bmRsZSBmb3IgR1RLIHBvcnQuCiAgICAgICAgICAgICogUGxhdGZvcm0vZ3RrL01vZHVsZUd0ay5j cHA6IEluaXRpYWwgY29kZSB1c2luZyBHTW9kdWxlIGNhbGxzLgogICAgICAgICAgICAoV2ViS2l0 OjpNb2R1bGU6OmxvYWQpOgogICAgICAgICAgICAoV2ViS2l0OjpNb2R1bGU6OnVubG9hZCk6CiAg ICAgICAgICAgIChXZWJLaXQ6Ok1vZHVsZTo6cGxhdGZvcm1GdW5jdGlvblBvaW50ZXIpOgoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwppbmRleCA2Yjk2MGUzLi5kYzVmOTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTEtMDItMDcgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gcGF0 Y2ggYnkgQW1ydXRoIFJhaiBhbmQgUmF2aSBQaGFuZWVuZHJhIEthc2liaGF0bGEuCisKKyAgICAg ICAgW0dUS10gSW1wbGVtZW50IE1vZHVsZSBjbGFzcyBmb3IgV2ViS2l0MgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg1MTAKKworICAgICAgICAqIEdO VW1ha2VmaWxlLmFtOgorICAgICAgICAqIFBsYXRmb3JtL01vZHVsZS5oOiAgQWRkZWQgR01vZHVs ZSBoYW5kbGUgZm9yIEdUSyBwb3J0LgorICAgICAgICAqIFBsYXRmb3JtL2d0ay9Nb2R1bGVHdGsu Y3BwOiBJbml0aWFsIGNvZGUgdXNpbmcgR01vZHVsZSBjYWxscy4KKyAgICAgICAgKFdlYktpdDo6 TW9kdWxlOjpsb2FkKToKKyAgICAgICAgKFdlYktpdDo6TW9kdWxlOjp1bmxvYWQpOgorICAgICAg ICAoV2ViS2l0OjpNb2R1bGU6OnBsYXRmb3JtRnVuY3Rpb25Qb2ludGVyKToKKwogMjAxMS0wMi0w OSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9HTlVt YWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCmluZGV4IGQ1OGY2YmQu LmE3YTk4NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCisrKyBi L1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCkBAIC04NCw2ICs4NCw3IEBAIGxpYldlYktp dDJfbGFfU09VUkNFUyA9IFwKIAlTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0hhbmRs ZU1lc3NhZ2UuaCBcCiAJU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9NZXNzYWdlSUQu aCBcCiAJU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9NZXNzYWdlU2VuZGVyLmggXAor CVNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Nb2R1bGVHdGsuY3BwIFwKIAlTb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9ndGsvUnVuTG9vcEd0ay5jcHAgXAogCVNvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL2d0ay9TaGFyZWRNZW1vcnlHdGsuY3BwIFwKIAlTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9n dGsvV29ya1F1ZXVlR3RrLmNwcCBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9Nb2R1bGUuaCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5oCmluZGV4IGVjNzUy M2MuLjQ3ODk5ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5oCkBAIC0zNyw2ICszNywxMCBA QAogI2luY2x1ZGUgPFFMaWJyYXJ5PgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspCit0eXBl ZGVmIHN0cnVjdCBfR01vZHVsZSBHTW9kdWxlOworI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJLaXQg ewogCiBjbGFzcyBNb2R1bGUgewpAQCAtNjIsNiArNjYsOCBAQCBwcml2YXRlOgogICAgIEhNT0RV TEUgbV9tb2R1bGU7CiAjZWxpZiBQTEFURk9STShRVCkKICAgICBRTGlicmFyeSBtX2xpYjsKKyNl bGlmIFBMQVRGT1JNKEdUSykKKyAgICBHTW9kdWxlKiBtX2hhbmRsZTsKICNlbmRpZgogfTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZ3RrL01vZHVsZUd0ay5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsvTW9kdWxlR3RrLmNwcApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi45YjAwZDIwCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vZ3RrL01vZHVsZUd0ay5jcHAKQEAgLTAsMCArMSw1NCBAQAorLyoKKyAq IENvcHlyaWdodCAoQykgMjAxMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBQ b3J0aW9ucyBDb3B5cmlnaHQgKGMpIDIwMTAgTW90b3JvbGEgTW9iaWxpdHksIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSBJZ2FsaWEgUy5MLgorICoKKyAq IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRp b25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVj ZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0 aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9u LgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRT IENPTlRSSUJVVE9SUyBgYEFTIElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdB UlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhFIElNUExJRUQg V0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5D LiBPUiBJVFMgQ09OVFJJQlVUT1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05TRVFVRU5USUFM IERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgor ICogU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBS T0ZJVFM7IE9SIEJVU0lORVNTCisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBP TiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJBQ1QsIFNUUklD VCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkK KyAqIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBF VkVOIElGIEFEVklTRUQgT0YKKyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAq LworCisjaW5jbHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiTW9kdWxlLmgiCisKKyNpbmNsdWRl IDxnbW9kdWxlLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgorCituYW1lc3BhY2Ug V2ViS2l0IHsKKworYm9vbCBNb2R1bGU6OmxvYWQoKQoreworICAgIG1faGFuZGxlID0gZ19tb2R1 bGVfb3BlbihtX3BhdGgudXRmOCgpLmRhdGEoKSwgR19NT0RVTEVfQklORF9MQVpZKTsKKyAgICBy ZXR1cm4gIW1faGFuZGxlOworfQorCit2b2lkIE1vZHVsZTo6dW5sb2FkKCkKK3sKKyAgICBnX21v ZHVsZV9jbG9zZShtX2hhbmRsZSk7Cit9CisKK3ZvaWQqIE1vZHVsZTo6cGxhdGZvcm1GdW5jdGlv blBvaW50ZXIoY29uc3QgY2hhciogZnVuY3Rpb25OYW1lKSBjb25zdAoreworICAgIGdwb2ludGVy IHN5bWJvbCA9IDA7CisgICAgZ19tb2R1bGVfc3ltYm9sKG1faGFuZGxlLCBmdW5jdGlvbk5hbWUs ICZzeW1ib2wpOworICAgIHJldHVybiBzeW1ib2w7Cit9CisKK30K