53928 2011-02-07 10:36:28 -0800 [Mac] spatial navigation is not set to false in DumpRenderTree explicitly 2011-02-07 13:41:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 49261 1 cshu cshu abarth eric webkit.review.bot oldest_to_newest 346663 0 cshu 2011-02-07 10:36:28 -0800 The preference in DumpRenderTree (Mac version) is missing a call to [preferences setSpatialNavigationEnabled:NO]. This may cause flaky tests where spatial navigation is enabled by accident. 346670 1 81491 cshu 2011-02-07 10:47:51 -0800 Created attachment 81491 fix patch 346734 2 81491 cshu 2011-02-07 12:52:06 -0800 Comment on attachment 81491 fix patch Clearing flags on attachment: 81491 Committed r77836: <http://trac.webkit.org/changeset/77836> 346735 3 cshu 2011-02-07 12:53:16 -0800 All reviewed patches have been landed. Closing bug. 346762 4 webkit.review.bot 2011-02-07 13:21:04 -0800 http://trac.webkit.org/changeset/77836 might have broken Qt Linux Release 346774 5 cshu 2011-02-07 13:41:19 -0800 (In reply to comment #4) > http://trac.webkit.org/changeset/77836 might have broken Qt Linux Release The patch only touches one .mm file. It shouldn't break Qt builds or tests. 81491 2011-02-07 10:47:51 -0800 2011-02-07 12:52:06 -0800 fix patch 53928_1.patch text/plain 1343 cshu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc3ODI5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDItMDcgIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxk IGRpc2FibGUgc3BhdGlhbCBuYXZpZ2F0aW9uIGV4cGxpY2l0bHkgZHVyaW5nIHRoZSBpbml0aWFs aXphdGlvbgorICAgICAgICBvZiBEdW1wUmVuZGVyVHJlZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzOTI4CisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChyZXNldERlZmF1bHRzVG9Db25z aXN0ZW50VmFsdWVzKToKKwogMjAxMS0wMi0wNyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBw bGUuY29tPgogCiAgICAgICAgIE5vdCByZXZpZXdlZC4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVy VHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0JKHJldmlzaW9uIDc3ODI5KQorKysgVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NDgs NiArNDQ4LDcgQEAgc3RhdGljIHZvaWQgcmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbAogICAg IFtwcmVmZXJlbmNlcyBzZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkOk5PXTsKICAgICBbcHJlZmVy ZW5jZXMgc2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5OllFU107CiAgICAgW3ByZWZlcmVuY2Vz IHNldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQ6Tk9dOworICAgIFtwcmVmZXJlbmNlcyBzZXRTcGF0 aWFsTmF2aWdhdGlvbkVuYWJsZWQ6Tk9dOwogICAgIFtwcmVmZXJlbmNlcyBzZXRFZGl0aW5nQmVo YXZpb3I6V2ViS2l0RWRpdGluZ01hY0JlaGF2aW9yXTsKICAgICBpZiAocGVyc2lzdGVudFVzZXJT dHlsZVNoZWV0TG9jYXRpb24pIHsKICAgICAgICAgW3ByZWZlcmVuY2VzIHNldFVzZXJTdHlsZVNo ZWV0TG9jYXRpb246W05TVVJMIFVSTFdpdGhTdHJpbmc6KE5TU3RyaW5nICopKHBlcnNpc3RlbnRV c2VyU3R5bGVTaGVldExvY2F0aW9uLmdldCgpKV1dOwo=