53791 2011-02-04 10:59:11 -0800 HTMLOutputElement::childrenChanged() should call its base class childrenChanged() 2011-02-07 22:31:16 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 50916 1 yael webkit-unassigned bashi bashi commit-queue oldest_to_newest 345617 0 yael 2011-02-04 10:59:11 -0800 While working on the bug https://bugs.webkit.org/show_bug.cgi?id=50916, I noticed that this is the only element that is not calling its base class childrenChanged(). Adding code to Element::childrenChanged() will not have the desired effect on HTMLOutputElement. 346144 1 81361 bashi 2011-02-05 07:59:53 -0800 Created attachment 81361 Patch 346156 2 81361 kling 2011-02-05 10:03:43 -0800 Comment on attachment 81361 Patch r=me 346174 3 yael 2011-02-05 12:13:04 -0800 This modification actually does change behavior :) If you run the following without this change, the second alert will show 2 instead of 1. <!DOCTYPE html> <html> <head> <script> window.onload=function(){ if (window.layoutTestController) layoutTestController.dumpAsText(); var list = document.getElementsByTagName("span"); var el = document.getElementById("result"); alert("The number of spans before removal is " + list.length); document.getElementById("parentOutput").removeChild(document.getElementById("first")); alert("The number of spans after removal is " + list.length); } </script> </head> <body> <output id="parentOutput"><span class="first" id="first"></span><span class="second" id="second"></span></output> <br> Test that a live list is updated after the child of an HTMLOutputElement was removed. <br> <div id="result"></div> </body> </html> 346263 4 81361 kling 2011-02-06 05:15:26 -0800 Comment on attachment 81361 Patch @Yael: Ah, beautiful! Let's add a test for it. 346418 5 81436 bashi 2011-02-06 17:56:56 -0800 Created attachment 81436 Patch V2 346419 6 bashi 2011-02-06 18:00:44 -0800 (In reply to comment #5) > Created an attachment (id=81436) [details] > Patch V2 Thank you guys for review and correcting my misunderstanding. I've added a test. Thanks! 346918 7 81436 bashi 2011-02-07 16:07:27 -0800 Comment on attachment 81436 Patch V2 Thank you for review. Could someone cq+? 347111 8 81436 commit-queue 2011-02-07 22:31:13 -0800 Comment on attachment 81436 Patch V2 Clearing flags on attachment: 81436 Committed r77902: <http://trac.webkit.org/changeset/77902> 347112 9 commit-queue 2011-02-07 22:31:16 -0800 All reviewed patches have been landed. Closing bug. 81361 2011-02-05 07:59:53 -0800 2011-02-06 17:56:51 -0800 Patch bug-53791-20110206005951.patch text/plain 1923 bashi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYjU0YjkyMDhmNTQ2OWVkY2U2MDBlYWM2NTE3ZWI1MzU2ZDliOTljLi5i YTc4N2NiMWZkZTVmMDg3MDA5ZDcxNjA3ZDNjOTZhYjAyZWE2NDQ0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTEtMDItMDUgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEhUTUxPdXRwdXRFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoKSBzaG91bGQgY2FsbCBpdHMgYmFz ZSBjbGFzcyBjaGlsZHJlbkNoYW5nZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTM3OTEKKworICAgICAgICBDYWxscyBIVE1MRm9ybUNvbnRyb2xF bGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoKSBpbiBIVE1MT3V0cHV0RWxlbWVudDo6Y2hpbGRyZW5D aGFuZ2VkKCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoaXMgbW9kaWZpY2F0aW9u IHdvdWxkbid0IGNoYW5nZSBhbnkgYmVoYXZpb3IuCisKKyAgICAgICAgKiBodG1sL0hUTUxPdXRw dXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxPdXRwdXRFbGVtZW50OjpjaGls ZHJlbkNoYW5nZWQpOiBDYWxscyBzdXBlciBjbGFzcydzCisgICAgICAgIGNoaWxkcmVuQ2hhbmdl ZCgpLgorCiAyMDExLTAyLTAzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQXR0ZW1wdCB0byBmaXggQ2hyb21pdW0gYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxPdXRwdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE91dHB1dEVsZW1lbnQuY3BwCmluZGV4IDJmMWQ0OTAxZDExZDYzOGY3OTE0YzJiNmIxM2Yx NGJlYzE1MmZlMzIuLjhiZTVkOTExYzA3OTg0NjJjNTU0MDc2YzM2OTk5MzI4ZDhmMzhhYzEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVsZW1lbnQuY3BwCkBAIC03NCw3ICs3NCw3 IEBAIHZvaWQgSFRNTE91dHB1dEVsZW1lbnQ6OnNldEZvcihjb25zdCBTdHJpbmcmIHZhbHVlKQog ICAgIG1fdG9rZW5zLT5zZXRWYWx1ZSh2YWx1ZSk7CiB9CiAKLXZvaWQgSFRNTE91dHB1dEVsZW1l bnQ6OmNoaWxkcmVuQ2hhbmdlZChib29sIGNyZWF0ZWRCeVBhcnNlciwgTm9kZSosIE5vZGUqLCBp bnQpCit2b2lkIEhUTUxPdXRwdXRFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoYm9vbCBjcmVhdGVk QnlQYXJzZXIsIE5vZGUqIGJlZm9yZUNoYW5nZSwgTm9kZSogYWZ0ZXJDaGFuZ2UsIGludCBjaGls ZENvdW50RGVsdGEpCiB7CiAgICAgaWYgKGNyZWF0ZWRCeVBhcnNlciB8fCBtX2lzU2V0VGV4dENv bnRlbnRJblByb2dyZXNzKSB7CiAgICAgICAgIG1faXNTZXRUZXh0Q29udGVudEluUHJvZ3Jlc3Mg PSBmYWxzZTsKQEAgLTgzLDYgKzgzLDcgQEAgdm9pZCBIVE1MT3V0cHV0RWxlbWVudDo6Y2hpbGRy ZW5DaGFuZ2VkKGJvb2wgY3JlYXRlZEJ5UGFyc2VyLCBOb2RlKiwgTm9kZSosIGludCkKIAogICAg IGlmIChtX2lzRGVmYXVsdFZhbHVlTW9kZSkKICAgICAgICAgbV9kZWZhdWx0VmFsdWUgPSB0ZXh0 Q29udGVudCgpOworICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChj cmVhdGVkQnlQYXJzZXIsIGJlZm9yZUNoYW5nZSwgYWZ0ZXJDaGFuZ2UsIGNoaWxkQ291bnREZWx0 YSk7CiB9CiAKIHZvaWQgSFRNTE91dHB1dEVsZW1lbnQ6OnJlc2V0KCkK 81436 2011-02-06 17:56:56 -0800 2011-02-07 22:31:13 -0800 Patch V2 bug-53791-20110207105654.patch text/plain 4911 bashi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwYzBkZDBlZGQ0MmI0NjcxZGFkYjIxZWRjZmMwYTY1ZWNmYmEzZWE0Li5mMGRlZjgz MzEyNzlmMTA4OGY5Yzg3NzQwOTViZTExNTQzOWU4YjhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDItMDYgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIVE1MT3V0cHV0RWxl bWVudDo6Y2hpbGRyZW5DaGFuZ2VkKCkgc2hvdWxkIGNhbGwgaXRzIGJhc2UgY2xhc3MgY2hpbGRy ZW5DaGFuZ2VkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUzNzkxCisKKyAgICAgICAgVGVzdCB0aGF0IGEgbGl2ZSBsaXN0IGlzIHVwZGF0ZWQgYWZ0 ZXIgdGhlIGNoaWxkIG9mIGFuIEhUTUxPdXRwdXRFbGVtZW50IHdhcyByZW1vdmVkLgorCisgICAg ICAgICogZmFzdC9kb20vSFRNTE91dHB1dEVsZW1lbnQvaHRtbG91dHB1dGVsZW1lbnQtY2hpbGRy ZW4tcmVtb3ZlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxP dXRwdXRFbGVtZW50L2h0bWxvdXRwdXRlbGVtZW50LWNoaWxkcmVuLXJlbW92ZWQuaHRtbDogQWRk ZWQuCisKIDIwMTEtMDItMDYgIERvbWluaWMgQ29vbmV5ICA8ZG9taW5pY2NAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2RvbS9IVE1MT3V0cHV0RWxlbWVudC9odG1sb3V0cHV0ZWxlbWVudC1jaGls ZHJlbi1yZW1vdmVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxPdXRw dXRFbGVtZW50L2h0bWxvdXRwdXRlbGVtZW50LWNoaWxkcmVuLXJlbW92ZWQtZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjYxYjMxNWRmY2ExOWY5YmUzOWNiNzU3MzMzOTk0ZjEwMmE1MzU4ZDQKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MT3V0cHV0RWxlbWVudC9o dG1sb3V0cHV0ZWxlbWVudC1jaGlsZHJlbi1yZW1vdmVkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDEyIEBACitUZXN0IHRoYXQgYSBsaXZlIGxpc3QgaXMgdXBkYXRlZCBhZnRlciB0aGUgY2hpbGQg b2YgYW4gSFRNTE91dHB1dEVsZW1lbnQgd2FzIHJlbW92ZWQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KKworCitUaGUgbnVtYmVyIG9mIHNwYW5zIGJlZm9yZSByZW1vdmFsIGlzIDIKK1Ro ZSBudW1iZXIgb2Ygc3BhbnMgYWZ0ZXIgcmVtb3ZhbCBpcyAxCitQQVNTIGxpc3QubGVuZ3RoID09 IGJlZm9yZUxlbmd0aCAtIDEgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hU TUxPdXRwdXRFbGVtZW50L2h0bWxvdXRwdXRlbGVtZW50LWNoaWxkcmVuLXJlbW92ZWQuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxPdXRwdXRFbGVtZW50L2h0bWxvdXRwdXRlbGVtZW50 LWNoaWxkcmVuLXJlbW92ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41YjRhNTVhMjc0OWM2YTkyYmIyNDk4 ZmVhZjk0OWViMmU0NDQ5ZDJkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9k b20vSFRNTE91dHB1dEVsZW1lbnQvaHRtbG91dHB1dGVsZW1lbnQtY2hpbGRyZW4tcmVtb3ZlZC5o dG1sCkBAIC0wLDAgKzEsMjQgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hl ZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdCB0aGF0IGEgbGl2ZSBsaXN0IGlzIHVw ZGF0ZWQgYWZ0ZXIgdGhlIGNoaWxkIG9mIGFuIEhUTUxPdXRwdXRFbGVtZW50IHdhcyByZW1vdmVk LicpOworPC9zY3JpcHQ+Cis8b3V0cHV0IGlkPSJwYXJlbnRPdXRwdXQiPjxzcGFuIGNsYXNzPSJp bm5lciIgaWQ9ImZpcnN0Ij48L3NwYW4+PHNwYW4gY2xhc3M9ImlubmVyIiBpZD0ic2Vjb25kIj48 L3NwYW4+PC9vdXRwdXQ+Cis8c2NyaXB0PgorICAgIHZhciBsaXN0ID0gZG9jdW1lbnQuZ2V0RWxl bWVudHNCeUNsYXNzTmFtZSgiaW5uZXIiKTsKKyAgICBkZWJ1ZygiVGhlIG51bWJlciBvZiBzcGFu cyBiZWZvcmUgcmVtb3ZhbCBpcyAiICsgbGlzdC5sZW5ndGgpOworICAgIHZhciBiZWZvcmVMZW5n dGggPSBsaXN0Lmxlbmd0aDsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGFyZW50T3V0 cHV0IikucmVtb3ZlQ2hpbGQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZpcnN0IikpOworICAg IGRlYnVnKCJUaGUgbnVtYmVyIG9mIHNwYW5zIGFmdGVyIHJlbW92YWwgaXMgIiArIGxpc3QubGVu Z3RoKTsKKyAgICBzaG91bGRCZVRydWUoJ2xpc3QubGVuZ3RoID09IGJlZm9yZUxlbmd0aCAtIDEn KTsKKyAgICB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlw dCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDAyMDM5MjExNTNlMDBlYTgwMzc0YWNmMTRmZWIw NzNmOGM2ZGQzOTIuLjBlZjg3NmJiMDE5YmZkNGU5ZmZlMjI3MjRjOGNlMmNiNzE2ZGI5Y2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wMi0wNiAgS2VuaWNoaSBJc2hpYmFzaGkg IDxiYXNoaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSFRNTE91dHB1dEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZCgpIHNob3Vs ZCBjYWxsIGl0cyBiYXNlIGNsYXNzIGNoaWxkcmVuQ2hhbmdlZCgpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc5MQorCisgICAgICAgIENhbGxzIEhU TUxGb3JtQ29udHJvbEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZCgpIGluIEhUTUxPdXRwdXRFbGVt ZW50OjpjaGlsZHJlbkNoYW5nZWQoKS4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MT3V0 cHV0RWxlbWVudC9odG1sb3V0cHV0ZWxlbWVudC1jaGlsZHJlbi1yZW1vdmVkLmh0bWwKKworICAg ICAgICAqIGh0bWwvSFRNTE91dHB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TE91dHB1dEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZCk6IENhbGxzIHN1cGVyIGNsYXNzJ3MKKyAg ICAgICAgY2hpbGRyZW5DaGFuZ2VkKCkuCisKIDIwMTEtMDItMDMgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPdXRwdXRFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVsZW1lbnQuY3BwCmluZGV4IDJmMWQ0 OTAxZDExZDYzOGY3OTE0YzJiNmIxM2YxNGJlYzE1MmZlMzIuLjhiZTVkOTExYzA3OTg0NjJjNTU0 MDc2YzM2OTk5MzI4ZDhmMzhhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE91dHB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE91dHB1dEVs ZW1lbnQuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgSFRNTE91dHB1dEVsZW1lbnQ6OnNldEZv cihjb25zdCBTdHJpbmcmIHZhbHVlKQogICAgIG1fdG9rZW5zLT5zZXRWYWx1ZSh2YWx1ZSk7CiB9 CiAKLXZvaWQgSFRNTE91dHB1dEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChib29sIGNyZWF0ZWRC eVBhcnNlciwgTm9kZSosIE5vZGUqLCBpbnQpCit2b2lkIEhUTUxPdXRwdXRFbGVtZW50OjpjaGls ZHJlbkNoYW5nZWQoYm9vbCBjcmVhdGVkQnlQYXJzZXIsIE5vZGUqIGJlZm9yZUNoYW5nZSwgTm9k ZSogYWZ0ZXJDaGFuZ2UsIGludCBjaGlsZENvdW50RGVsdGEpCiB7CiAgICAgaWYgKGNyZWF0ZWRC eVBhcnNlciB8fCBtX2lzU2V0VGV4dENvbnRlbnRJblByb2dyZXNzKSB7CiAgICAgICAgIG1faXNT ZXRUZXh0Q29udGVudEluUHJvZ3Jlc3MgPSBmYWxzZTsKQEAgLTgzLDYgKzgzLDcgQEAgdm9pZCBI VE1MT3V0cHV0RWxlbWVudDo6Y2hpbGRyZW5DaGFuZ2VkKGJvb2wgY3JlYXRlZEJ5UGFyc2VyLCBO b2RlKiwgTm9kZSosIGludCkKIAogICAgIGlmIChtX2lzRGVmYXVsdFZhbHVlTW9kZSkKICAgICAg ICAgbV9kZWZhdWx0VmFsdWUgPSB0ZXh0Q29udGVudCgpOworICAgIEhUTUxGb3JtQ29udHJvbEVs ZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChjcmVhdGVkQnlQYXJzZXIsIGJlZm9yZUNoYW5nZSwgYWZ0 ZXJDaGFuZ2UsIGNoaWxkQ291bnREZWx0YSk7CiB9CiAKIHZvaWQgSFRNTE91dHB1dEVsZW1lbnQ6 OnJlc2V0KCkK