53775 2011-02-04 09:29:00 -0800 Web Inspector: "Reveal in elements panel" does not always work. 2011-02-07 04:34:25 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth apavlov bweinstein commit-queue eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 345530 0 pfeldman 2011-02-04 09:29:00 -0800 If there is a current search query, panel switching schedules a search. As a result, revealed element can be lost is favor of the current search result. 345536 1 81231 pfeldman 2011-02-04 09:32:10 -0800 Created attachment 81231 [PATCH] Proposed change. 346531 2 81231 commit-queue 2011-02-07 03:26:38 -0800 Comment on attachment 81231 [PATCH] Proposed change. Clearing flags on attachment: 81231 Committed r77800: <http://trac.webkit.org/changeset/77800> 346532 3 commit-queue 2011-02-07 03:26:43 -0800 All reviewed patches have been landed. Closing bug. 346539 4 webkit.review.bot 2011-02-07 04:12:37 -0800 http://trac.webkit.org/changeset/77800 might have broken Leopard Intel Release (Tests) The following tests are not passing: platform/mac/fast/AppleScript/date.html 346543 5 commit-queue 2011-02-07 04:34:25 -0800 The commit-queue encountered the following flaky tests while processing attachment 81231: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 81231 2011-02-04 09:32:10 -0800 2011-02-07 03:26:38 -0800 [PATCH] Proposed change. reveal text/plain 6137 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NjE2MTk3Li5kYzM3YTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg QEAKIDIwMTEtMDItMDQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogIlJldmVhbCBpbiBlbGVtZW50cyBwYW5lbCIgZG9lcyBub3QgYWx3YXlzIHdvcmsuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc3NQorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5Db25zb2xlVmlldyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9D b250ZXh0TWVudS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db250ZXh0TWVudS5wcm90b3R5 cGUuc2hvdyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlLnN3aXRjaFRv QW5kRm9jdXMpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0 bGluZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3Rv dHlwZS5fY29udGV4dE1lbnVFdmVudEZpcmVkLmZvY3VzRWxlbWVudCk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5cGUuX2NvbnRleHRNZW51RXZlbnRG aXJlZCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2Vj dGlvbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RQcm9wZXJ0eVRyZWVFbGVtZW50 LnByb3RvdHlwZS51cGRhdGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9iamVjdFByb3BlcnR5 VHJlZUVsZW1lbnQucHJvdG90eXBlLl9jb250ZXh0TWVudUV2ZW50RmlyZWQpOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LmNhbmNlbFNlYXJjaCk6CisKKzIwMTEtMDItMDQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3JrIHBhbmVsIGZpbHRlcmluZyBpcyBicm9rZW4u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVW aWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5q cwppbmRleCBlMGI3ZDFhLi4zNWQxZWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTg5LDcgKzg5LDcgQEAgV2ViSW5zcGVj dG9yLkNvbnNvbGVWaWV3ID0gZnVuY3Rpb24oZHJhd2VyKQogICAgIHRoaXMuZmlsdGVyKHRoaXMu YWxsRWxlbWVudCwgZmFsc2UpOwogICAgIHRoaXMuX3JlZ2lzdGVyU2hvcnRjdXRzKCk7CiAKLSAg ICB0aGlzLm1lc3NhZ2VzRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRo aXMuX2hhbmRsZUNvbnRleHRNZW51RXZlbnQuYmluZCh0aGlzKSwgdHJ1ZSk7CisgICAgdGhpcy5t ZXNzYWdlc0VsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0aGlzLl9oYW5k bGVDb250ZXh0TWVudUV2ZW50LmJpbmQodGhpcyksIGZhbHNlKTsKIAogICAgIHRoaXMuX2N1c3Rv bUZvcm1hdHRlcnMgPSB7CiAgICAgICAgICJvYmplY3QiOiB0aGlzLl9mb3JtYXRvYmplY3QsCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnRleHRNZW51 LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db250ZXh0TWVudS5qcwpp bmRleCA0NzA0NWEyLi41ODgxMGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0NvbnRleHRNZW51LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29udGV4dE1lbnUuanMKQEAgLTQ0LDYgKzQ0LDcgQEAgV2ViSW5zcGVjdG9y LkNvbnRleHRNZW51LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5fY29u dGV4dE1lbnUgPSB0aGlzOwogICAgICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnNob3dD b250ZXh0TWVudShldmVudCwgdGhpcy5faXRlbXMpOwogICAgICAgICB9CisgICAgICAgIGV2ZW50 LnN0b3BQcm9wYWdhdGlvbigpOwogICAgIH0sCiAKICAgICBhcHBlbmRJdGVtOiBmdW5jdGlvbihs YWJlbCwgaGFuZGxlciwgZGlzYWJsZWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggMDk0ZjIwOS4uZTZhZjkzYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5l bC5qcwpAQCAtMjYxLDYgKzI2MSwxNCBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90 b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKKyAgICBzd2l0Y2hUb0Fu ZEZvY3VzOiBmdW5jdGlvbihub2RlKQorICAgIHsKKyAgICAgICAgLy8gUmVzZXQgc2VhcmNoIHJl c3RvcmUuCisgICAgICAgIFdlYkluc3BlY3Rvci5jYW5jZWxTZWFyY2goKTsKKyAgICAgICAgV2Vi SW5zcGVjdG9yLmN1cnJlbnRQYW5lbCA9IHRoaXM7CisgICAgICAgIHRoaXMuZm9jdXNlZERPTU5v ZGUgPSBub2RlOworICAgIH0sCisKICAgICBfdXBkYXRlTWF0Y2hlc0NvdW50OiBmdW5jdGlvbigp CiAgICAgewogICAgICAgICBXZWJJbnNwZWN0b3IudXBkYXRlU2VhcmNoTWF0Y2hlc0NvdW50KHRo aXMuX3NlYXJjaFJlc3VsdHMubGVuZ3RoLCB0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwppbmRleCA3 MjJjMDI4Li41NmMzZTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC0yNjgsOCArMjY4LDcgQEAg V2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUucHJvdG90eXBlID0gewogICAgICAgICBp ZiAodGhpcy5zaG93SW5FbGVtZW50c1BhbmVsRW5hYmxlZCkgewogICAgICAgICAgICAgZnVuY3Rp b24gZm9jdXNFbGVtZW50KCkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBXZWJJbnNw ZWN0b3IuY3VycmVudFBhbmVsID0gV2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50czsKLSAgICAg ICAgICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRzLmZvY3VzZWRET01Ob2RlID0g bGlzdEl0ZW0udHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3Q7CisgICAgICAgICAgICAgICAg V2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50cy5zd2l0Y2hUb0FuZEZvY3VzKGxpc3RJdGVtLnRy ZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0KTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSZXZlYWwgaW4g RWxlbWVudHMgUGFuZWwiKSwgZm9jdXNFbGVtZW50LmJpbmQodGhpcykpOwogICAgICAgICB9IGVs c2UgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmpl Y3RQcm9wZXJ0aWVzU2VjdGlvbi5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMKaW5kZXggMjY4M2QwOS4uODhmZGRkNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0 aWVzU2VjdGlvbi5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09i amVjdFByb3BlcnRpZXNTZWN0aW9uLmpzCkBAIC0xOTQsNyArMTk0LDcgQEAgV2ViSW5zcGVjdG9y Lk9iamVjdFByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhp cy5wcm9wZXJ0eS52YWx1ZS50eXBlKQogICAgICAgICAgICAgdGhpcy52YWx1ZUVsZW1lbnQuYWRk U3R5bGVDbGFzcygiY29uc29sZS1mb3JtYXR0ZWQtIiArIHRoaXMucHJvcGVydHkudmFsdWUudHlw ZSk7CiAgICAgICAgIGlmICh0aGlzLnByb3BlcnR5LnZhbHVlLnR5cGUgPT09ICJub2RlIikKLSAg ICAgICAgICAgIHRoaXMudmFsdWVFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51 IiwgdGhpcy5fY29udGV4dE1lbnVFdmVudEZpcmVkLmJpbmQodGhpcyksIHRydWUpOworICAgICAg ICAgICAgdGhpcy52YWx1ZUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0 aGlzLl9jb250ZXh0TWVudUV2ZW50RmlyZWQuYmluZCh0aGlzKSwgZmFsc2UpOwogCiAgICAgICAg IHRoaXMubGlzdEl0ZW1FbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAKQEAgLTIwOSw4ICsyMDks NyBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7 CiAgICAgICAgIGZ1bmN0aW9uIHNlbGVjdE5vZGUobm9kZUlkKQogICAgICAgICB7CiAgICAgICAg ICAgICBpZiAobm9kZUlkKSB7Ci0gICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmN1cnJlbnRQ YW5lbCA9IFdlYkluc3BlY3Rvci5wYW5lbHMuZWxlbWVudHM7Ci0gICAgICAgICAgICAgICAgV2Vi SW5zcGVjdG9yLnBhbmVscy5lbGVtZW50cy5mb2N1c2VkRE9NTm9kZSA9IFdlYkluc3BlY3Rvci5k b21BZ2VudC5ub2RlRm9ySWQobm9kZUlkKTsKKyAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iu cGFuZWxzLmVsZW1lbnRzLnN3aXRjaFRvQW5kRm9jdXMoV2ViSW5zcGVjdG9yLmRvbUFnZW50Lm5v ZGVGb3JJZChub2RlSWQpKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IDJiMjI5MTku LmU5NmQ2YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv aW5zcGVjdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzCkBAIC0xNTQ1LDYgKzE1NDUsMTIgQEAgV2ViSW5zcGVjdG9yLnBlcmZvcm1TZWFy Y2ggPSBmdW5jdGlvbihldmVudCkKICAgICB0aGlzLmRvUGVyZm9ybVNlYXJjaChldmVudC50YXJn ZXQudmFsdWUsIGZvcmNlU2VhcmNoLCBldmVudC5zaGlmdEtleSwgZmFsc2UpOwogfQogCitXZWJJ bnNwZWN0b3IuY2FuY2VsU2VhcmNoID0gZnVuY3Rpb24oKQoreworICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJzZWFyY2giKS52YWx1ZSA9ICIiOworICAgIHRoaXMuZG9QZXJmb3JtU2VhcmNo KCIiKTsKK30KKwogV2ViSW5zcGVjdG9yLmRvUGVyZm9ybVNlYXJjaCA9IGZ1bmN0aW9uKHF1ZXJ5 LCBmb3JjZVNlYXJjaCwgaXNCYWNrd2FyZFNlYXJjaCwgcmVwZWF0U2VhcmNoKQogewogICAgIHZh ciBpc1Nob3J0U2VhcmNoID0gKHF1ZXJ5Lmxlbmd0aCA8IDMpOwo=