53538 2011-02-01 15:18:26 -0800 REGRESSION(r77297): caused leopard crashes (Requested by paroga on #webkit). 2011-02-03 22:38:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 50516 1 webkit.review.bot webkit.review.bot darin ggaren jschuh paroga oldest_to_newest 343587 0 webkit.review.bot 2011-02-01 15:18:26 -0800 http://trac.webkit.org/changeset/77297 broke the build: caused leopard crashes (Requested by paroga on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 343588 1 80836 webkit.review.bot 2011-02-01 15:18:47 -0800 Created attachment 80836 ROLLOUT of r77297 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 343596 2 paroga 2011-02-01 15:33:13 -0800 Committed r77324: <http://trac.webkit.org/changeset/77324> 343817 3 ggaren 2011-02-01 21:06:04 -0800 Committed r77360: <http://trac.webkit.org/changeset/77360> 345101 4 jschuh 2011-02-03 16:12:45 -0800 The Leopard compile has been broken since r77360 was landed for this bug: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20(Build)/builds/28760 The commit message in trac doesn't match the one in the log. So, maybe something went wrong? 345368 5 paroga 2011-02-03 22:38:05 -0800 (In reply to comment #4) > The Leopard compile has been broken since r77360 was landed for this bug: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20(Build)/builds/28760 > > The commit message in trac doesn't match the one in the log. So, maybe something went wrong? Pleas never use the commit message! Use the ChangeLog! ChangeLog says: bug 53478 It's a classical unmerged ChangeLog, which caused the wrong commit message. 80836 2011-02-01 15:18:47 -0800 2011-02-01 15:21:34 -0800 ROLLOUT of r77297 bug-53538-20110201231845.patch text/plain 5697 webkit.review.bot ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg5MjBmYzY3OGI5ZGQ3MzBhZjljNDZiMGY1ZDA5 YWZkZmIxOTAzN2IuLjg4ODQyYTJhMzk4Nzc4YjIwYmJmZDE3YzkwZmRiMTQyNmMwMmY3MjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTAyLTAxICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByNzcyOTcuCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0Lzc3Mjk3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01MzUzOAorCisgICAgICAgIGNhdXNlZCBsZW9wYXJkIGNyYXNoZXMgKFJlcXVlc3Rl ZCBieSBwYXJvZ2Egb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS52Y3By b2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmOgorICAgICAgICAqIHd0Zi90ZXh0 L0F0b21pY1N0cmluZy5jcHA6CisgICAgICAgIChXVEY6OkF0b21pY1N0cmluZzo6ZnJvbVVURjgp OgorICAgICAgICAqIHd0Zi91bmljb2RlL1VURjguY3BwOgorICAgICAgICAoV1RGOjpVbmljb2Rl OjpjYWxjdWxhdGVTdHJpbmdIYXNoRnJvbVVURjgpOgorICAgICAgICAqIHd0Zi91bmljb2RlL1VU RjguaDoKKwogMjAxMS0wMi0wMSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFRyeSB0byBmaXggdGhlIHdpbmRvd3MgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLmRlZiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ov SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmCmluZGV4IGJlYzJiYTYxMGZjYzBhYmM3 N2M4NWUwZWI0NDE0MjU5Yzg2ODgyZmEuLjU1MDhjZTFkNzY5YWU1ZjAwMWU2YmYzMDliNzEzMDFm M2NhODMzZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNj cmlwdENvcmUuZGVmCkBAIC02NCw3ICs2NCw2IEBAIEVYUE9SVFMKICAgICA/Ynl0ZVNpemVAU291 cmNlUHJvdmlkZXJDYWNoZUBKU0NAQFFCRUlYWgogICAgID9jYWxjdWxhdGVEU1RPZmZzZXRAV1RG QEBZQU5OTkBaCiAgICAgP2NhbGN1bGF0ZVN0cmluZ0hhc2hGcm9tVVRGOEBVbmljb2RlQFdURkBA WUFJUEJEMEFBSUBaCi0gICAgP2NhbGN1bGF0ZVN0cmluZ0hhc2hBbmRMZW5ndGhGcm9tVVRGOEBV bmljb2RlQFdURkBAWUFJUEJEQUFJMUBaCiAgICAgP2NhbGN1bGF0ZVVUQ09mZnNldEBXVEZAQFlB SFhaCiAgICAgP2NhbGN1bGF0ZWRGdW5jdGlvbk5hbWVARGVidWdnZXJDYWxsRnJhbWVASlNDQEBR QkU/QVZVU3RyaW5nQDJAWFoKICAgICA/Y2FsbEBKU0NAQFlBP0FWSlNWYWx1ZUAxQFBBVkV4ZWNT dGF0ZUAxQFYyMUBXNENhbGxUeXBlQDFAQUJUQ2FsbERhdGFAMUAxQUJWQXJnTGlzdEAxQEBaCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCmluZGV4 IGI1ODRmNjdiMWVkMjU2ZjIxMDU1MDlmM2FiZmVmOWNkZWQ5OTJhNjguLmRkOGQ2NmMwNjdmODJm YWQ5NGViOWI0ODk4YmVkMDIyNTVlOGI2NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCkBAIC0zNzYsMTcgKzM3Niw3IEBAIEF0b21pY1N0 cmluZyBBdG9taWNTdHJpbmc6OmZyb21VVEY4KGNvbnN0IGNoYXIqIGNoYXJhY3RlcnMpCiB7CiAg ICAgaWYgKCFjaGFyYWN0ZXJzKQogICAgICAgICByZXR1cm4gQXRvbWljU3RyaW5nKCk7Ci0KLSAg ICBIYXNoQW5kVVRGOENoYXJhY3RlcnMgYnVmZmVyOwotICAgIGJ1ZmZlci5jaGFyYWN0ZXJzID0g Y2hhcmFjdGVyczsKLSAgICBidWZmZXIuaGFzaCA9IGNhbGN1bGF0ZVN0cmluZ0hhc2hBbmRMZW5n dGhGcm9tVVRGOChjaGFyYWN0ZXJzLCBidWZmZXIubGVuZ3RoLCBidWZmZXIudXRmMTZMZW5ndGgp OwotCi0gICAgaWYgKCFidWZmZXIuaGFzaCkKLSAgICAgICAgcmV0dXJuIEF0b21pY1N0cmluZygp OwotCi0gICAgQXRvbWljU3RyaW5nIGF0b21pY1N0cmluZzsKLSAgICBhdG9taWNTdHJpbmcubV9z dHJpbmcgPSBhZGRUb1N0cmluZ1RhYmxlPEhhc2hBbmRVVEY4Q2hhcmFjdGVycywgSGFzaEFuZFVU RjhDaGFyYWN0ZXJzVHJhbnNsYXRvcj4oYnVmZmVyKTsKLSAgICByZXR1cm4gYXRvbWljU3RyaW5n OworICAgIHJldHVybiBmcm9tVVRGOChjaGFyYWN0ZXJzLCBzdHJsZW4oY2hhcmFjdGVycykpOwog fQogCiB9IC8vIG5hbWVzcGFjZSBXVEYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvdW5pY29kZS9VVEY4LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29k ZS9VVEY4LmNwcAppbmRleCA0YzM3MzhiYzFhMjY5NjYxNmQzZDA0NzQ2NWE0YTA4NDFlMThlYzJk Li4zN2IxODM2MzkxMjZhYTNhMWI4MjVkNjRiZDc1YmU4ZjliOGUzM2Q0IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvVVRGOC5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL1VURjguY3BwCkBAIC0zMTQsMzMgKzMxNCwyNSBAQCBD b252ZXJzaW9uUmVzdWx0IGNvbnZlcnRVVEY4VG9VVEYxNigKICAgICByZXR1cm4gcmVzdWx0Owog fQogCi1zdGF0aWMgaW5saW5lIHVuc2lnbmVkIGNhbGN1bGF0ZVN0cmluZ0hhc2hBbmRMZW5ndGhG cm9tVVRGOEludGVybmFsKGNvbnN0IGNoYXIqIGRhdGEsIGNvbnN0IGNoYXIqIGRhdGFFbmQsIHVu c2lnbmVkJiBkYXRhTGVuZ3RoLCB1bnNpZ25lZCYgdXRmMTZMZW5ndGgpCit1bnNpZ25lZCBjYWxj dWxhdGVTdHJpbmdIYXNoRnJvbVVURjgoY29uc3QgY2hhciogZGF0YSwgY29uc3QgY2hhciogZGF0 YUVuZCwgdW5zaWduZWQmIHV0ZjE2TGVuZ3RoKQogewogICAgIGlmICghZGF0YSkKICAgICAgICAg cmV0dXJuIDA7CiAKICAgICBXVEY6OlN0cmluZ0hhc2hlciBzdHJpbmdIYXNoZXI7Ci0gICAgZGF0 YUxlbmd0aCA9IDA7CiAgICAgdXRmMTZMZW5ndGggPSAwOwogCi0gICAgd2hpbGUgKGRhdGEgPCBk YXRhRW5kIHx8ICghZGF0YUVuZCAmJiAqZGF0YSkpIHsKKyAgICB3aGlsZSAoZGF0YSA8IGRhdGFF bmQpIHsKICAgICAgICAgaWYgKGlzQVNDSUkoKmRhdGEpKSB7CiAgICAgICAgICAgICBzdHJpbmdI YXNoZXIuYWRkQ2hhcmFjdGVyKCpkYXRhKyspOwotICAgICAgICAgICAgZGF0YUxlbmd0aCsrOwog ICAgICAgICAgICAgdXRmMTZMZW5ndGgrKzsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICB9CiAKICAgICAgICAgaW50IHV0ZjhTZXF1ZW5jZUxlbmd0aCA9IGlubGluZVVURjhTZXF1ZW5j ZUxlbmd0aE5vbkFTQ0lJKCpkYXRhKTsKLSAgICAgICAgZGF0YUxlbmd0aCArPSB1dGY4U2VxdWVu Y2VMZW5ndGg7CiAKLSAgICAgICAgaWYgKCFkYXRhRW5kKSB7Ci0gICAgICAgICAgICBmb3IgKGlu dCBpID0gMTsgaSA8IHV0ZjhTZXF1ZW5jZUxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICAgICAg aWYgKCFkYXRhW2ldKQotICAgICAgICAgICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgICAg IH0KLSAgICAgICAgfSBlbHNlIGlmIChkYXRhRW5kIC0gZGF0YSA8IHV0ZjhTZXF1ZW5jZUxlbmd0 aCkKLSAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICBpZiAoZGF0YUVuZCAtIGRhdGEgPCB1 dGY4U2VxdWVuY2VMZW5ndGgpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAg aWYgKCFpc0xlZ2FsVVRGOChyZWludGVycHJldF9jYXN0PGNvbnN0IHVuc2lnbmVkIGNoYXIqPihk YXRhKSwgdXRmOFNlcXVlbmNlTGVuZ3RoKSkKICAgICAgICAgICAgIHJldHVybiAwOwpAQCAtMzY1 LDE3ICszNTcsNiBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGNhbGN1bGF0ZVN0cmluZ0hhc2hB bmRMZW5ndGhGcm9tVVRGOEludGVybmFsKGNvbnN0IGNoYXIqCiAgICAgcmV0dXJuIHN0cmluZ0hh c2hlci5oYXNoKCk7CiB9CiAKLXVuc2lnbmVkIGNhbGN1bGF0ZVN0cmluZ0hhc2hGcm9tVVRGOChj b25zdCBjaGFyKiBkYXRhLCBjb25zdCBjaGFyKiBkYXRhRW5kLCB1bnNpZ25lZCYgdXRmMTZMZW5n dGgpCi17Ci0gICAgdW5zaWduZWQgZGF0YUxlbmd0aDsKLSAgICByZXR1cm4gY2FsY3VsYXRlU3Ry aW5nSGFzaEFuZExlbmd0aEZyb21VVEY4SW50ZXJuYWwoZGF0YSwgZGF0YUVuZCwgZGF0YUxlbmd0 aCwgdXRmMTZMZW5ndGgpOwotfQotCi11bnNpZ25lZCBjYWxjdWxhdGVTdHJpbmdIYXNoQW5kTGVu Z3RoRnJvbVVURjgoY29uc3QgY2hhciogZGF0YSwgdW5zaWduZWQmIGRhdGFMZW5ndGgsIHVuc2ln bmVkJiB1dGYxNkxlbmd0aCkKLXsKLSAgICByZXR1cm4gY2FsY3VsYXRlU3RyaW5nSGFzaEFuZExl bmd0aEZyb21VVEY4SW50ZXJuYWwoZGF0YSwgMCwgZGF0YUxlbmd0aCwgdXRmMTZMZW5ndGgpOwot fQotCiBib29sIGVxdWFsVVRGMTZXaXRoVVRGOChjb25zdCBVQ2hhciogYSwgY29uc3QgVUNoYXIq IGFFbmQsIGNvbnN0IGNoYXIqIGIsIGNvbnN0IGNoYXIqIGJFbmQpCiB7CiAgICAgd2hpbGUgKGIg PCBiRW5kKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUv VVRGOC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL1VURjguaAppbmRleCBi YmZhYTg0MDliMWNjOTViNWE4Y2E1ZmI3ZjBlZjRlNGU0MmY1YjE2Li4xZjRiYWNhYzJiZGUxYTk5 ZWMxNTNhMjc0ZmI2ODQwYjk2ZmZiMmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL3VuaWNvZGUvVVRGOC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdW5p Y29kZS9VVEY4LmgKQEAgLTcxLDcgKzcxLDYgQEAgbmFtZXNwYWNlIFVuaWNvZGUgewogICAgICAg ICAgICAgICAgICAgICBjaGFyKiogdGFyZ2V0U3RhcnQsIGNoYXIqIHRhcmdldEVuZCwgYm9vbCBz dHJpY3QgPSB0cnVlKTsKIAogICAgIHVuc2lnbmVkIGNhbGN1bGF0ZVN0cmluZ0hhc2hGcm9tVVRG OChjb25zdCBjaGFyKiBkYXRhLCBjb25zdCBjaGFyKiBkYXRhRW5kLCB1bnNpZ25lZCYgdXRmMTZM ZW5ndGgpOwotICAgIHVuc2lnbmVkIGNhbGN1bGF0ZVN0cmluZ0hhc2hBbmRMZW5ndGhGcm9tVVRG OChjb25zdCBjaGFyKiBkYXRhLCB1bnNpZ25lZCYgZGF0YUxlbmd0aCwgdW5zaWduZWQmIHV0ZjE2 TGVuZ3RoKTsKIAogICAgIGJvb2wgZXF1YWxVVEYxNldpdGhVVEY4KGNvbnN0IFVDaGFyKiBhLCBj b25zdCBVQ2hhciogYUVuZCwgY29uc3QgY2hhciogYiwgY29uc3QgY2hhciogYkVuZCk7CiAK