53373 2011-01-29 01:18:11 -0800 [Qt] Button Element is rendered w/ text off-center. 2011-02-21 01:59:53 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 timo.lindemann cmarcelo benjamin cmarcelo commit-queue ossy oldest_to_newest 342052 0 80555 timo.lindemann 2011-01-29 01:18:11 -0800 Created attachment 80555 html that exhibits the behaviour. The example form is visible on http://buntebytes.de/~lindem/button-element.png (screenshot, comparison w/ input element, which is rendered correctly). The revision I am experiencing this with is qt 4.7.1 on Arch Linux. That'd be QtWebKit 2.0, but I don't really know which version to choose in the report form. The html is attached. Testing on windows, if I get around doing it today. 342122 1 80569 timo.lindemann 2011-01-29 11:53:50 -0800 Created attachment 80569 Screenshot. 342124 2 benjamin 2011-01-29 12:29:59 -0800 Looks related to #50521 342240 3 timo.lindemann 2011-01-30 05:07:24 -0800 Just wanted to comment that yasterday evening, on a suggestion from benjaminp in #qtwekbit, it's been revealed that html like <button> Text </button> causes the erroneous behaviour, while <button>Text</button> (note the absence of newlines inside the button element) does not. 353745 4 cmarcelo 2011-02-18 12:24:41 -0800 It seems that in RenderThemeQt::adjustButtonStyle() there's a call to style->setWhiteSpace(PRE) that shouldn't be there. I can't see the reason why Button should have special treatment for whitespaces. This layout test agrees with me LayoutTests/fast/forms/button-white-space.html 353846 5 83013 adawit 2011-02-18 14:47:35 -0800 Created attachment 83013 proposed fix... Patch based on comment #4 where it is correctly pointed out that setting a button's whitespace handling to PRE does not make sense and most definitely causes this bug in addition to violating the button with white-space layout test. 354029 6 83013 kling 2011-02-18 19:47:47 -0800 Comment on attachment 83013 proposed fix... r=me 354072 7 commit-queue 2011-02-18 23:21:15 -0800 The commit-queue encountered the following flaky tests while processing attachment 83013: http/tests/websocket/tests/handshake-challenge-randomness.html bug 53738 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 354073 8 83013 commit-queue 2011-02-18 23:23:10 -0800 Comment on attachment 83013 proposed fix... Clearing flags on attachment: 83013 Committed r79103: <http://trac.webkit.org/changeset/79103> 354074 9 commit-queue 2011-02-18 23:23:13 -0800 All reviewed patches have been landed. Closing bug. 354467 10 ossy 2011-02-21 01:59:53 -0800 This patch fixed 3 tests on Qt. See http://trac.webkit.org/changeset/79198 for details. 80555 2011-01-29 01:18:11 -0800 2011-01-29 01:18:11 -0800 html that exhibits the behaviour. test.html text/html 318 timo.lindemann PGh0bWw+Cgk8aGVhZD4KCTwvaGVhZD4KCTxib2R5PgoJCTxoMT4gVGVzdCBGb3JtIDwvaDE+CgkJ PGZvcm0gYWN0aW9uPSIiIG1ldGhvZD0icG9zdCI+CgkJCTx0YWJsZT4KCQkJCTx0cj4KCQkJCQk8 dGQ+CgkJCQkJCTxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJpbnB1dCIgLz4KCQkJCQk8L3Rk PgoJCQkJCTx0ZD4KCQkJCQkJPGJ1dHRvbiB0eXBlPSJzdWJtaXQiIHZhbHVlPSJidXR0b24iPiAK CQkJCQkJCWJ1dHRvbgoJCQkJCQk8L2J1dHRvbj4KCQkJCQk8L3RkPgoJCQkJPC90cj4KCQkJPC90 YWJsZT4KCQk8L2Zvcm0+Cgk8L2JvZHk+CjwvaHRtbD4K 80569 2011-01-29 11:53:50 -0800 2011-01-29 11:53:50 -0800 Screenshot. button_element.png image/png 3596 timo.lindemann iVBORw0KGgoAAAANSUhEUgAAARUAAADaCAIAAAAHRUFgAAAABmJLR0QA/wD/AP+gvaeTAAAACXBI WXMAAAsSAAALEgHS3X78AAANrElEQVR42u3de1BU9QLA8YOYIpnSpMhjFxDMB0iIgBZjRdeVysTH jMZ1NHXCZxdNJCfTsZlMB3NCgcSRmLk+cxIfqGXK4+JlZ5wScQg1wARLXLZLQrYQYAns/WPzzGkf BxZ2YbHvZ/pj2d95cfZ8OWcPSzrp9XoBQJf0YxcA9APQD0A/AP0AoB+AfgD6AegHAP0A9APQD0A/ AP0A6HY/Tl3Su99Pc3PzkiVLrJqlb32DcChOMn//07VjpRf/oKisrGzevHllZWVWbYO13yZ/MQXR o3P9tn///oiIiLKyMl5U9JhH5/wj3VrOP+gZ/a09ULp8mPYJtAGrcP8NcOx+CgsL165d+9JLLz31 1FM+Pj4xMTGbNm0qKiqSmUWj0axevfqFF15QKpUuLi5KpTIiIiIxMfHGjRumE5veFuv5e2VarTYp KWnKlCk+Pj6urq4hISELFy7csWNHfX29pVmM7ul99NFHISEhbm5uKpVq586dZqe5f/9+cnLynDlz vL29lUrl66+/npGRIZ4zy8vL169f//zzz7u5uUVGRr733ntqtZpD3L70VrJq3qampvj4eLPHsbOz 8/vvv//gwQPTufbs2TNo0CBLx1x+fr7MJnXhu+vO3jA4cuSIs7Oz2Q1wd3c/fvx4h+tNS0uTfpma mmo6TUVFRUhIiOkq4uLi2traDhw44OrqavzTsV+/7OxsPezGjv00NzcHBQXJ1xsZGfnHH39I57p4 8aKlY9FAoVDcu3fPcfr5/PPP5TdYEITly5fLr1c89AcMGBAVFdXW1mY6zeDBgy0tf8yYMZaGBg0a dOnSJQ70vtfPxo0bxSlHjx598uRJrVZbV1d39uzZ4OBgcSg9PV0614wZM8ShefPm5eXl1dXVnTx5 UnqIzJ8/34YZdOd0nZWV1b9/f/HcmJCQUFRU1NDQcPny5cTEROmJNysrS369W7ZsuXv3rvw0KpXq 1KlT9fX1arXaz8/PaHTKlCnZ2dlarXbr1q3Dhg0Tn589ezYHeh/rp6KiYsCAAYbJ/P39f/vtN+lo S0tLYGCgYdTDw6OpqUkc8vDwEJdfU1MjPn/+/HlfX9/Fixfv27fvhx9+cIR+tFrtY489Jg6dOHHC aMnHjx+XXsgZ5SFdbHh4eIfbNmbMmMbGRnHoyy+/lI76+PjU19ebXbVSqeRA72P9SE8+R44cMZ3g 9OnT4gQpKSni8wqFQnz+ww8/bG1tte2G2bCfbdu2dfgzftasWeI027dvt7Teffv2dbhtRn3W1tZK Rz/77DPpaE1NjfTCjwPdTux1/016oyw0NNR0gkmTJomPr169Kj5+7rnnxMebN28OCAhYs2bNuXPn WlpaHOF2i5T0DLBy5Uqz06xatUp8XFpaamlR48aN63B1YWFh0i+feOIJ6ZeTJ0+Wfjl06FDxcVNT k6PtukeHnc4/Hd45kIqOjhZnvHTpkul9JEEQXF1d58yZc/DgwZaWFvudf6yaccSIEeKMVVVVZqep rKwUpwkKCrK0Xo1G0+G2NTQ0SIfa29ulozqdzlbfF6w4eOzUj6Ub0GYFBgZK5z179uzw4cMtTezj 43Ps2DFH6MfFxUWc0VLVzc3N4jSPP/64pfUa3VE0O414U87sqOmFLv30AHtdv8kEYEqj0Ui/nD59 enV1dWZmZmRkpOmt4erq6tjY2IKCgl4/dUvPP1qt1uw00vch/v7+lhYl3muR0a+f3IvV4T102IO9 +gkICOjw4kSk0+mMZndxcVm6dOnFixfr6+uzs7PfeustX19fcbS9vf2DDz7o9X3n7e0tPr5586bZ aYyu3ywtSnofD/QjjB07Vnzc+U+R/Pjjj/v371+yZImfn19+fr4gCEOHDp09e3Z6evqtW7cyMzPF Ka9du2b8nUh+PBu9N7ATlUolPs7IyDA7zd69e+nnUWan9z9Xr14Vf3vo5eVVW1vbmYU/++yz4sJN fyUibWbs2LEy77ju37/fA+9/pOcWQRBOnTplNEF2drY46urqWllZae165afpzihswo6fP4iNjRWn 9PDw2LNnz40bN1paWjQajVqtfvXVV01/H3r06FHp8mfOnHngwIHa2trS0tL09HTpDdwVK1YYrU6p VIqj2dnZVVVVJSUldu1Hr9cnJyeL8zo5OSUmJhYXFzc2Nl65cmX9+vXSU2JaWloX1ks/f99+7ty5 Ex4e3plzYEJCgmGWtra2BQsWdDi9n5/fzz//bLQ60xljY2Pt3Y9er8/IyJB/Zy8IQnR0dHt7O/3Q j3Wvyu+//x4fHy9zYLm6um7ZskV6bLW2tq5atUr8UJmpsLCw69evm66roKDA6C6W0W1xO/Wj1+sP Hz5saYOHDBmSmppq9lMU9PMIkPv7bbO68PenhYWFarX6+vXr165du3379siRI8c9FBUV5enpaTpL dXX17t27i4qK7ty5o9Vq3dzcfH19/fz8FixYEBMTY2lFarU6KSmpuLh44MCBwcHBEydOlH7Exobf kan6+vqLD5WWliqVyqCgoPHjxy9btszLy6vL65WfpjujsAkn9izQZfz9NkA/AP0A9APQDwD6AegH oB+AfgDQD0A/AP0A9APQDwD6AegHoB+AfgDQD0A/AP0A9APQDwD6AegHoB+AfgDQD0A/AP0A9APQ DwDr9e/8pFdLSzU1GsfZdIW34pmQkD60wY6mwx0Im/VjOBZfjo52nE3Pyc0VBMHSEeCAG+xo5Hcg bNmPpkbz/JQpjY2NjrPpoRMmlHz7raWX3wE32NHI70DYsh8Dh/rHUjuzMfzrruwc+qEf+un7/Rj+ wfs+9PI72gbTz9+6n764xzlE4Cj9cP55xLBzerQfQRDa29ulX3p4ev3vJ60jv/xGGwz66c1+TPe4 vV8DTy/vn7Q1HCLo8/2YXg5pazQ9cIBaWgXXb3baseg86z7/pv8rL2+F9MGnmZkxM2c9PXqMalr0 sWPHpJM9ePBg67ZtL7wY9UzIhLi4pRqNxnQhpkv28lYIguDlrTD8ZzqZtRsMa3cg5HX3/oH4zMcf J5dXVKxcsTwsLOzMmS+2f7TDz88vLCzMMPrh1q2//HIvZddOQRD+vW//azNics6fc3d3l/lBqNfr NXeqFUofzZ1qs5Nx/ukmdk6P9iPIvv+puFGR+WmG4XFc3Jvt7W05ObkTJ040PKPTNaSm7DI8Tk3Z tW5dYnLyzu3bk+T76f7LzCECu+rW9Zsg+Rk/b+5c6VBUVFROTo44+nJ0tHQ0Ojr662++NlqIpSV3 5/KDKzSu3+zKZtdvL74YJR0NCAiounVLfCY8PEw6Gh4ertX+ZOkM09raJnTi/MP1Wzexc3q0H0H2 +s3ZuZ/M6OXi4mkqlfh8cfFlT09Pw6i/v39VVZW/v784WlDwH4HrNzxi/ciff+Tfw+Tl5qmmThWf z83Nmzx5smF02jTVhQv/HTlypDh6NOuYOO+TTz6p0+mGDBnShTY4//DDxYH6EWTPP/L9DB48+J13 1r/xxkJBEA4dOlyoVn9x5syf/ahUa95e6+zs/MorL5eUlJw6dTpw3Lj8/HzDaER4+JkzZ+bOnTtw 4MAuvPwcIuwcu7Li/oG17/Kloxs2vOvm5rY2Yd2bcUt1DQ0njh93dx9uGA0NDV2XsPZo1tF/TFXt zcgICw97++014rxxcW8WFqpDJ4b5B4yy9u0vtwe4f2BvTp3ciV99dXZSRIROp+vCOkY9Pbry5vc2 3/S2trbKqqrp01+z+Qb/TcjvQHRGtz4/2gMzytDz+VH770DYrJ/unPHt8VJx/4B++lI/Xd7jFeVl vfVS9dZ6x44LrCgv4/Cin78ciw71E8vBzz9dXvW4wKDysu/kn+ndLURX+nG0Pe7g969t+2vfXrkA Bv302ga3trampqYVXLig0+kmhoZu2PCup6enYShofPB3168ZTW94Mmh8sCAIgUHjDU+afcbwoKSk JDXtk8rKSkEQRo0atfbtNRMmTJAu6uChQznnc76/eVOpVC5evGjWzJn002v9KLwVxVeuDB82zHE2 /W5dncJb4bAbnJS0/Vfdr+9v3iwIQtaxrNh/zj908MCwh9vT1NRkOktTU1PRpW8mTX626NI3Ms8I gnD79u0VK1epVFPj//WWIAgnTpxctnzFoUMHlYo/d8iuXSmVVVXz588PDh6fl5+fkpI6wt09ODi4 8zsQtuzH8H+p7EP//+te3+C7dXUJCWsNj+Pj43fu3JX2ye7Vq+PFUbOzWBo1eiY3L2/GjNcWLVpk +HLFyhUDXVxyc3NnPjzJlJWXb9q0URAEvSCoVKrGxt/Onc/xeHgC7MwORGc4cRIHuox/vwSgH4B+ APoB6AcA/QD0A9APQD8A6AegH4B+APoB6AcA/QD0A9APQD8A6AegH4B+APoB6AcA/QD0A9APQD8A 6AegH4B+APoB6AcA/QD0A9APQD8A6AegH4B+APoB6AcA/QD0A9APQD8A6AegH4B+APoBQD8A/QD0 A9APQD8A6AegH4B+APoBQD8A/QD0A9APQD8A6AegH4B+APoBQD8A/QD0A9APQD8A6AegH4B+APoB QD8A/QD0A9APQD8A6AegH4B+APoBQD8A/QD0A9APAPoB6AegH4B+APoBQD8A/QD0A9APAPoB6Aeg H4B+APoBQD8A/QD0A9APAPoB6AegH4B+APoBQD8A/QD0A9APAPoBbOv/VMT9Yf5Qr6oAAAAASUVO RK5CYII= 83013 2011-02-18 14:47:35 -0800 2011-02-18 23:23:10 -0800 proposed fix... fix_whitespace_handling_in_buttons.patch text/plain 1178 adawit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMDkyMWI3Li4yODY0NTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMTggIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gIEJ1dHRvbiBF bGVtZW50IGlzIHJlbmRlcmVkIHcvIHRleHQgb2ZmLWNlbnRlci4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMzczCisKKyAgICAgICAgVGVzdDogTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9idXR0b24td2hpdGUtc3BhY2UuaHRtbCAKKworICAgICAgICAq IHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGhlbWVRdDo6YWRqdXN0QnV0dG9uU3R5bGUpOgorCiAyMDExLTAyLTE4ICBDc2FiYSBPc3p0cm9n b27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQW5k cmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRl clRoZW1lUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5j cHAKaW5kZXggZDQ2ODhjZi4uYWM3MDE2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v cXQvUmVuZGVyVGhlbWVRdC5jcHAKQEAgLTU0Nyw5ICs1NDcsNiBAQCB2b2lkIFJlbmRlclRoZW1l UXQ6OmFkanVzdEJ1dHRvblN0eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBSZW5kZXJT dHlsZSogcwogICAgIH0KICNlbmRpZgogCi0gICAgLy8gV2hpdGUtc3BhY2UgaXMgbG9ja2VkIHRv IHByZQotICAgIHN0eWxlLT5zZXRXaGl0ZVNwYWNlKFBSRSk7Ci0KICAgICBGb250RGVzY3JpcHRp b24gZm9udERlc2NyaXB0aW9uID0gc3R5bGUtPmZvbnREZXNjcmlwdGlvbigpOwogICAgIGZvbnRE ZXNjcmlwdGlvbi5zZXRJc0Fic29sdXRlU2l6ZSh0cnVlKTsKIAo=