<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>53370</bug_id>
          
          <creation_ts>2011-01-28 23:47:57 -0800</creation_ts>
          <short_desc>XSSFilter should replace URLs with about:blank instead of the empty string</short_desc>
          <delta_ts>2011-01-29 03:43:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>49845</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>abarth</cc>
    
    <cc>buildbot</cc>
    
    <cc>dbates</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>gustavo</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>342018</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-28 23:47:57 -0800</bug_when>
    <thetext>XSSFilter should replace URLs with about:blank instead of the empty string</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342019</commentid>
    <comment_count>1</comment_count>
      <attachid>80552</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-28 23:48:52 -0800</bug_when>
    <thetext>Created attachment 80552
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342020</commentid>
    <comment_count>2</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2011-01-28 23:52:53 -0800</bug_when>
    <thetext>Attachment 80552 did not build on gtk:
Build output: http://queues.webkit.org/results/7567446</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342021</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-01-28 23:52:59 -0800</bug_when>
    <thetext>Attachment 80552 did not build on chromium:
Build output: http://queues.webkit.org/results/7679063</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342025</commentid>
    <comment_count>4</comment_count>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2011-01-29 00:01:31 -0800</bug_when>
    <thetext>Attachment 80552 did not build on qt:
Build output: http://queues.webkit.org/results/7679065</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342026</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-29 00:10:08 -0800</bug_when>
    <thetext>This patch builds fine.  It just depends on patches earlier in the sequence.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342028</commentid>
    <comment_count>6</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-01-29 00:15:45 -0800</bug_when>
    <thetext>Attachment 80552 did not build on win:
Build output: http://queues.webkit.org/results/7582428</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342041</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-01-29 00:35:01 -0800</bug_when>
    <thetext>Attachment 80552 did not build on chromium:
Build output: http://queues.webkit.org/results/7679072</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342058</commentid>
    <comment_count>8</comment_count>
      <attachid>80552</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-29 01:22:37 -0800</bug_when>
    <thetext>Comment on attachment 80552
Patch

Clearing flags on attachment: 80552

Committed r77060: &lt;http://trac.webkit.org/changeset/77060&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342059</commentid>
    <comment_count>9</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-29 01:22:41 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342077</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-01-29 03:43:09 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/77060 might have broken GTK Linux 64-bit Debug</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80552</attachid>
            <date>2011-01-28 23:48:52 -0800</date>
            <delta_ts>2011-01-29 01:22:37 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-53370-20110128234850.patch</filename>
            <type>text/plain</type>
            <size>2017</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxOWRmYzhiNmZmNzUyYmMyOTE1ZWI1Nzk0MmQwMzUxN2Q1NDM3MjNhLi5h
YjBjNzhjODJiODg4MDM4YmUxMDkxYTM3NDg5OGQ2ZWQyYzc2Y2QwIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0y
LDYgKzIsMjEgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAg
ICAgICBYU1NGaWx0ZXIgc2hvdWxkIHJlcGxhY2UgVVJMcyB3aXRoIGFib3V0OmJsYW5rIGluc3Rl
YWQgb2YgdGhlIGVtcHR5IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NTMzNzAKKworICAgICAgICBVc2luZyB0aGUgZW1wdHkgc3RyaW5nIHdp
bGwgbWFrZSB0aGUgVVJMIGNvbXBsZXRlIHRvIHRoZSBjdXJyZW50CisgICAgICAgIGRvY3VtZW50
J3MgVVJMLCB3aGljaCBpc24ndCByZWFsbHkgd2hhdCB3ZSB3YW50LiAgSW5zdGVhZCwgd2Ugd2Fu
dCB0bworICAgICAgICB1c2UgYWJvdXQ6YmxhbmssIHdoaWNoIGlzIHNhZmUuCisKKyAgICAgICAg
KiBodG1sL3BhcnNlci9YU1NGaWx0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WFNTRmlsdGVy
OjpmaWx0ZXJPYmplY3RUb2tlbik6CisgICAgICAgIChXZWJDb3JlOjpYU1NGaWx0ZXI6OmZpbHRl
ckVtYmVkVG9rZW4pOgorCisyMDExLTAxLTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v
cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgRml4
IFhTU0ZpbHRlciBjcmFzaCB3aGVuIGV4dHJhY3RpbmcgdGhlIHNvdXJjZSBmb3IgYSB0b2tlbiB0
d2ljZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMz
NjgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvWFNTRmlsdGVyLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL1hTU0ZpbHRlci5jcHAKaW5kZXggNWNhMWRk
N2I2NGQyOTc1MWU0NDMyMDVhNDU4ZDhkNWU5MWEyNGMxYy4uMGViNDM3YmEwNTRjMmY5MTFhOTFl
NGZjNDRhZjc2ZTRlZGVhZjM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz
ZXIvWFNTRmlsdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9YU1NGaWx0
ZXIuY3BwCkBAIC0yMzgsNyArMjM4LDcgQEAgYm9vbCBYU1NGaWx0ZXI6OmZpbHRlck9iamVjdFRv
a2VuKEhUTUxUb2tlbiYgdG9rZW4pCiAKICAgICBib29sIGRpZEJsb2NrU2NyaXB0ID0gZmFsc2U7
CiAKLSAgICBkaWRCbG9ja1NjcmlwdCB8PSBlcmFzZUF0dHJpYnV0ZUlmSW5qZWN0ZWQodG9rZW4s
IGRhdGFBdHRyKTsKKyAgICBkaWRCbG9ja1NjcmlwdCB8PSBlcmFzZUF0dHJpYnV0ZUlmSW5qZWN0
ZWQodG9rZW4sIGRhdGFBdHRyLCBibGFua1VSTCgpLnN0cmluZygpKTsKICAgICBkaWRCbG9ja1Nj
cmlwdCB8PSBlcmFzZUF0dHJpYnV0ZUlmSW5qZWN0ZWQodG9rZW4sIHR5cGVBdHRyKTsKICAgICBk
aWRCbG9ja1NjcmlwdCB8PSBlcmFzZUF0dHJpYnV0ZUlmSW5qZWN0ZWQodG9rZW4sIGNsYXNzaWRB
dHRyKTsKIApAQCAtMjUzLDcgKzI1Myw3IEBAIGJvb2wgWFNTRmlsdGVyOjpmaWx0ZXJFbWJlZFRv
a2VuKEhUTUxUb2tlbiYgdG9rZW4pCiAKICAgICBib29sIGRpZEJsb2NrU2NyaXB0ID0gZmFsc2U7
CiAKLSAgICBkaWRCbG9ja1NjcmlwdCB8PSBlcmFzZUF0dHJpYnV0ZUlmSW5qZWN0ZWQodG9rZW4s
IHNyY0F0dHIpOworICAgIGRpZEJsb2NrU2NyaXB0IHw9IGVyYXNlQXR0cmlidXRlSWZJbmplY3Rl
ZCh0b2tlbiwgc3JjQXR0ciwgYmxhbmtVUkwoKS5zdHJpbmcoKSk7CiAgICAgZGlkQmxvY2tTY3Jp
cHQgfD0gZXJhc2VBdHRyaWJ1dGVJZkluamVjdGVkKHRva2VuLCB0eXBlQXR0cik7CiAKICAgICBy
ZXR1cm4gZGlkQmxvY2tTY3JpcHQ7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>