53323 2011-01-28 12:26:40 -0800 [GTK] character range extents is off when the end of a wrapped line is included 2011-02-01 01:54:46 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro mario oldest_to_newest 341641 0 jdiggs 2011-01-28 12:26:40 -0800 This may be another aspect of Bug #53300. But since they seem differentish.... Steps to reproduce: 1. Open the test case from Bug #53300 (https://bugs.webkit.org/attachment.cgi?id=80446) and resize the window so that the text wraps as follows: It's not pinin,' it's passed on! This parrot is no more! It has ceased to be! It's expired and gone to meet its maker! This is a late parrot! It's a stiff! Bereft of life, it [...] 2. Launch Accerciser, select the accessible object associated with the paragraph from the test case. Then in the iPython console: In [1]: text = acc.queryText() In [2]: text.getTextAtOffset(0, TEXT_BOUNDARY_LINE_START) Out[2]: ("It's not pinin,' it's passed on! This parrot is no more! It ", 0, 60) In [3]: text.getRangeExtents(0, 60, WINDOW_COORDS) Out[3]: (8, 8, 333, 34) <--- Two lines high In [4]: text.getRangeExtents(0, 59, WINDOW_COORDS) Out[4]: (8, 8, 333, 17) 3. Repeat the test using Gedit. In [5]: text = acc.queryText() In [6]: text.getTextAtOffset(0, TEXT_BOUNDARY_LINE_START) Out[6]: ("It's not pinin,' it's passed on! This parrot is no more! It ", 0, 60) In [7]: text.getRangeExtents(0, 60, WINDOW_COORDS) Out[7]: (6, 94, 472, 17) In [8]: text.getRangeExtents(0, 59, WINDOW_COORDS) Out[8]: (6, 94, 472, 17) As a result of the above difference, Orca's "flat review" feature presents multiple lines, rather than just one line, at a time. It would be quite helpful if the extents from WebKitGtk could match what we see from Gtk Text widgets. 342094 1 mario 2011-01-29 07:08:55 -0800 (In reply to comment #0) > This may be another aspect of Bug #53300. But since they seem differentish.... As usual, can't tell for sure at this point, but IMHO this could be caused *exactly* because of the very same reason than for bug 53300: poor handling of offsets near linebreaks, because of the upstream/downstream stuff regarding to positions, I'd bet. Now working on bug 53300 to see if I can get something out of this. Who knows, perhaps we can fix the two bugs in a row, if we finally confirm this is a duplicate of the other one :-) 342095 2 mario 2011-01-29 07:27:59 -0800 Just a quick comment I forgot to make before: (In reply to comment #0) > [...] > 2. Launch Accerciser, select the accessible object associated with the paragraph from the test case. Then in the iPython console: > > In [1]: text = acc.queryText() > In [2]: text.getTextAtOffset(0, TEXT_BOUNDARY_LINE_START) > Out[2]: ("It's not pinin,' it's passed on! This parrot is no more! It ", 0, 60) > In [3]: text.getRangeExtents(0, 60, WINDOW_COORDS) > Out[3]: (8, 8, 333, 34) <--- Two lines high The actual problem here is not getRangeExtents() returning a result meaning "two lines high" but text.getTextAtOffset() returning 60 when it should be returning 59 in case it doesn't count the linebreak as the last character of the line. So when you ask for the extents from 0 till 60 you're actually asking "from the beginning of the first line to the beginning of the second one" This makes me wonder whether ORCA expects the linebreak to be actually exposed or not as part of the first line, as just another offset position... guess it does, though. 342096 3 mario 2011-01-29 07:31:18 -0800 (In reply to comment #2) > [...] > This makes me wonder whether ORCA expects the linebreak to be actually exposed or not as part of the first line, as just another offset position... guess it does, though. Stupid me, I didn't see the " " after "It" in the returned text, so 60 is correct after all, and that is how the linebreak is represented. Sorry for the noise. I should keep my thoughts for myself instead of wildly dumping them here :P 342704 4 80666 mario 2011-01-31 11:27:01 -0800 Created attachment 80666 Patch proposal + unit tests Attaching patch proposal + unit test 342853 5 80666 mrobinson 2011-01-31 15:27:29 -0800 Comment on attachment 80666 Patch proposal + unit tests View in context: https://bugs.webkit.org/attachment.cgi?id=80666&action=review > Source/WebCore/ChangeLog:12 > + requested interval shouldn't include the last character- "character-" --> "character." 343089 6 mario 2011-02-01 01:54:46 -0800 Committed r77234: <http://trac.webkit.org/changeset/77234> 80666 2011-01-31 11:27:01 -0800 2011-01-31 15:27:29 -0800 Patch proposal + unit tests 0001-2011-01-31-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 5139 mario RnJvbSA1NGNjZjdlZmM2ZjUxNjUyODlhZWMxNmU2NGExZWUwZTVhMmYyMjkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDMxIEphbiAyMDExIDIwOjI2OjA5ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0wMS0zMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBjaGFy YWN0ZXIgcmFuZ2UgZXh0ZW50cyBpcyBvZmYgd2hlbiB0aGUgZW5kIG9mIGEgd3JhcHBlZCBsaW5l IGlzIGluY2x1ZGVkCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUzMzIzCgogICAgICAgIEZpeGVkIHdyb25nIGNhbGN1bGF0aW9uIGdldHRpbmcgdGhlIHJh bmdlIGV4dGVudHMuCgogICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJBdGsuY3BwOgogICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV90ZXh0X2dldF9y YW5nZV9leHRlbnRzKTogUmVtb3ZlZCAnKzEnIHNpbmNlIHRoZQogICAgICAgIHJlcXVlc3RlZCBp bnRlcnZhbCBzaG91bGRuJ3QgaW5jbHVkZSB0aGUgbGFzdCBjaGFyYWN0ZXItCgoyMDExLTAxLTMx ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtHVEtdIGNoYXJhY3RlciByYW5nZSBl eHRlbnRzIGlzIG9mZiB3aGVuIHRoZSBlbmQgb2YgYSB3cmFwcGVkIGxpbmUgaXMgaW5jbHVkZWQK ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMzMjMKCiAg ICAgICAgVXBkYXRlIHVuaXQgdGVzdCB0byBjaGVjayB0aGUgZml4IGZvciB0aGlzIGJ1Zy4KCiAg ICAgICAgKiB0ZXN0cy90ZXN0YXRrLmM6CiAgICAgICAgKHRlc3RXZWJraXRBdGtHZXRFeHRlbnRz KTogQ2hlY2sgdGhhdCB0aGUgZXh0ZW50IGZvciBhIGZ1bGwgbGluZQogICAgICAgIGFyZSB0aGUg c2FtZSBoZWlnaHQgdGhhbiBmb3IgYSBwYXJ0aWFsIHNlY3Rpb24gb2YgdGhlIHNhbWUgbGluZS4K LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTMgKysrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0 ay5jcHAgICAgICAgICAgfCAgICAyICstCiBTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogU291cmNlL1dlYktpdC9n dGsvdGVzdHMvdGVzdGF0ay5jICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysr KwogNCBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCA0MDg0MTUxLi5lNDc0YzQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDEtMzEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIGNo YXJhY3RlciByYW5nZSBleHRlbnRzIGlzIG9mZiB3aGVuIHRoZSBlbmQgb2YgYSB3cmFwcGVkIGxp bmUgaXMgaW5jbHVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUzMzIzCisKKyAgICAgICAgRml4ZWQgd3JvbmcgY2FsY3VsYXRpb24gZ2V0dGluZyB0 aGUgcmFuZ2UgZXh0ZW50cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX3Rl eHRfZ2V0X3JhbmdlX2V4dGVudHMpOiBSZW1vdmVkICcrMScgc2luY2UgdGhlCisgICAgICAgIHJl cXVlc3RlZCBpbnRlcnZhbCBzaG91bGRuJ3QgaW5jbHVkZSB0aGUgbGFzdCBjaGFyYWN0ZXItCisK IDIwMTEtMDEtMjggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3Njg5My4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy QXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyQXRrLmNwcAppbmRleCA5OWRhMDdiLi5mNWVkODliIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCkBAIC0xNTQzLDcgKzE1NDMsNyBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfYWNjZXNzaWJsZV90ZXh0X2dldF9jaGFyYWN0ZXJfZXh0ZW50cyhBdGtUZXh0KiB0 ZXh0LCBnaW50IG9mZgogCiBzdGF0aWMgdm9pZCB3ZWJraXRfYWNjZXNzaWJsZV90ZXh0X2dldF9y YW5nZV9leHRlbnRzKEF0a1RleHQqIHRleHQsIGdpbnQgc3RhcnRPZmZzZXQsIGdpbnQgZW5kT2Zm c2V0LCBBdGtDb29yZFR5cGUgY29vcmRzLCBBdGtUZXh0UmVjdGFuZ2xlKiByZWN0KQogewotICAg IEludFJlY3QgZXh0ZW50cyA9IHRleHRFeHRlbnRzKHRleHQsIHN0YXJ0T2Zmc2V0LCBlbmRPZmZz ZXQgLSBzdGFydE9mZnNldCArIDEsIGNvb3Jkcyk7CisgICAgSW50UmVjdCBleHRlbnRzID0gdGV4 dEV4dGVudHModGV4dCwgc3RhcnRPZmZzZXQsIGVuZE9mZnNldCAtIHN0YXJ0T2Zmc2V0LCBjb29y ZHMpOwogICAgIHJlY3QtPnggPSBleHRlbnRzLngoKTsKICAgICByZWN0LT55ID0gZXh0ZW50cy55 KCk7CiAgICAgcmVjdC0+d2lkdGggPSBleHRlbnRzLndpZHRoKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5k ZXggYWZkYzM3NS4uYzU1ZWMxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDExLTAxLTMxICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBjaGFy YWN0ZXIgcmFuZ2UgZXh0ZW50cyBpcyBvZmYgd2hlbiB0aGUgZW5kIG9mIGEgd3JhcHBlZCBsaW5l IGlzIGluY2x1ZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01MzMyMworCisgICAgICAgIFVwZGF0ZSB1bml0IHRlc3QgdG8gY2hlY2sgdGhlIGZpeCBm b3IgdGhpcyBidWcuCisKKyAgICAgICAgKiB0ZXN0cy90ZXN0YXRrLmM6CisgICAgICAgICh0ZXN0 V2Via2l0QXRrR2V0RXh0ZW50cyk6IENoZWNrIHRoYXQgdGhlIGV4dGVudCBmb3IgYSBmdWxsIGxp bmUKKyAgICAgICAgYXJlIHRoZSBzYW1lIGhlaWdodCB0aGFuIGZvciBhIHBhcnRpYWwgc2VjdGlv biBvZiB0aGUgc2FtZSBsaW5lLgorCiAyMDExLTAxLTI3ICBOYXRlIENoYXBpbiAgPGphcGhldEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L3Rlc3RzL3Rlc3RhdGsuYwppbmRleCBmN2E1YzU5Li4zNWY4ZDk2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMKKysrIGIvU291cmNlL1dlYktpdC9ndGsvdGVz dHMvdGVzdGF0ay5jCkBAIC0xMDg0LDYgKzEwODQsMjEgQEAgc3RhdGljIHZvaWQgdGVzdFdlYmtp dEF0a0dldEV4dGVudHMoKQogICAgIGdfYXNzZXJ0X2NtcGludCh5LCA9PSwgbWxpbmVfd2luZG93 LnkgKyBtbGluZV93aW5kb3cuaGVpZ2h0IC0gaGVpZ2h0KTsKICAgICBnX2Fzc2VydF9jbXBpbnQo aGVpZ2h0LCA8PSwgbWxpbmVfd2luZG93LmhlaWdodCk7CiAKKyAgICAvKiBDaGVjayB0aGF0IGV4 dGVudCBmb3IgYSBmdWxsIGxpbmUgYXJlIHRoZSBzYW1lIGhlaWdodCB0aGFuIGZvcgorICAgICAg IGEgcGFydGlhbCBzZWN0aW9uIG9mIHRoZSBzYW1lIGxpbmUgKi8KKyAgICBnaW50IHN0YXJ0T2Zm c2V0OworICAgIGdpbnQgZW5kT2Zmc2V0OworICAgIGdjaGFyKiB0ZXh0ID0gYXRrX3RleHRfZ2V0 X3RleHRfYXRfb2Zmc2V0KG11bHRpbGluZVRleHQsIDAsIEFUS19URVhUX0JPVU5EQVJZX0xJTkVf U1RBUlQsICZzdGFydE9mZnNldCwgJmVuZE9mZnNldCk7CisgICAgZ19mcmVlKHRleHQpOworCisg ICAgQXRrVGV4dFJlY3RhbmdsZSBmbGluZV93aW5kb3c7CisgICAgQXRrVGV4dFJlY3RhbmdsZSBh ZmxpbmVfd2luZG93OworICAgIGF0a190ZXh0X2dldF9yYW5nZV9leHRlbnRzKG11bHRpbGluZVRl eHQsIHN0YXJ0T2Zmc2V0LCBlbmRPZmZzZXQsIEFUS19YWV9XSU5ET1csICZmbGluZV93aW5kb3cp OworICAgIGF0a190ZXh0X2dldF9yYW5nZV9leHRlbnRzKG11bHRpbGluZVRleHQsIHN0YXJ0T2Zm c2V0LCBlbmRPZmZzZXQgLSAxLCBBVEtfWFlfV0lORE9XLCAmYWZsaW5lX3dpbmRvdyk7CisgICAg Z19hc3NlcnRfY21waW50KGZsaW5lX3dpbmRvdy54LCA9PSwgYWZsaW5lX3dpbmRvdy54KTsKKyAg ICBnX2Fzc2VydF9jbXBpbnQoZmxpbmVfd2luZG93LnksID09LCBhZmxpbmVfd2luZG93LnkpOwor ICAgIGdfYXNzZXJ0X2NtcGludChmbGluZV93aW5kb3cuaGVpZ2h0LCA9PSwgYWZsaW5lX3dpbmRv dy5oZWlnaHQpOworCiAgICAgZ19vYmplY3RfdW5yZWYoc2hvcnRUZXh0MSk7CiAgICAgZ19vYmpl Y3RfdW5yZWYoc2hvcnRUZXh0Mik7CiAgICAgZ19vYmplY3RfdW5yZWYobG9uZ1RleHQpOwotLSAK MS43LjMuNQoK