53300 2011-01-28 06:46:01 -0800 [GTK] Caret Offset is one off at the end of wrapped lines 2011-02-01 01:49:58 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro mario oldest_to_newest 341424 0 80446 jdiggs 2011-01-28 06:46:01 -0800 Created attachment 80446 test case Steps to reproduce: 1. Load the test case in Epiphany. 2. Launch Accerciser and select the accessible object associated with the paragraph from the test case. 3. Query the accessible text interface for the paragraph and use it to do the following: A. Position the caret one character to the left of the end of a line. Then check the caret offset. B. Position the caret at the end of the line from step 3A. Then check the caret offset. C. Position the caret at the beginning of the next line. Then check the caret offset. In [1]: text=acc.queryText() In [2]: text.caretOffset Out[2]: 110 <-- (one character before end of line) In [3]: text.caretOffset Out[3]: 112 <-- (end of line) In [4]: text.caretOffset Out[4]: 112 <-- (start of next line) In [5]: text.caretOffset Out[5]: 227 <-- (one character before end of line) In [6]: text.caretOffset Out[6]: 229 <-- (end of line) In [7]: text.caretOffset Out[7]: 229 <-- (start of next line) The impact of this bug is that Orca incorrectly presents the character/word at the end of the line when the user is navigating by character/word. (We wind up repeating the start of the following line.) 341644 1 jdiggs 2011-01-28 12:28:06 -0800 See also bug 53323 which *might* be related (?) 342694 2 80662 mario 2011-01-31 11:18:32 -0800 Created attachment 80662 Patch proposal + unit test Attached patch proposal + unit test 343086 3 mario 2011-02-01 01:49:58 -0800 Committed r77233: <http://trac.webkit.org/changeset/77233> 80446 2011-01-28 06:46:01 -0800 2011-01-28 06:46:01 -0800 test case parrot.html text/html 544 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+VGVzdDwvdGl0bGU+CjwvaGVhZD4KPGJvZHk+CjxwPgpJdCdz IG5vdCBwaW5pbiwnIGl0J3MgcGFzc2VkIG9uISBUaGlzIHBhcnJvdCBpcyBubyBtb3JlISBJdCBo YXMgY2Vhc2VkIHRvIGJlISBJdCdzIGV4cGlyZWQgYW5kIGdvbmUgdG8gbWVldCBpdHMgbWFrZXIh IFRoaXMgaXMgYSBsYXRlIHBhcnJvdCEgSXQncyBhIHN0aWZmISBCZXJlZnQgb2YgbGlmZSwgaXQg cmVzdHMgaW4gcGVhY2UhIElmIHlvdSBoYWRuJ3QgbmFpbGVkIGhpbSB0byB0aGUgcGVyY2ggaGUg d291bGQgYmUgcHVzaGluZyB1cCB0aGUgZGFpc2llcyEgSXRzIG1ldGFib2xpY2FsIHByb2Nlc3Nl cyBhcmUgb2YgaW50ZXJlc3Qgb25seSB0byBoaXN0b3JpYW5zISBJdCdzIGhvcHBlZCB0aGUgdHdp ZyEgSXQncyBzaHVmZmxlZCBvZmYgdGhpcyBtb3J0YWwgY29pbCEgSXQncyBydW4gZG93biB0aGUg Y3VydGFpbiBhbmQgam9pbmVkIHRoZSBjaG9pciBpbnZpc2libGUhIFRoaXMuLi4uIGlzIGFuIEVY LVBBUlJPVCEKPC9wPgo8L2JvZHk+CjwvaHRtbD4KCg== 80662 2011-01-31 11:18:32 -0800 2011-01-31 15:16:18 -0800 Patch proposal + unit test 0001-2011-01-31-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 5257 mario RnJvbSA1NWRmNzRmZTlhMzExMGI5NWVjOGEzZTBmNGY4YTJlM2M2Mzg4YjA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDMxIEphbiAyMDExIDIwOjA2OjE3ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0wMS0zMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBDYXJl dCBPZmZzZXQgaXMgb25lIG9mZiBhdCB0aGUgZW5kIG9mIHdyYXBwZWQgbGluZXMKICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMzMDAKCiAgICAgICAgQ29u c2lkZXIgbGluZWJyZWFrcyBhcyBzcGVjaWFsIGNhc2VzLgoKICAgICAgICAqIGFjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKICAgICAgICAob2JqZWN0 QW5kT2Zmc2V0VW5pZ25vcmVkKTogSW4gb3JkZXIgdG8gYXZvaWQgZ2V0dGluZyB3cm9uZyB2YWx1 ZXMKICAgICAgICB3aGVuIGFyb3VuZCBsaW5lYnJlYWtzLCB3ZSBuZWVkIHRvIHdvcmthcm91bmQg dGhpcyBieSBleHBsaWNpdGx5CiAgICAgICAgYXZvaWRpbmcgdGhvc2UgJ1xuJyB0ZXh0IG5vZGVz IGZyb20gYWZmZWN0aW5nIHRoZSByZXN1bHQgb2YKICAgICAgICBjYWxsaW5nIHRvIFRleHRJdGVy YXRvcjpyYW5nZUxlbmd0aCgpLgoKMjAxMS0wMS0zMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1z YW5jaGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK ICAgICAgICBbR1RLXSBDYXJldCBPZmZzZXQgaXMgb25lIG9mZiBhdCB0aGUgZW5kIG9mIHdyYXBw ZWQgbGluZXMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTMzMDAKCiAgICAgICAgVXBkYXRlIHVuaXQgdGVzdCB0byBjaGVjayB0aGUgZml4IGZvciB0aGlz IGJ1Zy4KCiAgICAgICAgKiB0ZXN0cy90ZXN0YXRrLmM6CiAgICAgICAgKHRlc3RXZWJraXRBdGtD YXJldE9mZnNldHNBbmRFeHRyYW5vdXNXaGl0ZVNwYWNlcyk6IFNldCBhbmQgZ2V0CiAgICAgICAg dGhlIGNhcmV0IG9mZnNldCBhdCB0aGUgZWRnZSBvZiB0aGUgbGluZS4KLS0tCiBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysr KysrKysrCiAuLi4vZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCAgICAgICAg ICB8ICAgMTYgKysrKysrKysrKysrKystLQogU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQv Z3RrL3Rlc3RzL3Rlc3RhdGsuYyAgICAgICAgICAgICAgICAgIHwgICAgNiArKysrKysKIDQgZmls ZXMgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNDA4NDE1MS4uN2Q3NTMyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTAx LTMxICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBDYXJldCBPZmZz ZXQgaXMgb25lIG9mZiBhdCB0aGUgZW5kIG9mIHdyYXBwZWQgbGluZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMzAwCisKKyAgICAgICAgQ29uc2lk ZXIgbGluZWJyZWFrcyBhcyBzcGVjaWFsIGNhc2VzLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgorICAgICAgICAob2JqZWN0 QW5kT2Zmc2V0VW5pZ25vcmVkKTogSW4gb3JkZXIgdG8gYXZvaWQgZ2V0dGluZyB3cm9uZyB2YWx1 ZXMKKyAgICAgICAgd2hlbiBhcm91bmQgbGluZWJyZWFrcywgd2UgbmVlZCB0byB3b3JrYXJvdW5k IHRoaXMgYnkgZXhwbGljaXRseQorICAgICAgICBhdm9pZGluZyB0aG9zZSAnXG4nIHRleHQgbm9k ZXMgZnJvbSBhZmZlY3RpbmcgdGhlIHJlc3VsdCBvZgorICAgICAgICBjYWxsaW5nIHRvIFRleHRJ dGVyYXRvcjpyYW5nZUxlbmd0aCgpLgorCiAyMDExLTAxLTI4ICBTaGVyaWZmIEJvdCAgPHdlYmtp dC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByNzY4OTMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9B Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKaW5kZXggOTlkYTA3 Yi4uOWJhYmJmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsv QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcApAQCAtNjMs NiArNjMsNyBAQAogI2luY2x1ZGUgIlRleHRFbmNvZGluZy5oIgogI2luY2x1ZGUgIlRleHRJdGVy YXRvci5oIgogI2luY2x1ZGUgIldlYktpdEFjY2Vzc2libGVIeXBlcmxpbmsuaCIKKyNpbmNsdWRl ICJ2aXNpYmxlX3VuaXRzLmgiCiAKICNpbmNsdWRlIDxhdGsvYXRrLmg+CiAjaW5jbHVkZSA8Z2xp Yi5oPgpAQCAtMjQ3Myw4ICsyNDc0LDE5IEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIG9iamVjdEFu ZE9mZnNldFVuaWdub3JlZChBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0LCBpCiAKICAg ICBOb2RlKiBub2RlID0gcmVhbE9iamVjdC0+bm9kZSgpOwogICAgIGlmIChub2RlKSB7Ci0gICAg ICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBSYW5nZTo6Y3JlYXRlKG5vZGUtPmRvY3VtZW50KCks IGZpcnN0UG9zaXRpb25Jbk5vZGUobm9kZSksIHJlYWxPYmplY3QtPnNlbGVjdGlvbigpLmVuZCgp KTsKLSAgICAgICAgb2Zmc2V0ID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUxlbmd0aChyYW5nZS5nZXQo KSk7CisgICAgICAgIFZpc2libGVQb3NpdGlvbiBzdGFydFBvc2l0aW9uID0gVmlzaWJsZVBvc2l0 aW9uKG5vZGUsIDAsIERPV05TVFJFQU0pOworICAgICAgICBWaXNpYmxlUG9zaXRpb24gZW5kUG9z aXRpb24gPSByZWFsT2JqZWN0LT5zZWxlY3Rpb24oKS52aXNpYmxlRW5kKCk7CisKKyAgICAgICAg aWYgKHN0YXJ0UG9zaXRpb24gPT0gZW5kUG9zaXRpb24pCisgICAgICAgICAgICBvZmZzZXQgPSAw OworICAgICAgICBlbHNlIGlmICghaXNTdGFydE9mTGluZShlbmRQb3NpdGlvbikpIHsKKyAgICAg ICAgICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBtYWtlUmFuZ2Uoc3RhcnRQb3NpdGlvbiwgZW5k UG9zaXRpb24ucHJldmlvdXMoKSk7CisgICAgICAgICAgICBvZmZzZXQgPSBUZXh0SXRlcmF0b3I6 OnJhbmdlTGVuZ3RoKHJhbmdlLmdldCgpKSArIDE7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlID0gbWFrZVJhbmdlKHN0YXJ0UG9zaXRpb24sIGVuZFBv c2l0aW9uKTsKKyAgICAgICAgICAgIG9mZnNldCA9IFRleHRJdGVyYXRvcjo6cmFuZ2VMZW5ndGgo cmFuZ2UuZ2V0KCkpOworICAgICAgICB9CisKICAgICB9CiAKICAgICByZXR1cm4gcmVhbE9iamVj dDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQvZ3RrL0NoYW5nZUxvZwppbmRleCBhZmRjMzc1Li40YmU0YjBkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMzEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2Fu Y2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtHVEtdIENhcmV0IE9mZnNldCBpcyBvbmUgb2ZmIGF0IHRoZSBlbmQgb2Ygd3Jh cHBlZCBsaW5lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTMzMDAKKworICAgICAgICBVcGRhdGUgdW5pdCB0ZXN0IHRvIGNoZWNrIHRoZSBmaXggZm9y IHRoaXMgYnVnLgorCisgICAgICAgICogdGVzdHMvdGVzdGF0ay5jOgorICAgICAgICAodGVzdFdl YmtpdEF0a0NhcmV0T2Zmc2V0c0FuZEV4dHJhbm91c1doaXRlU3BhY2VzKTogU2V0IGFuZCBnZXQK KyAgICAgICAgdGhlIGNhcmV0IG9mZnNldCBhdCB0aGUgZWRnZSBvZiB0aGUgbGluZS4KKwogMjAx MS0wMS0yNyAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0 cy90ZXN0YXRrLmMgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMKaW5kZXggZjdh NWM1OS4uZTQ0ZTMxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0 ay5jCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYwpAQCAtMjY1LDYgKzI2 NSwxMiBAQCBzdGF0aWMgdm9pZCB0ZXN0V2Via2l0QXRrQ2FyZXRPZmZzZXRzQW5kRXh0cmFub3Vz V2hpdGVTcGFjZXMoKQogICAgIGdpbnQgY2FyZXRPZmZzZXQgPSBhdGtfdGV4dF9nZXRfY2FyZXRf b2Zmc2V0KHRleHRPYmplY3QpOwogICAgIGdfYXNzZXJ0X2NtcGludChjYXJldE9mZnNldCwgPT0s IGNoYXJhY3RlckNvdW50IC0gMSk7CiAKKyAgICByZXN1bHQgPSBhdGtfdGV4dF9zZXRfY2FyZXRf b2Zmc2V0KHRleHRPYmplY3QsIGNoYXJhY3RlckNvdW50KTsKKyAgICBnX2Fzc2VydF9jbXBpbnQo cmVzdWx0LCA9PSwgVFJVRSk7CisKKyAgICBjYXJldE9mZnNldCA9IGF0a190ZXh0X2dldF9jYXJl dF9vZmZzZXQodGV4dE9iamVjdCk7CisgICAgZ19hc3NlcnRfY21waW50KGNhcmV0T2Zmc2V0LCA9 PSwgY2hhcmFjdGVyQ291bnQpOworCiAgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7CiB9CiAK LS0gCjEuNy4zLjUKCg==