53266 2011-01-27 16:17:26 -0800 Add WTFString method to compare equality with Vector<UChar> 2011-01-27 20:27:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 49845 1 abarth abarth abarth darin dglazkov eric webkit.review.bot oldest_to_newest 341110 0 abarth 2011-01-27 16:17:26 -0800 Add WTFString method to compare equality with Vector<UChar> 341111 1 80373 abarth 2011-01-27 16:18:35 -0800 Created attachment 80373 Patch 341133 2 80373 eric 2011-01-27 16:59:49 -0800 Comment on attachment 80373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80373&action=review Seems OK. > Source/JavaScriptCore/wtf/text/StringImpl.h:366 > + if (!a.size()) > + return true; > + return !memcmp(a.data(), b->characters(), b->length()); Is calling memcmp with length = 0 OK? If so then you don't need the !a.size() check. 341137 3 80373 abarth 2011-01-27 17:04:14 -0800 Comment on attachment 80373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80373&action=review >> Source/JavaScriptCore/wtf/text/StringImpl.h:366 >> + if (!a.size()) >> + return true; >> + return !memcmp(a.data(), b->characters(), b->length()); > > Is calling memcmp with length = 0 OK? If so then you don't need the !a.size() check. Sounds dodgy: http://coding.derkeiler.com/Archive/C_CPP/comp.lang.c/2004-07/0109.html 341180 4 darin 2011-01-27 17:45:14 -0800 (In reply to comment #3) > > Is calling memcmp with length = 0 OK? If so then you don't need the !a.size() check. > > Sounds dodgy: > http://coding.derkeiler.com/Archive/C_CPP/comp.lang.c/2004-07/0109.html Why the FUD? memcpy with length == 0 is definitely OK! 341181 5 darin 2011-01-27 17:45:27 -0800 (In reply to comment #4) > Why the FUD? memcpy with length == 0 is definitely OK! I mean memcmp. 341194 6 abarth 2011-01-27 17:55:53 -0800 > Why the FUD? memcpy with length == 0 is definitely OK! Even if one of the pointers is NULL? 341203 7 darin 2011-01-27 18:03:31 -0800 (In reply to comment #6) > > Why the FUD? memcmp with length == 0 is definitely OK! > > Even if one of the pointers is NULL? In practice, yes. I am pretty damned sure of this. And I think we rely on it. But the C standard does use wording that makes it seem a little ambiguous. 341215 8 abarth 2011-01-27 18:15:10 -0800 Okiedokes. Thanks. 341221 9 abarth 2011-01-27 18:21:05 -0800 Committed r76894: <http://trac.webkit.org/changeset/76894> 341265 10 webkit.review.bot 2011-01-27 19:47:31 -0800 Attachment 80373 did not build on chromium: Build output: http://queues.webkit.org/results/7597383 341287 11 webkit.review.bot 2011-01-27 20:27:11 -0800 http://trac.webkit.org/changeset/76894 might have broken GTK Linux 64-bit Debug 80373 2011-01-27 16:18:35 -0800 2011-01-27 18:01:59 -0800 Patch bug-53266-20110127161833.patch text/plain 2537 abarth ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRlZTA3ZTZhY2I2NGRmYjJlMmE2MTA1ZGU5ZTNk MjViYjI0OGVlZWIuLjMwNWQyMzliZWZjNjk3OTJjMWI3MmZkZDRiODM2ZTlhNTkzMjJlOTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTAxLTI3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIFdURlN0cmluZyBtZXRob2QgdG8gY29tcGFyZSBlcXVh bGl0eSB3aXRoIFZlY3RvcjxVQ2hhcj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUzMjY2CisKKyAgICAgICAgSSdtIHBsYW5uaW5nIHRvIHVzZSB0aGlz IG1ldGhvZCBpbiB0aGUgbmV3IFhTUyBmaWx0ZXIgaW1wbGVtZW50YXRpb24sCisgICAgICAgIGJ1 dCBpdCBzZWVtcyBnZW5lcmFsbHkgdXNlZnVsLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5n SW1wbC5oOgorICAgICAgICAoV1RGOjplcXVhbElnbm9yaW5nTnVsbGl0eSk6CisgICAgICAgICog d3RmL3RleHQvV1RGU3RyaW5nLmg6CisgICAgICAgIChXVEY6OmVxdWFsSWdub3JpbmdOdWxsaXR5 KToKKwogMjAxMS0wMS0yNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvdGV4dC9TdHJpbmdJbXBsLmgKaW5kZXggZGMxZGJiMjMyNTk1NmQ3MDhkMDkzOGY4YzU5ZDk0 ZjU2MzYzODRlNC4uNjExOTUwNjMwYTUyOGNiMTQzYjZjZmFiNjM2MzgxZjUyNjU5Y2ExOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC0zNTQsNiAr MzU0LDE4IEBAIGlubGluZSBib29sIGVxdWFsSWdub3JpbmdDYXNlKGNvbnN0IGNoYXIqIGEsIGNv bnN0IFVDaGFyKiBiLCB1bnNpZ25lZCBsZW5ndGgpIHsKIAogYm9vbCBlcXVhbElnbm9yaW5nTnVs bGl0eShTdHJpbmdJbXBsKiwgU3RyaW5nSW1wbCopOwogCit0ZW1wbGF0ZTxzaXplX3QgaW5saW5l Q2FwYWNpdHk+Citib29sIGVxdWFsSWdub3JpbmdOdWxsaXR5KGNvbnN0IFZlY3RvcjxVQ2hhciwg aW5saW5lQ2FwYWNpdHk+JiBhLCBTdHJpbmdJbXBsKiBiKQoreworICAgIGlmICghYikKKyAgICAg ICAgcmV0dXJuICFhLnNpemUoKTsKKyAgICBpZiAoYS5zaXplKCkgIT0gYi0+bGVuZ3RoKCkpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAoIWEuc2l6ZSgpKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICByZXR1cm4gIW1lbWNtcChhLmRhdGEoKSwgYi0+Y2hhcmFjdGVycygpLCBiLT5s ZW5ndGgoKSk7Cit9CisKIGludCBjb2RlUG9pbnRDb21wYXJlKGNvbnN0IFN0cmluZ0ltcGwqLCBj b25zdCBTdHJpbmdJbXBsKik7CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBpc1NwYWNlT3JOZXdsaW5l KFVDaGFyIGMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RG U3RyaW5nLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKaW5k ZXggY2I3MGIyZDVhYTQyYTFiN2ZlZTczMDVlYjY3OGQ1NzQ2ZDFmMzc2Ny4uMGFlZTJlZmQ3ZGYx NDRhODg1MzZkNzc3MjU2MmUwZWI1Y2YwMjcyZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvdGV4dC9XVEZTdHJpbmcuaApAQCAtMzY5LDYgKzM2OSw5IEBAIGlubGluZSBib29sIGVxdWFs UG9zc2libHlJZ25vcmluZ0Nhc2UoY29uc3QgU3RyaW5nJiBhLCBjb25zdCBTdHJpbmcmIGIsIGJv b2wgaWduCiAKIGlubGluZSBib29sIGVxdWFsSWdub3JpbmdOdWxsaXR5KGNvbnN0IFN0cmluZyYg YSwgY29uc3QgU3RyaW5nJiBiKSB7IHJldHVybiBlcXVhbElnbm9yaW5nTnVsbGl0eShhLmltcGwo KSwgYi5pbXBsKCkpOyB9CiAKK3RlbXBsYXRlPHNpemVfdCBpbmxpbmVDYXBhY2l0eT4KK2lubGlu ZSBib29sIGVxdWFsSWdub3JpbmdOdWxsaXR5KGNvbnN0IFZlY3RvcjxVQ2hhciwgaW5saW5lQ2Fw YWNpdHk+JiBhLCBjb25zdCBTdHJpbmcmIGIpIHsgcmV0dXJuIGVxdWFsSWdub3JpbmdOdWxsaXR5 KGEsIGIuaW1wbCgpKTsgfQorCiBpbmxpbmUgYm9vbCBvcGVyYXRvciEoY29uc3QgU3RyaW5nJiBz dHIpIHsgcmV0dXJuIHN0ci5pc051bGwoKTsgfQogCiBpbmxpbmUgdm9pZCBzd2FwKFN0cmluZyYg YSwgU3RyaW5nJiBiKSB7IGEuc3dhcChiKTsgfQo=