53149 2011-01-25 17:21:39 -0800 remove resize() check in DrawingBuffer 2011-01-25 18:13:56 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 reed reed commit-queue jamesr kbr oldest_to_newest 340035 0 reed 2011-01-25 17:21:39 -0800 DrawingBufer::reset() today checks if the new size is the same as its m_size, and if so, returns immediately. This does not match the semantics of <canvas>, which wants to clear its contents anytime the size is specified. 340041 1 80148 reed 2011-01-25 17:30:03 -0800 Created attachment 80148 fix for issue 340044 2 80149 reed 2011-01-25 17:34:19 -0800 Created attachment 80149 fix for issue 340045 3 reed 2011-01-25 17:34:45 -0800 uploaded new patch with more detail in ChangeLog 340046 4 80149 jamesr 2011-01-25 17:35:40 -0800 Comment on attachment 80149 fix for issue Looks good! R=me 340071 5 commit-queue 2011-01-25 18:13:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 80149: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html bug 52016 (author: jchaffraix@webkit.org) The commit-queue is continuing to process your patch. 340072 6 80149 commit-queue 2011-01-25 18:13:52 -0800 Comment on attachment 80149 fix for issue Clearing flags on attachment: 80149 Committed r76658: <http://trac.webkit.org/changeset/76658> 340073 7 commit-queue 2011-01-25 18:13:56 -0800 All reviewed patches have been landed. Closing bug. 80148 2011-01-25 17:30:03 -0800 2011-01-25 17:34:19 -0800 fix for issue drawingbufferpatch.txt text/plain 1935 reed SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NjY1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMjUgIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2Ug RHJhd2luZ0J1ZmZlciB0byBza2lwIHRoZSBtX3NpemU9PXNpemUgY2hlY2sgaW5zaWRlIHJlc2V0 KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMTQ5 CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGZvciB0aGlzIGNoYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0RyYXdpbmdCdWZmZXJDaHJvbWl1bS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEcmF3aW5nQnVmZmVyOjpEcmF3aW5nQnVmZmVyKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEcmF3aW5nQnVmZmVyOjpyZXNldCk6CisKIDIwMTEtMDEtMjUgIENyaXMgTmVja2FyICA8Y2Ru QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9EcmF3aW5nQnVmZmVyQ2hyb21pdW0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRHJh d2luZ0J1ZmZlckNocm9taXVtLmNwcAkocmV2aXNpb24gNzY1MDgpCisrKyBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0RyYXdpbmdCdWZmZXJDaHJvbWl1bS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTcyLDcgKzcyLDcgQEAgRHJhd2luZ0J1ZmZlcjo6RHJhd2luZ0J1ZmZlcihHcmFw aGljc0NvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIG11bHRpc2FtcGxlRXh0 ZW5zaW9uU3VwcG9ydGVkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIHBhY2tl ZERlcHRoU3RlbmNpbEV4dGVuc2lvblN1cHBvcnRlZCkKICAgICA6IG1fY29udGV4dChjb250ZXh0 KQotICAgICwgbV9zaXplKC0xLCAtMSkKKyAgICAsIG1fc2l6ZShzaXplKQogICAgICwgbV9tdWx0 aXNhbXBsZUV4dGVuc2lvblN1cHBvcnRlZChtdWx0aXNhbXBsZUV4dGVuc2lvblN1cHBvcnRlZCkK ICAgICAsIG1fcGFja2VkRGVwdGhTdGVuY2lsRXh0ZW5zaW9uU3VwcG9ydGVkKHBhY2tlZERlcHRo U3RlbmNpbEV4dGVuc2lvblN1cHBvcnRlZCkKICAgICAsIG1fZmJvKDApCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNwcAkocmV2aXNpb24g NzY1MDgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTQ1LDggKzE0NSw2IEBAIHZvaWQgRHJhd2luZ0J1ZmZlcjo6 cmVzaXplRGVwdGhTdGVuY2lsKGkKIAogdm9pZCBEcmF3aW5nQnVmZmVyOjpyZXNldChjb25zdCBJ bnRTaXplJiBuZXdTaXplKQogewotICAgIGlmIChtX3NpemUgPT0gbmV3U2l6ZSkKLSAgICAgICAg cmV0dXJuOwogICAgIG1fc2l6ZSA9IG5ld1NpemU7CiAKICAgICBpZiAoIW1fY29udGV4dCkK 80149 2011-01-25 17:34:19 -0800 2011-01-25 18:13:52 -0800 fix for issue drawingbufferpatch.txt text/plain 2139 reed SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NjY1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDEtMjUgIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcmF3aW5n QnVmZXI6OnJlc2V0KCkgdG9kYXkgY2hlY2tzIGlmIHRoZSBuZXcgc2l6ZSBpcyB0aGUgc2FtZSBh cyBpdHMKKyAgICAgICAgbV9zaXplLCBhbmQgaWYgc28sIHJldHVybnMgaW1tZWRpYXRlbHkuIFRo aXMgZG9lcyBub3QgbWF0Y2ggdGhlCisgICAgICAgIHNlbWFudGljcyBvZiA8Y2FudmFzPiwgd2hp Y2ggd2FudHMgdG8gY2xlYXIgaXRzIGNvbnRlbnRzIGFueXRpbWUgdGhlCisgICAgICAgIHNpemUg aXMgc3BlY2lmaWVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTMxNDkKKworICAgICAgICBUZXN0OiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIDxjYW52YXM+ IHRlc3RzIHVzaW5nIGdwdS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0RyYXdpbmdCdWZmZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmF3aW5nQnVm ZmVyOjpEcmF3aW5nQnVmZmVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJh d2luZ0J1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmF3aW5nQnVmZmVyOjpyZXNldCk6 CisKIDIwMTEtMDEtMjUgIENyaXMgTmVja2FyICA8Y2RuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9EcmF3aW5nQnVmZmVyQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRHJhd2luZ0J1ZmZlckNocm9taXVtLmNwcAko cmV2aXNpb24gNzY1MDgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0Ry YXdpbmdCdWZmZXJDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyLDcgKzcyLDcgQEAg RHJhd2luZ0J1ZmZlcjo6RHJhd2luZ0J1ZmZlcihHcmFwaGljc0NvbgogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBib29sIG11bHRpc2FtcGxlRXh0ZW5zaW9uU3VwcG9ydGVkLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBib29sIHBhY2tlZERlcHRoU3RlbmNpbEV4dGVuc2lvblN1 cHBvcnRlZCkKICAgICA6IG1fY29udGV4dChjb250ZXh0KQotICAgICwgbV9zaXplKC0xLCAtMSkK KyAgICAsIG1fc2l6ZShzaXplKQogICAgICwgbV9tdWx0aXNhbXBsZUV4dGVuc2lvblN1cHBvcnRl ZChtdWx0aXNhbXBsZUV4dGVuc2lvblN1cHBvcnRlZCkKICAgICAsIG1fcGFja2VkRGVwdGhTdGVu Y2lsRXh0ZW5zaW9uU3VwcG9ydGVkKHBhY2tlZERlcHRoU3RlbmNpbEV4dGVuc2lvblN1cHBvcnRl ZCkKICAgICAsIG1fZmJvKDApCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9E cmF3aW5nQnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dwdS9EcmF3aW5nQnVmZmVyLmNwcAkocmV2aXNpb24gNzY1MDgpCisrKyBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ1 LDggKzE0NSw2IEBAIHZvaWQgRHJhd2luZ0J1ZmZlcjo6cmVzaXplRGVwdGhTdGVuY2lsKGkKIAog dm9pZCBEcmF3aW5nQnVmZmVyOjpyZXNldChjb25zdCBJbnRTaXplJiBuZXdTaXplKQogewotICAg IGlmIChtX3NpemUgPT0gbmV3U2l6ZSkKLSAgICAgICAgcmV0dXJuOwogICAgIG1fc2l6ZSA9IG5l d1NpemU7CiAKICAgICBpZiAoIW1fY29udGV4dCkK