52863 2011-01-20 20:01:33 -0800 nrwt: suppress remaining integration tests for now 2011-02-17 17:33:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 48072 1 dpranke dpranke abarth mihaip ojan tony oldest_to_newest 337828 0 dpranke 2011-01-20 20:01:33 -0800 nrwt: suppress remaining integration tests for now 337829 1 79687 dpranke 2011-01-20 20:02:02 -0800 Created attachment 79687 Patch 337961 2 79687 eric 2011-01-21 02:40:44 -0800 Comment on attachment 79687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79687&action=review Maybe we should think about creating a new file suffix _integrationtest.py or something and having test-webkitpy know how to run them with passed --integration or some-such? This looks good except for the None to [] change. > Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:115 > + def get_printer(self, args=[], single_threaded=False, None is preferred for default arguments. The default values are shared by all instances, so if anything ever tried to mutate that args value, we'd have bad news bears. :) 338137 3 dpranke 2011-01-21 10:18:49 -0800 cc'ing some other people in case they have thoughts on this ... 1) regarding integration tests, my thinking had been to modify test-webkitpy to support some sort of @integration decorator that could mark up tests or classes. I would prefer to keep things in a single file because I think that allows for much better reuse of fixtures in between tests. 2) regarding using None instead of [] as a default argument value, Mihai had suggested in another code review a few days ago that [] might be preferable to None in functions where you weren't modifying the argument inside the function (the advantage is that it's clearer and shorter). That said, it's certainly more fragile. Arguably there's a middle ground where it might be safe to use [] if the variable is never passed to another function (so at least it's visible and in your control), but after having thought about it more, I think I'm inclined to agree with you that we should just use None to be safe. Anyone else have any thoughts on either point? 338377 4 dpranke 2011-01-21 15:23:59 -0800 Committed r76398: <http://trac.webkit.org/changeset/76398> 338400 5 mihaip 2011-01-21 15:45:49 -0800 (In reply to comment #3) > 2) regarding using None instead of [] as a default argument value, Mihai had suggested in another code review a few days ago that [] might be preferable to None in functions where you weren't modifying the argument inside the function (the advantage is that it's clearer and shorter). That said, it's certainly more fragile. Arguably there's a middle ground where it might be safe to use [] if the variable is never passed to another function (so at least it's visible and in your control), but after having thought about it more, I think I'm inclined to agree with you that we should just use None to be safe. I don't actually have a strong preference about this, so if you want to always use None (to be safe, in case the function is changed to modify the argument later), I can promise to point it out in reviews :) 338404 6 mihaip 2011-01-21 15:49:07 -0800 (In reply to comment #5) > I can promise to point it out in reviews :) Err, _not_ point it out in reviews. 353271 7 dpranke 2011-02-17 17:33:05 -0800 *** Bug 46322 has been marked as a duplicate of this bug. *** 79687 2011-01-20 20:02:02 -0800 2011-01-21 02:40:43 -0800 Patch bug-52863-20110120200201.patch text/plain 5202 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNzE2 NWExNGFhNTU5ZDcxMDQxM2M2NjUwNTFlZThiZWVkNzU4YzViLi5mZGExZGY0ZDIwZGM0MDZiMGNh MjIyNjFhNDE3OWU3ZmM0NDhjMTg5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTEtMDEtMjAgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3VwcHJlc3MgYSBmZXcgcmVtYWluaW5nIGludGVncmF0aW9uIHRl c3RzIHNvIHRoYXQgbm9uZSBvZiB0aGUKKyAgICAgICAgbGF5b3V0X3Rlc3QgdW5pdCB0ZXN0cyBl dmVyIHJlYWQgZnJvbSB0aGUgZmlsZXN5c3RlbSBvciBsYXVuY2gKKyAgICAgICAgc3VicHJvY2Vz c2VzIHRoYXQgYXJlbid0IHBhcnQgb2YgdGhlIHVuaXQgdGVzdHMuCisKKyAgICAgICAgQWxzbyBm aXggYSBtaW5vciBidWcgaW4gdGhlIHByaW50aW5nIHVuaXQgdGVzdHMgdGhhdCB3YXMKKyAgICAg ICAgaW5jb3JyZWN0bHkgcmVseWluZyBvbiBzeXMuYXJndi4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI4NjMKKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3ByaW50aW5nX3VuaXR0ZXN0LnB5 OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0 Y2FzZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Vi a2l0X3Rlc3RzX3VuaXR0ZXN0LnB5OgorCisyMDExLTAxLTIwICBEaXJrIFByYW5rZSAgPGRwcmFu a2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAg ICAgICAgRGlzYWJsZSB0aGUgdGVzdHMgdGhhdCBzdGFydCBhbmQgc3RvcCB0aGUgaHR0cCBzZXJ2 ZXIgYW5kIHdlYgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmdfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZ191bml0dGVzdC5weQpp bmRleCBjM2ViMDRmYzE3NjcyY2I0YzUzZDk4OTU5ZTM5N2UxNGIzMDcwNjRjLi5jYTcxM2YzZWQ3 ZWJhNDE5MzJhOWFlZjVkNzJjZjVjNWNmNWMxZDExIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZ191bml0dGVzdC5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2Fn ZS9wcmludGluZ191bml0dGVzdC5weQpAQCAtMTEyLDcgKzExMiw3IEBAIGNsYXNzIFRlc3RVdGls aXR5RnVuY3Rpb25zKHVuaXR0ZXN0LlRlc3RDYXNlKToKIAogCiBjbGFzcyAgVGVzdHByaW50ZXIo dW5pdHRlc3QuVGVzdENhc2UpOgotICAgIGRlZiBnZXRfcHJpbnRlcihzZWxmLCBhcmdzPU5vbmUs IHNpbmdsZV90aHJlYWRlZD1GYWxzZSwKKyAgICBkZWYgZ2V0X3ByaW50ZXIoc2VsZiwgYXJncz1b XSwgc2luZ2xlX3RocmVhZGVkPUZhbHNlLAogICAgICAgICAgICAgICAgICAgIGlzX2Z1bGx5X3Bh cmFsbGVsPUZhbHNlKToKICAgICAgICAgcHJpbnRpbmdfb3B0aW9ucyA9IHByaW50aW5nLnByaW50 X29wdGlvbnMoKQogICAgICAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2Vy KG9wdGlvbl9saXN0PXByaW50aW5nX29wdGlvbnMpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKaW5kZXggYzc4 NDZjMzFmNzI0NDMwN2U5Yjg0YTFhNmE4YTA5ODgwZGFiYjFkOS4uMGIwM2I0YzBhMDJmYjg4OWM2 ZTcyM2QyNmQxMmMzODQxMjhhMWU3MSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weQpAQCAtNTcsNyArNTcs NyBAQCBjbGFzcyBQb3J0VGVzdENhc2UodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBwb3J0 LnN0YXJ0X2h0dHBfc2VydmVyKCkKICAgICAgICAgcG9ydC5zdG9wX2h0dHBfc2VydmVyKCkKIAot ICAgIGRlZiB0ZXN0X2ltYWdlX2RpZmYoc2VsZik6CisgICAgZGVmIGRpc2FibGVkX3Rlc3RfaW1h Z2VfZGlmZihzZWxmKToKICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KCkKICAgICAgICAg aWYgbm90IHBvcnQ6CiAgICAgICAgICAgICByZXR1cm4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0 ZXN0LnB5CmluZGV4IGZmYzk3ZGQ4NjBkOGZkYjkwZTZhOGY0N2NjNDAzYjExMzg5MmZmOWEuLjY3 N2JlY2QyNTk0M2ZjNDNlNmQzZTExMjg0NDBjYTNhNmM2ODU5NzQgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3Qu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0c191bml0dGVzdC5weQpAQCAtOTgsOSArOTgsOSBAQCBkZWYgcGFzc2luZ19ydW4oZXh0cmFf YXJncz1Ob25lLCBwb3J0X29iaj1Ob25lLCByZWNvcmRfcmVzdWx0cz1GYWxzZSwKICAgICByZXR1 cm4gcmVzID09IDAKIAogCi1kZWYgbG9nZ2luZ19ydW4oZXh0cmFfYXJncz1Ob25lLCBwb3J0X29i aj1Ob25lLCB0ZXN0c19pbmNsdWRlZD1GYWxzZSwgZmlsZXN5c3RlbT1Ob25lKToKK2RlZiBsb2dn aW5nX3J1bihleHRyYV9hcmdzPU5vbmUsIHBvcnRfb2JqPU5vbmUsIHJlY29yZF9yZXN1bHRzPUZh bHNlLCB0ZXN0c19pbmNsdWRlZD1GYWxzZSwgZmlsZXN5c3RlbT1Ob25lKToKICAgICBvcHRpb25z LCBwYXJzZWRfYXJncyA9IHBhcnNlX2FyZ3MoZXh0cmFfYXJncz1leHRyYV9hcmdzLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWNvcmRfcmVzdWx0cz1GYWxzZSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVjb3JkX3Jlc3VsdHM9cmVjb3Jk X3Jlc3VsdHMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRlc3RzX2lu Y2x1ZGVkPXRlc3RzX2luY2x1ZGVkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBwcmludF9ub3RoaW5nPUZhbHNlKQogICAgIHVzZXIgPSBNb2NrVXNlcigpCkBAIC0yNDAs NyArMjQwLDkgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgZGVm IHRlc3RfbGFzdF9yZXN1bHRzKHNlbGYpOgogICAgICAgICBmcyA9IHBvcnQudW5pdF90ZXN0X2Zp bGVzeXN0ZW0oKQotICAgICAgICBwYXNzaW5nX3J1bihbJy0tY2xvYmJlci1vbGQtcmVzdWx0cydd LCByZWNvcmRfcmVzdWx0cz1UcnVlLCBmaWxlc3lzdGVtPWZzKQorICAgICAgICAjIFdlIGRvIGEg bG9nZ2luZyBydW4gaGVyZSBpbnN0ZWFkIG9mIGEgcGFzc2luZyBydW4gaW4gb3JkZXIgdG8KKyAg ICAgICAgIyBzdXBwcmVzcyB0aGUgb3V0cHV0IGZyb20gdGhlIGpzb24gZ2VuZXJhdG9yLgorICAg ICAgICAocmVzLCBidWlsZGJvdF9vdXRwdXQsIHJlZ3VsYXJfb3V0cHV0LCB1c2VyKSA9IGxvZ2dp bmdfcnVuKFsnLS1jbG9iYmVyLW9sZC1yZXN1bHRzJ10sIHJlY29yZF9yZXN1bHRzPVRydWUsIGZp bGVzeXN0ZW09ZnMpCiAgICAgICAgIChyZXMsIGJ1aWxkYm90X291dHB1dCwgcmVndWxhcl9vdXRw dXQsIHVzZXIpID0gbG9nZ2luZ19ydW4oCiAgICAgICAgICAgICBbJy0tcHJpbnQtbGFzdC1mYWls dXJlcyddLCBmaWxlc3lzdGVtPWZzKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJlZ3VsYXJf b3V0cHV0LmdldCgpLCBbJ1xuXG4nXSkKQEAgLTUxOSwxNSArNTIxLDE0IEBAIGNsYXNzIERyeXJ1 blRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICMgY2hyb21pdW0gcGxhdGZvcm1zIHJlcXVp cmUgYSBjaHJvbWl1bSBjaGVja291dCwgYW5kIHRoZSBtYWMgcGxhdGZvcm0KICAgICAjIHJlcXVp cmVzIGZjbnRsLCBzbyBpdCBjYW4ndCBiZSB0ZXN0ZWQgb24gd2luMzIsIGV0Yy4gVGhlcmUgaXMK ICAgICAjIHByb2JhYmx5IGEgYmV0dGVyIHdheSBvZiBoYW5kbGluZyB0aGlzLgotICAgIGRlZiB0 ZXN0X2RhcndpbihzZWxmKToKKyAgICBkZWYgZGlzYWJsZWRfdGVzdF9kYXJ3aW4oc2VsZik6CiAg ICAgICAgIGlmIHN5cy5wbGF0Zm9ybSAhPSAiZGFyd2luIjoKICAgICAgICAgICAgIHJldHVybgog Ci0gICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwYXNzaW5nX3J1bihbJy0tcGxhdGZvcm0nLCAndGVz dCddKSkKLSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVuKFsnLS1wbGF0Zm9ybScs ICdkcnlydW4nLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdmYXN0L2h0 bWwnXSkpCi0gICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwYXNzaW5nX3J1bihbJy0tcGxhdGZvcm0n LCAnZHJ5cnVuLW1hYycsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Zh c3QvaHRtbCddKSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVuKFsnLS1wbGF0 Zm9ybScsICdkcnlydW4nLCAnZmFzdC9odG1sJ10sCisgICAgICAgICAgICAgICAgICAgICAgICB0 ZXN0c19pbmNsdWRlZD1UcnVlKSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVu KFsnLS1wbGF0Zm9ybScsICdkcnlydW4tbWFjJywgJ2Zhc3QvaHRtbCddLAorICAgICAgICAgICAg ICAgICAgICAgICAgdGVzdHNfaW5jbHVkZWQ9VHJ1ZSkpCiAKICAgICBkZWYgdGVzdF90ZXN0KHNl bGYpOgogICAgICAgICBzZWxmLmFzc2VydFRydWUocGFzc2luZ19ydW4oWyctLXBsYXRmb3JtJywg J2RyeXJ1bi10ZXN0JywK