52817 2011-01-20 08:47:11 -0800 QtTestBrowser should have seperate menu for Settings 2011-01-20 14:51:09 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 mansi.mithal webkit-unassigned commit-queue laszlo.gombos tonikitoo oldest_to_newest 337366 0 mansi.mithal 2011-01-20 08:47:11 -0800 QtTestBrowser should have seperate menu for "Settings" and move "Enable interrupting JS scripts" and "Enable js pop up windows" under the "Settings" menu 337499 1 79632 mansi.mithal 2011-01-20 12:19:59 -0800 Created attachment 79632 Adds a new menu item and move the settings under it. 337546 2 79632 tonikitoo 2011-01-20 13:20:57 -0800 Comment on attachment 79632 Adds a new menu item and move the settings under it. Why not moving Spatial Navigation, Frame flattening, etc at once? 337549 3 tonikitoo 2011-01-20 13:22:07 -0800 Also, you can use the "Depends on" and "Blocks" fields to set inter-dependencies between bugs. 337618 4 commit-queue 2011-01-20 14:48:26 -0800 The commit-queue encountered the following flaky tests while processing attachment 79632: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 337623 5 79632 commit-queue 2011-01-20 14:51:04 -0800 Comment on attachment 79632 Adds a new menu item and move the settings under it. Clearing flags on attachment: 79632 Committed r76286: <http://trac.webkit.org/changeset/76286> 337624 6 commit-queue 2011-01-20 14:51:09 -0800 All reviewed patches have been landed. Closing bug. 79632 2011-01-20 12:19:59 -0800 2011-01-20 14:51:04 -0800 Adds a new menu item and move the settings under it. 52817.patch text/plain 2727 mansi.mithal SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2MjY3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDEtMjAgIE1hbnNpIE1pdGhhbCAgPG1hbnNpLm1pdGhhbEBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUXRU ZXN0QnJvd3NlciBzaG91bGQgaGF2ZSBhIHNlcGVyYXRlIG1lbnUgZm9yIFNldHRpbmdzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjgxNworICAgICAg ICAKKyAgICAgICAgQWRkZWQgYSBuZXcgbWVudSBpdGVtIG5hbWVkICJTZXR0aW5ncyIKKyAgICAg ICAgYW5kIG1vdmVkIHRoZSAiRW5hYmxlIGludGVycnVwdGluZyBqcyBzY3JpcHRzIiBhbmQgIkVu YWJsZSBqcyBwb3AgdXAgd2luZG93cyIgdW5kZXIgdGhlICJTZXR0aW5ncyIgbWVudSAKKworICAg ICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwOgorICAgICAgICAoTGF1bmNo ZXJXaW5kb3c6OmNyZWF0ZUNocm9tZSk6CisKIDIwMTEtMDEtMjAgIE1hY2llaiBTdGFjaG93aWFr ICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRl eDogVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAJKHJldmlzaW9uIDc2MDMwKQor KysgVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI1NiwxNiArMjU2LDYgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkK IAogICAgIHRvb2xzTWVudS0+YWRkU2VwYXJhdG9yKCk7CiAKLSAgICBRQWN0aW9uKiB0b2dnbGVJ bnRlcnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQgPSB0b29sc01lbnUtPmFkZEFjdGlvbigiRW5h YmxlIGludGVycnVwdGluZyBqcyBzY3JpcHRzIiwgdGhpcywgU0xPVCh0b2dnbGVJbnRlcnJ1cHRp bmdKYXZhU2NyaXB0RW5hYmxlZChib29sKSkpOwotICAgIHRvZ2dsZUludGVycnVwdGluZ0phdmFT Y3JpcHRlRW5hYmxlZC0+c2V0Q2hlY2thYmxlKHRydWUpOwotICAgIHRvZ2dsZUludGVycnVwdGlu Z0phdmFTY3JpcHRlRW5hYmxlZC0+c2V0Q2hlY2tlZChmYWxzZSk7Ci0KLSAgICBRQWN0aW9uKiB0 b2dnbGVKYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MgPSB0b29sc01lbnUtPmFkZEFjdGlvbigiRW5h YmxlIGpzIHBvcHVwIHdpbmRvd3MiLCB0aGlzLCBTTE9UKHRvZ2dsZUphdmFzY3JpcHRDYW5PcGVu V2luZG93cyhib29sKSkpOwotICAgIHRvZ2dsZUphdmFzY3JpcHRDYW5PcGVuV2luZG93cy0+c2V0 Q2hlY2thYmxlKHRydWUpOwotICAgIHRvZ2dsZUphdmFzY3JpcHRDYW5PcGVuV2luZG93cy0+c2V0 Q2hlY2tlZChmYWxzZSk7Ci0KLSAgICB0b29sc01lbnUtPmFkZFNlcGFyYXRvcigpOwotCiAgICAg UUFjdGlvbiogdXNlckFnZW50QWN0aW9uID0gdG9vbHNNZW51LT5hZGRBY3Rpb24oIkNoYW5nZSBV c2VyIEFnZW50IiwgdGhpcywgU0xPVChzaG93VXNlckFnZW50RGlhbG9nKCkpKTsKICAgICB1c2Vy QWdlbnRBY3Rpb24tPnNldFNob3J0Y3V0KFFLZXlTZXF1ZW5jZShRdDo6Q1RSTCB8IFF0OjpTSElG VCB8IFF0OjpLZXlfVSkpOwogCkBAIC0zNzEsNiArMzYxLDE3IEBAIHZvaWQgTGF1bmNoZXJXaW5k b3c6OmNyZWF0ZUNocm9tZSgpCiAgICAgc2hvd0ZQUy0+c2V0RW5hYmxlZChpc0dyYXBoaWNzQmFz ZWQoKSk7CiAgICAgc2hvd0ZQUy0+Y29ubmVjdCh0b2dnbGVHcmFwaGljc1ZpZXcsIFNJR05BTCh0 b2dnbGVkKGJvb2wpKSwgU0xPVChzZXRFbmFibGVkKGJvb2wpKSk7CiAgICAgc2hvd0ZQUy0+c2V0 Q2hlY2tlZChtX3dpbmRvd09wdGlvbnMuc2hvd0ZyYW1lUmF0ZSk7CisKKyAgICBRTWVudSogc2V0 dGluZ3NNZW51ID0gbWVudUJhcigpLT5hZGRNZW51KCImU2V0dGluZ3MiKTsKKworICAgIFFBY3Rp b24qIHRvZ2dsZUludGVycnVwdGluZ0phdmFTY3JpcHRlRW5hYmxlZCA9IHNldHRpbmdzTWVudS0+ YWRkQWN0aW9uKCJFbmFibGUgaW50ZXJydXB0aW5nIGpzIHNjcmlwdHMiLCB0aGlzLCBTTE9UKHRv Z2dsZUludGVycnVwdGluZ0phdmFTY3JpcHRFbmFibGVkKGJvb2wpKSk7CisgICAgdG9nZ2xlSW50 ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkLT5zZXRDaGVja2FibGUodHJ1ZSk7CisgICAgdG9n Z2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkLT5zZXRDaGVja2VkKGZhbHNlKTsKKwor ICAgIFFBY3Rpb24qIHRvZ2dsZUphdmFzY3JpcHRDYW5PcGVuV2luZG93cyA9IHNldHRpbmdzTWVu dS0+YWRkQWN0aW9uKCJFbmFibGUganMgcG9wdXAgd2luZG93cyIsIHRoaXMsIFNMT1QodG9nZ2xl SmF2YXNjcmlwdENhbk9wZW5XaW5kb3dzKGJvb2wpKSk7CisgICAgdG9nZ2xlSmF2YXNjcmlwdENh bk9wZW5XaW5kb3dzLT5zZXRDaGVja2FibGUodHJ1ZSk7CisgICAgdG9nZ2xlSmF2YXNjcmlwdENh bk9wZW5XaW5kb3dzLT5zZXRDaGVja2VkKGZhbHNlKTsKKwogI2VuZGlmCiB9CiAK