52680 2011-01-18 16:14:44 -0800 [chromium] Notify WebViewClient when spellcheck state changes 2011-01-21 12:13:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sail webkit-unassigned commit-queue fishd morrita ojan rniwa thakis tkent tony webkit.review.bot oldest_to_newest 336184 0 sail 2011-01-18 16:14:44 -0800 [chromium] Event for spellcheck menu 336191 1 79352 sail 2011-01-18 16:16:07 -0800 Created attachment 79352 Patch 336192 2 sail 2011-01-18 16:19:29 -0800 This is a part of the Chromium change to enable the "Check Spelling While Typing" menu item. It adds a event to allow clients to know when the continuous spell checking state has changed. See: http://codereview.chromium.org/6020017/ 336193 3 thakis 2011-01-18 16:20:56 -0800 Looks good to me, but I'm not a reviewer. 336196 4 79352 rniwa 2011-01-18 16:28:02 -0800 Comment on attachment 79352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79352&action=review > Source/WebKit/chromium/public/WebViewClient.h:192 > + // This method is called when continuous spelling is enabled or disabled. > + virtual void continuousSpellCheckingEnabledStateChanged() { } > + I don't think this should be a public member function. It should at least be private. 336198 5 rniwa 2011-01-18 16:31:17 -0800 (In reply to comment #4) > (From update of attachment 79352 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79352&action=review > > > Source/WebKit/chromium/public/WebViewClient.h:192 > > + // This method is called when continuous spelling is enabled or disabled. > > + virtual void continuousSpellCheckingEnabledStateChanged() { } > > + > > I don't think this should be a public member function. It should at least be private. I take it back. I thought this was added to WebEditorClient.h 336199 6 79352 rniwa 2011-01-18 16:34:33 -0800 Comment on attachment 79352 Patch r=me now that I understand why this change is needed. 336200 7 79352 rniwa 2011-01-18 16:35:05 -0800 Comment on attachment 79352 Patch Oops, please update ChangeLog. 336203 8 79353 sail 2011-01-18 16:40:21 -0800 Created attachment 79353 Patch 336427 9 commit-queue 2011-01-19 04:32:21 -0800 The commit-queue encountered the following flaky tests while processing attachment 79353: http/tests/appcache/fallback.html bug 52710 (authors: ap@webkit.org and michaeln@google.com) The commit-queue is continuing to process your patch. 336428 10 79353 commit-queue 2011-01-19 04:32:49 -0800 Comment on attachment 79353 Patch Rejecting attachment 79353 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'la..." exit_code: 1 Last 500 characters of output: n/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 76109 = 060014058f4dca178941270f8f25cad11e3c5110 r76110 = cfbc645577b3375c8578ec30aeacdbee54eb4fca r76111 = 74f79aced1389d503321aa45d3fd024f20010694 r76112 = da68231a03735b50fd0711d1aa0d4939131b9a02 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://queues.webkit.org/results/7584193 336519 11 79425 sail 2011-01-19 07:39:37 -0800 Created attachment 79425 Patch 336520 12 webkit.review.bot 2011-01-19 07:41:44 -0800 Attachment 79425 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LANG = "en_US.US-ASCII" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). Updating OpenSource perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LANG = "en_US.US-ASCII" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 132. If any of these errors are false positives, please file a bug against check-webkit-style. 336524 13 79425 thakis 2011-01-19 07:53:15 -0800 Comment on attachment 79425 Patch Usually, the commit queue fills in the reviewer automatically. I wonder why it didn't this time. 336532 14 thakis 2011-01-19 07:58:54 -0800 kling on IRC tells me that the tools didn't work in this case because patch set 1 had "r+ with comments", and the follow-up patch only had cq+. The tools only work if the final patch has the r+ bit set; i.e. if you get an "r+ with comments" and a non-reviewer sets cq+, you need to "manually" fill in the reviewer when you address the comments. (There's a script that can do this for you iirc.) 336551 15 79425 fishd 2011-01-19 08:41:27 -0800 Comment on attachment 79425 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79425&action=review > Source/WebKit/chromium/public/WebViewClient.h:191 > + virtual void continuousSpellCheckingEnabledStateChanged() { } This function name is a real mouthful. We also have a naming convention for methods like this, where they start with "didChange" instead. So, didChangeContinuousSpellCheckingEnabledState would be more consistent. I still find this method name to be overly verbose. Also, this method is on WebViewClient.h, and yet the corresponding methods to query the "spellchecking" state lives on WebFrame. shouldn't this notification method live on WebFrameClient, then? 336554 16 fishd 2011-01-19 08:43:13 -0800 How about didToggleContinuousSpellChecking as a name? That is nice because "toggle" isn't precise about whether the feature was enabled or disabled. You have to query WebFrame::isContinuousSpellCheckingEnabled. Also, "toggle" is used by the corresponding EditorClient method. 336555 17 fishd 2011-01-19 08:44:39 -0800 One more comment: Should WebFrameClient::didToggleContinuousSpellChecking be called in response to WebFrame::enableContinousSpellChecking? I'm assuming that you don't need it to be, but just from studying the interfaces it is not obvious that it behaves this way. You should add a comment explaining this subtle behavior. 336645 18 79452 sail 2011-01-19 10:56:50 -0800 Created attachment 79452 Patch 336675 19 sail 2011-01-19 11:38:14 -0800 (In reply to comment #17) > One more comment: > > Should WebFrameClient::didToggleContinuousSpellChecking be called in response to WebFrame::enableContinousSpellChecking? I'm assuming that you don't need it to be, but just from studying the interfaces it is not obvious that it behaves this way. You should add a comment explaining this subtle behavior. I added a comment to WebFrameImpl::enableContinuousSpellChecking() noting that didToggleContinuousSpellChecking is called in EditorClientImpl. 338243 20 79452 commit-queue 2011-01-21 12:13:30 -0800 Comment on attachment 79452 Patch Clearing flags on attachment: 79452 Committed r76377: <http://trac.webkit.org/changeset/76377> 338244 21 commit-queue 2011-01-21 12:13:38 -0800 All reviewed patches have been landed. Closing bug. 79352 2011-01-18 16:16:07 -0800 2011-01-18 16:40:18 -0800 Patch bug-52680-20110118161605.patch text/plain 2149 sail ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMGZlZjkwMjdiMTJkZTU1MjkyMjMzNmI2NTE3 OTU5NzZiNzRiZTQ3MS4uYzQ5NTgxZTEwNDNiYWRlNGNkMDM4YzY1MDA0NWRlZDA4ZTYyNjUzMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMS0xOCAg U2FpbGVzaCBBZ3Jhd2FsICA8c2FpbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBFdmVudCBmb3Igc3BlbGxj aGVjayBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MjY4MAorCisgICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAgICAgICAgKFdl YktpdDo6V2ViVmlld0NsaWVudDo6Y29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkU3RhdGVD aGFuZ2VkKToKKyAgICAgICAgKiBzcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkVkaXRvckNsaWVudEltcGw6OnRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5nKToK KwogMjAxMS0wMS0xOCAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJWaWV3Q2xpZW50LmgKaW5kZXggMDhmYjk0MjZhOTg4NzNlMzBhZWYwMzJhMGRkODhj YTQ2YTEyM2E0Yi4uZDdiMzc2ZDU0NzJiNjlkZmUyMzZhMjM4N2JiMTk2ZDAyMTZkYTljMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtMTg3 LDYgKzE4Nyw5IEBAIHB1YmxpYzoKICAgICAvLyBVcGRhdGUgdGhlIHNwZWxsaW5nIFVJIHdpdGgg dGhlIGdpdmVuIHdvcmQuCiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZVNwZWxsaW5nVUlXaXRoTWlz c3BlbGxlZFdvcmQoY29uc3QgV2ViU3RyaW5nJiB3b3JkKSB7IH0KIAorICAgIC8vIFRoaXMgbWV0 aG9kIGlzIGNhbGxlZCB3aGVuIGNvbnRpbnVvdXMgc3BlbGxpbmcgaXMgZW5hYmxlZCBvciBkaXNh YmxlZC4KKyAgICB2aXJ0dWFsIHZvaWQgY29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkU3Rh dGVDaGFuZ2VkKCkgeyB9CisKIAogICAgIC8vIERpYWxvZ3MgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuY3BwCmluZGV4IDE5YjU4NzMwOTIz MDVjODEwNjcwNGMxM2ZjODIyZDMwYTg1MjBiMGQuLjMwN2VhMzEyNTA5NmU2ZDQwY2FiNjMwZDMy ZGIzNDFjZTQ5NWMzYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Vk aXRvckNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRv ckNsaWVudEltcGwuY3BwCkBAIC0xNjEsNiArMTYxLDggQEAgdm9pZCBFZGl0b3JDbGllbnRJbXBs Ojp0b2dnbGVDb250aW51b3VzU3BlbGxDaGVja2luZygpCiAgICAgICAgIG1fc3BlbGxDaGVja1Ro aXNGaWVsZFN0YXR1cyA9IFNwZWxsQ2hlY2tGb3JjZWRPZmY7CiAgICAgZWxzZQogICAgICAgICBt X3NwZWxsQ2hlY2tUaGlzRmllbGRTdGF0dXMgPSBTcGVsbENoZWNrRm9yY2VkT247CisgICAgaWYg KG1fd2ViVmlldy0+Y2xpZW50KCkpCisgICAgICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmNvbnRp bnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZFN0YXRlQ2hhbmdlZCgpOwogfQogCiBib29sIEVkaXRv ckNsaWVudEltcGw6OmlzR3JhbW1hckNoZWNraW5nRW5hYmxlZCgpCg== 79353 2011-01-18 16:40:21 -0800 2011-01-19 07:39:33 -0800 Patch bug-52680-20110118164020.patch text/plain 2174 sail ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMGZlZjkwMjdiMTJkZTU1MjkyMjMzNmI2NTE3 OTU5NzZiNzRiZTQ3MS4uMGZjZDk4OWI3Njk2ZmUzNWI3ZmE1NTRjNmE4NjAyY2EzOTI0Njc0YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMS0xOCAg U2FpbGVzaCBBZ3Jhd2FsICA8c2FpbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBOb3RpZnkgV2ViVmlld0Ns aWVudCB3aGVuIHNwZWxsY2hlY2sgc3RhdGUgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI2ODAKKworICAgICAgICAqIHB1YmxpYy9XZWJW aWV3Q2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdDbGllbnQ6OmNvbnRpbnVvdXNT cGVsbENoZWNraW5nRW5hYmxlZFN0YXRlQ2hhbmdlZCk6CisgICAgICAgICogc3JjL0VkaXRvckNs aWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGllbnRJbXBsOjp0b2dnbGVD b250aW51b3VzU3BlbGxDaGVja2luZyk6CisKIDIwMTEtMDEtMTggIEFkYW0gS2xlaW4gIDxhZGFt a0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCmluZGV4IDA4ZmI5 NDI2YTk4ODczZTMwYWVmMDMyYTBkZDg4Y2E0NmExMjNhNGIuLmQ3YjM3NmQ1NDcyYjY5ZGZlMjM2 YTIzODdiYjE5NmQwMjE2ZGE5YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlZpZXdDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJWaWV3Q2xpZW50LmgKQEAgLTE4Nyw2ICsxODcsOSBAQCBwdWJsaWM6CiAgICAgLy8gVXBk YXRlIHRoZSBzcGVsbGluZyBVSSB3aXRoIHRoZSBnaXZlbiB3b3JkLgogICAgIHZpcnR1YWwgdm9p ZCB1cGRhdGVTcGVsbGluZ1VJV2l0aE1pc3NwZWxsZWRXb3JkKGNvbnN0IFdlYlN0cmluZyYgd29y ZCkgeyB9CiAKKyAgICAvLyBUaGlzIG1ldGhvZCBpcyBjYWxsZWQgd2hlbiBjb250aW51b3VzIHNw ZWxsaW5nIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQuCisgICAgdmlydHVhbCB2b2lkIGNvbnRpbnVv dXNTcGVsbENoZWNraW5nRW5hYmxlZFN0YXRlQ2hhbmdlZCgpIHsgfQorCiAKICAgICAvLyBEaWFs b2dzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9y Q2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJ bXBsLmNwcAppbmRleCAxOWI1ODczMDkyMzA1YzgxMDY3MDRjMTNmYzgyMmQzMGE4NTIwYjBkLi4z MDdlYTMxMjUwOTZlNmQ0MGNhYjYzMGQzMmRiMzQxY2U0OTVjM2I2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcApAQCAtMTYxLDYgKzE2MSw4 IEBAIHZvaWQgRWRpdG9yQ2xpZW50SW1wbDo6dG9nZ2xlQ29udGludW91c1NwZWxsQ2hlY2tpbmco KQogICAgICAgICBtX3NwZWxsQ2hlY2tUaGlzRmllbGRTdGF0dXMgPSBTcGVsbENoZWNrRm9yY2Vk T2ZmOwogICAgIGVsc2UKICAgICAgICAgbV9zcGVsbENoZWNrVGhpc0ZpZWxkU3RhdHVzID0gU3Bl bGxDaGVja0ZvcmNlZE9uOworICAgIGlmIChtX3dlYlZpZXctPmNsaWVudCgpKQorICAgICAgICBt X3dlYlZpZXctPmNsaWVudCgpLT5jb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWRTdGF0ZUNo YW5nZWQoKTsKIH0KIAogYm9vbCBFZGl0b3JDbGllbnRJbXBsOjppc0dyYW1tYXJDaGVja2luZ0Vu YWJsZWQoKQo= 79425 2011-01-19 07:39:37 -0800 2011-01-19 10:56:46 -0800 Patch bug-52680-20110119073936.patch text/plain 2172 sail ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMGZlZjkwMjdiMTJkZTU1MjkyMjMzNmI2NTE3 OTU5NzZiNzRiZTQ3MS4uM2UwNzFmMTQyYjc1MzU3Yzc3NDE3ZGM0NWQxM2I1NmY3NDFiNzRlNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMS0xOCAg U2FpbGVzaCBBZ3Jhd2FsICA8c2FpbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIFtjaHJvbWl1bV0gTm90aWZ5IFdlYlZpZXdDbGll bnQgd2hlbiBzcGVsbGNoZWNrIHN0YXRlIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNjgwCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmll d0NsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Q2xpZW50Ojpjb250aW51b3VzU3Bl bGxDaGVja2luZ0VuYWJsZWRTdGF0ZUNoYW5nZWQpOgorICAgICAgICAqIHNyYy9FZGl0b3JDbGll bnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50SW1wbDo6dG9nZ2xlQ29u dGludW91c1NwZWxsQ2hlY2tpbmcpOgorCiAyMDExLTAxLTE4ICBBZGFtIEtsZWluICA8YWRhbWtA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAppbmRleCAwOGZiOTQy NmE5ODg3M2UzMGFlZjAzMmEwZGQ4OGNhNDZhMTIzYTRiLi5kN2IzNzZkNTQ3MmI2OWRmZTIzNmEy Mzg3YmIxOTZkMDIxNmRhOWMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViVmlld0NsaWVudC5oCkBAIC0xODcsNiArMTg3LDkgQEAgcHVibGljOgogICAgIC8vIFVwZGF0 ZSB0aGUgc3BlbGxpbmcgVUkgd2l0aCB0aGUgZ2l2ZW4gd29yZC4KICAgICB2aXJ0dWFsIHZvaWQg dXBkYXRlU3BlbGxpbmdVSVdpdGhNaXNzcGVsbGVkV29yZChjb25zdCBXZWJTdHJpbmcmIHdvcmQp IHsgfQogCisgICAgLy8gVGhpcyBtZXRob2QgaXMgY2FsbGVkIHdoZW4gY29udGludW91cyBzcGVs bGluZyBpcyBlbmFibGVkIG9yIGRpc2FibGVkLgorICAgIHZpcnR1YWwgdm9pZCBjb250aW51b3Vz U3BlbGxDaGVja2luZ0VuYWJsZWRTdGF0ZUNoYW5nZWQoKSB7IH0KKwogCiAgICAgLy8gRGlhbG9n cyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNs aWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1w bC5jcHAKaW5kZXggMTliNTg3MzA5MjMwNWM4MTA2NzA0YzEzZmM4MjJkMzBhODUyMGIwZC4uMzA3 ZWEzMTI1MDk2ZTZkNDBjYWI2MzBkMzJkYjM0MWNlNDk1YzNiNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHAKQEAgLTE2MSw2ICsxNjEsOCBA QCB2b2lkIEVkaXRvckNsaWVudEltcGw6OnRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5nKCkK ICAgICAgICAgbV9zcGVsbENoZWNrVGhpc0ZpZWxkU3RhdHVzID0gU3BlbGxDaGVja0ZvcmNlZE9m ZjsKICAgICBlbHNlCiAgICAgICAgIG1fc3BlbGxDaGVja1RoaXNGaWVsZFN0YXR1cyA9IFNwZWxs Q2hlY2tGb3JjZWRPbjsKKyAgICBpZiAobV93ZWJWaWV3LT5jbGllbnQoKSkKKyAgICAgICAgbV93 ZWJWaWV3LT5jbGllbnQoKS0+Y29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkU3RhdGVDaGFu Z2VkKCk7CiB9CiAKIGJvb2wgRWRpdG9yQ2xpZW50SW1wbDo6aXNHcmFtbWFyQ2hlY2tpbmdFbmFi bGVkKCkK 79452 2011-01-19 10:56:50 -0800 2011-01-21 12:13:30 -0800 Patch bug-52680-20110119105649.patch text/plain 3258 sail ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMGZlZjkwMjdiMTJkZTU1MjkyMjMzNmI2NTE3 OTU5NzZiNzRiZTQ3MS4uMDJhMzE3NjI4MzFhYjBkN2I2NTMxMzI2Yzk0ZTEzOTA0ZDc3YWY2NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0xOCAg U2FpbGVzaCBBZ3Jhd2FsICA8c2FpbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIFtjaHJvbWl1bV0gTm90aWZ5IFdlYkZyYW1lQ2xp ZW50IHdoZW4gc3BlbGxjaGVjayBzdGF0ZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjY4MAorCisgICAgICAgICogcHVibGljL1dlYkZy YW1lQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lQ2xpZW50Ojpjb250aW51b3Vz U3BlbGxDaGVja2luZ0VuYWJsZWRTdGF0ZUNoYW5nZWQpOgorICAgICAgICAqIHNyYy9FZGl0b3JD bGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50SW1wbDo6dG9nZ2xl Q29udGludW91c1NwZWxsQ2hlY2tpbmcpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3Bw OgorCiAyMDExLTAxLTE4ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCmluZGV4IDFjNmZkMDRhZjFhNjA5YTgzZWEwZWYwNzAx YzcyZWJmNjA0NmZiOTIuLjJlMTg5MGFkNTBmYTBjZDNhNDlmMjZkMTk0YmY3MzYwNTIxZjAyYzAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50 LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaApA QCAtMTA5LDYgKzEwOSw5IEBAIHB1YmxpYzoKICAgICAvLyBDb250cm9scyB3aGV0aGVyIGltYWdl cyBhcmUgYWxsb3dlZCBmb3IgdGhpcyBmcmFtZS4KICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dJbWFn ZXMoV2ViRnJhbWUqLCBib29sIGVuYWJsZWRQZXJTZXR0aW5ncykgeyByZXR1cm4gZW5hYmxlZFBl clNldHRpbmdzOyB9CiAKKyAgICAvLyBOb3RpZmllcyB0aGUgY2xpZW50IHRoYXQgY29udGludW91 cyBzcGVsbCBjaGVja2luZyBoYXMgYmVlbiBlbmFibGVkIG9yCisgICAgLy8gZGlzYWJsZWQuCisg ICAgdmlydHVhbCB2b2lkIGRpZFRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5nKFdlYkZyYW1l KikgeyB9CiAKICAgICAvLyBMb2FkIGNvbW1hbmRzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcAppbmRleCAxOWI1ODczMDkyMzA1YzgxMDY3MDRj MTNmYzgyMmQzMGE4NTIwYjBkLi42ODY5NGMyZWZlMzE0ZDE4ZGI5NWI5MDE0ZDczYmU4ZmQ1N2Jl YTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJ bXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBs LmNwcApAQCAtNDUsNiArNDUsNyBAQAogI2luY2x1ZGUgIldlYkF1dG9GaWxsQ2xpZW50LmgiCiAj aW5jbHVkZSAiV2ViRWRpdGluZ0FjdGlvbi5oIgogI2luY2x1ZGUgIldlYkVsZW1lbnQuaCIKKyNp bmNsdWRlICJXZWJGcmFtZUNsaWVudC5oIgogI2luY2x1ZGUgIldlYkZyYW1lSW1wbC5oIgogI2lu Y2x1ZGUgIldlYktpdC5oIgogI2luY2x1ZGUgIldlYklucHV0RWxlbWVudC5oIgpAQCAtMTYxLDYg KzE2MiwxMSBAQCB2b2lkIEVkaXRvckNsaWVudEltcGw6OnRvZ2dsZUNvbnRpbnVvdXNTcGVsbENo ZWNraW5nKCkKICAgICAgICAgbV9zcGVsbENoZWNrVGhpc0ZpZWxkU3RhdHVzID0gU3BlbGxDaGVj a0ZvcmNlZE9mZjsKICAgICBlbHNlCiAgICAgICAgIG1fc3BlbGxDaGVja1RoaXNGaWVsZFN0YXR1 cyA9IFNwZWxsQ2hlY2tGb3JjZWRPbjsKKworICAgIFdlYkZyYW1lSW1wbCogd2ViZnJhbWUgPSBX ZWJGcmFtZUltcGw6OmZyb21GcmFtZSgKKyAgICAgICAgbV93ZWJWaWV3LT5mb2N1c2VkV2ViQ29y ZUZyYW1lKCkpOworICAgIGlmICh3ZWJmcmFtZSkKKyAgICAgICAgd2ViZnJhbWUtPmNsaWVudCgp LT5kaWRUb2dnbGVDb250aW51b3VzU3BlbGxDaGVja2luZyh3ZWJmcmFtZSk7CiB9CiAKIGJvb2wg RWRpdG9yQ2xpZW50SW1wbDo6aXNHcmFtbWFyQ2hlY2tpbmdFbmFibGVkKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IGExM2VlYzAxYWY2MWM3MWEy ODZiOWI5NzA5MjIzMjg1MTQ0YTE5MDcuLjNmZmVkNTAzYjI1YjdjOGVmNTM2ODA2MjllZWJmOTVi MmYwMzI1NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNw cApAQCAtMTE5OCw2ICsxMTk4LDkgQEAgdm9pZCBXZWJGcmFtZUltcGw6OmVuYWJsZUNvbnRpbnVv dXNTcGVsbENoZWNraW5nKGJvb2wgZW5hYmxlKQogewogICAgIGlmIChlbmFibGUgPT0gaXNDb250 aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOworICAgIC8vIE5v dGUsIHRoZSBlZGl0b3Igd2lsbCB3aWxsIG5vdGlmeSB0aGUgY2xpZW50IHRoYXQgdGhlIGNvbnRp bnVvdXMgc3BlbGwKKyAgICAvLyBjaGVja2luZyBzdGF0ZSBoYXMgY2hhbmdlZCBieSBjYWxsaW5n CisgICAgLy8gV2ViRnJhbWVDbGllbnQ6OmRpZFRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5n KCkuCiAgICAgZnJhbWUoKS0+ZWRpdG9yKCktPnRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5n KCk7CiB9CiAK