52610 2011-01-17 22:50:34 -0800 Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch 2011-01-18 13:24:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 51001 1 kalman kalman commit-queue rniwa oldest_to_newest 335666 0 kalman 2011-01-17 22:50:34 -0800 Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch 335667 1 79242 kalman 2011-01-17 22:53:02 -0800 Created attachment 79242 Patch 335806 2 79242 rniwa 2011-01-18 07:06:47 -0800 Comment on attachment 79242 Patch Thanks for doing this! 336051 3 79242 commit-queue 2011-01-18 13:24:23 -0800 Comment on attachment 79242 Patch Clearing flags on attachment: 79242 Committed r76053: <http://trac.webkit.org/changeset/76053> 336052 4 commit-queue 2011-01-18 13:24:27 -0800 All reviewed patches have been landed. Closing bug. 79242 2011-01-17 22:53:02 -0800 2011-01-18 13:24:23 -0800 Patch bug-52610-20110118175259.patch text/plain 3989 kalman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzAyOTA1ZDc3ZTlhNTc2ZDA1MWJmZjEwMTgxOGZiOGRjOTBkZTFiLi45 OTI2OWExYTRkNjdmMGMxMTRjNjg5YTg2Y2ZkMWJlNGQ5N2JlN2I3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTEtMDEtMTcgIEJlbmphbWluIEthbG1hbiAgPGthbG1hbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VHdlYWsgc3R5bGUgaW4gdmlzaWJsZV91bml0cy5jcHAgYW5kIFRleHRJdGVyYXRvci5jcHAgaW4g cHJlcGFyYXRpb24gZm9yIGFub3RoZXIgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNjEwCisKKyAgICAgICAgVGhpcyBpcyBhIHB1cmVseSBh ZXN0aGV0aWMgY2hhbmdlLgorCisgICAgICAgICogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2ltcGxpZmllZEJhY2t3YXJkc1RleHRJdGVyYXRvcjo6YWR2YW5j ZSk6CisgICAgICAgICogZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OnByZXZpb3VzQm91bmRhcnkpOgorCiAyMDExLTAxLTE3ICBOYW9raSBUYWthbm8gIDx0YWth bm8ubmFva2lAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCmluZGV4IDdlNDE0MjBkZGY0YzY1 ZmI1OGUyYmE0OGRiNTBiNjQ3ZWY3YThjOWQuLmMyNGJjYjI0MjYxNWUxNGVhOWFlNGY4MDRiZWY0 MWYyNTRhNmE2MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJh dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAKQEAg LTExMjgsMTAgKzExMjgsMTAgQEAgdm9pZCBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9y OjphZHZhbmNlKCkKICAgICAgICAgaWYgKCFuZXh0KSB7CiAgICAgICAgICAgICAvLyBFeGl0IGVt cHR5IGNvbnRhaW5lcnMgYXMgd2UgcGFzcyBvdmVyIHRoZW0gb3IgY29udGFpbmVycwogICAgICAg ICAgICAgLy8gd2hlcmUgW2NvbnRhaW5lciwgMF0gaXMgd2hlcmUgd2Ugc3RhcnRlZCBpdGVyYXRp bmcuCi0gICAgICAgICAgICBpZiAoIW1faGFuZGxlZE5vZGUgJiYKLSAgICAgICAgICAgICAgICBj YW5IYXZlQ2hpbGRyZW5Gb3JFZGl0aW5nKG1fbm9kZSkgJiYgCi0gICAgICAgICAgICAgICAgbV9u b2RlLT5wYXJlbnROb2RlKCkgJiYgCi0gICAgICAgICAgICAgICAgKCFtX25vZGUtPmxhc3RDaGls ZCgpIHx8IChtX25vZGUgPT0gbV9lbmROb2RlICYmIG1fZW5kT2Zmc2V0ID09IDApKSkgeworICAg ICAgICAgICAgaWYgKCFtX2hhbmRsZWROb2RlCisgICAgICAgICAgICAgICAgICAgICYmIGNhbkhh dmVDaGlsZHJlbkZvckVkaXRpbmcobV9ub2RlKQorICAgICAgICAgICAgICAgICAgICAmJiBtX25v ZGUtPnBhcmVudE5vZGUoKQorICAgICAgICAgICAgICAgICAgICAmJiAoIW1fbm9kZS0+bGFzdENo aWxkKCkgfHwgKG1fbm9kZSA9PSBtX2VuZE5vZGUgJiYgIW1fZW5kT2Zmc2V0KSkpIHsKICAgICAg ICAgICAgICAgICBleGl0Tm9kZSgpOwogICAgICAgICAgICAgICAgIGlmIChtX3Bvc2l0aW9uTm9k ZSkgewogICAgICAgICAgICAgICAgICAgICBtX2hhbmRsZWROb2RlID0gdHJ1ZTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCmluZGV4IDdiYjE1MTU3MzZmZGNmM2UxZTMw NTBlN2JmN2IzZjM0NmJkNzM3MmIuLjFhNTU0Yjc3YzQ5ZDMzN2M0MzdiNmY4YTgzNGU5NDYyMWQx MDRkYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcApAQCAtMTE1 LDIyICsxMTUsMTggQEAgc3RhdGljIFZpc2libGVQb3NpdGlvbiBwcmV2aW91c0JvdW5kYXJ5KGNv bnN0IFZpc2libGVQb3NpdGlvbiYgYywgQm91bmRhcnlTZWFyY2gKICAgICAgICAgQVNTRVJUKCFu ZWVkTW9yZUNvbnRleHQpOwogICAgIH0KIAotICAgIGlmIChpdC5hdEVuZCgpICYmIG5leHQgPT0g MCkgewotICAgICAgICBwb3MgPSBpdC5yYW5nZSgpLT5zdGFydFBvc2l0aW9uKCk7Ci0gICAgfSBl bHNlIGlmIChuZXh0ICE9IDApIHsKLSAgICAgICAgTm9kZSAqbm9kZSA9IGl0LnJhbmdlKCktPnN0 YXJ0Q29udGFpbmVyKGVjKTsKLSAgICAgICAgaWYgKChub2RlLT5pc1RleHROb2RlKCkgJiYgc3Rh dGljX2Nhc3Q8aW50PihuZXh0KSA8PSBub2RlLT5tYXhDaGFyYWN0ZXJPZmZzZXQoKSkgfHwgKG5v ZGUtPnJlbmRlcmVyKCkgJiYgbm9kZS0+cmVuZGVyZXIoKS0+aXNCUigpICYmICFuZXh0KSkKLSAg ICAgICAgICAgIC8vIFRoZSBuZXh0IHZhcmlhYmxlIGNvbnRhaW5zIGEgdXNhYmxlIGluZGV4IGlu dG8gYSB0ZXh0IG5vZGUKLSAgICAgICAgICAgIHBvcyA9IFBvc2l0aW9uKG5vZGUsIG5leHQpOwot ICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgIC8vIFVzZSB0aGUgY2hhcmFjdGVyIGl0ZXJhdG9y IHRvIHRyYW5zbGF0ZSB0aGUgbmV4dCB2YWx1ZSBpbnRvIGEgRE9NIHBvc2l0aW9uLgotICAgICAg ICAgICAgQmFja3dhcmRzQ2hhcmFjdGVySXRlcmF0b3IgY2hhckl0KHNlYXJjaFJhbmdlLmdldCgp LCBUZXh0SXRlcmF0b3JFbmRzQXRFZGl0aW5nQm91bmRhcnkpOwotICAgICAgICAgICAgY2hhckl0 LmFkdmFuY2Uoc3RyaW5nLnNpemUoKSAtIHN1ZmZpeExlbmd0aCAtIG5leHQpOwotICAgICAgICAg ICAgcG9zID0gY2hhckl0LnJhbmdlKCktPmVuZFBvc2l0aW9uKCk7Ci0gICAgICAgIH0KLSAgICB9 Ci0KLSAgICByZXR1cm4gVmlzaWJsZVBvc2l0aW9uKHBvcywgRE9XTlNUUkVBTSk7CisgICAgaWYg KCFuZXh0KQorICAgICAgICByZXR1cm4gVmlzaWJsZVBvc2l0aW9uKGl0LmF0RW5kKCkgPyBpdC5y YW5nZSgpLT5zdGFydFBvc2l0aW9uKCkgOiBwb3MsIERPV05TVFJFQU0pOworCisgICAgTm9kZSog bm9kZSA9IGl0LnJhbmdlKCktPnN0YXJ0Q29udGFpbmVyKGVjKTsKKyAgICBpZiAoKG5vZGUtPmlz VGV4dE5vZGUoKSAmJiBzdGF0aWNfY2FzdDxpbnQ+KG5leHQpIDw9IG5vZGUtPm1heENoYXJhY3Rl ck9mZnNldCgpKSB8fCAobm9kZS0+cmVuZGVyZXIoKSAmJiBub2RlLT5yZW5kZXJlcigpLT5pc0JS KCkgJiYgIW5leHQpKQorICAgICAgICAvLyBUaGUgbmV4dCB2YXJpYWJsZSBjb250YWlucyBhIHVz YWJsZSBpbmRleCBpbnRvIGEgdGV4dCBub2RlCisgICAgICAgIHJldHVybiBWaXNpYmxlUG9zaXRp b24oUG9zaXRpb24obm9kZSwgbmV4dCksIERPV05TVFJFQU0pOworCisgICAgLy8gVXNlIHRoZSBj aGFyYWN0ZXIgaXRlcmF0b3IgdG8gdHJhbnNsYXRlIHRoZSBuZXh0IHZhbHVlIGludG8gYSBET00g cG9zaXRpb24uCisgICAgQmFja3dhcmRzQ2hhcmFjdGVySXRlcmF0b3IgY2hhckl0KHNlYXJjaFJh bmdlLmdldCgpLCBUZXh0SXRlcmF0b3JFbmRzQXRFZGl0aW5nQm91bmRhcnkpOworICAgIGNoYXJJ dC5hZHZhbmNlKHN0cmluZy5zaXplKCkgLSBzdWZmaXhMZW5ndGggLSBuZXh0KTsKKyAgICByZXR1 cm4gVmlzaWJsZVBvc2l0aW9uKGNoYXJJdC5yYW5nZSgpLT5lbmRQb3NpdGlvbigpLCBET1dOU1RS RUFNKTsKIH0KIAogc3RhdGljIFZpc2libGVQb3NpdGlvbiBuZXh0Qm91bmRhcnkoY29uc3QgVmlz aWJsZVBvc2l0aW9uJiBjLCBCb3VuZGFyeVNlYXJjaEZ1bmN0aW9uIHNlYXJjaEZ1bmN0aW9uKQo=