52558 2011-01-17 00:42:34 -0800 ShadowElement::m_shadowParent should be removed 2011-01-23 23:32:22 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 48698 1 morrita webkit-unassigned dglazkov dominicc rolandsteiner oldest_to_newest 335192 0 morrita 2011-01-17 00:42:34 -0800 ShadowElement::m_shadowParent is used by anyone and there is Node::shadowParent(). Currently m_shadowParent is served for some lifecycle trick, but we shouldn't need that. 337149 1 79556 morrita 2011-01-19 23:32:26 -0800 Created attachment 79556 Patch 337150 2 morrita 2011-01-19 23:33:09 -0800 Hi Dimitri, could you take a look? I just removed an unused variable. Tests passed. 337201 3 79556 eric 2011-01-20 02:26:45 -0800 Comment on attachment 79556 Patch OK. Do we need to ref the parent? That's the only side-effect of this change I can see. 337245 4 morrita 2011-01-20 04:02:12 -0800 Hi Eric, thank you for taking a look! I'll land this soon. (In reply to comment #3) > (From update of attachment 79556 [details]) > OK. Do we need to ref the parent? That's the only side-effect of this change I can see. No, the shadow root belongs the host(parent), and the host has normal lifecycle as usual DOM node. 337246 5 morrita 2011-01-20 04:08:27 -0800 Committed r76221: <http://trac.webkit.org/changeset/76221> 338597 6 dglazkov 2011-01-22 09:54:07 -0800 For what it's worth, we should remove ShadowElement entirely. Its purpose is very limited already, and it'll become completely useless once we convert all elements that rely on it to new shadow DOM. 338857 7 morrita 2011-01-23 23:32:22 -0800 (In reply to comment #6) > For what it's worth, we should remove ShadowElement entirely. Its purpose is very limited already, and it'll become completely useless once we convert all elements that rely on it to new shadow DOM. Yes. I think we should do it after shadow migration is finished. 79556 2011-01-19 23:32:26 -0800 2011-01-20 02:26:45 -0800 Patch bug-52558-20110120163224.patch text/plain 1386 morrita ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZDkxZDFhODU2OGU2MjgzNWQ4YjllMWY4N2E2OTE1MDgwYzhmM2IzLi5j OTE5NTM0ZTQ1ODM2NWE0NGJkMDAxODM5NjcxODQ3MTRlNGU4N2NkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDEtMTkgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hh ZG93RWxlbWVudDo6bV9zaGFkb3dQYXJlbnQgc2hvdWxkIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyNTU4CisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBObyBiZWhhdmlvcmFsIGNoYW5nZS4KKworICAgICAgICAqIHJlbmRlcmluZy9T aGFkb3dFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpTaGFkb3dFbGVtZW50OjpTaGFkb3dF bGVtZW50KToKKwogMjAxMS0wMS0xOCBNT1JJVEEgSGFqaW1lIDxtb3JyaXRhQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvU2hhZG93RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1NoYWRvd0VsZW1lbnQuaAppbmRleCAyYzFhNjllZmI5NWE1M2Q2N2M5MzMwYjU5OGZkM2Zi OWRkZTE5ZjhlLi44YmNiMzRlMmFkNTY2NjZjOTdjOTc1Yzk1NGI2NDAwNDIwYmVhMWUwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2hhZG93RWxlbWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaGFkb3dFbGVtZW50LmgKQEAgLTM5LDE2ICszOSwxMiBA QCBjbGFzcyBTaGFkb3dFbGVtZW50IDogcHVibGljIEJhc2VFbGVtZW50IHsKIHByb3RlY3RlZDoK ICAgICBTaGFkb3dFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIEhUTUxFbGVtZW50 KiBzaGFkb3dQYXJlbnQpCiAgICAgICAgIDogQmFzZUVsZW1lbnQobmFtZSwgc2hhZG93UGFyZW50 LT5kb2N1bWVudCgpKQotICAgICAgICAsIG1fc2hhZG93UGFyZW50KHNoYWRvd1BhcmVudCkKICAg ICB7CiAgICAgICAgIEJhc2VFbGVtZW50OjpzZXRTaGFkb3dIb3N0KHNoYWRvd1BhcmVudCk7CiAg ICAgfQogCiBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwotCi1wcml2YXRlOgot ICAgIFJlZlB0cjxIVE1MRWxlbWVudD4gbV9zaGFkb3dQYXJlbnQ7CiB9OwogCiB0ZW1wbGF0ZTxj bGFzcyBCYXNlRWxlbWVudD4K