52505 2011-01-14 19:03:07 -0800 [jsfunfuzz] Incorrect handling of consecutive duplicate labels 2011-01-14 22:35:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 13638 1 oliver webkit-unassigned barraclough ggaren jruderman oldest_to_newest 334818 0 oliver 2011-01-14 19:03:07 -0800 When I reworked label handling I incorrectly compared Identifier*'s rather than their impls. This caused the following test to assert: tryItOut("\"\";L:L:if(s);else if(\"\")\"\"") 334822 1 oliver 2011-01-14 19:07:49 -0800 I've fixed this but my tree just picked up a "rebuild the world" patch so it's going to take a while to get the testcase verified. 334848 2 79052 oliver 2011-01-14 22:00:05 -0800 Created attachment 79052 Patch 334851 3 79052 mjs 2011-01-14 22:07:45 -0800 Comment on attachment 79052 Patch r=me 334855 4 oliver 2011-01-14 22:35:42 -0800 Committed r75872: <http://trac.webkit.org/changeset/75872> 79052 2011-01-14 22:00:05 -0800 2011-01-14 22:07:44 -0800 Patch bug-52505-20110114220004.patch text/plain 4066 oliver ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3OTRkYTM1MzY4NTBhOWZlYWEwY2M5OWM5YzIzM2QzNWRhZTRiZGUxLi4xOWE2Njdk ZDZlNTVlMGIwZWNiMTk2ZDQ4YTNkMGQ0NWQwYThjOWY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK IDIwMTEtMDEtMTQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbanNmdW5mdXp6XSBJbmNvcnJl Y3QgaGFuZGxpbmcgb2YgY29uc2VjdXRpdmUgZHVwbGljYXRlIGxhYmVscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI1MDUKKworICAgICAgICBBZGQg YSBmZXcgdGVzdHMgb2YgY29uc2VjdXRpdmUgbGFiZWxzIGNvbnRhaW5pbmcgZHVwbGljYXRlcyB0 byB0aGUgcGFyc2VyIGNoZWNrLgorCisgICAgICAgICogZmFzdC9qcy9wYXJzZXItc3ludGF4LWNo ZWNrLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9wYXJzZXIt c3ludGF4LWNoZWNrLmpzOgorCisyMDExLTAxLTE0ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBs ZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RlcGhhbmllIExld2lzLgogCiAgICAgICAg IFtqc2Z1bmZ1enpdIFdlIHNob3VsZCBiZSBjbGVhcmluZyB0aGUgbGV4ZXJzIHRlbXBvcmFyeSBj aGFyYWN0ZXIgYnVmZmVycyB3aGVuIHN3aXRjaGluZyB0byBzdHJpY3QgbW9kZQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9wYXJzZXItc3ludGF4LWNoZWNrLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvanMvcGFyc2VyLXN5bnRheC1jaGVjay1leHBlY3RlZC50eHQKaW5k ZXggY2YwODVlNDdkYTI2OGNiMDg5ZDFhNDc5NDQwNGI1MGRjZWRhYWEzNC4uZTVmNWRjMTgzMGQ5 NjA3NjMwNzVkNzVkYjRkZjBhYWYyMWU1ODI0MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFz dC9qcy9wYXJzZXItc3ludGF4LWNoZWNrLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2pzL3BhcnNlci1zeW50YXgtY2hlY2stZXhwZWN0ZWQudHh0CkBAIC01MzEsNiArNTMxLDEy IEBAIFBBU1MgSW52YWxpZDogInN3aXRjaCAoNCAtICkgeyB9IgogUEFTUyBJbnZhbGlkOiAiZnVu Y3Rpb24gZigpIHsgc3dpdGNoICg0IC0gKSB7IH0gfSIKIFBBU1MgSW52YWxpZDogInN3aXRjaCAo bCkgeyBkZWZhdWx0IGNhc2U6IDU7IH0iCiBQQVNTIEludmFsaWQ6ICJmdW5jdGlvbiBmKCkgeyBz d2l0Y2ggKGwpIHsgZGVmYXVsdCBjYXNlOiA1OyB9IH0iCitQQVNTIEludmFsaWQ6ICJMOiBMOiA7 IgorUEFTUyBJbnZhbGlkOiAiZnVuY3Rpb24gZigpIHsgTDogTDogOyB9IgorUEFTUyBJbnZhbGlk OiAiTDogTDE6IEw6IDsiCitQQVNTIEludmFsaWQ6ICJmdW5jdGlvbiBmKCkgeyBMOiBMMTogTDog OyB9IgorUEFTUyBJbnZhbGlkOiAiTDogTDE6IEwyOiBMMzogTDQ6IEw6IDsiCitQQVNTIEludmFs aWQ6ICJmdW5jdGlvbiBmKCkgeyBMOiBMMTogTDI6IEwzOiBMNDogTDogOyB9IgogUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9wYXJzZXItc3ludGF4LWNoZWNrLmpzIGIvTGF5 b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcGFyc2VyLXN5bnRheC1jaGVjay5qcwppbmRl eCAxMzVhYmY4YmEyN2MyOWZhNTU0ZDA3NDQ0MjM5MzY2NTBiOGZhYzM1Li4wNjAzZTU2NDlmNTRl OTFmYjQwMThlNWZhMzAxMGI2Mzg0ZjNhN2EzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2pzL3NjcmlwdC10ZXN0cy9wYXJzZXItc3ludGF4LWNoZWNrLmpzCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvanMvc2NyaXB0LXRlc3RzL3BhcnNlci1zeW50YXgtY2hlY2suanMKQEAgLTMzOSw0ICsz MzksOCBAQCB2YWxpZCAgKCJzd2l0Y2ggKGwpIHsgY2FzZSAxOiBhOiB3aXRoKGcpIHN3aXRjaCAo ZykgeyBjYXNlIDI6IGRlZmF1bHQ6IH0gZGVmYXVsdAogaW52YWxpZCgic3dpdGNoICg0IC0gKSB7 IH0iKTsKIGludmFsaWQoInN3aXRjaCAobCkgeyBkZWZhdWx0IGNhc2U6IDU7IH0iKTsKIAoraW52 YWxpZCgiTDogTDogOyIpOworaW52YWxpZCgiTDogTDE6IEw6IDsiKTsKK2ludmFsaWQoIkw6IEwx OiBMMjogTDM6IEw0OiBMOiA7Iik7CisKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZGVjYmM2MWNlNzY1YTI1NWQyNjM5ZDUxMTljZmI5 NWIxYmExYjYzOC4uZjFkODIxYjk3OGJmZWQ3MmNlOGYzNzNjNDFjZTBlNTkyOWVhN2JiYyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMDEtMTQgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbanNmdW5mdXp6XSBJbmNvcnJlY3QgaGFuZGxpbmcgb2YgY29u c2VjdXRpdmUgZHVwbGljYXRlIGxhYmVscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTI1MDUKKworICAgICAgICBDb21wYXJlIFN0cmluZ0ltcGwqJ3Mg aW5zdGVhZCBvZiBJZGVudGlmaWVyKidzIHdoZW4gbG9va2luZyBmb3IgZHVwbGljYXRlCisgICAg ICAgIGxhYmVscy4KKworICAgICAgICAqIHBhcnNlci9KU1BhcnNlci5jcHA6CisgICAgICAgIChK U0M6OkpTUGFyc2VyOjpwYXJzZUV4cHJlc3Npb25PckxhYmVsU3RhdGVtZW50KToKKworMjAxMS0w MS0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2Vk IGJ5IFN0ZXBoYW5pZSBMZXdpcy4KIAogICAgICAgICBbanNmdW5mdXp6XSBXZSBzaG91bGQgYmUg Y2xlYXJpbmcgdGhlIGxleGVycyB0ZW1wb3JhcnkgY2hhcmFjdGVyIGJ1ZmZlcnMgd2hlbiBzd2l0 Y2hpbmcgdG8gc3RyaWN0IG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvSlNQYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9KU1BhcnNl ci5jcHAKaW5kZXggNzkyZDE5YmEyZDVjMjE3N2YwYTc3MGUwN2IxNzgyNmIxMDdiYzM5YS4uNjQw ZjYwM2UwNTgwNWVmN2Y0OGNjMjllN2JhYjZjYzVlNmE2N2VkMyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9KU1BhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9KU1BhcnNlci5jcHAKQEAgLTEzMDgsNyArMTMwOCw3IEBAIHRlbXBsYXRl IDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZVN0YXRlbWVudCBKU1BhcnNlcjo6cGFyc2VFeHByZXNz aW9uT3JMYWJlbFN0YXRlCiAgICAgICAgICAgICAvLyBUaGlzIGlzIE8oTl4yKSBvdmVyIHRoZSBj dXJyZW50IGxpc3Qgb2YgY29uc2VjdXRpdmUgbGFiZWxzLCBidXQgSQogICAgICAgICAgICAgLy8g aGF2ZSBuZXZlciBzZWVuIG1vcmUgdGhhbiBvbmUgbGFiZWwgaW4gYSByb3cgaW4gdGhlIHJlYWwg d29ybGQuCiAgICAgICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxhYmVscy5zaXplKCk7 IGkrKykKLSAgICAgICAgICAgICAgICBmYWlsSWZUcnVlKGlkZW50ID09IGxhYmVsc1tpXS5tX2lk ZW50KTsKKyAgICAgICAgICAgICAgICBmYWlsSWZUcnVlKGlkZW50LT5pbXBsKCkgPT0gbGFiZWxz W2ldLm1faWRlbnQtPmltcGwoKSk7CiAgICAgICAgICAgICBmYWlsSWZUcnVlKGdldExhYmVsKGlk ZW50KSk7CiAgICAgICAgICAgICBsYWJlbHMuYXBwZW5kKExhYmVsSW5mbyhpZGVudCwgc3RhcnQs IGVuZCkpOwogICAgICAgICB9Cg==