52504 2011-01-14 18:55:32 -0800 Add PassPosition to avoid refcount thrashing 2011-02-04 10:20:06 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED INVALID P2 Enhancement --- 1 rniwa rniwa ap darin enrica eric ojan tony oldest_to_newest 334814 0 rniwa 2011-01-14 18:55:32 -0800 Currently, Position's convenience functions return an instance of Position which results in multiple refcount update for the anchor node. We should add PassPosition that acts like PassRefPtr for RefPtr to avoid this. 334815 1 rniwa 2011-01-14 18:58:02 -0800 We can also create special classes for positions before/after node so that they only contains a pointer and therefore fits in a single register. 343578 2 rniwa 2011-02-01 15:07:48 -0800 It seems like helper functions in Position.h are inline and therefore does not cause ref-count churn. 345587 3 darin 2011-02-04 10:20:06 -0800 (In reply to comment #2) > It seems like helper functions in Position.h are inline and therefore does not cause ref-count churn. Inlining should have no effect on this. Could you show me some evidence, perhaps disassembly of compiled code, that there is no increment and decrement of reference counts going on? I am almost certain there is churn.