52409 2011-01-13 16:33:29 -0800 [Qt] QtTestBrowser should have a UI setting to prevent loading images. 2011-01-25 15:20:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned commit-queue laszlo.gombos mansi.mithal tonikitoo webkit-ews oldest_to_newest 334023 0 yael 2011-01-13 16:33:29 -0800 It would help a lot when debugging if we could turn off loading images at runtime. 337515 1 mansi.mithal 2011-01-20 12:36:57 -0800 I have the patch ready. But since the patch depends on the bug : 52817 , I will submit it after the other one gets checked in. 339810 2 80093 mansi.mithal 2011-01-25 11:57:34 -0800 Created attachment 80093 Add "Disable Auto Load Images" under Settings Menu 339839 3 webkit-ews 2011-01-25 12:23:39 -0800 Attachment 80093 did not build on qt: Build output: http://queues.webkit.org/results/7630234 339849 4 80093 tonikitoo 2011-01-25 12:34:48 -0800 Comment on attachment 80093 Add "Disable Auto Load Images" under Settings Menu Fix Qt buildbot before landing 339850 5 tonikitoo 2011-01-25 12:35:49 -0800 ../../../Tools/QtTestBrowser/launcherwindow.cpp: In member function ‘void LauncherWindow::createChrome()’: ../../../Tools/QtTestBrowser/launcherwindow.cpp:372: error: ‘disableAutoLoadImages’ was not declared in this scope distcc[15190] ERROR: compile ../../../Tools/QtTestBrowser/launcherwindow.cpp on cute3.inf.u-szeged.hu/7,lzo failed make[1]: *** [launcherwindow.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/webkit/WebKit-qt-ews/WebKitBuild/Release/QtTestBrowser' make: *** [sub-QtTestBrowser-QtTestBrowser-pro-make_default-ordered] Error 2 339857 6 80106 mansi.mithal 2011-01-25 12:52:06 -0800 Created attachment 80106 Add "Disable Auto Load Images" under Settings Menu 339960 7 commit-queue 2011-01-25 15:20:07 -0800 The commit-queue encountered the following flaky tests while processing attachment 80106: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 339961 8 80106 commit-queue 2011-01-25 15:20:44 -0800 Comment on attachment 80106 Add "Disable Auto Load Images" under Settings Menu Clearing flags on attachment: 80106 Committed r76646: <http://trac.webkit.org/changeset/76646> 339962 9 commit-queue 2011-01-25 15:20:50 -0800 All reviewed patches have been landed. Closing bug. 80093 2011-01-25 11:57:34 -0800 2011-01-25 12:52:06 -0800 Add "Disable Auto Load Images" under Settings Menu 52409.patch text/plain 2609 mansi.mithal SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2NjIwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDEtMjUgIE1hbnNpIE1pdGhhbCAgPG1hbnNpLm1pdGhhbEBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUXRU ZXN0QnJvd3NlciBzaG91bGQgaGF2ZSBhIFVJIFNldHRpbmdzIHRvIHByZXZlbnQgbG9hZGluZyBp bWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy NDA5CisgICAgICAgIAorICAgICAgICBBZGRlZCBhIG5ldyBhY3Rpb24gaXRlbSBuYW1lZCAiRGlz YWJsZUF1dG9Mb2FkSW1hZ2VzIgorICAgICAgICB1bmRlciB0aGUgIlNldHRpbmdzIiBtZW51IAor CisKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcDoKKyAgICAgICAg KExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUpOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6 OnRvZ2dsZUF1dG9Mb2FkSW1hZ2VzKToKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL2xhdW5jaGVy d2luZG93Lmg6CisKIDIwMTEtMDEtMjUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBUb29scy9RdFRl c3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdFRlc3RC cm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAkocmV2aXNpb24gNzY2MTMpCisrKyBUb29scy9RdFRl c3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzY3LDYgKzM2 NywxMCBAQCB2b2lkIExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogCiAgICAgUU1lbnUq IHNldHRpbmdzTWVudSA9IG1lbnVCYXIoKS0+YWRkTWVudSgiJlNldHRpbmdzIik7CiAKKyAgICBR QWN0aW9uKiB0b2dnbGVBdXRvTG9hZEltYWdlcyA9IHNldHRpbmdzTWVudS0+YWRkQWN0aW9uKCJE aXNhYmxlIEF1dG8gTG9hZCBJbWFnZXMiLCB0aGlzLCBTTE9UKHRvZ2dsZUF1dG9Mb2FkSW1hZ2Vz KGJvb2wpKSk7CisgICAgdG9nZ2xlQXV0b0xvYWRJbWFnZXMtPnNldENoZWNrYWJsZSh0cnVlKTsK KyAgICBkaXNhYmxlQXV0b0xvYWRJbWFnZXMtPnNldENoZWNrZWQoZmFsc2UpOworCiAgICAgUUFj dGlvbiogdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkID0gc2V0dGluZ3NNZW51 LT5hZGRBY3Rpb24oIkVuYWJsZSBpbnRlcnJ1cHRpbmcganMgc2NyaXB0cyIsIHRoaXMsIFNMT1Qo dG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCkpKTsKICAgICB0b2dnbGVJ bnRlcnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrYWJsZSh0cnVlKTsKICAgICB0 b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrZWQoZmFsc2UpOwpA QCAtNzcwLDYgKzc3NCwxMSBAQCB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVKYXZhc2NyaXB0 Q2FuCiAgICAgcGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpK YXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MsIGVuYWJsZSk7CiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5k b3c6OnRvZ2dsZUF1dG9Mb2FkSW1hZ2VzKGJvb2wgZW5hYmxlKQoreworICAgIHBhZ2UoKS0+c2V0 dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6QXV0b0xvYWRJbWFnZXMsICFlbmFi bGUpOworfQorCiAjaWYgZGVmaW5lZChRVF9DT05GSUdVUkVEX1dJVEhfT1BFTkdMKQogdm9pZCBM YXVuY2hlcldpbmRvdzo6dG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQoYm9vbCBlbmFibGUpCiB7Cklu ZGV4OiBUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCShyZXZpc2lvbiA3NjYxMykKKysr IFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaAkod29ya2luZyBjb3B5KQpAQCAt MTYzLDYgKzE2Myw3IEBAIHByb3RlY3RlZCBzbG90czoKICAgICB2b2lkIHRvZ2dsZUZyYW1lRmxh dHRlbmluZyhib29sIHRvZ2dsZSk7CiAgICAgdm9pZCB0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2Ny aXB0RW5hYmxlZChib29sIGVuYWJsZSk7CiAgICAgdm9pZCB0b2dnbGVKYXZhc2NyaXB0Q2FuT3Bl bldpbmRvd3MoYm9vbCBlbmFibGUpOworICAgIHZvaWQgdG9nZ2xlQXV0b0xvYWRJbWFnZXMoYm9v bCBlbmFibGUpOwogCiAjaWYgZGVmaW5lZChRVF9DT05GSUdVUkVEX1dJVEhfT1BFTkdMKQogICAg IHZvaWQgdG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQoYm9vbCBlbmFibGUpOwo= 80106 2011-01-25 12:52:06 -0800 2011-01-25 15:20:44 -0800 Add "Disable Auto Load Images" under Settings Menu 52409.patch text/plain 2606 mansi.mithal SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc2NjI2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDEtMjUgIE1hbnNpIE1pdGhhbCAgPG1hbnNpLm1pdGhhbEBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUXRU ZXN0QnJvd3NlciBzaG91bGQgaGF2ZSBhIFVJIFNldHRpbmdzIHRvIHByZXZlbnQgbG9hZGluZyBp bWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUy NDA5CisgICAgICAgIAorICAgICAgICBBZGRlZCBhIG5ldyBhY3Rpb24gaXRlbSBuYW1lZCAiRGlz YWJsZUF1dG9Mb2FkSW1hZ2VzIgorICAgICAgICB1bmRlciB0aGUgIlNldHRpbmdzIiBtZW51IAor CisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAgIChM YXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojp0 b2dnbGVBdXRvTG9hZEltYWdlcyk6CisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndp bmRvdy5oOgorCiAyMDExLTAxLTI1ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogVG9vbHMvUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvUXRUZXN0QnJv d3Nlci9sYXVuY2hlcndpbmRvdy5jcHAJKHJldmlzaW9uIDc2NjEzKQorKysgVG9vbHMvUXRUZXN0 QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2Nyw2ICszNjcs MTAgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKIAogICAgIFFNZW51KiBz ZXR0aW5nc01lbnUgPSBtZW51QmFyKCktPmFkZE1lbnUoIiZTZXR0aW5ncyIpOwogCisgICAgUUFj dGlvbiogdG9nZ2xlQXV0b0xvYWRJbWFnZXMgPSBzZXR0aW5nc01lbnUtPmFkZEFjdGlvbigiRGlz YWJsZSBBdXRvIExvYWQgSW1hZ2VzIiwgdGhpcywgU0xPVCh0b2dnbGVBdXRvTG9hZEltYWdlcyhi b29sKSkpOworICAgIHRvZ2dsZUF1dG9Mb2FkSW1hZ2VzLT5zZXRDaGVja2FibGUodHJ1ZSk7Cisg ICAgdG9nZ2xlQXV0b0xvYWRJbWFnZXMtPnNldENoZWNrZWQoZmFsc2UpOworCiAgICAgUUFjdGlv biogdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkID0gc2V0dGluZ3NNZW51LT5h ZGRBY3Rpb24oIkVuYWJsZSBpbnRlcnJ1cHRpbmcganMgc2NyaXB0cyIsIHRoaXMsIFNMT1QodG9n Z2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCkpKTsKICAgICB0b2dnbGVJbnRl cnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrYWJsZSh0cnVlKTsKICAgICB0b2dn bGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0ZUVuYWJsZWQtPnNldENoZWNrZWQoZmFsc2UpOwpAQCAt NzcwLDYgKzc3NCwxMSBAQCB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVKYXZhc2NyaXB0Q2Fu CiAgICAgcGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZh c2NyaXB0Q2FuT3BlbldpbmRvd3MsIGVuYWJsZSk7CiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5kb3c6 OnRvZ2dsZUF1dG9Mb2FkSW1hZ2VzKGJvb2wgZW5hYmxlKQoreworICAgIHBhZ2UoKS0+c2V0dGlu Z3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6QXV0b0xvYWRJbWFnZXMsICFlbmFibGUp OworfQorCiAjaWYgZGVmaW5lZChRVF9DT05GSUdVUkVEX1dJVEhfT1BFTkdMKQogdm9pZCBMYXVu Y2hlcldpbmRvdzo6dG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQoYm9vbCBlbmFibGUpCiB7CkluZGV4 OiBUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCShyZXZpc2lvbiA3NjYxMykKKysrIFRv b2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaAkod29ya2luZyBjb3B5KQpAQCAtMTYz LDYgKzE2Myw3IEBAIHByb3RlY3RlZCBzbG90czoKICAgICB2b2lkIHRvZ2dsZUZyYW1lRmxhdHRl bmluZyhib29sIHRvZ2dsZSk7CiAgICAgdm9pZCB0b2dnbGVJbnRlcnJ1cHRpbmdKYXZhU2NyaXB0 RW5hYmxlZChib29sIGVuYWJsZSk7CiAgICAgdm9pZCB0b2dnbGVKYXZhc2NyaXB0Q2FuT3Blbldp bmRvd3MoYm9vbCBlbmFibGUpOworICAgIHZvaWQgdG9nZ2xlQXV0b0xvYWRJbWFnZXMoYm9vbCBl bmFibGUpOwogCiAjaWYgZGVmaW5lZChRVF9DT05GSUdVUkVEX1dJVEhfT1BFTkdMKQogICAgIHZv aWQgdG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQoYm9vbCBlbmFibGUpOwo=