52264 2011-01-11 17:23:04 -0800 REGRESSION (r71562): servePendingRequests() no longer called when resources are done loading. 2011-01-11 17:57:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar, Regression P2 Normal --- 27165 1 aestes aestes oldest_to_newest 332816 0 aestes 2011-01-11 17:23:04 -0800 REGRESSION (r71562): servePendingRequests() no longer called when resources are done loading. 332822 1 aestes 2011-01-11 17:38:45 -0800 <rdar://problem/8767429> 332824 2 aestes 2011-01-11 17:40:06 -0800 The removal of servePendingRequests() is what caused the Adobe Creative Suite 4 installer to break on Mac OS X. 332825 3 aestes 2011-01-11 17:41:02 -0800 Prior to r71562, Loader::servePendingRequests() would be called as part of marking a load as finished. servePendingRequests() kicks off loads for pending requests if there are available loader slots due to the completed load. r71562 removed this call (accidentally? intentionally? sadly the ChangeLog provides no clue) as part of a refactoring, instead relying on a request timer to call servePendingRequests(). However, if a modal dialog is displayed while the request timer is active, and that dialog attempts to use resources that were previously placed in the pending queue, the load will stall since the request timer can't be started reentrantly and therefore the resources will have no way to move from the pending queue to the loader. Restoring the call to servePendingRequests() at various points (didFinishLoading(), didFail(), didReceiveResponse()) fixes this issue. It's not entirely clear to me how to write a test using web content that captures the nature of this bug. The key to the bug is that a timer fires which calls runJavaScriptAlert(), and Adobe has an alert delegate which then re-enters WebCore. Since a timer is firing, sharedTimerFiredInternal's reentrancy guard causes no new timers (such as m_requestTimer in ResourceLoadScheduler) to fire in the nested context. I've tried to approximate this using showModalDialog(), but that calls TimerBase::fireTimersInNestedEventLoop(), which resets the reentrancy guard and allows the timers to fire. I'm not sure what else to try short of adding a mechanism to DRT where a test can provide a custom UI delegate for runJavaScriptAlertPanelWithMessage: 332827 4 78631 aestes 2011-01-11 17:43:42 -0800 Created attachment 78631 Patch 332829 5 78631 darin 2011-01-11 17:50:30 -0800 Comment on attachment 78631 Patch Still worth trying to figure out if we can do a regression test for this, but that should not block checking the fix in. 332834 6 aestes 2011-01-11 17:57:58 -0800 Committed r75580: <http://trac.webkit.org/changeset/75580> 78631 2011-01-11 17:43:42 -0800 2011-01-11 17:50:30 -0800 Patch bug-52264-20110111174340.patch text/plain 1844 aestes SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1NTc2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDEtMTEgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHI3MTU2Mik6IHNlcnZlUGVuZGluZ1JlcXVlc3Rz KCkgbm8gbG9uZ2VyIGNhbGxlZCB3aGVuCisgICAgICAgIHJlc291cmNlcyBhcmUgZG9uZSBsb2Fk aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIy NjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg3Njc0Mjk+CisgICAgICAgIAorICAgICAgICBJ biByNzE1NjIsIHNlcnZlUGVuZGluZ1JlcXVlc3RzKCkgaXMgbm8gbG9uZ2VyIGNhbGxlZCBpbiBM b2FkZXIncworICAgICAgICBkaWRGaW5pc2hMb2FkaW5nKCksIGRpZEZhaWwoKSBhbmQgZGlkUmVj ZWl2ZVJlc3BvbnNlKCkgbWV0aG9kcy4gU2luY2UKKyAgICAgICAgcjcxNTYyIHdhcyBpbnRlbmRl ZCBvbmx5IGFzIGEgcmVmYWN0b3JpbmcsIHRoZXNlIGNhbGxzIHNob3VsZCBiZQorICAgICAgICBy ZXN0b3JlZC4gQXQgbGVhc3Qgb25lIFdlYktpdC1iYXNlZCBNYWMgT1MgWCBhcHBsaWNhdGlvbiBy ZWxpZXMgb24gdGhpcworICAgICAgICBmb3IgY29ycmVjdCBiZWhhdmlvci4KKworICAgICAgICAq IGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDYWNoZWRSZXNvdXJjZUxvYWRlcjo6bG9hZERvbmUpOiBDYWxsCisgICAgICAgIHJlc291cmNl TG9hZFNjaGVkdWxlcigpLT5zZXJ2ZVBlbmRpbmdSZXF1ZXN0cygpLgorCiAyMDExLTAxLTExICBC cmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNv dXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hl L0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAkocmV2aXNpb24gNzU0NTQpCisrKyBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00Myw2ICs0Myw3IEBACiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIk1lbW9y eUNhY2hlLmgiCiAjaW5jbHVkZSAiUGluZ0xvYWRlci5oIgorI2luY2x1ZGUgIlJlc291cmNlTG9h ZFNjaGVkdWxlci5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5jbHVkZSAiU2V0 dGluZ3MuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oPgpAQCAtNTIx LDYgKzUyMiw3IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OmxvYWREb25lKENhY2gKICAg ICBpZiAoZnJhbWUoKSkKICAgICAgICAgZnJhbWUoKS0+bG9hZGVyKCktPmxvYWREb25lKCk7CiAg ICAgY2hlY2tGb3JQZW5kaW5nUHJlbG9hZHMoKTsKKyAgICByZXNvdXJjZUxvYWRTY2hlZHVsZXIo KS0+c2VydmVQZW5kaW5nUmVxdWVzdHMoKTsKIH0KIAogdm9pZCBDYWNoZWRSZXNvdXJjZUxvYWRl cjo6Y2FuY2VsUmVxdWVzdHMoKQo=