52214 2011-01-11 08:43:59 -0800 [HTML5] Revert display:none on datalist 2011-01-17 23:53:28 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED http://adactio.com/journal/4272/ P3 Minor --- 27247 52612 1 jeremy webkit-unassigned commit-queue eric mathias mike rik tkent webmaster oldest_to_newest 332359 0 jeremy 2011-01-11 08:43:59 -0800 Until the datalist element is supported, the element should be ignored (like any other unknown element). Instead the CSS currently applies display:none to datalist elements (line 539 of html.css). The datalist element can contain content other than option elements; this is by design so that authors can rely on non-supporting browsers to display the non-option content as a fallback. Applying display:none to datalist negates this ability. In effect, the spec is relying on non-supporting browsers to treat the datalist element the same way they would treat foo, bar, or any other element they don't recognise. Here's a test case: http://adactio.s3.amazonaws.com/misc/datalist.html Source: https://gist.github.com/771830/ Without the author CSS that sets datalist to display: inline-block, the fallback content (a select element a text node) is hidden. The expected behaviour is that the fallback content is displayed. I've tested this in the latest nightly build r75294 on Mac OS X 10.6.6. Because this issue can be resolved in a user or author stylesheet, I'm marking this bug as minor rather than normal. 332366 1 rik 2011-01-11 08:52:59 -0800 It looks like the datalist implementation is hidden behind a flag but there is no flag in html.css for the datalist rule. 332386 2 eric 2011-01-11 09:10:35 -0800 I not only strongly support fixing this, I would upgrade the status to normal or even higher. Browsers should NOT hide elements they don't understand. If there's anything else that's similarly hidden (modulo 'head' and its descendants, of course) it should also be un-hidden. Can someone please direct me to the location of the UA CSS, assuming it's a browsable file? I'd like to see if any other elements are similarly afflicted. 332387 3 jeremy 2011-01-11 09:13:16 -0800 html.css is here: http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/css/html.css 332393 4 rik 2011-01-11 09:22:05 -0800 Oh I forgot to link to the changeset introducing this rule: https://trac.webkit.org/changeset/47420/ 332426 5 eric 2011-01-11 10:17:00 -0800 Thanks! I found this bit: ruby > rp { display: none; } /* other elements */ noframes { display: none } I'm trying to imagine the justification for either. Have to ponder. 332801 6 tkent 2011-01-11 16:48:32 -0800 (In reply to comment #1) > It looks like the datalist implementation is hidden behind a flag but there is no flag in html.css for the datalist rule. Yes, the root problem is that our UA CSS processor doesn't support feature flags such as ENABLE_DATALIST. Anyway, I think it's ok to remove the datalist definition from html.css for now. The datalist implementation is still incomplete and I don't have a plan to restart it soon. 335048 7 79099 rik 2011-01-16 09:11:28 -0800 Created attachment 79099 Patch 335110 8 79099 tkent 2011-01-16 17:30:50 -0800 Comment on attachment 79099 Patch Thanks! 335128 9 79099 commit-queue 2011-01-16 20:18:29 -0800 Comment on attachment 79099 Patch Rejecting attachment 79099 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'build-..." exit_code: 2 Last 500 characters of output: ........ fast/events/scoped . fast/eventsource .. fast/fast-mobile-scrolling .. fast/files ....... fast/flexbox ................................... fast/forms ........................................................................................................ fast/forms/datalist-nonoption-child.html -> failed Exiting early after 1 failures. 8171 tests run. 169.95s total testing time 8170 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7529125 335154 10 tkent 2011-01-16 23:12:10 -0800 (In reply to comment #9) > fast/forms/datalist-nonoption-child.html -> failed It's an actual failure. Would you update datalist-nonoption-child-expected.txt and add a comment that we need to add display:none again later to datalist-nonoption-child.html please? 335290 11 79162 rik 2011-01-17 06:26:37 -0800 Created attachment 79162 Patch 335291 12 rik 2011-01-17 06:28:46 -0800 Locally, datalist.html was also failing so I put the comment in this one. 335292 13 79162 tkent 2011-01-17 06:29:20 -0800 Comment on attachment 79162 Patch ok 335301 14 commit-queue 2011-01-17 06:58:46 -0800 The commit-queue encountered the following flaky tests while processing attachment 79162: inspector/debugger-pause-on-breakpoint.html bug 51320 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch. 335304 15 79162 commit-queue 2011-01-17 06:59:55 -0800 Comment on attachment 79162 Patch Clearing flags on attachment: 79162 Committed r75940: <http://trac.webkit.org/changeset/75940> 335305 16 commit-queue 2011-01-17 07:00:02 -0800 All reviewed patches have been landed. Closing bug. 79099 2011-01-16 09:11:28 -0800 2011-01-17 06:26:30 -0800 Patch bug-52214-20110116181125.patch text/plain 987 rik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMDQyOGE0MDQ0ZWNmZWFjYjhhY2EzMGZlMDg4MTJkNTRhYjdmNjA3Li5l MDYwMDFjZjdjNjY2NWUzYWRlYTJlNWUyNjg0Nzg2OTE0ODZhODFjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTEtMDEtMTYgIEFudGhvbnkgUmljYXVkICA8cmlrQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDUy MjE0IC0gUmVtb3ZlIGRpc3BsYXk6bm9uZSBvbiBkYXRhbGlzdCBlbGVtZW50cworICAgICAgICAK KyAgICAgICAgVW50aWwgZGF0YWxpc3Qgc3VwcG9ydCBpcyBpbXBsZW1lbnRlZCwgd2Ugc2hvdWxk IGRpc3BsYXkgdGhlIGNvbnRlbnQuCisKKyAgICAgICAgKiBjc3MvaHRtbC5jc3M6CisKIDIwMTEt MDEtMTUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3NTcwOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9odG1sLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcwppbmRleCBk NWIzYTE5YTk0NjIyZGI5NTFiMWFmN2UzYmM4NDdkNjZiYzdmMDU4Li4zYzc1NTU5MTFhNDE5ZWM3 ZjkwY2NmOTA2NDM0NDdmM2RkMWI3MTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv aHRtbC5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCkBAIC01MzcsMTAgKzUz Nyw2IEBAIHNlbGVjdFtzaXplPSIxIl0gewogICAgIHdoaXRlLXNwYWNlOiBwcmU7CiB9CiAKLWRh dGFsaXN0IHsKLSAgICBkaXNwbGF5OiBub25lOwotfQotCiBvcHRncm91cCB7CiAgICAgZm9udC13 ZWlnaHQ6IGJvbGRlcjsKIH0K 79162 2011-01-17 06:26:37 -0800 2011-01-17 06:59:55 -0800 Patch bug-52214-20110117152634.patch text/plain 3250 rik ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1ODU0MWE1MGJiYTVkZGQ2YTdhNWM5YTA2YzllNTAxNzJmMTVhNmQyLi5mMjdjZTVj NzJlZTM5Y2RlMzViMTkxYWM3MWNmNTdkOThlNTU2N2QzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDEtMTcgIEFudGhvbnkgUmljYXVkICA8cmlrQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0hUTUw1XSBSZXZlcnQgZGlz cGxheTpub25lIG9uIGRhdGFsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MjIxNAorCisgICAgICAgICogZmFzdC9mb3Jtcy9kYXRhbGlzdC1leHBl Y3RlZC50eHQ6CisgICAgICAgICogZmFzdC9mb3Jtcy9kYXRhbGlzdC1ub25vcHRpb24tY2hpbGQt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZm9ybXMvZGF0YWxpc3QuaHRtbDoKKwogMjAx MS0wMS0xNCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvZGF0YWxpc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9k YXRhbGlzdC1leHBlY3RlZC50eHQKaW5kZXggNDYwOTQ4OTA0Y2QyMDE5OWYxZDkxMjZiODJjMTRk N2I5YzQwNDc2ZS4uMzFhM2QzYzQwMmY4ZjJiMWE2MGJkMjBiYWFhZjUzNTJjZTkzMmE3MCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC1leHBlY3RlZC50eHQKQEAgLTgsNCAr OCw0IEBAIFBBU1MgZGF0YWxpc3Qub3B0aW9ucy5sZW5ndGggaXMgMwogUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCi0KK1RoZSBjaG9pY2VzIGFyZSAsICwg LCBhbmQgLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC1ub25v cHRpb24tY2hpbGQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlz dC1ub25vcHRpb24tY2hpbGQtZXhwZWN0ZWQudHh0CmluZGV4IGIwYWE3ZDU2MmQ2OTgzMGQxMDY2 NzRjYTc1OTlmZmUzNzAyN2YyOTYuLmM3ZjIzZDkyZTY1NDQ0YTQyYzA3MjljN2Q5ZDI5M2RlY2Ri NjM0NDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZGF0YWxpc3Qtbm9ub3B0 aW9uLWNoaWxkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RhdGFs aXN0LW5vbm9wdGlvbi1jaGlsZC1leHBlY3RlZC50eHQKQEAgLTksNCArOSw2IEBAIFBBU1MgZGF0 YWxpc3QuZmlyc3RDaGlsZC5ub2RlTmFtZSBpcyAiRElWIgogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCitUZXh0IGlzIG9rLiBBbiBpbmxpbmUgZWxlbWVu dCBpcyBvay4KK0EgYmxvY2sgZWxlbWVudCBpcyBub3Qgb2suCiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvZGF0YWxpc3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv ZGF0YWxpc3QuaHRtbAppbmRleCAwMTE0OTcyZDI3MjVkNDEzZmNiMGM2YjRmNjZjZmZkZDk5OGU5 Mjk2Li4xZGE5MjZiMjIwMGU1N2ViOTVkYjkwOWNiN2MwYmM0YzhiNjZjM2E0IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RhdGFsaXN0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9kYXRhbGlzdC5odG1sCkBAIC0yOSw3ICsyOSw4IEBAIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdvNCcpLmRpc2FibGVkID0gdHJ1ZTsKIHNob3VsZEJlKCdkYXRhbGlzdC5vcHRp b25zLmxlbmd0aCcsICczJyk7CiAKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwotLy8g VGhlIGV4cGVjdGVkIHRleHQgc2hvdWxkIG5vdCBjb250YWluIHRoZSB0ZXh0IGluIHRoZSBkYXRh bGlzdCBlbGVtZW50LgorLy8gQWZ0ZXIgZGF0YWxpc3QgaXMgaW1wbGVtZW50ZWQsIHRoZSBleHBl Y3RlZCB0ZXh0IHNob3VsZCBub3QgY29udGFpbiB0aGUKKy8vIHRleHQgaW4gdGhlIGRhdGFsaXN0 IGVsZW1lbnQuCiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgogPC9ib2R5PgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBjNDBm ZGFmMTVjODA2ZjJhMDA4MDBhY2Y0NzgzNzNiMjJhNDIzMDcuLjE5MjliNTBjYmJhZjYzYmE0OTdi YzViYTM2MTgyMzJlMTViNDI5NGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0w MS0xNyAgQW50aG9ueSBSaWNhdWQgIDxyaWtAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbSFRNTDVdIFJldmVydCBkaXNwbGF5Om5v bmUgb24gZGF0YWxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUyMjE0CisKKyAgICAgICAgKiBjc3MvaHRtbC5jc3M6CisKIDIwMTEtMDEtMTcgIFBh dmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmll d2VkOiBRdCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5j c3MgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MKaW5kZXggZDViM2ExOWE5NDYyMmRiOTUx YjFhZjdlM2JjODQ3ZDY2YmM3ZjA1OC4uM2M3NTU1OTExYTQxOWVjN2Y5MGNjZjkwNjQzNDQ3ZjNk ZDFiNzEzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcwpAQCAtNTM3LDEwICs1MzcsNiBAQCBzZWxlY3Rbc2l6 ZT0iMSJdIHsKICAgICB3aGl0ZS1zcGFjZTogcHJlOwogfQogCi1kYXRhbGlzdCB7Ci0gICAgZGlz cGxheTogbm9uZTsKLX0KLQogb3B0Z3JvdXAgewogICAgIGZvbnQtd2VpZ2h0OiBib2xkZXI7CiB9 Cg==