52153 2011-01-10 10:44:25 -0800 Consider allowing resource revalidation and reloading after initial page load 2011-09-23 11:21:09 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 koivisto simonjam ap bs koivisto simonjam webkit.review.bot oldest_to_newest 331692 0 koivisto 2011-01-10 10:44:25 -0800 This test in CachedResourceLoader::determineRevalidationPolicy() // Avoid loading the same resource multiple times for a single document, even if the cache policies would tell us to. if (m_validatedURLs.contains(existingResource->url())) return Use; means that we never revalidate a resource for a given document (except if it has Cache-control:no-store which is handled separately), no matter how expired it is. While we don't want to load a resource multiple times during a page load we should probably allow revalidation for resources that are requested by a script after the page load has completed. This might be achieved simply be clearing (and not adding to it afterwards) m_validatedURLs when the page load completes. It would also be good to figure out what exactly other browsers do here before making any changes. 331699 1 koivisto 2011-01-10 10:49:06 -0800 Note that the current behavior has been in WebKit for a very long time so we are unlikely to fix any web sites by changing this. However it might allow better performance in some cases (since web sites could revalidate their resources instead on full reload forced by no-store). This is probably also required if we want to have XHR in the memory cache. 331711 2 ap 2011-01-10 10:58:28 -0800 See also: bug 51286 and bug 26226. 449553 3 simonjam 2011-08-10 18:37:15 -0700 *** Bug 66020 has been marked as a duplicate of this bug. *** 449589 4 ap 2011-08-10 21:56:43 -0700 Per bug 66020, this is affecting Google Docs. 450640 5 103811 simonjam 2011-08-12 13:52:37 -0700 Created attachment 103811 Patch 453049 6 103811 koivisto 2011-08-18 08:17:05 -0700 Comment on attachment 103811 Patch r=me 453195 7 103811 webkit.review.bot 2011-08-18 11:41:42 -0700 Comment on attachment 103811 Patch Clearing flags on attachment: 103811 Committed r93326: <http://trac.webkit.org/changeset/93326> 453196 8 webkit.review.bot 2011-08-18 11:41:47 -0700 All reviewed patches have been landed. Closing bug. 472353 9 ap 2011-09-23 11:21:09 -0700 This patch has broken MobileMe galleries, see bug 68682. 103811 2011-08-12 13:52:37 -0700 2011-08-18 11:41:42 -0700 Patch bug-52153-20110812135236.patch text/plain 5801 simonjam U3VidmVyc2lvbiBSZXZpc2lvbjogOTI5NTkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZTI4NzhmMmU4MjQzZGZiYzE5NDBj ZDMwMWE4MjIzYTVlZWY1Y2RhLi43MTNjNjdiZTM1ZDE2MGEyYjI2OWNiYTQ5MDI0MjY5MjliMzVl YWRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMTAgIEphbWVzIFNpbW9uc2VuICA8 c2ltb25qYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmFsaWRhdGUgZXhwaXJlZCByZXNv dXJjZXMgaWYgdGhleSdyZSByZXF1ZXN0ZWQgYWZ0ZXIgdGhlIGluaXRpYWwgZG9jdW1lbnQgbG9h ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIxNTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAv dGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtbXVsdGlwbGUtaW5zdGFuY2VzLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1tdWx0aXBsZS1p bnN0YW5jZXMuaHRtbDogQWRkZWQuCisKIDIwMTEtMDgtMTIgIEFuZHJlaSBQb3Blc2N1ICA8YW5k cmVpcEBnb29nbGUuY29tPgogCiAgICAgICAgIFtDaHJvbWl1bV0gUmViYXNlbGluZSB0aGVzZSB0 ZXN0cyBvbiBMZW9wYXJkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNo ZS9zdWJyZXNvdXJjZS1tdWx0aXBsZS1pbnN0YW5jZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1tdWx0aXBsZS1pbnN0YW5jZXMtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjJiZDIzNDdlMmNkOGY0MjFlYmQwMDZiZTEwMTI5Yzk0Yjg5Mzc4 NTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3N1YnJl c291cmNlLW11bHRpcGxlLWluc3RhbmNlcy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAor VmVyaWZpZXMgdGhhdCByZXNvdXJjZXMgYXJlIGxvYWRlZCBvbmx5IG9uY2UgZHVyaW5nIHRoZSBp bml0aWFsIGRvY3VtZW50IGxvYWQsIGJ1dCBhcmUgcmVsb2FkZWQgaWYgdGhleSBhcmUgcmVxdWVz dGVkIGFnYWluIGxhdGVyIGFuZCBjYW4gbm90IGJlIGNhY2hlZC4KKworUEFTUyBmaXJzdFJhbmRv bU51bWJlciBpcyBub24temVyby4KK1BBU1Mgc2Vjb25kUmFuZG9tTnVtYmVyIGlzIG5vbi16ZXJv LgorUEFTUyB0aGlyZFJhbmRvbU51bWJlciBpcyBub24temVyby4KK1BBU1MgZmlyc3RSYW5kb21O dW1iZXIgPT0gc2Vjb25kUmFuZG9tTnVtYmVyIGlzIHRydWUKK1BBU1MgZmlyc3RSYW5kb21OdW1i ZXIgIT0gdGhpcmRSYW5kb21OdW1iZXIgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtbXVsdGlwbGUtaW5zdGFuY2VzLmh0bWwgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3N1YnJlc291cmNlLW11bHRpcGxlLWluc3RhbmNlcy5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjE3YWNlMDExYTVlOTNlZWI5ZWRhNjIxMzc0NDdiZjY2Y2UxZjhkNmEKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3N1YnJlc291cmNl LW11bHRpcGxlLWluc3RhbmNlcy5odG1sCkBAIC0wLDAgKzEsNTIgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5UZXN0IENhY2hpbmcgIm5vLXN0b3JlIiBGb3IgSGlz dG9yeSBPbmx5PC90aXRsZT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy10ZXN0LXJlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlZlcmlmaWVzIHRo YXQgcmVzb3VyY2VzIGFyZSBsb2FkZWQgb25seSBvbmNlIGR1cmluZyB0aGUgaW5pdGlhbCBkb2N1 bWVudAorbG9hZCwgYnV0IGFyZSByZWxvYWRlZCBpZiB0aGV5IGFyZSByZXF1ZXN0ZWQgYWdhaW4g bGF0ZXIgYW5kIGNhbiBub3QgYmUgY2FjaGVkLgorPC9wPgorPHByZSBpZD0iY29uc29sZSI+PC9w cmU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KK3ZhciByYW5kb21OdW1iZXIgPSAw OwordmFyIGZpcnN0UmFuZG9tTnVtYmVyID0gMDsKK3ZhciBzZWNvbmRSYW5kb21OdW1iZXIgPSAw OwordmFyIHRoaXJkUmFuZG9tTnVtYmVyID0gMDsKK2Z1bmN0aW9uIGZpcnN0TG9hZGVkKCkgewor ICAgIGZpcnN0UmFuZG9tTnVtYmVyID0gcmFuZG9tTnVtYmVyOworICAgIHZhciBuZXdTY3JpcHQg PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzY3JpcHQiKTsKKyAgICBuZXdTY3JpcHQuc3JjID0g InJlc291cmNlcy9jYWNoZS1zaW11bGF0b3IuY2dpP3VuaXF1ZUlkPTEmQ2FjaGUtY29udHJvbD1t YXgtYWdlPTAiOworICAgIG5ld1NjcmlwdC5vbmxvYWQgPSBzZWNvbmRMb2FkZWQ7CisgICAgZG9j dW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImhlYWQiKVswXS5hcHBlbmRDaGlsZChuZXdTY3Jp cHQpOworfQorZnVuY3Rpb24gc2Vjb25kTG9hZGVkKCkgeworICAgIHNlY29uZFJhbmRvbU51bWJl ciA9IHJhbmRvbU51bWJlcjsKK30KK2Z1bmN0aW9uIGxvYWROZXh0U2NyaXB0KCkgeworICAgIHZh ciBuZXdTY3JpcHQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzY3JpcHQiKTsKKyAgICBuZXdT Y3JpcHQuc3JjID0gInJlc291cmNlcy9jYWNoZS1zaW11bGF0b3IuY2dpP3VuaXF1ZUlkPTEmQ2Fj aGUtY29udHJvbD1tYXgtYWdlPTAiOworICAgIG5ld1NjcmlwdC5vbmxvYWQgPSB0aGlyZExvYWRl ZDsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiaGVhZCIpWzBdLmFwcGVuZENo aWxkKG5ld1NjcmlwdCk7Cit9CitmdW5jdGlvbiB0aGlyZExvYWRlZCgpIHsKKyAgICB0aGlyZFJh bmRvbU51bWJlciA9IHJhbmRvbU51bWJlcjsKKyAgICBzaG91bGRCZU5vblplcm8oImZpcnN0UmFu ZG9tTnVtYmVyIik7CisgICAgc2hvdWxkQmVOb25aZXJvKCJzZWNvbmRSYW5kb21OdW1iZXIiKTsK KyAgICBzaG91bGRCZU5vblplcm8oInRoaXJkUmFuZG9tTnVtYmVyIik7CisgICAgc2hvdWxkQmVU cnVlKCJmaXJzdFJhbmRvbU51bWJlciA9PSBzZWNvbmRSYW5kb21OdW1iZXIiKTsKKyAgICBzaG91 bGRCZVRydWUoImZpcnN0UmFuZG9tTnVtYmVyICE9IHRoaXJkUmFuZG9tTnVtYmVyIik7CisgICAg ZmluaXNoSlNUZXN0KCk7Cit9Cit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIGZ1bmN0 aW9uKCkgeyBzZXRUaW1lb3V0KGxvYWROZXh0U2NyaXB0LCAwKTsgfSwgZmFsc2UpOwordmFyIGpz VGVzdElzQXN5bmMgPSB0cnVlOwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvY2FjaGUtc2ltdWxhdG9yLmNnaT91bmlxdWVJ ZD0xJkNhY2hlLWNvbnRyb2w9bWF4LWFnZT0wIiBvbmxvYWQ9ImZpcnN0TG9hZGVkKCkiIGFzeW5j Pjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU5MzMx MzY5ZWRhZDZjNWQ5NjhjNzFjM2FkZTRiZTc4NjRkMDliMi4uNzEwNTdmYTU0MTA4YmMyYjQxMjM5 NTA1ZjZlZDQ3NDY4M2Q1MDFmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA4 LTEwICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZhbGlkYXRlIGV4cGlyZWQgcmVzb3VyY2VzIGlmIHRoZXkncmUgcmVxdWVzdGVkIGFmdGVyIHRo ZSBpbml0aWFsIGRvY3VtZW50IGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUyMTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1tdWx0aXBs ZS1pbnN0YW5jZXMuaHRtbAorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNl TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlTG9hZGVyOjpkZXRl cm1pbmVSZXZhbGlkYXRpb25Qb2xpY3kpOgorCiAyMDExLTA4LTEyICBQYXZlbCBGZWxkbWFuICA8 cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtYWtlIGZvbGRl cnMgb3B0aW9uYWwgaW4gdGhlIFNjcmlwdHMnIHBhbmVsIGZpbGUgc2VsZWN0b3IuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcApp bmRleCA3NzdkOGJlMDVhMjM0M2ZiZmEwZTllN2RmYTBmYjFiZDQ3YjAxYTYwLi5kOWNkMGNiMmI0 ZDRkZWQ4YWExZTc2ZTZmNjU3NjkzMTg3Nzg1NWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTQ3NCwxMCArNDc0 LDEwIEBAIENhY2hlZFJlc291cmNlTG9hZGVyOjpSZXZhbGlkYXRpb25Qb2xpY3kgQ2FjaGVkUmVz b3VyY2VMb2FkZXI6OmRldGVybWluZVJldmFsaWRhCiAgICAgICAgIHJldHVybiBSZWxvYWQ7CiAg ICAgfQogCi0gICAgLy8gQXZvaWQgbG9hZGluZyB0aGUgc2FtZSByZXNvdXJjZSBtdWx0aXBsZSB0 aW1lcyBmb3IgYSBzaW5nbGUgZG9jdW1lbnQsIGV2ZW4gaWYgdGhlIGNhY2hlIHBvbGljaWVzIHdv dWxkIHRlbGwgdXMgdG8uCi0gICAgaWYgKG1fdmFsaWRhdGVkVVJMcy5jb250YWlucyhleGlzdGlu Z1Jlc291cmNlLT51cmwoKSkpCisgICAgLy8gRHVyaW5nIHRoZSBpbml0aWFsIGxvYWQsIGF2b2lk IGxvYWRpbmcgdGhlIHNhbWUgcmVzb3VyY2UgbXVsdGlwbGUgdGltZXMgZm9yIGEgc2luZ2xlIGRv Y3VtZW50LCBldmVuIGlmIHRoZSBjYWNoZSBwb2xpY2llcyB3b3VsZCB0ZWxsIHVzIHRvLgorICAg IGlmICghZG9jdW1lbnQoKS0+bG9hZEV2ZW50RmluaXNoZWQoKSAmJiBtX3ZhbGlkYXRlZFVSTHMu Y29udGFpbnMoZXhpc3RpbmdSZXNvdXJjZS0+dXJsKCkpKQogICAgICAgICByZXR1cm4gVXNlOwot ICAgIAorCiAgICAgLy8gQ2FjaGVQb2xpY3lSZWxvYWQgYWx3YXlzIHJlbG9hZHMKICAgICBpZiAo Y2FjaGVQb2xpY3koKSA9PSBDYWNoZVBvbGljeVJlbG9hZCkgewogICAgICAgICBMT0coUmVzb3Vy Y2VMb2FkaW5nLCAiQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OmRldGVybWluZVJldmFsaWRhdGlvblBv bGljeSByZWxvYWRpbmcgZHVlIHRvIENhY2hlUG9saWN5UmVsb2FkLiIpOwo=