52146 2011-01-10 07:23:31 -0800 [WK2] Support for ARM's RVCT compiler in WKBase.h 2011-01-10 12:07:51 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 50251 1 s.mathur s.mathur barraclough commit-queue eric oldest_to_newest 331617 0 s.mathur 2011-01-10 07:23:31 -0800 Similar to Microsoft's compilers, ARM's RVCT (ARMCC) compiler supports __declspec(dllexport) directive to indicate a DLL export. Update WebKit2/Shared/API/c/WKBase.h to reflect this. Additionally, passing ARMCC the GNU compatbility flag causes the __GNUC__ macro to be implicitly defined, so explicitly guard against use of __attribute__((visibility("default"))). 331661 1 78404 s.mathur 2011-01-10 09:35:53 -0800 Created attachment 78404 Patch 331755 2 78404 eric 2011-01-10 11:30:10 -0800 Comment on attachment 78404 Patch OK. rs=me. 331756 3 eric 2011-01-10 11:30:38 -0800 CCing Gavin who might know something about ARM. 331807 4 barraclough 2011-01-10 12:06:06 -0800 Don't really know anything about this, but would have RS'ed too! 331809 5 commit-queue 2011-01-10 12:06:23 -0800 The commit-queue encountered the following flaky tests while processing attachment 78404: security/block-test-no-port.html bug 52164 (author: pam@chromium.org) The commit-queue is continuing to process your patch. 331813 6 78404 commit-queue 2011-01-10 12:07:45 -0800 Comment on attachment 78404 Patch Clearing flags on attachment: 78404 Committed r75404: <http://trac.webkit.org/changeset/75404> 331814 7 commit-queue 2011-01-10 12:07:51 -0800 All reviewed patches have been landed. Closing bug. 78404 2011-01-10 09:35:53 -0800 2011-01-10 12:07:45 -0800 Patch 52146_v1.patch text/plain 1181 s.mathur SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTM4MCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMTAgIFNpZGRoYXJ0aCBNYXRodXIgIDxzaWRkaGFydGgu bWF0aHVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTdXBwb3J0IGZvciBBUk0ncyBSVkNUKEFSTUNDKSBjb21waWxlciBpbiBpbXBv cnQvZXhwb3J0IGRpcmVjdGl2ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUyMTQ2IAorCisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLQmFzZS5oOgor CiAyMDExLTAxLTEwICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KSW5kZXg6IFdlYktpdDIvU2hhcmVk L0FQSS9jL1dLQmFzZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFz ZS5oCShyZXZpc2lvbiA3NTM3NSkKKysrIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC05OSw5ICs5OSw5IEBAIHR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1 ZVdLQnVuZGxlU2NyaXAKICN1bmRlZiBXS19FWFBPUlQKICNpZiBkZWZpbmVkKFdLX05PX0VYUE9S VCkKICNkZWZpbmUgV0tfRVhQT1JUCi0jZWxpZiBkZWZpbmVkKF9fR05VQ19fKQorI2VsaWYgZGVm aW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19BUk1DQ19fKQogI2RlZmluZSBXS19FWFBPUlQg X19hdHRyaWJ1dGVfXygodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKLSNlbGlmIGRlZmluZWQoV0lO MzIpIHx8IGRlZmluZWQoX1dJTjMyKQorI2VsaWYgZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChf V0lOMzIpIHx8IGRlZmluZWQoX19BUk1DQ19fKQogI2lmIEJVSUxESU5HX1dFQktJVAogI2RlZmlu ZSBXS19FWFBPUlQgX19kZWNsc3BlYyhkbGxleHBvcnQpCiAjZWxzZQo=