52031 2011-01-06 15:24:59 -0800 [WIN] Add ProxyServerWin.cpp 2011-01-10 10:14:27 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 52109 1 paroga paroga commit-queue laszlo.gombos oldest_to_newest 330483 0 paroga 2011-01-06 15:24:59 -0800 see patch 330493 1 78177 paroga 2011-01-06 15:30:33 -0800 Created attachment 78177 Patch 330655 2 78177 eric 2011-01-06 23:12:07 -0800 Comment on attachment 78177 Patch OK. Does the CPP file need to be wrapped in #if ENABLE()? 330687 3 paroga 2011-01-07 01:30:45 -0800 (In reply to comment #2) > (From update of attachment 78177 [details]) > OK. Does the CPP file need to be wrapped in #if ENABLE()? No. It will be used (linked) only when the NSAPI is enabled, otherwise they will be ignored while linking. 331638 4 78177 laszlo.gombos 2011-01-10 08:45:25 -0800 Comment on attachment 78177 Patch LGTM, r+. ResourceHandleWin.cpp seems to be a similar case; no guard as it is only picked up by WinCE build system. I would still prefer to have some indication in the cpp files that these are at the moment only for WinCE (e.g. OS(x) guard), but it seems that this should be done for some other files as well, so perhaps it should be a separate patch. 331671 5 78177 commit-queue 2011-01-10 10:14:19 -0800 Comment on attachment 78177 Patch Clearing flags on attachment: 78177 Committed r75383: <http://trac.webkit.org/changeset/75383> 331672 6 commit-queue 2011-01-10 10:14:27 -0800 All reviewed patches have been landed. Closing bug. 78177 2011-01-06 15:30:33 -0800 2011-01-10 10:14:19 -0800 Patch bug-52031.patch text/plain 3502 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9XZWJDb3JlL0NNYWtlTGlzdHMu dHh0CmluZGV4IDU1MTVmMGUuLjc2N2U1OGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTQwOCw2ICsxNDA4LDcgQEAg U0VUKFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuY3Bw CiAgICAgcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHAKICAgICBwbGF0 Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5jcHAKKyAgICBwbGF0Zm9ybS9uZXR3b3JrL1By b3h5U2VydmVyLmNwcAogICAgIHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VFcnJvckJhc2UuY3Bw CiAgICAgcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5jcHAKICAgICBwbGF0Zm9ybS9u ZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NNYWtl TGlzdHNXaW5DRS50eHQgYi9XZWJDb3JlL0NNYWtlTGlzdHNXaW5DRS50eHQKaW5kZXggYzMzZGMx Ni4uYjhjMTNlZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DTWFrZUxpc3RzV2luQ0UudHh0CisrKyBi L1dlYkNvcmUvQ01ha2VMaXN0c1dpbkNFLnR4dApAQCAtNzQsNiArNzQsNyBAQCBMSVNUKEFQUEVO RCBXZWJDb3JlX1NPVVJDRVMKIAogICAgIHBsYXRmb3JtL25ldHdvcmsvd2luL0Nvb2tpZUphcldp bi5jcHAKICAgICBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9OZXR3b3JrU3RhdGVOb3RpZmllcldpbi5j cHAKKyAgICBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9Qcm94eVNlcnZlcldpbi5jcHAKICAgICBwbGF0 Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHAKICAgICBwbGF0Zm9ybS9uZXR3 b3JrL3dpbi9Tb2NrZXRTdHJlYW1IYW5kbGVXaW4uY3BwCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDEwMWMzMS4uOTlhZmRlOCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMS0wMS0wNiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb V0lOXSBBZGQgUHJveHlTZXJ2ZXJXaW4uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MjAzMQorCisgICAgICAgIEFkZCBzdHViIGltcGxlbWVudGF0 aW9uIHRvIGZpeCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSBvbiBXaW5DRS4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICAqIENNYWtlTGlzdHNXaW5DRS50eHQ6CisgICAg ICAgICogcGxhdGZvcm0vbmV0d29yay93aW4vUHJveHlTZXJ2ZXJXaW4uY3BwOiBBZGRlZC4KKyAg ICAgICAgKFdlYkNvcmU6OnByb3h5U2VydmVyc0ZvclVSTCk6CisKIDIwMTEtMDEtMDYgIEphbWVz IFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4v UHJveHlTZXJ2ZXJXaW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9Qcm94eVNl cnZlcldpbi5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzYxMGUyMAot LS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUHJveHlTZXJ2 ZXJXaW4uY3BwCkBAIC0wLDAgKzEsMzcgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgQnJl bnQgRnVsZ2hhbSA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4uIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg d2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3Ry aWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAor ICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVw cm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNv bmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3Vt ZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmli dXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFO RCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBUSEUgSU1Q TElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBM RSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwg SU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IKKyAqIENPTlNFUVVF TlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5U IE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwg T1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQg QU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCisgKiBDT05UUkFDVCwg U1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJX SVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdB UkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJQcm94eVNlcnZlci5oIgor CituYW1lc3BhY2UgV2ViQ29yZSB7CisKK1ZlY3RvcjxQcm94eVNlcnZlcj4gcHJveHlTZXJ2ZXJz Rm9yVVJMKGNvbnN0IEtVUkwmLCBjb25zdCBOZXR3b3JraW5nQ29udGV4dCopCit7CisgICAgLy8g RklYTUU6IEltcGxlbWVudC4KKyAgICByZXR1cm4gVmVjdG9yPFByb3h5U2VydmVyPigpOworfQor Cit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==