52011 2011-01-06 12:58:37 -0800 JSC bindings should use RuntimeEnabledFeatures 2013-05-15 09:35:45 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 REOPENED InRadar P2 Enhancement --- 116147 1 joenotcharles webkit-unassigned abarth cdumez cmarcelo darin dbates ddkilzer dw.im jorlow ksakamoto rniwa robert oldest_to_newest 330345 0 joenotcharles 2011-01-06 12:58:37 -0800 Only the V8 bindings generate code to enable/disable Javascript features that have the EnabledAtRuntime attribute, even though the RuntimeEnabledFeatures class is in bindings/generic so it's available to JSC. This would allow attributes to be completely removed if they are disabled (simply returning "undefined" is not good enough because they will still be visible in iteration). This needs at least: - code added to CodeGeneratorJS.pm to parallel that in CodeGeneratorV8.pm that checks EnabledAtRuntime (or better yet move these checks into common helpers) - possibly added to the other CodeGenerator scripts as well? - existing uses of RuntimeEnabledFeatures that are wrapped in "#if USE(V8)" need to be audited to see if they should now be unconditional - RuntimeEnabledFeatures needs to be added to the build for all platforms using JSC 745442 1 ddkilzer 2012-10-18 11:51:38 -0700 <rdar://problem/10155019> 778682 2 tkent 2012-11-28 21:45:40 -0800 *** Bug 91199 has been marked as a duplicate of this bug. *** 889329 3 rniwa 2013-05-15 09:19:55 -0700 *** This bug has been marked as a duplicate of bug 116147 *** 889343 4 cdumez 2013-05-15 09:32:08 -0700 (In reply to comment #3) > > *** This bug has been marked as a duplicate of bug 116147 *** Actually, I think we can keep the other one open make add a dependency. My patch only adds support for global constructors. Work will still be needed to extend that to regular attributes and operations. 889346 5 rniwa 2013-05-15 09:35:45 -0700 Okay.