51998 2011-01-06 11:52:51 -0800 Allow framesets after hidden inputs 2011-01-06 14:30:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tonyg tonyg abarth commit-queue eric webkit.review.bot oldest_to_newest 330265 0 tonyg 2011-01-06 11:52:51 -0800 Allow framesets after hidden inputs 330268 1 78138 tonyg 2011-01-06 11:56:30 -0800 Created attachment 78138 Patch 330269 2 tonyg 2011-01-06 11:57:28 -0800 That code is simply a joy to work in. Lines up with the spec update perfectly. 330363 3 78138 eric 2011-01-06 13:17:20 -0800 Comment on attachment 78138 Patch Thanks! 330408 4 commit-queue 2011-01-06 14:06:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 78138: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html bug 52016 (author: jchaffraix@webkit.org) The commit-queue is continuing to process your patch. 330410 5 78138 commit-queue 2011-01-06 14:07:57 -0800 Comment on attachment 78138 Patch Clearing flags on attachment: 78138 Committed r75198: <http://trac.webkit.org/changeset/75198> 330411 6 commit-queue 2011-01-06 14:08:02 -0800 All reviewed patches have been landed. Closing bug. 330428 7 webkit.review.bot 2011-01-06 14:30:05 -0800 http://trac.webkit.org/changeset/75198 might have broken Qt Linux Release minimal 78138 2011-01-06 11:56:30 -0800 2011-01-06 14:07:57 -0800 Patch bug-51998-20110106115629.patch text/plain 3387 tonyg ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhZDAyODE5YzRlYWEwZjRmNmNmMzFkZTYzYjU1MTQ3ZTFjMzkyZGM0Li4yMDM1M2Qz Mzk2NTYwNzk1YTQwZTM5NzU3MWQ5OGYwMDVmNmEzZDM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDEtMDYgIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxvdyBmcmFtZXNl dHMgYWZ0ZXIgaGlkZGVuIGlucHV0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTE5OTgKKworICAgICAgICAqIGh0bWw1bGliL3Jlc291cmNlcy93ZWJr aXQwMS5kYXQ6IERlbW9uc3RyYXRlIHRoYXQgdGhlIHZhbHVlIG9mIHRoZSB0eXBlIGF0dHJpYnV0 ZSBtYXR0ZXJzLiBBbiBpbnB1dCB3aXRoIG5vIHR5cGUgaXMgdGVzdGVkIGluIHRlc3RzMTkuZGF0 LgorCiAyMDExLTAxLTA2ICBBbmRyZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dG1sNWxpYi9yZXNvdXJjZXMvd2Via2l0MDEuZGF0IGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVz b3VyY2VzL3dlYmtpdDAxLmRhdAppbmRleCBmOGQ3M2Y5MjcyZDgxNWNmNGY0NzVlMjQxZTEzZGZj ZmUyYzZlZTVkLi40MTAxYjIxNmUxOGJjZmRkYzE1ZjdjMzlmNGIwMDE5YWY4MTcyOWU3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMvd2Via2l0MDEuZGF0CisrKyBi L0xheW91dFRlc3RzL2h0bWw1bGliL3Jlc291cmNlcy93ZWJraXQwMS5kYXQKQEAgLTU4NywzICs1 ODcsMjMgQEAgY29uc29sZS5sb2coIkZPTzxzcGFuPkJBUjwvc3Bhbj5CQVoiKTsKIHwgICAgICAg ICAgICAgIjEiCiB8ICAgICAgICAgPG1hdGggbWk+CiB8ICAgICAgICAgICAiYSIKKworI2RhdGEK KzwhZG9jdHlwZSBodG1sPjxpbnB1dCB0eXBlPSJoaWRkZW4iPjxmcmFtZXNldD4KKyNlcnJvcnMK KyNkb2N1bWVudAorfCA8IURPQ1RZUEUgaHRtbD4KK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8ICAg PGZyYW1lc2V0PgorCisjZGF0YQorPCFkb2N0eXBlIGh0bWw+PGlucHV0IHR5cGU9ImJ1dHRvbiI+ PGZyYW1lc2V0PgorI2Vycm9ycworI2RvY3VtZW50Cit8IDwhRE9DVFlQRSBodG1sPgorfCA8aHRt bD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4KK3wgICAgIDxpbnB1dD4KK3wgICAgICAgdHlwZT0i YnV0dG9uIgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCA0MGY5ZTE4NDdlOWM3MTkyYzU4YTY4N2RjM2MyZmFkNWI1ZDU0MjlhLi4yMjgxMGM3 Yjg5ZDlmOGU1NGU3ZGMyZjQ2Mjc1OTgyM2U0NWY2YzU2IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAx LTA2ICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgZnJhbWVzZXRzIGFmdGVy IGhpZGRlbiBpbnB1dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxOTk4CisKKyAgICAgICAgVGhpcyBpbXBsZW1lbnRzIHRoZSBIVE1MNSBzcGVjIHVw ZGF0ZSBpbiByZXNwb25zZSB0bzoKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvQnVncy9QdWJs aWMvc2hvd19idWcuY2dpP2lkPTExMTU2CisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJl ZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNz U3RhcnRUYWdGb3JJbkJvZHkpOgorCiAyMDExLTAxLTA2ICBKYW4gRXJpayBIYW5zc2VuICA8amhh bnNzZW5Ac2VuY2hhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIvV2Vi Q29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCmluZGV4IGMzN2Q2ZjE5N2Y4ZWM1 OWMwZWZhZjAzODE1NGU3MmU3MmYzOWEwOWUuLjAyNzEzZTU3ZGU1M2M2OTUxODRlYTdmZTIxMjI1 NTExOGIxM2I0NTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWls ZGVyLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKQEAg LTg5Myw3ICs4OTMsNiBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc1N0YXJ0VGFnRm9y SW5Cb2R5KEF0b21pY0hUTUxUb2tlbiYgdG9rZW4pCiAgICAgICAgIHx8IHRva2VuLm5hbWUoKSA9 PSBiclRhZwogICAgICAgICB8fCB0b2tlbi5uYW1lKCkgPT0gZW1iZWRUYWcKICAgICAgICAgfHwg dG9rZW4ubmFtZSgpID09IGltZ1RhZwotICAgICAgICB8fCB0b2tlbi5uYW1lKCkgPT0gaW5wdXRU YWcKICAgICAgICAgfHwgdG9rZW4ubmFtZSgpID09IGtleWdlblRhZwogICAgICAgICB8fCB0b2tl bi5uYW1lKCkgPT0gd2JyVGFnKSB7CiAgICAgICAgIG1fdHJlZS5yZWNvbnN0cnVjdFRoZUFjdGl2 ZUZvcm1hdHRpbmdFbGVtZW50cygpOwpAQCAtOTAxLDYgKzkwMCwxNCBAQCB2b2lkIEhUTUxUcmVl QnVpbGRlcjo6cHJvY2Vzc1N0YXJ0VGFnRm9ySW5Cb2R5KEF0b21pY0hUTUxUb2tlbiYgdG9rZW4p CiAgICAgICAgIG1fZnJhbWVzZXRPayA9IGZhbHNlOwogICAgICAgICByZXR1cm47CiAgICAgfQor ICAgIGlmICh0b2tlbi5uYW1lKCkgPT0gaW5wdXRUYWcpIHsKKyAgICAgICAgUmVmUHRyPEF0dHJp YnV0ZT4gdHlwZUF0dHJpYnV0ZSA9IHRva2VuLmdldEF0dHJpYnV0ZUl0ZW0odHlwZUF0dHIpOwor ICAgICAgICBtX3RyZWUucmVjb25zdHJ1Y3RUaGVBY3RpdmVGb3JtYXR0aW5nRWxlbWVudHMoKTsK KyAgICAgICAgbV90cmVlLmluc2VydFNlbGZDbG9zaW5nSFRNTEVsZW1lbnQodG9rZW4pOworICAg ICAgICBpZiAoIXR5cGVBdHRyaWJ1dGUgfHwgIWVxdWFsSWdub3JpbmdDYXNlKHR5cGVBdHRyaWJ1 dGUtPnZhbHVlKCksICJoaWRkZW4iKSkKKyAgICAgICAgICAgIG1fZnJhbWVzZXRPayA9IGZhbHNl OworICAgICAgICByZXR1cm47CisgICAgfQogICAgIGlmICh0b2tlbi5uYW1lKCkgPT0gcGFyYW1U YWcKICAgICAgICAgfHwgdG9rZW4ubmFtZSgpID09IHNvdXJjZVRhZwogICAgICAgICB8fCB0b2tl bi5uYW1lKCkgPT0gdHJhY2tUYWcpIHsK