51951 2011-01-05 13:48:56 -0800 [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser 2011-01-05 18:04:57 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P5 Minor --- 1 benjamin benjamin commit-queue oldest_to_newest 329764 0 benjamin 2011-01-05 13:48:56 -0800 Minibrowser does not define a function for QWKPage::setCreateNewPageFunction(), so the webprocess has no way to create new windows. Fix that. 329767 1 78037 benjamin 2011-01-05 13:55:15 -0800 Created attachment 78037 Patch 329945 2 commit-queue 2011-01-05 18:02:22 -0800 The commit-queue encountered the following flaky tests while processing attachment 78037: http/tests/xmlhttprequest/cookies.html bug 51976 (authors: ap@webkit.org and eric@webkit.org) The commit-queue is continuing to process your patch. 329947 3 78037 commit-queue 2011-01-05 18:04:53 -0800 Comment on attachment 78037 Patch Clearing flags on attachment: 78037 Committed r75124: <http://trac.webkit.org/changeset/75124> 329948 4 commit-queue 2011-01-05 18:04:57 -0800 All reviewed patches have been landed. Closing bug. 78037 2011-01-05 13:55:15 -0800 2011-01-05 18:04:53 -0800 Patch bug-51951-20110105230030.patch text/plain 6830 benjamin ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0Mzkx MDIyYTUwMWM0MTQwZjlmYzlmYTEyNWM2ZjE2MmZkYmFlMWZkLi44YjI1MDYzMGIwYWFiYTllN2Fj NTQ0NDVhZmZlNDk1YmMwMWYyMjZlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDEtMDUgIEJlbmphbWluIFBv dWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFtXSzJdIEFkZCB0aGUgcG9zc2liaWxp dHkgdG8gb3BlbiB3aW5kb3cgZnJvbSB0aGUgV2ViUHJvY2VzcyBpbiBNaW5pYnJvd3NlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE5NTEKKworICAg ICAgICBTZXQgYSBmdW5jdGlvbiB0byBRV0tQYWdlOjpzZXRDcmVhdGVOZXdQYWdlRnVuY3Rpb24o KSBpbiBNaW5pYnJvd3NlciBzbyB0aGVyZSBpcyBhIHdheQorICAgICAgICB0byBjcmVhdGUgbmV3 IHdpbmRvdyBmcm9tIFdlYktpdC4KKworICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJX aW5kb3cuY3BwOgorICAgICAgICAobmV3UGFnZUZ1bmN0aW9uKToKKyAgICAgICAgKEJyb3dzZXJX aW5kb3c6OkJyb3dzZXJXaW5kb3cpOgorICAgICAgICAoQnJvd3NlcldpbmRvdzo6cGFnZSk6IEFk ZGVkIHRvIGF2b2lkIHRoZSBpbmRpcmVjdCBhY2Nlc3MgdG8gUVdLUGFnZSBzcHJlYWQgaW4gdGhl IGNsYXNzCisgICAgICAgIChCcm93c2VyV2luZG93OjpuZXdXaW5kb3cpOgorICAgICAgICAoQnJv d3NlcldpbmRvdzo6dXBkYXRlVXNlckFnZW50TGlzdCk6CisgICAgICAgIChCcm93c2VyV2luZG93 OjpzaG93VXNlckFnZW50RGlhbG9nKToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9Ccm93c2Vy V2luZG93Lmg6IEFkZCB0aGUgZ2xvYmFsIHZhcmlhYmxlIGJhY2tpbmdTdG9yZVR5cGVGb3JOZXdX aW5kb3cgdG8KKyAgICAgICAgZGVmaW5lIHRoZSB0eXBlIG9mIHRoZSBiYWNraW5nIHN0b3JlIHVz ZWQgZm9yIG5ldyB3aW5kb3dzLgorICAgICAgICAqIE1pbmlCcm93c2VyL3F0L21haW4uY3BwOgor ICAgICAgICAobWFpbik6CisKIDIwMTEtMDEtMDUgIEt1bmR1IFN1Y2hpc21pdGEgIDxzdWNoaS5r dW5kdUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlm ZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwIGIvVG9vbHMv TWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKaW5kZXggNzQzYzkxYWY1NWYwNTQ3MjM0 ZWQ3MTA4YjUxYjZiM2FlYmM3MWE0NS4uYmUwOGNhZTgwNDdhYzA4OWEzNGU0N2QxYWNjNGI4M2Zh MmI3MTExMyAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5j cHAKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKQEAgLTI4LDEz ICsyOCwyMCBAQAogCiAjaW5jbHVkZSAiQnJvd3NlcldpbmRvdy5oIgogCi1Ccm93c2VyV2luZG93 OjpCcm93c2VyV2luZG93KFFHcmFwaGljc1dLVmlldzo6QmFja2luZ1N0b3JlVHlwZSB0eXBlKQot ICAgIDogbV9iYWNraW5nU3RvcmVUeXBlKHR5cGUpCitzdGF0aWMgUVdLUGFnZSogbmV3UGFnZUZ1 bmN0aW9uKFFXS1BhZ2UqKQoreworICAgIEJyb3dzZXJXaW5kb3cqIHdpbmRvdyA9IG5ldyBCcm93 c2VyV2luZG93KCk7CisgICAgcmV0dXJuIHdpbmRvdy0+cGFnZSgpOworfQorCitRR3JhcGhpY3NX S1ZpZXc6OkJhY2tpbmdTdG9yZVR5cGUgQnJvd3NlcldpbmRvdzo6YmFja2luZ1N0b3JlVHlwZUZv ck5ld1dpbmRvdyA9IFFHcmFwaGljc1dLVmlldzo6U2ltcGxlOworCitCcm93c2VyV2luZG93OjpC cm93c2VyV2luZG93KCkKIHsKICAgICBzZXRBdHRyaWJ1dGUoUXQ6OldBX0RlbGV0ZU9uQ2xvc2Up OwogCiAgICAgbV9tZW51ID0gbmV3IFFNZW51QmFyKCk7Ci0gICAgbV9icm93c2VyID0gbmV3IEJy b3dzZXJWaWV3KG1fYmFja2luZ1N0b3JlVHlwZSk7CisgICAgbV9icm93c2VyID0gbmV3IEJyb3dz ZXJWaWV3KGJhY2tpbmdTdG9yZVR5cGVGb3JOZXdXaW5kb3cpOwogICAgIG1fYWRkcmVzc0JhciA9 IG5ldyBRTGluZUVkaXQoKTsKIAogICAgIG1fbWVudS0+YWRkQWN0aW9uKCJOZXcgV2luZG93Iiwg dGhpcywgU0xPVChuZXdXaW5kb3coKSkpOwpAQCAtNTEsMTAgKzU4LDEwIEBAIEJyb3dzZXJXaW5k b3c6OkJyb3dzZXJXaW5kb3coUUdyYXBoaWNzV0tWaWV3OjpCYWNraW5nU3RvcmVUeXBlIHR5cGUp CiAgICAgY29ubmVjdChtX2Jyb3dzZXItPnZpZXcoKSwgU0lHTkFMKHVybENoYW5nZWQoY29uc3Qg UVVybCYpKSwgU0xPVCh1cmxDaGFuZ2VkKGNvbnN0IFFVcmwmKSkpOwogCiAgICAgUVRvb2xCYXIq IGJhciA9IGFkZFRvb2xCYXIoIk5hdmlnYXRpb24iKTsKLSAgICBiYXItPmFkZEFjdGlvbihtX2Jy b3dzZXItPnZpZXcoKS0+cGFnZSgpLT5hY3Rpb24oUVdLUGFnZTo6QmFjaykpOwotICAgIGJhci0+ YWRkQWN0aW9uKG1fYnJvd3Nlci0+dmlldygpLT5wYWdlKCktPmFjdGlvbihRV0tQYWdlOjpGb3J3 YXJkKSk7Ci0gICAgYmFyLT5hZGRBY3Rpb24obV9icm93c2VyLT52aWV3KCktPnBhZ2UoKS0+YWN0 aW9uKFFXS1BhZ2U6OlJlbG9hZCkpOwotICAgIGJhci0+YWRkQWN0aW9uKG1fYnJvd3Nlci0+dmll dygpLT5wYWdlKCktPmFjdGlvbihRV0tQYWdlOjpTdG9wKSk7CisgICAgYmFyLT5hZGRBY3Rpb24o cGFnZSgpLT5hY3Rpb24oUVdLUGFnZTo6QmFjaykpOworICAgIGJhci0+YWRkQWN0aW9uKHBhZ2Uo KS0+YWN0aW9uKFFXS1BhZ2U6OkZvcndhcmQpKTsKKyAgICBiYXItPmFkZEFjdGlvbihwYWdlKCkt PmFjdGlvbihRV0tQYWdlOjpSZWxvYWQpKTsKKyAgICBiYXItPmFkZEFjdGlvbihwYWdlKCktPmFj dGlvbihRV0tQYWdlOjpTdG9wKSk7CiAgICAgYmFyLT5hZGRXaWRnZXQobV9hZGRyZXNzQmFyKTsK IAogICAgIHRoaXMtPnNldE1lbnVCYXIobV9tZW51KTsKQEAgLTY1LDYgKzcyLDggQEAgQnJvd3Nl cldpbmRvdzo6QnJvd3NlcldpbmRvdyhRR3JhcGhpY3NXS1ZpZXc6OkJhY2tpbmdTdG9yZVR5cGUg dHlwZSkKICAgICBRU2hvcnRjdXQqIHNlbGVjdEFkZHJlc3NCYXIgPSBuZXcgUVNob3J0Y3V0KFF0 OjpDVFJMIHwgUXQ6OktleV9MLCB0aGlzKTsKICAgICBjb25uZWN0KHNlbGVjdEFkZHJlc3NCYXIs IFNJR05BTChhY3RpdmF0ZWQoKSksIHRoaXMsIFNMT1Qob3BlbkxvY2F0aW9uKCkpKTsKIAorICAg IHBhZ2UoKS0+c2V0Q3JlYXRlTmV3UGFnZUZ1bmN0aW9uKG5ld1BhZ2VGdW5jdGlvbik7CisKICAg ICByZXNpemUoOTYwLCA2NDApOwogICAgIHNob3coKTsKIH0KQEAgLTc1LDkgKzg0LDE0IEBAIHZv aWQgQnJvd3NlcldpbmRvdzo6bG9hZChjb25zdCBRU3RyaW5nJiB1cmwpCiAgICAgbV9icm93c2Vy LT5sb2FkKHVybCk7CiB9CiAKK1FXS1BhZ2UqIEJyb3dzZXJXaW5kb3c6OnBhZ2UoKQoreworICAg IHJldHVybiBtX2Jyb3dzZXItPnZpZXcoKS0+cGFnZSgpOworfQorCiBCcm93c2VyV2luZG93KiBC cm93c2VyV2luZG93OjpuZXdXaW5kb3coY29uc3QgUVN0cmluZyYgdXJsKQogewotICAgIEJyb3dz ZXJXaW5kb3cqIHdpbmRvdyA9IG5ldyBCcm93c2VyV2luZG93KG1fYmFja2luZ1N0b3JlVHlwZSk7 CisgICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gbmV3IEJyb3dzZXJXaW5kb3c7CiAgICAgd2lu ZG93LT5sb2FkKHVybCk7CiAgICAgcmV0dXJuIHdpbmRvdzsKIH0KQEAgLTEyNSw4ICsxMzksNiBA QCB2b2lkIEJyb3dzZXJXaW5kb3c6OnVybENoYW5nZWQoY29uc3QgUVVybCYgdXJsKQogCiB2b2lk IEJyb3dzZXJXaW5kb3c6OnVwZGF0ZVVzZXJBZ2VudExpc3QoKQogewotICAgIFFXS1BhZ2UqIHBh Z2UgPSBtX2Jyb3dzZXItPnZpZXcoKS0+cGFnZSgpOwotCiAgICAgUUZpbGUgZmlsZSgiOi91c2Vy YWdlbnRsaXN0LnR4dCIpOwogCiAgICAgaWYgKGZpbGUub3BlbihRSU9EZXZpY2U6OlJlYWRPbmx5 KSkgewpAQCAtMTM5LDkgKzE1MSw5IEBAIHZvaWQgQnJvd3NlcldpbmRvdzo6dXBkYXRlVXNlckFn ZW50TGlzdCgpCiAgICAgfQogCiAgICAgUV9BU1NFUlQoIW1fdXNlckFnZW50TGlzdC5pc0VtcHR5 KCkpOwotCi0gICAgaWYgKCEocGFnZS0+Y3VzdG9tVXNlckFnZW50KCkuaXNFbXB0eSgpIHx8IG1f dXNlckFnZW50TGlzdC5jb250YWlucyhwYWdlLT5jdXN0b21Vc2VyQWdlbnQoKSkpKQotICAgICAg ICBtX3VzZXJBZ2VudExpc3QgPDwgcGFnZS0+Y3VzdG9tVXNlckFnZW50KCk7CisgICAgUVdLUGFn ZSogd2tQYWdlID0gcGFnZSgpOworICAgIGlmICghKHdrUGFnZS0+Y3VzdG9tVXNlckFnZW50KCku aXNFbXB0eSgpIHx8IG1fdXNlckFnZW50TGlzdC5jb250YWlucyh3a1BhZ2UtPmN1c3RvbVVzZXJB Z2VudCgpKSkpCisgICAgICAgIG1fdXNlckFnZW50TGlzdCA8PCB3a1BhZ2UtPmN1c3RvbVVzZXJB Z2VudCgpOwogfQogCiB2b2lkIEJyb3dzZXJXaW5kb3c6OnNob3dVc2VyQWdlbnREaWFsb2coKQpA QCAtMTYwLDcgKzE3Miw3IEBAIHZvaWQgQnJvd3NlcldpbmRvdzo6c2hvd1VzZXJBZ2VudERpYWxv ZygpCiAgICAgY29tYm8tPmluc2VydEl0ZW1zKDAsIG1fdXNlckFnZW50TGlzdCk7CiAgICAgbGF5 b3V0LT5hZGRXaWRnZXQoY29tYm8pOwogCi0gICAgaW50IGluZGV4ID0gY29tYm8tPmZpbmRUZXh0 KG1fYnJvd3Nlci0+dmlldygpLT5wYWdlKCktPmN1c3RvbVVzZXJBZ2VudCgpKTsKKyAgICBpbnQg aW5kZXggPSBjb21iby0+ZmluZFRleHQocGFnZSgpLT5jdXN0b21Vc2VyQWdlbnQoKSk7CiAgICAg Y29tYm8tPnNldEN1cnJlbnRJbmRleChpbmRleCk7CiAKICAgICBRRGlhbG9nQnV0dG9uQm94KiBi dXR0b25Cb3ggPSBuZXcgUURpYWxvZ0J1dHRvbkJveChRRGlhbG9nQnV0dG9uQm94OjpPayB8IFFE aWFsb2dCdXR0b25Cb3g6OkNhbmNlbApAQCAtMTcwLDcgKzE4Miw3IEBAIHZvaWQgQnJvd3Nlcldp bmRvdzo6c2hvd1VzZXJBZ2VudERpYWxvZygpCiAgICAgbGF5b3V0LT5hZGRXaWRnZXQoYnV0dG9u Qm94KTsKIAogICAgIGlmIChkaWFsb2cuZXhlYygpICYmICFjb21iby0+Y3VycmVudFRleHQoKS5p c0VtcHR5KCkpCi0gICAgICAgIG1fYnJvd3Nlci0+dmlldygpLT5wYWdlKCktPnNldEN1c3RvbVVz ZXJBZ2VudChjb21iby0+Y3VycmVudFRleHQoKSk7CisgICAgICAgIHBhZ2UoKS0+c2V0Q3VzdG9t VXNlckFnZW50KGNvbWJvLT5jdXJyZW50VGV4dCgpKTsKIH0KIAogQnJvd3NlcldpbmRvdzo6fkJy b3dzZXJXaW5kb3coKQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3Nlcldp bmRvdy5oIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oCmluZGV4IGZlOTRk NmI2NjY0NzM1NDIzMGFjMWZkOTRlYzFmMDU0MjNhNDMzOTcuLjAwMTBmYmViZWYxNzEyY2I3Njgw MDg1MTU4NmRmNTg2NmZjYWU0YTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jy b3dzZXJXaW5kb3cuaAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmgK QEAgLTM4LDEwICszOCwxNCBAQCBjbGFzcyBCcm93c2VyV2luZG93IDogcHVibGljIFFNYWluV2lu ZG93IHsKICAgICBRX09CSkVDVAogCiBwdWJsaWM6Ci0gICAgQnJvd3NlcldpbmRvdyhRR3JhcGhp Y3NXS1ZpZXc6OkJhY2tpbmdTdG9yZVR5cGUpOworICAgIEJyb3dzZXJXaW5kb3coKTsKICAgICB+ QnJvd3NlcldpbmRvdygpOwogICAgIHZvaWQgbG9hZChjb25zdCBRU3RyaW5nJiB1cmwpOwogCisg ICAgUVdLUGFnZSogcGFnZSgpOworCisgICAgc3RhdGljIFFHcmFwaGljc1dLVmlldzo6QmFja2lu Z1N0b3JlVHlwZSBiYWNraW5nU3RvcmVUeXBlRm9yTmV3V2luZG93OworCiBwdWJsaWMgc2xvdHM6 CiAgICAgQnJvd3NlcldpbmRvdyogbmV3V2luZG93KGNvbnN0IFFTdHJpbmcmIHVybCA9ICJhYm91 dDpibGFuayIpOwogICAgIHZvaWQgb3BlbkxvY2F0aW9uKCk7CkBAIC02MCw3ICs2NCw2IEBAIHBy aXZhdGU6CiAgICAgUU1lbnVCYXIqIG1fbWVudTsKICAgICBRTGluZUVkaXQqIG1fYWRkcmVzc0Jh cjsKICAgICBRU3RyaW5nTGlzdCBtX3VzZXJBZ2VudExpc3Q7Ci0gICAgUUdyYXBoaWNzV0tWaWV3 OjpCYWNraW5nU3RvcmVUeXBlIG1fYmFja2luZ1N0b3JlVHlwZTsKIH07CiAKICNlbmRpZgpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvbWFpbi5jcHAgYi9Ub29scy9NaW5pQnJvd3Nl ci9xdC9tYWluLmNwcAppbmRleCAyMGY0ZmY1NGZhZDI5MmIwYzgzMmY2MzA0ZGQ4MjhkZThkMjky NGE5Li44Yzk4N2M1YTEzMGQxNmEyYTQ2OGY4NzE2OTBkYjJlODMxZGY3ZTJkIDEwMDY0NAotLS0g YS9Ub29scy9NaW5pQnJvd3Nlci9xdC9tYWluLmNwcAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9x dC9tYWluLmNwcApAQCAtNTMsNyArNTMsOCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFy Z3YpIHsKICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCJodHRwOi8vd3d3Lmdvb2dsZS5jb20iKTsK ICAgICB9CiAKLSAgICBCcm93c2VyV2luZG93KiB3aW5kb3cgPSBuZXcgQnJvd3NlcldpbmRvdyhi YWNraW5nU3RvcmVUeXBlVG9Vc2UpOworICAgIEJyb3dzZXJXaW5kb3c6OmJhY2tpbmdTdG9yZVR5 cGVGb3JOZXdXaW5kb3cgPSBiYWNraW5nU3RvcmVUeXBlVG9Vc2U7CisgICAgQnJvd3NlcldpbmRv dyogd2luZG93ID0gbmV3IEJyb3dzZXJXaW5kb3c7CiAgICAgd2luZG93LT5sb2FkKGFyZ3NbMF0p OwogCiAgICAgZm9yIChpbnQgaSA9IDE7IGkgPCBhcmdzLnNpemUoKTsgKytpKQo=