51948 2011-01-05 13:18:55 -0800 [Qt] REGRESSION(r74776) TestNetscapePlugin doesn't link on OS X 2011-01-06 05:28:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 jhanssen webkit-unassigned annulen commit-queue oldest_to_newest 329745 0 jhanssen 2011-01-05 13:18:55 -0800 TestNetscapePlugin fails to link on OS X, with the following error: g++ -headerpad_max_install_names -arch x86_64 -single_module -dynamiclib -Xarch_x86_64 -mmacosx-version-min=10.5 -o TestNetscapePlugIn PluginObjectMac.o PluginObject.o PluginTest.o TestObject.o DocumentOpenInDestroyStream.o EvaluateJSAfterRemovingPluginElement.o GetUserAgentWithNullNPPFromNPPNew.o NPRuntimeObjectFromDestroyedPlugin.o NPRuntimeRemoveProperty.o NullNPPGetValuePointer.o PassDifferentNPPStruct.o PluginScriptableNPObjectInvokeDefault.o main.o -F/Users/jhanssen/dev/WebKit/WebKitBuild-qt/Debug/lib -F/Users/jhanssen/dev/qt/lib -L/Users/jhanssen/dev/WebKit/WebKitBuild-qt/Debug/lib -L/Users/jhanssen/dev/qt/lib -framework QtWebKit -framework Carbon -framework Cocoa -framework QuartzCore -lX11 -framework QtGui -L/Users/jhanssen/dev/qt/lib -F/Users/jhanssen/dev/qt/lib -framework QtCore ld: library not found for -lX11 collect2: ld returned 1 exit status The problem is that r74776 (from bug 51700) introduced a dependency on libX11 for all Unix platforms, and Qt considers OS X a unix platform. I'll upload a patch shortly that addresses this problem. 329751 1 78033 jhanssen 2011-01-05 13:24:05 -0800 Created attachment 78033 Patch 329849 2 78033 ariya.hidayat 2011-01-05 16:13:04 -0800 Comment on attachment 78033 Patch re=me 329851 3 78033 ariya.hidayat 2011-01-05 16:14:21 -0800 Comment on attachment 78033 Patch Apparently it needs more exclusion. r- meanwhile 329855 4 78060 jhanssen 2011-01-05 16:18:31 -0800 Created attachment 78060 Patch 329857 5 78060 ariya.hidayat 2011-01-05 16:21:52 -0800 Comment on attachment 78060 Patch re=me 330006 6 78060 commit-queue 2011-01-05 20:56:29 -0800 Comment on attachment 78060 Patch Clearing flags on attachment: 78060 Committed r75134: <http://trac.webkit.org/changeset/75134> 330007 7 commit-queue 2011-01-05 20:56:33 -0800 All reviewed patches have been landed. Closing bug. 330067 8 annulen 2011-01-06 01:48:28 -0800 I don't agree with this patch. If platform does not match win32, embedded, mac, and symbian, it does not mean that this platform uses X11 (e.g., it will break Haiku) I think that the most correct expression is unix:!mac It it was CMake, I'd used Q_WS_X11, but I don't know if it's available in QMake 330102 9 jhanssen 2011-01-06 05:04:20 -0800 (In reply to comment #8) > I don't agree with this patch. If platform does not match win32, embedded, mac, and symbian, it does not mean that this platform uses X11 (e.g., it will break Haiku) > > I think that the most correct expression is > > unix:!mac That won't work for Qt Embedded, which is still Unix but doesn't use X11. The expression from my last patch is already used by Qt (see $QTDIR/src/gui/gui.pro). If there is a CONFIG option for haiku then we might have to add that to the list. 330103 10 annulen 2011-01-06 05:28:18 -0800 (In reply to comment #9) I don't know anything about Haiku, I only thought that it's erroneous to assume that everything "unknown" uses X11. Inside Tools/DumpRenderTree/qt/main.cpp Q_WS_X11 macro is used. For example it will be defined if Qt on Mac is compiled with X11 support. "Exotic" platforms may add patches to make Q_WS_X11 and related macros work properly. Unfortunately I don't know how to check for Q_WS_X11 in qmake (in CMake it's trivial). Let it be:) 78033 2011-01-05 13:24:05 -0800 2011-01-05 16:18:24 -0800 Patch bug-51948-20110105222403.patch text/plain 1157 jhanssen ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0Mzkx MDIyYTUwMWM0MTQwZjlmYzlmYTEyNWM2ZjE2MmZkYmFlMWZkLi4xOGQwY2JmNWEyZGJiZTE4ZTdk Mjg0MTM1Mjc4MDdmOWY0OTdmNTU3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMDUgIEphbiBFcmlrIEhh bnNzZW4gIDxqaGFuc3NlbkBzZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVGVzdE5ldHNjYXBlUGx1Z2luIGRvZXNuJ3QgbGlu ayBvbiBPUyBYCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MTk0OAorCisgICAgICAgIERvbid0IGFkZCBhIGRlcGVuZGVuY3kgb24gbGliWDExIG9uIE9T IFguCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVz dE5ldHNjYXBlUGx1Z2luLnBybzoKKwogMjAxMS0wMS0wNSAgS3VuZHUgU3VjaGlzbWl0YSAgPHN1 Y2hpLmt1bmR1QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5n LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdE5ldHNjYXBlUGx1Z2lu L1Rlc3ROZXRzY2FwZVBsdWdpbi5wcm8gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0TmV0 c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybwppbmRleCBmZDU4MWZiNjBkYjhkZDMx ZWFkMThmNDUyNjg2MjY4YmQ4M2VjNWMwLi4yYzhmNTRiNTQxMjFmNTUyMTA2OTViZmU1MDA4M2Nj NjZhM2VjYzljIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0TmV0c2Nh cGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybworKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9xdC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybwpAQCAtNDUsNiAr NDUsNiBAQCBtYWMgewogICAgIFNPVVJDRVMgKz0gLi4vLi4vdW5peC9UZXN0TmV0c2NhcGVQbHVn aW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcAogfQogCi11bml4IHsKK3VuaXg6IW1hYyB7CiAgICAg TElCUyArPSAtbFgxMQogfQo= 78060 2011-01-05 16:18:31 -0800 2011-01-05 20:56:29 -0800 Patch bug-51948-20110106011828.patch text/plain 1183 jhanssen ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0Mzkx MDIyYTUwMWM0MTQwZjlmYzlmYTEyNWM2ZjE2MmZkYmFlMWZkLi5jZGFmOWE1YTUxOWZjM2UzNzYw MzYxMmJhNTc1M2VkMTFjYWZiNGU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMDUgIEphbiBFcmlrIEhh bnNzZW4gIDxqaGFuc3NlbkBzZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVGVzdE5ldHNjYXBlUGx1Z2luIGRvZXNuJ3QgbGlu ayBvbiBPUyBYCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MTk0OAorCisgICAgICAgIE9ubHkgYWRkIGEgZGVwZW5kZW5jeSBvbiBsaWJYMTEgb24gWDEx IHN5c3RlbXMKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L1Rlc3ROZXRzY2FwZVBsdWdp bi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvOgorCiAyMDExLTAxLTA1ICBLdW5kdSBTdWNoaXNtaXRh ICA8c3VjaGkua3VuZHVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMg S2xpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0TmV0c2NhcGVQ bHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rl c3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvCmluZGV4IGZkNTgxZmI2MGRi OGRkMzFlYWQxOGY0NTI2ODYyNjhiZDgzZWM1YzAuLmMyOTYxMmEwNmNlZDJjMTZkYzI4MzYxYWE3 ZDg3ZmY2MzQyOTA0OTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RO ZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvCisrKyBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvCkBAIC00 NSw2ICs0NSw2IEBAIG1hYyB7CiAgICAgU09VUkNFUyArPSAuLi8uLi91bml4L1Rlc3ROZXRzY2Fw ZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCiB9CiAKLXVuaXggeworIXdpbjMyOiFlbWJl ZGRlZDohbWFjOiFzeW1iaWFuIHsKICAgICBMSUJTICs9IC1sWDExCiB9Cg==