51929 2011-01-05 08:48:22 -0800 [Qt][V8] ScriptCachedFrameData.cpp misses V8DOMWindowShell::setContext 2011-01-12 11:46:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 51930 1 abecsi abecsi abarth andreip antonm eric ossy oldest_to_newest 329582 0 abecsi 2011-01-05 08:48:22 -0800 After http://trac.webkit.org/changeset/74778 QtWebKit-V8 does not build because of the missing V8DOMWindowShell::setContext method, which was originally introduced in http://trac.webkit.org/changeset/56716. 329583 1 andreip 2011-01-05 08:52:30 -0800 Oh, Android uses that method to enable WebKit's page cache mechanism so the method *is* used. Anton, please roll back your change :) 329586 2 78008 abecsi 2011-01-05 09:04:36 -0800 Created attachment 78008 proposed fix I'm not really sure whether this is the right way to fix the issue, maybe someone who is more familiar with V8 bindings can help. 329587 3 abecsi 2011-01-05 09:06:15 -0800 (In reply to comment #1) > Oh, Android uses that method to enable WebKit's page cache mechanism so the method *is* used. Anton, please roll back your change :) Ah OK. Thanks for the help. 329589 4 andreip 2011-01-05 09:08:14 -0800 (In reply to comment #2) > Created an attachment (id=78008) [details] > proposed fix > > I'm not really sure whether this is the right way to fix the issue, maybe someone who is more familiar with V8 bindings can help. I don't think that's the right fix. We should simply roll back Anton's change, IMHO. 329592 5 abecsi 2011-01-05 09:11:44 -0800 (In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=78008) [details] [details] > > proposed fix > > > > I'm not really sure whether this is the right way to fix the issue, maybe someone who is more familiar with V8 bindings can help. > > I don't think that's the right fix. We should simply roll back Anton's change, IMHO. OK, sheriffbot can do that. 329616 6 abecsi 2011-01-05 09:44:24 -0800 The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073. 332334 7 antonm 2011-01-11 07:51:41 -0800 Sorry for the trouble. May I have a look how you use this method? (In reply to comment #6) > The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073. 332350 8 andreip 2011-01-11 08:23:38 -0800 (In reply to comment #7) > Sorry for the trouble. > > May I have a look how you use this method? > > (In reply to comment #6) > > The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073. If I remember right, it's called from here: http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/ScriptCachedFrameData.cpp?rev=56716#L58 Thanks, Andrei 333201 9 antonm 2011-01-12 11:46:28 -0800 Thanks a lot! (In reply to comment #8) > (In reply to comment #7) > > Sorry for the trouble. > > > > May I have a look how you use this method? > > > > (In reply to comment #6) > > > The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073. > > If I remember right, it's called from here: > > http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/ScriptCachedFrameData.cpp?rev=56716#L58 > > Thanks, > Andrei 78008 2011-01-05 09:04:36 -0800 2011-01-05 09:05:35 -0800 proposed fix 0001-Qt-V8-ScriptCachedFrameData.cpp-misses-V8DOMWindowSh.patch text/plain 1867 abecsi RnJvbSBkNzA4MWEwNjA1YTY0ZDMxNzhkYzlmMTM3ZTg0ZDFkOWJiZmI5MWQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyYXMgQmVjc2kgPGFiZWNzaUB3ZWJraXQub3JnPgpEYXRl OiBXZWQsIDUgSmFuIDIwMTEgMTg6MDQ6NDcgKzAxMDAKU3ViamVjdDogW1BBVENIXSBbUXRdW1Y4 XSBTY3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwIG1pc3NlcyBWOERPTVdpbmRvd1NoZWxsOjpzZXRD b250ZXh0CgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDYWNoZWRG cmFtZURhdGEuY3BwIHwgICAgNiArKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDZmNTc3YmQuLjU4ZWEwNGYgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIw MTEtMDEtMDUgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bVjhdIFNjcmlwdENhY2hl ZEZyYW1lRGF0YS5jcHAgbWlzc2VzIFY4RE9NV2luZG93U2hlbGw6OnNldENvbnRleHQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxOTI5CisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENh Y2hlZEZyYW1lRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDYWNoZWRGcmFtZURh dGE6OnJlc3RvcmUpOiBVc2UgY2xlYXJGb3JDbG9zZSBhbmQgaW5zdGFsbERPTVdpbmRvdworICAg ICAgICBpbnN0ZWFkIG9mIFY4RE9NV2luZG93U2hlbGw6OnNldENvbnRleHQuCisKKzIwMTEtMDEt MDUgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2Vk IGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KIAogICAgICAgICBbUXRdW1Y4XSBGaXggdGhlIGJ1aWxk IGFmdGVyIHJlY2VudCBjaGFuZ2VzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9T Y3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDYWNo ZWRGcmFtZURhdGEuY3BwCmluZGV4IGRjMjhmMzIuLmM0YTIxMGQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYmluZGluZ3MvdjgvU2NyaXB0Q2FjaGVkRnJhbWVEYXRhLmNwcAorKysgYi9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdENhY2hlZEZyYW1lRGF0YS5jcHAKQEAgLTYxLDggKzYxLDEwIEBAIHZv aWQgU2NyaXB0Q2FjaGVkRnJhbWVEYXRhOjpyZXN0b3JlKEZyYW1lKiBmcmFtZSkKIAogICAgIG1f Y29udGV4dC5nZXQoKS0+UmVhdHRhY2hHbG9iYWwobV9nbG9iYWwuZ2V0KCkpOwogICAgIFY4UHJv eHkqIHByb3h5ID0gVjhQcm94eTo6cmV0cmlldmUoZnJhbWUpOwotICAgIGlmIChwcm94eSkKLSAg ICAgICAgcHJveHktPndpbmRvd1NoZWxsKCktPnNldENvbnRleHQobV9jb250ZXh0LmdldCgpKTsK KyAgICBpZiAocHJveHkpIHsKKyAgICAgICAgcHJveHktPndpbmRvd1NoZWxsKCktPmNsZWFyRm9y Q2xvc2UoKTsKKyAgICAgICAgcHJveHktPndpbmRvd1NoZWxsKCktPmluc3RhbGxET01XaW5kb3co bV9jb250ZXh0LmdldCgpLCBmcmFtZS0+ZG9tV2luZG93KCkpOworICAgIH0KIH0KIAogdm9pZCBT Y3JpcHRDYWNoZWRGcmFtZURhdGE6OmNsZWFyKCkKLS0gCjEuNy4zLjQKCg==