51805 2011-01-02 17:10:52 -0800 commit-queue shouldn't reject patches twice if two bots process the same patch 2011-01-03 11:27:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 328451 0 abarth 2011-01-02 17:10:52 -0800 commit-queue shouldn't reject patches twice if two bots process the same patch 328455 1 77786 abarth 2011-01-02 17:21:32 -0800 Created attachment 77786 Patch 328659 2 commit-queue 2011-01-03 11:03:45 -0800 The commit-queue encountered the following flaky tests while processing attachment 77786: http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 328660 3 77786 commit-queue 2011-01-03 11:05:10 -0800 Comment on attachment 77786 Patch Clearing flags on attachment: 77786 Committed r74910: <http://trac.webkit.org/changeset/74910> 328661 4 commit-queue 2011-01-03 11:05:16 -0800 All reviewed patches have been landed. Closing bug. 328662 5 eric 2011-01-03 11:09:13 -0800 We need to fix the real locking issue of course. :) 328671 6 abarth 2011-01-03 11:27:10 -0800 (In reply to comment #5) > We need to fix the real locking issue of course. :) Yeah. The lock doesn't seem to be working properly for some reason. Maybe some date calculation issue in the new year? 77786 2011-01-02 17:21:32 -0800 2011-01-03 11:05:10 -0800 Patch bug-51805-20110102172131.patch text/plain 2476 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc0ODgxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDEtMDIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb21taXQtcXVl dWUgc2hvdWxkbid0IHJlamVjdCBwYXRjaGVzIHR3aWNlIGlmIHR3byBib3RzIHByb2Nlc3MgdGhl IHNhbWUgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUxODA1CisKKyAgICAgICAgQmVmb3JlIHJhaXNpbmcgYW4gZXJyb3IsIHdlIGZpcnN0IGNo ZWNrIHdoZXRoZXIgdGhlIHBhdGNoIGlzIHN0aWxsIGluCisgICAgICAgIHRoZSBjb21taXQtcXVl dWUuICBUaGlzIGNoZWNrIGlzIHN0aWxsIHJhY3ksIG9mIGNvdXJzZSwgYnV0IHRoZSB0aW1lCisg ICAgICAgIHdpbmRvdyBpcyBtdWNoIHNtYWxsZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFzay5weToKKwogMjAxMS0wMS0wMiAgUGF0cmljayBH YW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1 ZXRhc2sucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9j b21taXRxdWV1ZXRhc2sucHkJKHJldmlzaW9uIDc0ODYyKQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkJKHdvcmtpbmcgY29weSkKQEAgLTE5Miw5 ICsxOTIsMTQgQEAgY2xhc3MgQ29tbWl0UXVldWVUYXNrKG9iamVjdCk6CiAgICAgICAgICAgICBy ZXR1cm4gRmFsc2UKIAogICAgICAgICBpZiBzZWxmLl9idWlsZF9hbmRfdGVzdF93aXRob3V0X3Bh dGNoKCk6Ci0gICAgICAgICAgICByYWlzZSBzZWxmLl9zY3JpcHRfZXJyb3IgICMgVGhlIGVycm9y IGZyb20gdGhlIHByZXZpb3VzIC5fdGVzdCgpIHJ1biBpcyByZWFsLCByZXBvcnQgaXQuCisgICAg ICAgICAgICByZXR1cm4gc2VsZi5yZXBvcnRfZmFpbHVyZSgpICAjIFRoZSBlcnJvciBmcm9tIHRo ZSBwcmV2aW91cyAuX3Rlc3QoKSBydW4gaXMgcmVhbCwgcmVwb3J0IGl0LgogICAgICAgICByZXR1 cm4gRmFsc2UgICMgVHJlZSBtdXN0IGJlIHJlZCwganVzdCByZXRyeSBsYXRlci4KIAorICAgIGRl ZiByZXBvcnRfZmFpbHVyZShzZWxmKToKKyAgICAgICAgaWYgbm90IHNlbGYuX3ZhbGlkYXRlKCk6 CisgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAgcmFpc2Ugc2VsZi5fc2NyaXB0X2Vy cm9yCisKICAgICBkZWYgcnVuKHNlbGYpOgogICAgICAgICBpZiBub3Qgc2VsZi5fdmFsaWRhdGUo KToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQpAQCAtMjAzLDExICsyMDgsMTEgQEAgY2xhc3Mg Q29tbWl0UXVldWVUYXNrKG9iamVjdCk6CiAgICAgICAgIGlmIG5vdCBzZWxmLl91cGRhdGUoKToK ICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBpZiBub3Qgc2VsZi5fYXBwbHkoKToK LSAgICAgICAgICAgIHJhaXNlIHNlbGYuX3NjcmlwdF9lcnJvcgorICAgICAgICAgICAgcmV0dXJu IHNlbGYucmVwb3J0X2ZhaWx1cmUoKQogICAgICAgICBpZiBub3Qgc2VsZi5fYnVpbGQoKToKICAg ICAgICAgICAgIGlmIG5vdCBzZWxmLl9idWlsZF93aXRob3V0X3BhdGNoKCk6CiAgICAgICAgICAg ICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAgICAgICByYWlzZSBzZWxmLl9zY3JpcHRfZXJyb3IK KyAgICAgICAgICAgIHJldHVybiBzZWxmLnJlcG9ydF9mYWlsdXJlKCkKICAgICAgICAgaWYgbm90 IHNlbGYuX3Rlc3RfcGF0Y2goKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICAj IE1ha2Ugc3VyZSB0aGUgcGF0Y2ggaXMgc3RpbGwgdmFsaWQgYmVmb3JlIGxhbmRpbmcgKGUuZy4s IG1ha2Ugc3VyZQpAQCAtMjE2LDUgKzIyMSw1IEBAIGNsYXNzIENvbW1pdFF1ZXVlVGFzayhvYmpl Y3QpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgICMgRklYTUU6IFdlIHNob3Vs ZCB1bmRlcnN0YW5kIHdoeSB0aGUgbGFuZCBmYWlsdXJlIG9jY3VyZWQgYW5kIHJldHJ5IGlmIHBv c3NpYmxlLgogICAgICAgICBpZiBub3Qgc2VsZi5fbGFuZCgpOgotICAgICAgICAgICAgcmFpc2Ug c2VsZi5fc2NyaXB0X2Vycm9yCisgICAgICAgICAgICByZXR1cm4gc2VsZi5yZXBvcnRfZmFpbHVy ZSgpCiAgICAgICAgIHJldHVybiBUcnVlCg==