51761 2010-12-30 12:16:09 -0800 bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build 2010-12-30 13:58:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 43906 0 ben webkit-unassigned commit-queue paroga oldest_to_newest 327993 0 ben 2010-12-30 12:16:09 -0800 That file is required when NOTIFICATIONS is enabled. 327995 1 77694 ben 2010-12-30 12:18:20 -0800 Created attachment 77694 proposed solution 328001 2 paroga 2010-12-30 12:28:55 -0800 LGTM! 328012 3 77694 commit-queue 2010-12-30 12:54:46 -0800 Comment on attachment 77694 proposed solution Rejecting attachment 77694 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77694]" exit_code: 2 Last 500 characters of output: ug. Processing patch 77694 from bug 51761. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/CMakeLists.txt patching file WebCore/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7206278 328033 4 77694 paroga 2010-12-30 13:57:25 -0800 Comment on attachment 77694 proposed solution Clearing flags on attachment: 77694 Manually committed r74810: <http://trac.webkit.org/changeset/74810> 328034 5 paroga 2010-12-30 13:58:18 -0800 All reviewed patches have been landed. Closing bug. 77694 2010-12-30 12:18:20 -0800 2010-12-30 13:57:25 -0800 proposed solution 0001-2010-12-30-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 1853 ben RnJvbSBjZjAwZmQzZWYwNzBiOTI5Y2E3ZTMwZmJhMzhiNjc3MzA0Nzg2YmUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogVGh1LCAzMCBEZWMgMjAxMCAxNTowOTo0MyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTAt MTItMzAgIEJlbmphbWluIEMgTWV5ZXIgIDxibWV5ZXJAcmltLmNvbT4KCiAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGJpbmRpbmdzL2pzL0pTRGVza3RvcE5vdGlm aWNhdGlvbnNDdXN0b20uY3BwIGlzIG5vdCBpbmNsdWRlZCBpbiB0aGUgY21ha2UgYnVpbGQKICAg ICAgICB3aGljaCBpcyByZXF1aXJlZCB3aGVuIE5PVElGSUNBVElPTlMgaXMgZW5hYmxlZC4KCiAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzYxCgogICAg ICAgICogQ01ha2VMaXN0cy50eHQ6Ci0tLQogV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCB8ICAgIDEg KwogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICB8ICAgMTEgKysrKysrKysrKysKIDIgZmlsZXMgY2hh bmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NNYWtlTGlzdHMudHh0IGIvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCA2Yzk5YmJj Li44OThkNGIyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKQEAgLTYxNSw2ICs2MTUsNyBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VT CiAgICAgYmluZGluZ3MvanMvSlNDdXN0b21TUUxTdGF0ZW1lbnRFcnJvckNhbGxiYWNrLmNwcAog ICAgIGJpbmRpbmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmNwcAogICAgIGJpbmRpbmdzL2pz L0pTQ3VzdG9tWFBhdGhOU1Jlc29sdmVyLmNwcAorICAgIGJpbmRpbmdzL2pzL0pTRGVza3RvcE5v dGlmaWNhdGlvbnNDdXN0b20uY3BwICAgIAogICAgIGJpbmRpbmdzL2pzL0pTRE9NQXBwbGljYXRp b25DYWNoZUN1c3RvbS5jcHAKICAgICBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuY3BwCiAgICAg YmluZGluZ3MvanMvSlNET01Gb3JtRGF0YUN1c3RvbS5jcHAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2NjMjc5Mi4uNTJlZWY4OSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIs NiArMiwxNyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAg ICAgIGJpbmRpbmdzL2pzL0pTRGVza3RvcE5vdGlmaWNhdGlvbnNDdXN0b20uY3BwIGlzIG5vdCBp bmNsdWRlZCBpbiB0aGUgY21ha2UgYnVpbGQKKyAgICAgICAgd2hpY2ggaXMgcmVxdWlyZWQgd2hl biBOT1RJRklDQVRJT05TIGlzIGVuYWJsZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzYxCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoK KworMjAxMC0xMi0zMCAgQmVuamFtaW4gQyBNZXllciAgPGJtZXllckByaW0uY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFdoZW4gRU5BQkxFX05F VFNDQVBFX1BMVUdJTl9BUEkgaXMgT0ZGIHRoZSBjbWFrZSBidWlsZCBzeXN0ZW0gd2FzIG5vdCBp bmNsdWRpbmcKICAgICAgICAgcGx1Z2lucy9QbHVnaW5EYXRhTm9uZS5jcHAgd2hpY2ggZ29lcyB3 aXRoIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCiAgICAgICAgIGFuZCBwbHVnaW5zL1Bs dWdpblZpZXdOb25lLmNwcC4KLS0gCjEuNy4xCgo=