51704 2010-12-29 06:27:55 -0800 [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell) 2011-01-05 09:13:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 51930 1 antonm antonm abarth commit-queue eric webkit.review.bot oldest_to_newest 327549 0 antonm 2010-12-29 06:27:55 -0800 [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell) 327551 1 77616 antonm 2010-12-29 06:35:16 -0800 Created attachment 77616 Patch 327787 2 77616 eric 2010-12-29 18:31:38 -0800 Comment on attachment 77616 Patch OK. 327813 3 commit-queue 2010-12-29 20:06:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 77616: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 327814 4 77616 commit-queue 2010-12-29 20:07:16 -0800 Comment on attachment 77616 Patch Clearing flags on attachment: 77616 Committed r74778: <http://trac.webkit.org/changeset/74778> 327815 5 commit-queue 2010-12-29 20:07:22 -0800 All reviewed patches have been landed. Closing bug. 327838 6 webkit.review.bot 2010-12-29 22:37:33 -0800 http://trac.webkit.org/changeset/74778 might have broken Leopard Intel Debug (Tests) 327962 7 antonm 2010-12-30 10:47:34 -0800 (In reply to comment #2) > (From update of attachment 77616 [details]) > OK. Thanks a lot, Eric. 77616 2010-12-29 06:35:16 -0800 2010-12-29 20:07:16 -0800 Patch bug-51704-20101229173513.patch text/plain 2308 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTVkZDUyNzRkODk3NTg1MmUyNTU5ZWU5NWI2MmYyMzdkMzVmNTg1NC4uODQ3NDIxMDI5YWY0ZTE0 MGJiODZjMmE3MmU5OGE4YTg4Y2U5OTFkOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0yOSAgQW50 b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFt2OF0gTWlub3IgY2xlYW51cDogcmVtb3ZlIHVudXNl ZCBtZXRob2QgKHRoZSBvbmx5IG1ldGhvZCB3aGljaCBjYW4gbXV0YXRlIGNvbnRleHQgb2YgVjhE T01XaW5kb3dTaGVsbCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxNzA0CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNw cDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmg6CisKIDIwMTAtMTIt MjkgIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9W OERPTVdpbmRvd1NoZWxsLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVs bC5jcHAKaW5kZXggODBiZjY4Mzg2NzU3ZTQ1MGRjMDIzOGEzOTdhNTlkM2Q5ZDAwNzI1Mi4uYzFk MjkzM2ZmYmJkZDU0MmI4MjVmYTE1OWJmMzUwYTUxYzYzMGFlNiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCkBAIC0zNDksMTYgKzM0OSw2IEBAIHY4OjpQZXJzaXN0 ZW50PHY4OjpDb250ZXh0PiBWOERPTVdpbmRvd1NoZWxsOjpjcmVhdGVOZXdDb250ZXh0KHY4OjpI YW5kbGU8djg6Ok9iCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotdm9pZCBWOERPTVdpbmRvd1No ZWxsOjpzZXRDb250ZXh0KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQpCi17Ci0gICAg Ly8gaWYgd2UgYWxyZWFkeSBoYXZlIGEgY29udGV4dCwgY2xlYXIgaXQgYmVmb3JlIHNldHRpbmcg dGhlIG5ldyBvbmUuCi0gICAgaWYgKCFtX2NvbnRleHQuSXNFbXB0eSgpKSB7Ci0gICAgICAgIG1f Y29udGV4dC5EaXNwb3NlKCk7Ci0gICAgICAgIG1fY29udGV4dC5DbGVhcigpOwotICAgIH0KLSAg ICBtX2NvbnRleHQgPSB2ODo6UGVyc2lzdGVudDx2ODo6Q29udGV4dD46Ok5ldyhjb250ZXh0KTsK LX0KLQogYm9vbCBWOERPTVdpbmRvd1NoZWxsOjppbnN0YWxsRE9NV2luZG93KHY4OjpIYW5kbGU8 djg6OkNvbnRleHQ+IGNvbnRleHQsIERPTVdpbmRvdyogd2luZG93KQogewogICAgIC8vIENyZWF0 ZSBhIG5ldyBKUyB3aW5kb3cgb2JqZWN0IGFuZCB1c2UgaXQgYXMgdGhlIHByb3RvdHlwZSBmb3Ig dGhlICBzaGFkb3cgZ2xvYmFsIG9iamVjdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XaW5kb3dTaGVsbC5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1No ZWxsLmgKaW5kZXggNzZjMjdhZjM2MWU4ZDdlOTViNzY5Mzk4ZWI1ODM2ZTA1MDVkZDRjZC4uODRk MTRiOWU3OWM5ZTFhOWU0ZWZiZjc0MDk3OTA0MGJiMDQ1MTg3MSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdpbmRvd1NoZWxsLmgKQEAgLTY2LDggKzY2LDcgQEAgcHVibGljOgogICAgIGJvb2wg aXNDb250ZXh0SW5pdGlhbGl6ZWQoKTsKIAogICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0 PiBjcmVhdGVOZXdDb250ZXh0KHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZ2xvYmFsLCBpbnQgZXh0 ZW5zaW9uR3JvdXApOwotICAgIHZvaWQgc2V0Q29udGV4dCh2ODo6SGFuZGxlPHY4OjpDb250ZXh0 Pik7Ci0gICAgc3RhdGljIGJvb2wgaW5zdGFsbERPTVdpbmRvdyh2ODo6SGFuZGxlPHY4OjpDb250 ZXh0PiBjb250ZXh0LCBET01XaW5kb3cqKTsKKyAgICBzdGF0aWMgYm9vbCBpbnN0YWxsRE9NV2lu ZG93KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+LCBET01XaW5kb3cqKTsKIAogICAgIGJvb2wgaW5p dENvbnRleHRJZk5lZWRlZCgpOwogICAgIHZvaWQgdXBkYXRlRG9jdW1lbnRXcmFwcGVyKHY4OjpI YW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlcik7Cg==